Loïc Guitaut
3eaac56797
DEV: Use proper wording for contexts in specs
2022-08-04 11:05:02 +02:00
Phil Pirozhkov
493d437e79
Add RSpec 4 compatibility ( #17652 )
...
* Remove outdated option
04078317bahttps://github.com/rspec/rspec-core/pull/2803
* Use the non-globally exposed RSpec syntax, cont
https://github.com/rspec/rspec-core/pull/2803
* Comply to strict predicate matchers
See:
- https://github.com/rspec/rspec-expectations/pull/1195
- https://github.com/rspec/rspec-expectations/pull/1196
- https://github.com/rspec/rspec-expectations/pull/1277
2022-07-28 10:27:38 +08:00
Loïc Guitaut
91b6b5eee7
DEV: Don’t use change { … }.by(0) in specs
2022-07-26 10:34:15 +02:00
Gerhard Schlager
eef17318c3
FIX: Applying default user options didn't work for boolean flags ( #16890 )
...
It also ensures that only human users are updated and replaces usage of `send` with `public_send`. Also, it adds more specs for existing code.
2022-05-23 15:20:51 +02:00
David Taylor
c9dab6fd08
DEV: Automatically require 'rails_helper' in all specs ( #16077 )
...
It's very easy to forget to add `require 'rails_helper'` at the top of every core/plugin spec file, and omissions can cause some very confusing/sporadic errors.
By setting this flag in `.rspec`, we can remove the need for `require 'rails_helper'` entirely.
2022-03-01 17:50:50 +00:00
Alan Guo Xiang Tan
454d3740b4
DEV: Remove deprecated site settings. ( #15725 )
2022-02-07 11:26:06 +08:00
David Taylor
8cd7c9b259
DEV: Support setting deprecated site settings via the API ( #12172 )
2021-02-22 18:10:54 +00:00
Krzysztof Kotlarek
084e15b447
FIX: modify notification after remove auto_watch_category ( #10568 )
...
When a category is removed from `auto_watch_category` we are removing
CategoryUser. However, there are still TopicUser with notification level
set to `watching` which was inherited from Category.
We should move them back to `regular` unless they were modified by a user.
2020-09-01 13:07:41 +10:00
Sam Saffron
38a30a6e96
DEV: correct regression and correct tests
...
etag change in 31976ecf
2020-07-06 10:56:19 +10:00
Bianca Nenciu
a1df68d4c4
FIX: Do not change tracked categories for staged users ( #10076 )
2020-06-18 21:09:54 +03:00
Jarek Radosz
781e3f5e10
DEV: Use response.parsed_body in specs ( #9615 )
...
Most of it was autofixed with rubocop-discourse 2.1.1.
2020-05-07 17:04:12 +02:00
Vinoth Kannan
f3ddc36ac6
FIX: update email_digests user option when default_email_digest_frequency updated.
2020-03-20 00:55:47 +05:30
Vinoth Kannan
56b19ba740
UX: instead of total user count display only the count of users going to be affected.
...
edec922803
2019-11-18 00:09:38 +05:30
Vinoth Kannan
72aa26c8c5
FEATURE: New site settings for default tags in user preferences. ( #8283 )
2019-11-01 12:40:13 +05:30
Vinoth Kannan
d355506123
FEATURE: Option to update user preferences of all users when default site setting changed.
2019-10-31 06:48:03 +05:30
Vinoth Kannan
b2f682f35e
FEATURE: Option to update category preferences of all users when site setting changed ( #8180 )
2019-10-15 18:41:27 +05:30
Daniel Waterworth
e219588142
DEV: Prefabrication (test optimization) ( #7414 )
...
* Introduced fab!, a helper that creates database state for a group
It's almost identical to let_it_be, except:
1. It creates a new object for each test by default,
2. You can disable it using PREFABRICATION=0
2019-05-07 13:12:20 +10:00
Sam Saffron
4ea21fa2d0
DEV: use #frozen_string_literal: true on all spec
...
This change both speeds up specs (less strings to allocate) and helps catch
cases where methods in Discourse are mutating inputs.
Overall we will be migrating everything to use #frozen_string_literal: true
it will take a while, but this is the first and safest move in this direction
2019-04-30 10:27:42 +10:00
Guo Xiang Tan
b0c8fdd7da
FIX: Properly support defaults for upload site settings.
2019-03-13 16:36:57 +08:00
Guo Xiang Tan
44391ee8ab
FEATURE: Upload Site Settings. ( #6573 )
2018-11-14 15:03:02 +08:00
OsamaSayegh
93b1386fb2
REFACTOR: admin site settings controller specs to requests ( #5966 )
2018-06-11 12:48:09 +08:00
