Commit Graph

13126 Commits

Author SHA1 Message Date
Guo Xiang Tan
24347ace10 FIX: Properly associate user_profiles background urls via upload id.
`Upload#url` is more likely and can change from time to time. When it
does changes, we don't want to have to look through multiple tables to
ensure that the URLs are all up to date. Instead, we simply associate
uploads properly to `UserProfile` so that it does not have to replicate
the URLs in the table.
2019-05-02 14:58:24 +08:00
Joe
5a834a05ea
FIX: crawler layout CSS adjustments (#7469)
* Fix header size to fit the viewport

Setting the header to border-box means that the padding is factored in when calculating its width. If this is not done, the header width would be 100% of the viewport width + any padding when set on it. That causes some parts of the header to be rendered off-screen and causes horizontal scrolling.

* prevent code in posts from causing horizontal overflow

We are currently not wrapping code in posts in the crawler view. This affects both unformatted code and inline code blocks. This commit forces such code to wrap in order to prevent horizontal overflow which the Google bot complains about since it causes some content to be rendered outside of the viewport for the mobile crawler.
2019-05-02 13:00:29 +08:00
Sam Saffron
157dc5e298 FEATURE: disable native share API on non tablets/phones
Native share API works fantastically on phones/tablets but on full desktop
it is confusing.
2019-05-02 13:18:29 +10:00
Arpit Jalan
b5ea50a154
FIX: use full screen login for new-topic route (#7467)
DEV: add javascript tests for new-topic and new-message routes

DEV: fix an existing test that was being skipped
2019-05-01 22:54:29 +05:30
Vinoth Kannan
7869a10d18 Revert "FEATURE: Added unlisted topics option to advanced search (#7447)"
This reverts commit 539723f8ff since it is failing the build.
2019-05-01 21:06:20 +05:30
Joffrey JAFFEUX
ae493f4722
UX: fills picker with emoji autocomplete state on more click (#7466) 2019-05-01 16:19:45 +02:00
David Taylor
0e303c7f5d
FEATURE: Automatically generate optimized site metadata icons (#7372)
This change automatically resizes icons for various purposes. Admins can now upload `logo` and `logo_small`, and everything else will be auto-generated. Specific icons can still be uploaded separately if required.

## Core

- Adds an SiteIconManager module which manages automatic resizing and fallback

- Icons are looked up in the OptimizedImage table at runtime, and then cached in Redis. If the resized version is missing for some reason, then most icons will fall back to the original files. Some icons (e.g. PWA Manifest) will return `nil` (because an incorrectly sized icon is worse than a missing icon). 

- `SiteSetting.site_large_icon_url` will return the optimized version, including any fallback. `SiteSetting.large_icon` continues to return the upload object. This means that (almost) no changes are required in core/plugins to support this new system.

- Icons are resized whenever a relevant site setting is changed, and during post-deploy migrations

## Wizard

- Allows `requiresRefresh` wizard steps to reload data via AJAX instead of a full page reload

- Add placeholders to the **icons** step of the wizard, which automatically update from the "Square Logo"

- Various copy updates to support the changes

- Remove the "upload-time" resizing for `large_icon`. This is no longer required.

## Site Settings UX

- Move logo/icon settings under a new "Branding" tab

- Various copy changes to support the changes

- Adds placeholder support to the `image-uploader` component

- Automatically reloads site settings after saving. This allows setting placeholders to change based on changes to other settings

- Upload site settings will be assigned a placeholder if SiteIconManager `responds_to?` an icon of the same name

## Dashboard Warnings

- Remove PWA icon and PWA title warnings. Both are now handled automatically.

## Bonus

- Updated the sketch logos to use @awesomerobot's new high-res designs
2019-05-01 14:44:45 +01:00
Arpit Jalan
c6409fd2cc FIX: pass correct date arguments to server when exporting CSV 2019-05-01 10:46:30 +05:30
Arpit Jalan
002e1f560a FIX: initialize empty object if no custom filters are present 2019-05-01 10:27:19 +05:30
Tim Lange
539723f8ff FEATURE: Added unlisted topics option to advanced search (#7447) 2019-05-01 12:31:13 +10:00
Robin Ward
404b35bd04 FEATURE: Category Reviewable by Group
Allow a group to review content in a particular category.
2019-04-30 15:23:06 -04:00
Robin Ward
dd29af4475 REFACTOR: {{avatar}} and {{date}} helpers in vdom templates
This is a step towards a nicer flag display under posts.
2019-04-30 15:22:38 -04:00
Roman Rizzi
404666c9e9
DEV: Export the default behaviour of a topic-list-item so it can be reused by the discourse-assign plugin (#7433) 2019-04-30 15:36:54 -03:00
David Taylor
583226d295 FIX: Linking to /new-topic from /latest
`/new-topic` redirects back to `/latest`, so the ember router considers this to be a 'refresh'. This triggers the `resetParams()` logic, which would cause the transition to abort, and the composer would never open.

This commit fixes the `resetParams()` logic so that it uses the default values, instead of setting everything to `null`. Therefore the transition is no longer aborted, and the composer opens successfully.

Unfortunately I have not been able to reproduce the issue in a QUnit test.
2019-04-30 16:25:25 +01:00
Joffrey JAFFEUX
8e68244eea
FIX: prevents google to track certain pages (#7463) 2019-04-30 15:57:51 +02:00
Joffrey JAFFEUX
726dd0fe37 Revert "FIX: prevents google to track certain pages (#7455)"
This reverts commit c863e62998.
2019-04-30 10:17:12 +02:00
Joffrey JAFFEUX
c863e62998 FIX: prevents google to track certain pages (#7455) 2019-04-30 13:59:55 +08:00
Guo Xiang Tan
dca7f8ecf2 FIX: Loading more broken on groups page.
Regressed in 1f17d52f55.
2019-04-30 10:35:17 +08:00
Neil Lalonde
a00354f11f Prettier site-settings/group-list.js.es6 2019-04-29 16:26:13 -04:00
Neil Lalonde
1ba72ccab8 DEV: add site setting type group_list for a list of groups
Add a js test
2019-04-29 16:15:22 -04:00
Penar Musaraj
bfadb1fabc FIX: use more specific target for ".tag-box"
This avoids tags named "box" from receiving styling aimed at this specific element on the tag list page.
2019-04-29 13:55:40 -04:00
Penar Musaraj
b75720d911 FIX: skip click-tracking for mentions 2019-04-29 12:05:47 -04:00
Joffrey JAFFEUX
5768011cad
FIX: prevents exception in the composer with regexp flags 2019-04-29 16:58:17 +02:00
Penar Musaraj
629ae7a5b7 FIX: Revert tracking links in quotes 2019-04-29 10:30:04 -04:00
Bianca Nenciu
aef35faefc FIX: Open links in external tabs. (#7444) 2019-04-29 10:27:29 -04:00
Penar Musaraj
ca9fd95a08 FIX: Respect "open external links in new window" in quotes and edit history 2019-04-29 10:13:53 -04:00
Joffrey JAFFEUX
286f2abc65
FIX: prevents exception when clicking directly on site text 2019-04-29 12:07:30 +02:00
Tim Lange
574f39f9d0 FIX: Fixed uploadPlaceholder regex failing on not escaped characters (#7442) 2019-04-29 12:32:48 +10:00
Joffrey JAFFEUX
6952510fc4
FIX: restores skipHeader computed property 2019-04-26 23:43:49 +02:00
Tim Lange
1486328756 UX: Changed post stream placeholder to animation (#7434) 2019-04-26 17:29:48 +01:00
Joffrey JAFFEUX
bcca2b5d73
FEATURE: initial implementation of generic filters for reports 2019-04-26 12:17:10 +02:00
Maja Komel
4b455e741e DEV: Ember 3.8.0
Co-Authored-By: majakomel <maja.komel@gmail.com>
2019-04-26 12:16:21 +02:00
Vinoth Kannan
be0ae2e487 FIX: plain text table detection should work even if html content not found. 2019-04-26 11:16:41 +05:30
Vinoth Kannan
dc2ee78f7a UX: Only do plain text table detection in outside code if HTML pasting enabled
Co-authored-by: Tim Lange <tim.lange@titanhq.de>
PR: https://github.com/discourse/discourse/pull/7436
2019-04-26 09:20:21 +05:30
romanrizzi
34b772575e FIX: Return 'failed' attribute when catching an ajax error and the attribute is present 2019-04-25 14:49:52 -03:00
Joffrey JAFFEUX
7cbc4c1e46
FIX: uses no tags label for tag-drop header (#7438) 2019-04-25 13:16:06 +02:00
Joffrey JAFFEUX
e386fa7674
FIX: ensures we have touches when starting pan event (#7435) 2019-04-25 10:36:41 +02:00
Tarek Khalil
d8ff94ecaa
FEATURE: Ignoring users from the preferences page in a cleaner way (#7289)
* FEATURE: Ignoring users from the preferences page in a cleaner way
2019-04-25 09:26:49 +01:00
Dan Ungureanu
3aa143a52c
SECURITY: Fix tab nabbing. 2019-04-25 00:11:28 +03:00
Kris
505c5addca Allow signup form width to increase when no external logins are present 2019-04-24 13:08:39 -04:00
Tarek Khalil
e4d8d80cf8
FIX: Make sure we hide the first post in a topic by an ignored user (#7428) 2019-04-24 16:00:20 +01:00
Penar Musaraj
1a8c6577e0 FIX: refactor padding when exiting composer
Previously, when existing composer, the `#main-outlet` element padding was set to zero. This inline style would override any CSS set for that element, causing issues with the mobile footer nav.

The fix removes the inline padding style instead of setting it to zero. It also uses integers for the set values, and removes a duplicate style.
2019-04-24 10:26:35 -04:00
Tarek Khalil
ad61d87ffb
FIX: Do not replace text of collapsed ignore posts (#7422) 2019-04-24 13:54:46 +01:00
Penar Musaraj
a452933071 FIX: disable input zoom on search in iOS 2019-04-24 08:41:20 -04:00
Tim Lange
104a9e79f9 UX: User card loading (#7404) 2019-04-24 11:55:09 +03:00
Joffrey JAFFEUX
7334362b77
FEATURE: generic theme component bbcode wrapper (#7400)
Usage:

```
[wrap=name foo=bar]
hello world
[/wrap]
```
2019-04-24 10:37:34 +02:00
Bianca Nenciu
b9339e15a1 FIX: Do not track a elements with no href. 2019-04-23 23:13:23 +03:00
Bianca Nenciu
b81d169e2a FIX: Do not track user mentions. 2019-04-23 23:08:00 +03:00
Joffrey JAFFEUX
c99faa6b25
FIX: improves locale support in tag-drop (#7418) 2019-04-23 17:53:59 +02:00
Joffrey JAFFEUX
d4e788c136
FIX: improves share/invite behavior on mobile and especially iOS (#7416) 2019-04-23 17:07:31 +02:00