github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-25 09:42:07 +08:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity
39,861 Commits 214 Branches 500 Tags 960 MiB
24976669b8
Commit Graph

39861 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Daniel Waterworth
ec4c2a58ea
FIX: Paths with categories and tags were being generated incorrectly (#11167) 
Paths prefixed with /tag/ are exclusively for when the tag name is the
next string in the path. Therefore, when a category is being used as
context, the path should start with /tags/ instead.
 2020-11-09 12:34:52 +00:00
David Taylor
a0095d6e52
UX: Show theme git branch for private repositories (#11166) 2020-11-09 11:33:38 +00:00
Joe
3414566466
UX: Remove label and add danger class to remove draft button (#11165) 2020-11-09 15:28:39 +08:00
Guo Xiang Tan
f70b330e7a DEV: Fix the build. 
Follow-up to 650da7b626
 2020-11-09 14:25:14 +08:00
Guo Xiang Tan
650da7b626 PERF: Update index for category in a background job. 
Search indexing can get expensive and there is no need for us to block
the entire request just to wait for index to finish.
 2020-11-09 13:51:26 +08:00
Sam
94cd5ac0b1
FIX: global setting needs to be coerced to float (#11162) 
disable_search_queue_threshold needs to be coerced to a float so it is not
treated as a string when sub second values are provided.

Longer term fix is to possibly provide hints in the config so we do the
coersion automatically. However this would be a far more complex change.
 2020-11-09 16:46:52 +11:00
Kris
1455421433
UX: truncate long usernames in multi-username notifications (#11153) 
* UX: truncate long usernames in multi-username notifications

* remove extra class, clarify comments
 2020-11-09 16:06:52 +11:00
Kris
8be04ff7f7
UX: Give furigana and other top-overflowing elements a little space (#11154) 2020-11-09 16:03:36 +11:00
Kris
4c0d027a5a
UX: truncate long nav items in dropdown menu (#11156) 2020-11-09 16:02:40 +11:00
jbrw
caead1bd35
DEV: update AWS and onebox gems 
onebox update contains ab2f9a8cda which correct onebox behavior for instagram
 2020-11-09 16:01:20 +11:00
Alan Guo Xiang Tan
0e4d966a74
DEV: Remove stale ignored_columns. (#11160) 2020-11-09 15:57:59 +11:00
dependabot-preview[bot]
43df3348b7 Create Dependabot config file 2020-11-09 12:57:35 +08:00
dependabot-preview[bot]
f8e48a413c Build(deps): Bump parallel from 1.19.2 to 1.20.0 
Bumps [parallel](https://github.com/grosser/parallel) from 1.19.2 to 1.20.0.
- [Release notes](https://github.com/grosser/parallel/releases)
- [Commits](https://github.com/grosser/parallel/compare/v1.19.2...v1.20.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2020-11-09 12:53:03 +08:00
dependabot-preview[bot]
ee9d879794 Build(deps): Bump onebox from 2.1.4 to 2.1.5 
Bumps [onebox](https://github.com/discourse/onebox) from 2.1.4 to 2.1.5.
- [Release notes](https://github.com/discourse/onebox/releases)
- [Changelog](https://github.com/discourse/onebox/blob/master/CHANGELOG.md)
- [Commits](https://github.com/discourse/onebox/compare/v2.1.4...v2.1.5)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2020-11-09 12:52:45 +08:00
dependabot-preview[bot]
1a4cdf120e
Build(deps): Bump tzinfo from 1.2.7 to 1.2.8 (#11157) 
Bumps [tzinfo](https://github.com/tzinfo/tzinfo) from 1.2.7 to 1.2.8.
- [Release notes](https://github.com/tzinfo/tzinfo/releases)
- [Changelog](https://github.com/tzinfo/tzinfo/blob/v1.2.8/CHANGES.md)
- [Commits](https://github.com/tzinfo/tzinfo/compare/v1.2.7...v1.2.8)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
 2020-11-08 13:58:50 +01:00
tshenry
6060f32970
Improve max_personal_messages_per_day description copy (#11155) 2020-11-06 17:42:26 -08:00
Justin DiRose
09b8a61f65
FEATURE: Add Google Universal Analytics v4 as an option (#11123) 
Per Google, sites are encouraged to upgrade from Universal Analytics v3 `analytics.js` to v4 `gtag.js` for Google Analytics tracking. We're giving admins the option to stay on the v3 API or migrate to v4. Admins can change the implementation they're using via the `ga_version` site setting. Eventually Google will deprecate v3, but our implementation gives admins the choice on what to use for now.

We chose this implementation to make the change less error prone, as many site admins are using custom events via the v3 UA API. With the site stetting defaulted to `v3_analytics`, site analytics won't break until the admin is ready to make the migration.

Additionally, in the v4 implementation, we do not enable automatic pageview tracking (on by default in the v4 API). Instead we rely on Discourse's page change API to report pageviews on transition to avoid double-tracking.
 2020-11-06 14:15:36 -06:00
dependabot-preview[bot]
8f7e4f87ec
Build(deps-dev): Bump rubocop-discourse from 2.4.0 to 2.4.1 (#11151) 
Bumps [rubocop-discourse](https://github.com/discourse/rubocop-discourse) from 2.4.0 to 2.4.1.
- [Release notes](https://github.com/discourse/rubocop-discourse/releases)
- [Commits](https://github.com/discourse/rubocop-discourse/compare/v2.4.0...v2.4.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
 2020-11-06 20:54:21 +01:00
Mark VanLandingham
95c871be3e
DEV: Move popups left if application.hbs wrapper is moved by theme 
We have a div that is inside #main because of the history of Ember explained here. Once we have Ember cli, we can use optional feature flags and disable creating this div with application-template-wrapper: false, and refactor this code and any plugins that rely on that div being present (some plugin regarding remote collaboration??).
 2020-11-06 09:46:26 -06:00
Bianca Nenciu
0863c36221
FIX: Improve errors when invite to topic fails (#11133) 
It used to simply say "not allowed" without giving any hint what the
problem could be. This commit refactors the code and tries to improve
readability.
 2020-11-06 16:58:10 +02:00
dependabot-preview[bot]
75a893fd61
Build(deps): Bump rails_failover from 0.5.8 to 0.5.9 (#11143) 
Bumps rails_failover from 0.5.8 to 0.5.9.

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
 2020-11-06 01:09:40 +00:00
Martin Brennan
00c8f520e9
FIX: Do not enable published page if secure media enabled (#11131) 
There are issues around displaying images on published pages when secure media is enabled. This PR temporarily makes it appear as if published pages are enabled if secure media is also enabled.
 2020-11-06 10:33:19 +10:00
Sam
2d4455161b
FIX: Correct "no tags" route in tag drop-down (#11142) 
We refactored routes and removed /tags/none... instead is should be /tag/none
 2020-11-06 10:28:57 +11:00
Jarek Radosz
1ca6434d40
DEV: Remove i18n-patches (#11139) 
* DEV: Move toHumanSize patch into I18n proper
  The patch wasn't loaded in Ember CLI environment causing translation discrepancies.

* DEV: Remove String.prototype.i18n
  I don't think this patch is needed. Let the CI prove me wrong. :P
 2020-11-06 00:08:36 +01:00
dependabot-preview[bot]
bfafccacd2
Build(deps-dev): Bump webmock from 3.9.3 to 3.9.4 (#11141) 
Bumps [webmock](https://github.com/bblimke/webmock) from 3.9.3 to 3.9.4.
- [Release notes](https://github.com/bblimke/webmock/releases)
- [Changelog](https://github.com/bblimke/webmock/blob/master/CHANGELOG.md)
- [Commits](https://github.com/bblimke/webmock/compare/v3.9.3...v3.9.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
 2020-11-06 00:07:51 +01:00
Krzysztof Kotlarek
9bfce1a8dd
FIX: trim no-break space in to-markdown (#11130) 
No-break spaces were the reason for double spaces when pasting text to the composer.

https://meta.discourse.org/t/extra-spaces-added-to-markdown-with-rich-text-pasted/112769
 2020-11-06 09:36:36 +11:00
Jarek Radosz
1b52cdedb1
DEV: Move more tests into modules (#11119) 
Models, services, mixins, utilities, and most of the controllers
 2020-11-05 20:23:28 +01:00
dependabot-preview[bot]
334ca86c9e
Build(deps): Bump rubocop from 1.1.0 to 1.2.0 (#11138) 
Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 1.1.0 to 1.2.0.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v1.1.0...v1.2.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
 2020-11-05 20:22:30 +01:00
dependabot-preview[bot]
c2e48028a8
Build(deps): Bump rails_failover from 0.5.7 to 0.5.8 (#11137) 
Bumps rails_failover from 0.5.7 to 0.5.8.

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
 2020-11-05 18:33:38 +00:00
dependabot-preview[bot]
122c7406b4
Build(deps): Bump rubocop-ast from 1.1.0 to 1.1.1 (#11135) 
Bumps [rubocop-ast](https://github.com/rubocop-hq/rubocop-ast) from 1.1.0 to 1.1.1.
- [Release notes](https://github.com/rubocop-hq/rubocop-ast/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop-ast/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop-ast/compare/v1.1.0...v1.1.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
 2020-11-05 19:00:21 +01:00
jbrw
bba73fc15e
FEATURE: Allow category group moderators to delete topics (#11069) 
* FEATURE - allow category group moderators to delete topics

* Allow individual posts to be deleted

* DEV - refactor for new `can_moderate_topic?` method
 2020-11-05 12:18:26 -05:00
Arpit Jalan
436bd48512
UX: update topic small action post to add link for new linked topic URL (#11132) 
https://meta.discourse.org/t/linked-topics-splitting-and-managing-megatopics/168992/4?u=techapj
 2020-11-05 22:39:21 +05:30
Penar Musaraj
707ed01f33
UX: Wider canvas buttons in wizard (#11124) 2020-11-05 09:55:35 -05:00
dependabot-preview[bot]
d508545954
Build(deps-dev): Bump better_errors from 2.9.0 to 2.9.1 (#11134) 
Bumps [better_errors](https://github.com/BetterErrors/better_errors) from 2.9.0 to 2.9.1.
- [Release notes](https://github.com/BetterErrors/better_errors/releases)
- [Commits](https://github.com/BetterErrors/better_errors/compare/v2.9.0...v2.9.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
 2020-11-05 15:52:51 +01:00
Penar Musaraj
9f6c4ad71a
FIX: inconsistency in S3 inventory config (#11112) 
Ensures it matches S3 inventory config generation in our hosting.
 2020-11-05 08:39:40 -05:00
Sam
2686d14b9a
PERF: introduce aggressive rate limiting for anonymous (#11129) 
Previous to this change our anonymous rate limits acted as a throttle.
New implementation means we now also consider rate limited requests towards
the limit.

This means that if an anonymous user is hammering the server it will not be
able to get any requests through until it subsides with traffic.
 2020-11-05 16:36:17 +11:00
Tobias Eigen
6490fac881
DEV: improved text on invite tabs when nothing to show (#11122) 2020-11-05 15:24:09 +11:00
dependabot-preview[bot]
df996c4d10
DEV: Bump better_errors from 2.8.3 to 2.9.0 (#11128) 
Bumps [better_errors](https://github.com/BetterErrors/better_errors) from 2.8.3 to 2.9.0.
- [Release notes](https://github.com/BetterErrors/better_errors/releases)
- [Commits](https://github.com/BetterErrors/better_errors/compare/v2.8.3...v2.9.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
 2020-11-05 15:10:21 +11:00
Kris
3ee216c036
FIX: include header offset relative to window (#11114) 2020-11-04 21:14:17 -05:00
Roman Rizzi
fa12302e77
FIX: Update review settings. (#11125) 
We didn't update review settings even if the UI says it was successfully saved. After #11097, we started to clone each setting and store the changes there instead, but we still use the original objects when we perform the save action.
 2020-11-05 12:26:59 +11:00
tshenry
d778d99b55
FIX: limit_topics_per_day should only apply to regular topics (#11127) 
PMs were being evaluted by both the limit_topics_per_day and limit_private_messages_per_day rate limiters when it should only be the latter.
 2020-11-04 16:23:49 -08:00
Sam
1ec76ff8d4
FEATURE: change default so log_out_strict is default disabled (#11126) 
Discourse used to break from convention by logging out all sessions on any
specific session logout.

This would leave users confused about why mobile is logged out when the user
logged out of desktop.

log_out_strict is too conservative for most and not the pattern the industry
has adopted (google/twitter/facebook all perform no strict logouts)
 2020-11-05 09:30:05 +11:00
Penar Musaraj
c1f3bd6a1c
FIX: secure_media stripping on lightboxes, non-image links (#11121) 
- Fixes stripping of lightboxes with empty srcset attribute
- Does not fail when email has links with secure media URLs but no child image elements
 2020-11-04 15:45:50 -05:00
Arpit Jalan
3397e0e38b
UX: sort user badges by Gold > Silver > Bronze. (#11117) 2020-11-04 22:17:47 +05:30
Arpit Jalan
d237ada12f
FIX: enqueue PostCreator jobs outside transaction block (#11120) 
The `enqueue_jobs` is not correctly post-processing the post since the
post is being created inside a transaction block. This commit explicitly
enqueues the job outside transaction block.
 2020-11-04 21:41:05 +05:30
jbrw
d85fc96193
DEV - Test for an integer padded with spaces (#11111) 2020-11-04 11:05:31 -05:00
Arpit Jalan
24d1b1f159
UX: when creating linked topic use URL and let onebox work its magic (#11118) 
When the linked topic is created we'll not hardcode the topic title and
let onebox work its magic instead so that the title can be updated
automatically.
 2020-11-04 17:19:09 +05:30
dependabot-preview[bot]
950413a81a
Build(deps-dev): Bump ruby-prof from 1.4.1 to 1.4.2 (#11116) 
Bumps [ruby-prof](https://github.com/ruby-prof/ruby-prof) from 1.4.1 to 1.4.2.
- [Release notes](https://github.com/ruby-prof/ruby-prof/releases)
- [Changelog](https://github.com/ruby-prof/ruby-prof/blob/master/CHANGES)
- [Commits](https://github.com/ruby-prof/ruby-prof/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
 2020-11-04 11:30:20 +01:00
Arpit Jalan
0cb4109cbb
FIX: group notification level cannot be null (#11109) 
Group's `default_notification_level` cannot be null so there is no need
to provide "none" translation for group notification level dropdown.
 2020-11-04 07:29:00 +05:30
Martin Brennan
2bb7676ba4
FIX: Stop bypassing email checks for invite emails (#11113) 
See #10794 for original context.

I did not mean to add invite to the BYPASS_TYPES for Email::Sender, it was supposed to be invite_password_instructions.
 2020-11-04 09:18:22 +10:00