discourse

github-mirror/discourse

Fork 0

mirror of https://github.com/discourse/discourse.git synced 2024-11-29 17:35:12 +08:00

Commit Graph

Author SHA1 Message Date

Author	SHA1	Message	Date
David Taylor	b2a8dc4c0f	FIX: Maintain HTML `<img` when downloading remote images (#16278 ) Under some conditions, replacing an `<img` with `![]()` can break rendering, and make the image disappear. Context at https://meta.discourse.org/t/152801	2022-03-29 10:55:10 +01:00
David Taylor	c9dab6fd08	DEV: Automatically require 'rails_helper' in all specs (#16077 ) It's very easy to forget to add `require 'rails_helper'` at the top of every core/plugin spec file, and omissions can cause some very confusing/sporadic errors. By setting this flag in `.rspec`, we can remove the need for `require 'rails_helper'` entirely.	2022-03-01 17:50:50 +00:00
Jarek Radosz	48b92d8897	DEV: Isolate multisite specs (#13634 ) Mixing multisite and standard specs can lead to issues (e.g. when using `fab!`) Disabled the (upcoming https://github.com/discourse/rubocop-discourse/pull/11) rubocop rule for two files that have thoroughly tangled both types of specs.	2021-07-07 18:57:42 +02:00

David Taylor

b2a8dc4c0f

FIX: Maintain HTML <img when downloading remote images (#16278 )

Under some conditions, replacing an `<img` with `![]()` can break rendering, and make the image disappear.

Context at https://meta.discourse.org/t/152801

2022-03-29 10:55:10 +01:00

David Taylor

c9dab6fd08

DEV: Automatically require 'rails_helper' in all specs (#16077 )

It's very easy to forget to add `require 'rails_helper'` at the top of every core/plugin spec file, and omissions can cause some very confusing/sporadic errors.

By setting this flag in `.rspec`, we can remove the need for `require 'rails_helper'` entirely.

2022-03-01 17:50:50 +00:00

Jarek Radosz

48b92d8897

DEV: Isolate multisite specs (#13634 )

Mixing multisite and standard specs can lead to issues (e.g. when using `fab!`)
Disabled the (upcoming https://github.com/discourse/rubocop-discourse/pull/11) rubocop rule for two files that have thoroughly tangled both types of specs.

2021-07-07 18:57:42 +02:00

3 Commits