Joe
2b071ed930
DEV: pass the current category to discovery-list-container-top on tag pages ( #11690 )
2021-01-13 20:04:02 +08:00
Martin Brennan
2404fa7a23
DEV: Split toggle topic close job ( #11679 )
...
Splits the `ToggleTopicClosed` job into two distinct `OpenTopic` and `CloseTopic` jobs to make the code clearer. The old job cannot be deleted yet because of outstanding sidekiq schedules, so a todo has been added to do so later this year.
Also replaced mentions of `topic_status_update` with `topic_timer` in some files, because the `topic_status_update` model is obsolete and replaced by topic timer.
Added some shortcut methods for checking if a topic is open/whether a user can change an open topic.
2021-01-13 08:49:29 +10:00
dependabot[bot]
0005036ae3
Build(deps): Bump sanitize from 5.2.2 to 5.2.3 ( #11697 )
...
Bumps [sanitize](https://github.com/rgrove/sanitize ) from 5.2.2 to 5.2.3.
- [Release notes](https://github.com/rgrove/sanitize/releases )
- [Changelog](https://github.com/rgrove/sanitize/blob/master/HISTORY.md )
- [Commits](https://github.com/rgrove/sanitize/compare/v5.2.2...v5.2.3 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-12 22:42:03 +01:00
dependabot[bot]
e76c043bc5
Build(deps-dev): Bump shoulda-matchers from 4.4.1 to 4.5.0 ( #11696 )
...
Bumps [shoulda-matchers](https://github.com/thoughtbot/shoulda-matchers ) from 4.4.1 to 4.5.0.
- [Release notes](https://github.com/thoughtbot/shoulda-matchers/releases )
- [Changelog](https://github.com/thoughtbot/shoulda-matchers/blob/master/CHANGELOG.md )
- [Commits](https://github.com/thoughtbot/shoulda-matchers/compare/v4.4.1...v4.5.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-12 22:40:30 +01:00
dependabot[bot]
87e7b1efe8
Build(deps): Bump faraday-net_http from 1.0.0 to 1.0.1 ( #11695 )
...
Bumps [faraday-net_http](https://github.com/lostisland/faraday-net_http ) from 1.0.0 to 1.0.1.
- [Release notes](https://github.com/lostisland/faraday-net_http/releases )
- [Commits](https://github.com/lostisland/faraday-net_http/compare/v1.0.0...v1.0.1 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-12 22:31:59 +01:00
Andrew Prigorshnev
0f1c9a2180
FIX: Use the same time moment for related Redis calls in rate limiter ( #11692 )
...
Co-authored-by: Robin Ward <robin.ward@gmail.com>
2021-01-12 15:09:15 -05:00
Andrew Prigorshnev
e25dd41aee
FIX: sliding window end time in rate limiter ( #11691 )
...
If the sliding window size is N seconds, then a moment at the Nth second
should be considered as the moment outside of the sliding window.
Otherwise, if the sliding window is already full, at the Nth second,
a new call wouldn't be allowed, but a time to wait before the next call
would be equal to zero, which is confusing.
In other words, the end of the time range shouldn't be included in the
sliding window.
Let's say we start at the second 0, and the sliding window size is 10
seconds. In the current version of rate limiter, this sliding window will
be considered as a time range [0, 10] (including the end of the range),
which actually is 11 seconds in length.
After this fix, the time range will be considered as [0, 10)
(excluding the end of the range), which is exactly 10 seconds in length.
2021-01-12 13:26:43 -05:00
Bianca Nenciu
ec0212e56b
FIX: Make category slugs lowercase ( #11277 )
...
Admins could specify category slug with upper case characters and same slug,
but with different cases could be used simultaneously.
2021-01-12 17:28:33 +02:00
Robin Ward
e80332a2bc
REFACTOR: Sync up master with changes for Ember-CLI ( #11671 )
...
The more parallel the branches, the easier the transition will be.
2021-01-12 10:13:21 -05:00
Bianca Nenciu
499a594754
FIX: Do not downsize or crop GIF images ( #10989 )
...
It was a problem because during this operation only the first frame
is kept. This commit removes the alternative solution to check if a GIF
image is animated.
2021-01-12 17:07:07 +02:00
Discourse Translator Bot
0e8e3f4813
Update translations ( #11689 )
2021-01-12 14:29:05 +01:00
Kris
7210e0a050
FEATURE: Add before-groups-index-container outlet ( #11681 )
2021-01-11 20:27:24 -05:00
dependabot[bot]
c1763561f3
Build(deps): Bump omniauth-oauth2 from 1.7.0 to 1.7.1 ( #11687 )
...
Bumps [omniauth-oauth2](https://github.com/omniauth/omniauth-oauth2 ) from 1.7.0 to 1.7.1.
- [Release notes](https://github.com/omniauth/omniauth-oauth2/releases )
- [Commits](https://github.com/omniauth/omniauth-oauth2/compare/v1.7.0...v1.7.1 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-11 22:53:07 +01:00
dependabot[bot]
bc699581b3
Build(deps): Bump uniform_notifier from 1.13.1 to 1.13.2 ( #11684 )
...
Bumps [uniform_notifier](https://github.com/flyerhzm/uniform_notifier ) from 1.13.1 to 1.13.2.
- [Release notes](https://github.com/flyerhzm/uniform_notifier/releases )
- [Changelog](https://github.com/flyerhzm/uniform_notifier/blob/master/CHANGELOG.md )
- [Commits](https://github.com/flyerhzm/uniform_notifier/compare/v1.13.1...v1.13.2 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-11 22:52:10 +01:00
dependabot[bot]
f4d01c6bc9
Build(deps): Bump rubocop from 1.8.0 to 1.8.1 ( #11685 )
...
Bumps [rubocop](https://github.com/rubocop-hq/rubocop ) from 1.8.0 to 1.8.1.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases )
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v1.8.0...v1.8.1 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-11 22:51:34 +01:00
dependabot[bot]
fbb1130022
Build(deps-dev): Bump mock_redis from 0.27.2 to 0.27.3 ( #11686 )
...
Bumps [mock_redis](https://github.com/sds/mock_redis ) from 0.27.2 to 0.27.3.
- [Release notes](https://github.com/sds/mock_redis/releases )
- [Changelog](https://github.com/sds/mock_redis/blob/master/CHANGELOG.md )
- [Commits](https://github.com/sds/mock_redis/compare/v0.27.2...v0.27.3 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-11 22:51:05 +01:00
Kane York
a88a246c6e
FIX: Discobot exception when site_contact_username is promoted ( #11666 )
...
Because the site admin is sending a message to themselves, there is only one user in the topic_allowed_users, and `.last` returns nil.
Attempt to recognize this situation and continue, or bail without doing anything if this somehow happens another way.
2021-01-11 13:07:36 -08:00
jbrw
b1f32f2f57
DEV: TopicTrackingState calls should happen in the background ( #11682 )
...
* DEV: TopicTrackingState calls should happen in the background
It was observed that calling TopicTrackingState on popular topics could result in a large number of calls to redis, resulting in slow response times when posting replies.
These calls should be moved to a background job.
* DEV: PostUpdateTopicTrackingState should execute on default queue
2021-01-11 15:58:27 -05:00
Mark VanLandingham
3eae4d3669
FIX: Publish DND ends_at updates in httpdate format ( #11683 )
2021-01-11 14:11:26 -06:00
Robin Ward
49b753eee0
FIX: Hiding a post should not trigger the duplicate check ( #11680 )
...
If for some reason a post was allowed to be duplicated (probably via
staff edit) hiding it should be permitted.
2021-01-11 14:56:08 -05:00
Kris
2f84ab6e0a
UX: add space between links and text in labels ( #11674 )
2021-01-11 13:35:41 -05:00
Osama Sayegh
422f395042
FIX: Show unassigned component warning when installing multiple components successively ( #11675 )
...
A while ago we made a change to display a warning after installing a theme component when the admin tries to leave the page without adding the new installed component to any themes (see 5e29ae3ef5
2021-01-11 18:29:12 +03:00
Osama Sayegh
116a879ff4
FIX: Reset theme install modal state on close ( #11670 )
...
The theme install modal should reset its state on close, otherwise it might cause confusion when installing multiple components successively.
2021-01-11 18:27:31 +03:00
Neil Lalonde
19cbda15e9
FIX: hidden tags returned in extras of tags index json
2021-01-11 10:21:54 -05:00
Krzysztof Kotlarek
efaa63bd1d
FIX: always truncate uncomplete emojis in excerpts ( #11678 )
...
Additional fix after https://github.com/discourse/discourse/pull/11667
Always truncate "broken" emojis from excerpts.
2021-01-11 13:43:11 +11:00
Krzysztof Kotlarek
7f78b6ec10
FIX: broken emojis in topic excerpt ( #11667 )
...
When a post is truncated into the excerpt, sometimes we are breaking code of emoji
2021-01-11 10:40:41 +11:00
dependabot[bot]
2e24254773
Build(deps-dev): Bump simplecov from 0.21.1 to 0.21.2 ( #11676 )
...
Bumps [simplecov](https://github.com/simplecov-ruby/simplecov ) from 0.21.1 to 0.21.2.
- [Release notes](https://github.com/simplecov-ruby/simplecov/releases )
- [Changelog](https://github.com/simplecov-ruby/simplecov/blob/main/CHANGELOG.md )
- [Commits](https://github.com/simplecov-ruby/simplecov/compare/v0.21.1...v0.21.2 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-11 00:23:10 +01:00
dependabot[bot]
9498de420b
Build(deps): Bump uniform_notifier from 1.13.0 to 1.13.1 ( #11677 )
...
Bumps [uniform_notifier](https://github.com/flyerhzm/uniform_notifier ) from 1.13.0 to 1.13.1.
- [Release notes](https://github.com/flyerhzm/uniform_notifier/releases )
- [Changelog](https://github.com/flyerhzm/uniform_notifier/blob/master/CHANGELOG.md )
- [Commits](https://github.com/flyerhzm/uniform_notifier/compare/v1.13.0...v1.13.1 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-11 00:21:43 +01:00
David Taylor
b0088361a4
FIX: Do not include URL query in auto-generated CSP header ( #11673 )
2021-01-09 13:52:53 +00:00
Jarek Radosz
9da9b2e1cc
DEV: Add i18n fallback specs ( #11669 )
...
Those fail on the buggy i18n release (1.8.6) and pass on 1.8.5, 1.8.7 (the revert release), and with the second stab at thread safety on the current master (63a79cb929
2021-01-08 17:47:28 +01:00
Justin DiRose
f6e87e1e5e
DEV: Improvements to Discourse Merger script ( #11660 )
...
After running the Discourse merge script, it was pretty evident it held up well after all these years ;)
Made a few fixes:
Included an environment variable for DB_PASS as likely the password will need to be changed if running the import in an official Docker container (recommended)
Set a hard order for imported categories, otherwise sometimes they'd be imported in a weird order making things unpredictable for parent/child category imports
Fixed a couple of instances where we added unique indexes (such as on category slugs)
Set up upload regex to handle AWS URLs better
Fixed the script to work with frozen string literals
2021-01-08 09:31:39 -06:00
Arpit Jalan
25b4e82601
FEATURE: allow disabling self-deletions of posts ( #11668 )
...
https://meta.discourse.org/t/restoring-deleted-messages/173647/6?u=techapj
2021-01-08 20:35:13 +05:30
Roman Rizzi
caa17386ee
FEATURE: Use the site's small logo as the system user's avatar. ( #11661 )
2021-01-08 10:40:00 -03:00
Michael Brown
e63a9facc7
UI: remove extra word from approval_not_required client string ( #11627 )
2021-01-08 12:59:23 +11:00
Krzysztof Kotlarek
4928f9cceb
FIX: don't error topic RSS when posts are deleted ( #11641 )
2021-01-08 11:16:15 +11:00
dependabot[bot]
1cf9231045
Build(deps-dev): Bump mock_redis from 0.27.0 to 0.27.2 ( #11664 )
...
Bumps [mock_redis](https://github.com/sds/mock_redis ) from 0.27.0 to 0.27.2.
- [Release notes](https://github.com/sds/mock_redis/releases )
- [Changelog](https://github.com/sds/mock_redis/blob/master/CHANGELOG.md )
- [Commits](https://github.com/sds/mock_redis/compare/v0.27.0...v0.27.2 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-07 16:32:28 -05:00
dependabot[bot]
2d11309ac5
Build(deps): Bump unicode-display_width from 1.7.0 to 2.0.0 ( #11662 )
...
Bumps [unicode-display_width](https://github.com/janlelis/unicode-display_width ) from 1.7.0 to 2.0.0.
- [Release notes](https://github.com/janlelis/unicode-display_width/releases )
- [Changelog](https://github.com/janlelis/unicode-display_width/blob/main/CHANGELOG.md )
- [Commits](https://github.com/janlelis/unicode-display_width/compare/v1.7.0...v2.0.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-07 16:31:21 -05:00
Roman Rizzi
e696cba071
FIX: Don't count HTML comments when calculating reply length. ( #11658 )
...
We'll remove them when we sanitize the post raw content.
2021-01-07 15:44:17 -03:00
Osama Sayegh
2e3b3ec2de
FEATURE: Warn admins when installing a theme that's already installed ( #11651 )
...
Installing multiple copies of the same theme/component is possible, but you rarely need to actually have multiple copies installed. We've seen many times new admins installing duplicates of components because they were unaware it was already installed. This PR makes the theme installer modal loop through the existing themes when you click on 'install', and if there is a theme with a URL that matches the URL you entered, a warning will show up and you will need to click 'install' again to proceed.
2021-01-07 21:03:35 +03:00
Mark VanLandingham
4601f3be7e
FEATURE: Send notification emails when users leave do not disturb mode ( #11643 )
2021-01-07 10:49:49 -06:00
Osama Sayegh
3865308e36
FIX: Tab key should autocomplete like enter key does ( #11659 )
2021-01-07 19:43:13 +03:00
Penar Musaraj
c819284660
UX: Improve color scheme choices in user prefs ( #11656 )
2021-01-07 11:15:38 -05:00
dependabot[bot]
ef84fb6469
Build(deps-dev): Bump minitest from 5.14.2 to 5.14.3 ( #11649 )
...
Bumps [minitest](https://github.com/seattlerb/minitest ) from 5.14.2 to 5.14.3.
- [Release notes](https://github.com/seattlerb/minitest/releases )
- [Changelog](https://github.com/seattlerb/minitest/blob/master/History.rdoc )
- [Commits](https://github.com/seattlerb/minitest/compare/v5.14.2...v5.14.3 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-07 10:44:45 -05:00
Joffrey JAFFEUX
49f4c75080
FIX: recurring was not working for some cases (eg: hours and unit > 1) ( #11657 )
2021-01-07 12:21:51 +01:00
dependabot[bot]
0c451d14d9
Build(deps): Bump nokogiri from 1.11.0 to 1.11.1 ( #11647 )
...
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri ) from 1.11.0 to 1.11.1.
- [Release notes](https://github.com/sparklemotion/nokogiri/releases )
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/master/CHANGELOG.md )
- [Commits](https://github.com/sparklemotion/nokogiri/compare/v1.11.0...v1.11.1 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-07 11:59:12 +01:00
tshenry
d8b015e3be
Minor copyedit on flag stat popup ( #11655 )
2021-01-06 20:49:35 -08:00
dependabot[bot]
ee9ea20d95
Build(deps): Bump onebox from 2.2.1 to 2.2.2 ( #11653 )
...
Bumps [onebox](https://github.com/discourse/onebox ) from 2.2.1 to 2.2.2.
- [Release notes](https://github.com/discourse/onebox/releases )
- [Changelog](https://github.com/discourse/onebox/blob/master/CHANGELOG.md )
- [Commits](https://github.com/discourse/onebox/compare/v2.2.1...v2.2.2 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-06 15:18:05 -08:00
Jordan Vidrine
437ca97eac
FIX: Fix bg color of header on published page ( #11652 )
...
This commit correctly sets the bg color of the header on published pages to be var(--header_background) instead of var(--secondary).
2021-01-06 16:54:37 -06:00
Mark VanLandingham
aa909f58a9
FIX: Hide notification count on document title in Do Not Disturb ( #11646 )
2021-01-06 16:15:04 -06:00
Kris
d15159dff7
UX: Refactor topic list nav ( #11285 )
2021-01-06 16:15:28 -05:00
