Commit Graph

12524 Commits

Author SHA1 Message Date
Rafael dos Santos Silva
2ce8845c89 Enable last visit line on mobile 2016-09-27 16:24:23 -03:00
Rafael dos Santos Silva
a0f50ddaa7 Tone down text 2016-09-27 15:43:23 -03:00
Guo Xiang Tan
119225e496 Make eslint happy. 2016-09-27 15:12:47 +08:00
Rafael dos Santos Silva
16aad189fb UX: Add text to new messages line 2016-09-27 14:52:03 +08:00
Jeff Atwood
a300e01af3 Merge pull request #4466 from xfalcox/word-wrap-latest-topics
FIX: Add word-wrap for blink browsers on categories latest session
2016-09-27 07:20:27 +02:00
Vibol Hou
34af73c7cb FEATURE: sparkpost webhook 2016-09-26 22:13:34 -07:00
Rafael dos Santos Silva
03ec480c65 Removes UI for print, adds CTRL+P shortcut 2016-09-26 20:46:55 -03:00
Rafael dos Santos Silva
0229df4c73 Second review fixes 2016-09-26 20:46:55 -03:00
Rafael dos Santos Silva
2a5a0bebb3 Adjusts from review 2016-09-26 20:46:55 -03:00
Rafael dos Santos Silva
acc70cc3de SiteSetting, admin passtrough, CSS, hide on mobile 2016-09-26 20:46:55 -03:00
Rafael dos Santos Silva
6faedfa716 Rate limit printing 2016-09-26 20:46:55 -03:00
Rafael dos Santos Silva
70c68f0a7c Open print dialog automatically 2016-09-26 20:44:50 -03:00
Rafael dos Santos Silva
c12e533273 Feature: Adds a button to print a topic 2016-09-26 20:44:50 -03:00
Rafael dos Santos Silva
ece10386a1 FIX: Long words on title shouldn't break layout 2016-09-26 19:12:46 -03:00
Rafael dos Santos Silva
c759b5f955 Make ES5 compatible 2016-09-26 18:43:33 -03:00
Jeff Atwood
d69cf820d8 Merge pull request #4462 from xfalcox/hide-names-about
FIX: Hide full names on /about for crawlers when names are disabled
2016-09-26 23:21:08 +02:00
Jeff Atwood
a4dd862ad0 Merge pull request #4463 from xfalcox/emoji-grouping
FIX: New Emoji had missing group info
2016-09-26 23:20:35 +02:00
Rafael dos Santos Silva
7149e2ba20 FIX: New Emoji had missing group info 2016-09-26 18:12:40 -03:00
Rafael dos Santos Silva
108e3fdf97 FIX: Hide full names on /about for crawlers when names are disabled 2016-09-26 16:31:39 -03:00
Rafael dos Santos Silva
048dea01f4 Fix tags separation on new category page 2016-09-26 16:14:41 -03:00
Guo Xiang Tan
999f52954f FIX: Incorrect import path for iconHTML helper. 2016-09-25 12:39:17 +08:00
Guo Xiang Tan
4e663998af PERF: N+1 query on user summary page. 2016-09-23 12:44:08 +08:00
Guo Xiang Tan
bddbfa56f6 UX: Format numbers on user summary page. 2016-09-23 12:36:42 +08:00
Robin Ward
f90e1ce847 FIX: Don't double escape the category title 2016-09-22 21:13:08 -04:00
Neil Lalonde
e0be2f482e FEATURE: tag filter dropdown menu is scoped to user and category 2016-09-22 15:23:37 -04:00
Robin Ward
3d621767cc FIX: Wizard didn't work with subfolders 2016-09-22 14:39:36 -04:00
Robin Ward
92529cd409 FIX: Tab ordering and outlines for wizard 2016-09-22 13:38:58 -04:00
Robin Ward
7f66cf618c FIX: You should be an admin to do the wizard 2016-09-22 11:12:51 -04:00
Régis Hanol
8f7a2cb470 UX: user messages list was too thin 2016-09-22 16:26:38 +02:00
Robin Ward
a09a09f686 FIX: Test was broken 2016-09-22 10:01:25 -04:00
Jeff Atwood
3ac348e898 Revert "add bit of random to the confetti"
This reverts commit 913e18579f8c4c6bad3269896c549779b554ece1.
2016-09-22 09:52:19 -04:00
Jeff Atwood
3f09ef70eb add bit of random to the confetti 2016-09-22 09:52:19 -04:00
Robin Ward
9bba0f3288 FIX: Show "Categories" when you are viewing the categories pills 2016-09-22 09:52:19 -04:00
Robin Ward
a95bb6006d Show staff count on invites page, don't warn if you have 3 2016-09-22 09:52:19 -04:00
Robin Ward
62e1f88adc Try to be smarter about scaling images on canvases 2016-09-22 09:52:19 -04:00
Robin Ward
14bee641aa Can choose categories or latest as homepage style 2016-09-22 09:52:19 -04:00
Jeff Atwood
776d540c7f Emoji copy update 2016-09-22 09:52:19 -04:00
Robin Ward
2a0443445b New step to choose emoji set 2016-09-22 09:52:19 -04:00
Robin Ward
8f36f95180 Bump up the size of the theme preview 2016-09-22 09:52:19 -04:00
Robin Ward
2545c2ffa6 Add new welcome message step 2016-09-22 09:52:19 -04:00
Jeff Atwood
ff17950993 tweaks 2016-09-22 09:52:19 -04:00
Robin Ward
3fac43249c Javascript file was missing 2016-09-22 09:52:19 -04:00
Robin Ward
f4f1569e0c Move step text into progress bar 2016-09-22 09:52:19 -04:00
Robin Ward
9938f9bd67 Added images to the first and last step of the wizard 2016-09-22 09:52:19 -04:00
Robin Ward
b0ee7930e8 Server side support for inviting as a moderator via the wizard 2016-09-22 09:52:19 -04:00
Robin Ward
42f6e52dc6 Warn the user if they haven't invited anyone 2016-09-22 09:52:19 -04:00
Robin Ward
cf84538fbf Bump up smallest size again 2016-09-22 09:52:19 -04:00
Robin Ward
1bf1bf4f93 Use our badge colors for the speech bubbles 2016-09-22 09:52:19 -04:00
Robin Ward
c718826134 Randomly flip some of the bubbles 2016-09-22 09:52:19 -04:00
Robin Ward
844c86481e Add more particles, remove black color 2016-09-22 09:52:19 -04:00
Robin Ward
899779b3c4 FIX: Confetti should go all the way to the right 2016-09-22 09:52:19 -04:00
Robin Ward
afe1a8e895 UX: Remove checkmark icon from Done 2016-09-22 09:52:19 -04:00
Robin Ward
454bcdca0b Add confetti effect for when you finish the wizard 2016-09-22 09:52:19 -04:00
Robin Ward
598db7a81c Add Apple Icon preview 2016-09-22 09:52:19 -04:00
Robin Ward
e7c1962aa0 Preview the favicon in the wizard 2016-09-22 09:52:19 -04:00
Robin Ward
0a41217604 Small Logo Preview looks better 2016-09-22 09:52:19 -04:00
Robin Ward
a318b18236 Custom Preview for Header Logo 2016-09-22 09:52:19 -04:00
Robin Ward
69325fbe02 Wizard: Support for custom image previews for uploads 2016-09-22 09:52:19 -04:00
Robin Ward
05d1c8167f UX: Use a minimum height for the wizard so it doesn't move as much 2016-09-22 09:52:19 -04:00
Robin Ward
74ed2e82ac UX: Wiggle invalid form elements. Don't allow a site title of Discourse 2016-09-22 09:52:19 -04:00
Robin Ward
2ff6295f71 UX: De-emphasize back/quit buttons in the wizard 2016-09-22 09:52:19 -04:00
Robin Ward
29cf47cfb2 Track steps the user has completed, nag them to finish it. 2016-09-22 09:52:19 -04:00
Robin Ward
ef84981e38 Invite Users step 2016-09-22 09:52:19 -04:00
Robin Ward
35b767f6af Company Name Step which updates the TOS 2016-09-22 09:52:19 -04:00
Robin Ward
28b6c300a0 Clean up wizard updater API for better plugin use 2016-09-22 09:52:19 -04:00
Robin Ward
e3640ee5f6 Privacy Step 2016-09-22 09:52:19 -04:00
Robin Ward
af83c8dc14 Upload Logos Step 2016-09-22 09:52:19 -04:00
Robin Ward
c94e6f1b96 Add locale step 2016-09-22 09:52:19 -04:00
Robin Ward
3f6e3b9aff Wizard - Color Scheme Step 2016-09-22 09:52:19 -04:00
Robin Ward
9f12b571ef Wizard: Server Side Validation + Finished Step 2016-09-22 09:52:19 -04:00
Robin Ward
be1d74d207 Split out common functions into discourse-common module 2016-09-22 09:52:19 -04:00
Robin Ward
3a4615c205 Wizard: Step 1 2016-09-22 09:48:58 -04:00
Robin Ward
0471ad393c Scaffold for new Wizard - Rails / Ember / Tests 2016-09-22 09:48:58 -04:00
Robin Ward
6070939daa Support for other i18n bundles 2016-09-22 09:48:58 -04:00
Guo Xiang Tan
7acbd63d92 FIX: Remove CSS hack. 2016-09-22 17:39:20 +08:00
Régis Hanol
9aecf4e6d1 Merge pull request #4455 from tgxworld/fix_category_logo_url
FIX: Form CDN URL client side instead.
2016-09-22 11:01:16 +02:00
Guo Xiang Tan
5d2aa957b4 UX: Take into account of header when rendering autocomplete. 2016-09-22 13:42:49 +08:00
Guo Xiang Tan
7dea31adce FIX: Form CDN URL client side instead. 2016-09-22 11:57:18 +08:00
Guo Xiang Tan
9374e5d42d Revert "FIX: don't overwrite category's logo & background URLs"
This reverts commit 641b95f655.
2016-09-22 11:30:19 +08:00
Guo Xiang Tan
2470d1f65a Revert "FIX: serve category images from the CDN"
This reverts commit d0962d6e5a.
2016-09-22 11:29:04 +08:00
Régis Hanol
641b95f655 FIX: don't overwrite category's logo & background URLs 2016-09-21 22:11:31 +02:00
Guo Xiang Tan
6b8a96f2a9 Make eslint happy. 2016-09-21 11:45:17 +08:00
Guo Xiang Tan
24dcd7df47 FIX: 'quote reply' button not showing when an emoji is included. 2016-09-21 11:14:43 +08:00
Guo Xiang Tan
62ce9938ab Add plugin outlet after user names in user profile page. 2016-09-21 10:49:48 +08:00
Erick Guan
707fcb9434
FIX: Content-Lenght should be the size in octets 2016-09-21 10:31:20 +08:00
Arpit Jalan
afef9a0668 FEATURE: add page identifier on user badges page 2016-09-20 23:54:59 +05:30
Arpit Jalan
4f13422c47 FEATURE: add more page identifiers 2016-09-20 23:13:56 +05:30
Robin Ward
a26e0df0c7 FIX: Bug when linking to anchors 2016-09-20 11:13:40 -04:00
Daniel Marquard
5968f39d7e Allow for search engine updates 2016-09-19 22:25:54 -04:00
Daniel Marquard
d77deaa185 Firefox needs "title" OpenSearch parameter 2016-09-19 22:21:42 -04:00
Daniel Marquard
222ef942ee Well formed OpenSearch/XML
1 of 2 changes for OpenSearch to better support Firefox.
2016-09-19 22:12:43 -04:00
Guo Xiang Tan
547750e9dd Unify API keys and web hooks into a single admin nav header. 2016-09-20 05:22:03 +08:00
Neil Lalonde
fa6b10cf3c FIX: scale fontawesome glyph avatar flair on user cards 2016-09-19 14:04:51 -04:00
Robin Ward
2766b2edc3 FIX: Allow redirection for slugs that start with digits 2016-09-19 13:31:19 -04:00
Arpit Jalan
332cc2bb95 FEATURE: new twitter_summary_large_image_url setting 2016-09-19 18:43:33 +05:30
Sam
8dc4329094 FEATURE: optionally get extra profile info from facebook
This feature requires the application be approved by facebook, so it is
default off
2016-09-19 16:14:11 +10:00
Sam
5b3cd3fac9 FEATURE: Import facebook avatars when logging in via facebook
FIX: warning about popup dimensions when using facebook login

Rules are:

- On account creation we always import
- If you already have an avatar uploaded, nothing is changed
- If you have no avatar uploaded, we upload from facebook on login
- If you have no avatar uploaded, we select facebook unless gravatar already selected

This also fixes SSO issues where on account creation accounts had missing avatar uploads
2016-09-19 15:10:23 +10:00
Arpit Jalan
72f9369966 add unique body class to search and user pages 2016-09-19 10:24:58 +05:30
Erick Guan
48fb0558d8 UX: Add headers for webhook events 2016-09-19 12:07:55 +08:00
Erick Guan
00d5facf36 FEATURE: prompts new webhook events 2016-09-19 12:07:17 +08:00
Erick Guan
c463cf63d4 FEATURE: Webhook for user creation and approval 2016-09-19 10:12:55 +08:00
Sam
fd9056973a FEATURE: increase interval to 24 hours for "please refresh site"
Used to be 2 hours, which is a bit tight, especially for people who leave
computer running overnight.

Keep in mind we always refresh on route change, so clicking on a topic will
trigger a refresh
2016-09-19 10:12:27 +10:00
Sam
24401e71bf FEATURE: add seen_notification_id to current user serializer 2016-09-18 14:30:32 +10:00
cpradio
2eddeab66b Escape the hyphen 2016-09-16 19:07:46 -04:00
cpradio
0d2d8797b6 FIX: Backup validation wasn't escaping hyphens 2016-09-16 15:20:42 -04:00
Neil Lalonde
28f857c530 FIX: primary group name class missing from poster name 2016-09-16 15:09:35 -04:00
Guo Xiang Tan
451050c6c4 Merge pull request #4437 from fantasticfears/webhooks-event-name
FIX: show event name in webhook headers
2016-09-16 14:27:12 +08:00
Sam
75f3f7fcbd FEATURE: clean API method for reading a single notification 2016-09-16 16:14:15 +10:00
Guo Xiang Tan
512922d776 SECURITY: Add filename validation for backup uploads. 2016-09-16 11:58:14 +08:00
Sam
e6fcaadd45 FIX: redirects back to origin for SSO and omniauth login 2016-09-16 13:48:50 +10:00
Sam
25a82e7d22 PERF: only publish notification state if we changed it
also publish seen_notification_id so we can tell what is new and what is old
cleanup controller so it correctly checks user
fix bug around clearing notification when people click mark read
2016-09-16 12:02:19 +10:00
Sam
33578a2c17 FIX: always import avatars during SSO if they are missing 2016-09-16 09:45:00 +10:00
Neil Lalonde
b9801d2e26 UX: add text near group flair settings explaining that flair only shows for a user's primary group 2016-09-15 17:39:47 -04:00
Neil Lalonde
a74781fbbc fix jslint error 2016-09-15 16:50:23 -04:00
Neil Lalonde
d0ebde9d84 don't try to render flair if there's no primary group 2016-09-15 16:26:58 -04:00
Neil Lalonde
e3e15182df FEATURE: avatar flair on user cards 2016-09-15 16:15:18 -04:00
Robin Ward
cd571b26ba FIX: Allow Safe Redirections in Topic Embedding 2016-09-15 13:56:59 -04:00
Arpit Jalan
5dbd6a304b add search-container class to search page 2016-09-15 13:46:22 +05:30
Guo Xiang Tan
baacb30ba1 FIX: Incorrect folder. 2016-09-15 15:20:07 +08:00
Guo Xiang Tan
b0752b1f91 FIX: Don't bypass validations. 2016-09-15 10:15:17 +08:00
Sam
fe7883eeea UX: don't allow user scaling in mobile view
on iOS 10 behavior of zoom restriction has changed.

This does not disable zooming on iOS 10 but it DOES stop it from randomly
zooming when you are composing
2016-09-15 07:36:16 +10:00
Robin Ward
aa7c735d34 FIX: Improve selecting text over line breaks 2016-09-13 11:36:17 -04:00
Neil Lalonde
06eb256d0a FIX: blocking users should never hide all posts if they are trust level 1 or higher 2016-09-12 11:58:10 -04:00
Erick Guan
7423140825
FIX: show event name in webhook headers 2016-09-12 17:48:54 +08:00
Sam
2d859ba0ed FIX: user api should always be available to staff 2016-09-12 15:42:06 +10:00
Neil Lalonde
b381d84dd9 FIX: tag search should not be case sensitive 2016-09-09 16:55:26 -04:00
Robin Ward
1f5325e3f0 FIX: Only validate uploaded URLs if they change 2016-09-08 12:06:18 -04:00
Arpit Jalan
19ddf95efa FIX: add custom invite email templates 2016-09-08 00:54:48 +05:30
Robin Ward
9609a47016 Ability to skip email validation via a plugin 2016-09-07 14:05:46 -04:00
Robin Ward
acaac02673 Merge pull request #4423 from SafaAlfulaij/arabic_client_plural_rules
Add Arabic Pluralization Rules for Client
2016-09-06 11:22:21 -04:00
Matt Palmer
51854e56ac Don't hide e-mail in settings behind email-in plugins 2016-09-06 14:23:43 +10:00
Guo Xiang Tan
0fbb949af5 Merge pull request #4432 from tgxworld/migrate_upload_scheme_to_scheduled_job
FIX: Make `Jobs::MigrateUploadScheme` a scheduled job.
2016-09-06 08:39:27 +08:00
Erick Guan
9ce61b4586 FEATURE: Webhooks. 2016-09-05 18:44:00 +08:00
Guo Xiang Tan
aabb7a8592 FIX: DiscourseEvent should not be triggered from within the controller. 2016-09-05 15:58:04 +08:00
Guo Xiang Tan
e4b75f604c FIX: Make clean up upload script a safer task to run. 2016-09-05 10:06:02 +08:00
Sam
39e6cbc442 FIX: disable double submission which invalidates nonce 2016-09-04 16:05:25 +10:00
Sam
340874d345 FIX: post notifications in JSON so we properly support arrays and so on 2016-09-04 15:51:16 +10:00
Angus McLeod
422941a606 fix order of plugin template resolution 2016-09-02 12:55:11 -04:00
Sam
1d281e02c7 id is optional if already specified in header 2016-09-02 17:08:46 +10:00
Sam
be0fd5b4cc FEATURE: allow user api key revocation for read only keys 2016-09-02 17:04:00 +10:00
Guo Xiang Tan
1a4a0d7e89 FIX: Don't fail silently. 2016-09-02 11:59:03 +08:00
Guo Xiang Tan
692ecff3eb Revert "FIX: Don't fail silently."
This reverts commit baa6af93a2.
2016-09-02 11:58:56 +08:00
Guo Xiang Tan
baa6af93a2 FIX: Don't fail silently. 2016-09-02 11:53:53 +08:00
Guo Xiang Tan
a869d861f4 FIX: Make Jobs::MigrateUploadScheme a scheduled job.
This reverts https://github.com/discourse/discourse/commit/9d8db11c

If the job fails during execution or if `SiteSetting.migrate_to_new_scheme`
has been set to `false`, the job will be considered as executed even
though the migration has not been completed. As a result, the job
will have to be executed manually which is not desirable.
2016-09-02 11:48:45 +08:00
Guo Xiang Tan
efd7cbd887 Remove limit default.
Having the limit makes it harder to migrate all `Upload`/`OptimizedImage`
since the count has to be figured out and passed to the method.
2016-09-02 10:55:11 +08:00
Sam
0a39ba43ed FIX: always respect avatar_force_update 2016-09-02 12:04:22 +10:00
Sam
211c374df6 Merge pull request #4213 from fantasticfears/sso
FIX: Importing user avatar when new user login by SSO
2016-09-01 18:05:18 -07:00
Sam
034dc52beb UX: adjust to show all and stat period 2016-09-02 11:03:52 +10:00
Neil Lalonde
1078d929cd Revert "see if gtm automatically pushes pageview events without our own page-tracking code" 2016-09-01 13:28:04 -04:00
Neil Lalonde
572713b801 see if gtm automatically pushes pageview events without our own page-tracking code 2016-09-01 12:16:54 -04:00
Arpit Jalan
929730c008 FIX: properly insert images in markdown inline format (take 2) 2016-09-01 17:56:39 +05:30
Arpit Jalan
54a1180140 FIX: properly insert images in markdown inline format 2016-09-01 11:55:40 +05:30
Sam
1d7df97c30 FIX: display old category style on mobile 2016-09-01 15:57:23 +10:00
Angus McLeod
18da378f9a only perform the check on mobile view 2016-08-31 10:23:56 -04:00
Angus McLeod
0b20c0b581 check the plugin mobile/list dir for templates 2016-08-31 10:12:16 -04:00
Guo Xiang Tan
90a0327fd2 FIX: Check against reserved usernames should be case insensitive. 2016-08-31 21:53:41 +08:00
Sam
282a4e1efb FIX: remove from preload store so it is not cached forever 2016-08-31 14:07:31 +10:00
Sam
55fad7b339 FIX: missing avatars from categories page when ajax loaded
UX: display last poster on categories page instead of OP
2016-08-31 14:02:30 +10:00
Rafael dos Santos Silva
8fc556f81a FIX: Avatars on new category page 2016-08-30 23:54:15 -03:00
Sam
591dab1bb5 FIX: on load categories list not showing create button 2016-08-31 09:35:23 +10:00
Jeff Atwood
329faae3e0 Merge pull request #4427 from xfalcox/patch-1
[WIP] Add text on last-visit line
2016-08-30 15:40:42 -07:00
Rafael dos Santos Silva
91840be2b9 Makes it variable topic height proof 2016-08-30 19:07:56 -03:00
Robin Ward
7da44e3bf0 FEATURE: Support author meta tags for embedding 2016-08-30 12:01:04 -04:00
Rafael dos Santos Silva
a307783644 attr fallback is not yet supported =( 2016-08-30 12:37:05 -03:00
Rafael dos Santos Silva
d73bbe8d8c Add i18n-able text to last visit line 2016-08-30 12:26:28 -03:00
Robin Ward
3d8e75c6ca FIX: Sometimes we hide the in_reply_to when a quote is present 2016-08-30 11:11:16 -04:00
Régis Hanol
8ef49a9458 add span around subcategories to allow for better styling 2016-08-30 10:27:09 +02:00
Régis Hanol
96513f3848 FIX: select a period when 2/3 of the categories matches the criteria 2016-08-29 23:50:48 +02:00
Régis Hanol
e064e6f7a3 FEATURE: new 'categories_and_latest' endpoint 2016-08-29 22:47:44 +02:00
Erick Guan
0217973374
FIX: Importing user avatar when new user login by SSO 2016-08-29 20:47:19 +08:00
Régis Hanol
6c8e6e9d2a UX: post count should be right aligned in /categories page 2016-08-29 10:52:22 +02:00
Régis Hanol
5833e96017 FIX: use 'topic_all_time' as topic count failover in /categories page 2016-08-29 10:25:46 +02:00
Sam
653f94975c FIX: don't fail if targetUsernames is not set 2016-08-29 12:39:25 +10:00
Sam
0303080586 we do not define auth providers for builtins 2016-08-29 11:12:24 +10:00
Sam
22b8c0d44e FIX: fullscreen login set from client needs to be respected 2016-08-29 10:13:51 +10:00
Neil Lalonde
2251104e32 FEATURE: avatar flair can be font awesome icons 2016-08-26 17:15:37 -04:00
safaalfulaij
75f6548710 Add Arabic Pluralization Rules for Client 2016-08-26 22:52:15 +03:00
Robin Ward
58cb43884d Merge pull request #4415 from vinkas0/tweak-49070
FIX: “Your search term is too short” message when no search term is entered at all
2016-08-26 14:02:42 -04:00
Vinoth Kannan
f373e3ac8d braces added for if condition 2016-08-26 22:38:34 +05:30
Robin Ward
20241a01e9 FIX: Run the regular expression against query parameters 2016-08-26 12:47:47 -04:00
Neil Lalonde
39de27a4b2 FIX: top period chooser layout on mobile 2016-08-26 12:39:09 -04:00
Sam
896732975e correct url linked in push notification 2016-08-26 13:45:56 +10:00
Sam
ca79c4b276 stop eating up push_urls 2016-08-26 13:23:06 +10:00
Sam
a37db9448f correctly return access rights in auth redirect 2016-08-26 13:12:38 +10:00
Sam
4fe52c8cbe FEATURE: backend support for pushing notifications to clients 2016-08-26 12:47:10 +10:00
Sam
2b15919aee missing spot where old api was used 2016-08-26 10:58:34 +10:00
Sam
eaf87f0770 FIX: correctly handle api key so it uses current user provider 2016-08-26 10:39:13 +10:00
Matt Palmer
394cd43d77 Scrub only after converting strings to UTF-8
Scrubbing an ASCII-8BIT string isn't ever going to remove anything, because
there's no code point that isn't valid 8-bit ASCII.  Since we'd really
prefer it if everything were UTF-8 anyway, we'll just assume, for now, that
whatever comes out of SimpleRSS is probably UTF-8, and just nuke anything
that isn't a valid UTF-8 codepoint.

Of course, the *real* bug here is that SimpleRSS [unilaterally converts
everything to
ASCII-8BIT](https://github.com/cardmagic/simple-rss/issues/15).  It's
presumably *far* too much to ask that it detects the encoding of the source
RSS feed and marks the parsed strings with the correct encoding...
2016-08-25 16:09:07 +10:00
Arpit Jalan
bfefda06f6 FIX: handle embed count when topic not found 2016-08-25 07:12:20 +05:30
Régis Hanol
7d600d9fee FIX: show topic entrance when clicking the # of replies in /categories 2016-08-24 22:25:10 +02:00
Régis Hanol
3e00672c7d FIX: clicking the timestamp next to a feature topics should link to the latest post 2016-08-24 22:07:25 +02:00
Régis Hanol
467564eb82 fix unread/new badge in /categories page 2016-08-24 22:04:30 +02:00
Régis Hanol
4fb47dd749 FIX: tag text was too big in /categories page 2016-08-24 21:50:52 +02:00
Neil Lalonde
50a8eb1810 Merge pull request #4405 from gdpelican/fix/intersection-pagination
FIX: Don't join on tags unnecessarily when matching all tags
2016-08-24 14:45:15 -04:00
Vinoth Kannan
fc95764f60 Update search-menu.js.es6 2016-08-24 15:25:51 +05:30
Robin Ward
2cb4cb7b72 FIX: Don't enqueue jobs in a transaction 2016-08-23 16:07:59 -04:00
Neil Lalonde
2f68be2c5c FEATURE: custom html and text can be added to summary emails 2016-08-23 16:06:02 -04:00
Robin Ward
c3a3aff120 FEATURE: Support for a whitelist for embeddable host paths 2016-08-23 14:56:12 -04:00
Robin Ward
1468616465 FIX: Support links with google analytics tracking and hashes 2016-08-23 12:13:31 -04:00
Guo Xiang Tan
17f0727b04 FIX: Don't track user profile view when viewed by system user. 2016-08-23 16:25:31 +08:00
Guo Xiang Tan
90571f0364 FIX: Format selection as multiline code only when selection spans multiple lines. 2016-08-23 15:00:16 +08:00
Sam
691f739f11 better error handling
push notifications imply read access, no need for a special permission
2016-08-23 16:48:00 +10:00
Guo Xiang Tan
e9927ce5b1 Make eslint happy. 2016-08-23 09:56:24 +08:00
Guo Xiang Tan
f32d8e2882 FIX: Code fences shortcut did not insert newlines before and after backticks. 2016-08-23 09:51:01 +08:00
Régis Hanol
2690ef7050 prefix setting with 'desktop_' since it's only used for desktop 2016-08-22 23:43:42 +02:00
Régis Hanol
d06e2793aa fix logic for when to include topics in category list 2016-08-22 23:11:08 +02:00
Régis Hanol
9573e28df9 remove unecessary console.logsss 2016-08-22 23:03:40 +02:00
Régis Hanol
4d6028ea2d UX: new 'category_page_style' site setting 2016-08-22 23:01:43 +02:00
Robin Ward
b6bcfc0426 FIX: Improper routing of https URLs 2016-08-22 16:45:11 -04:00
Arpit Jalan
b4e32f20f2 FIX: disable browser autocomplete for invite modal 2016-08-22 23:20:02 +05:30
Robin Ward
9f4ef6eeb6 Add a decorator for the footer links in the hamburger 2016-08-22 13:21:41 -04:00
Robin Ward
884bdf7240 FEATURE: Ability to scrub titles when importing embeddable content 2016-08-22 12:43:02 -04:00
Régis Hanol
ecaa751455 FIX: Use Ember.set to update the site settings via the Message Bus 2016-08-22 12:18:45 +02:00
Arpit Jalan
f6bd114b5e FEATURE: fall back to apple_touch_icon_url if default_opengraph_image_url is not present 2016-08-22 15:30:05 +05:30
Arpit Jalan
a39929d12e FEATURE: add opengraph and twitter meta tags on every page 2016-08-21 22:08:49 +05:30
Sam
0a1d7896bf Merge pull request #4407 from dtbaker/patch-1
Typo: Unmatched braces }}
2016-08-21 03:22:51 -07:00
Sam
1e9ca3c7c1 need to pass category on mobile as well 2016-08-21 20:21:07 +10:00
Sam
c51fec7fda FIX: improve last visited detection
- clear line detection cache on category change
- don't show last visited unless latest / descending
- improve perf of last visited detection algorithm
2016-08-21 17:06:00 +10:00
dtbaker
bbb1517d33 Typo: Unmatched braces }}
Just a little typo
2016-08-20 23:55:07 +10:00
Jeff Atwood
03ce370d5e right align category counts 2016-08-19 12:57:07 -07:00
Robin Ward
4061725a95 FIX: Don't ever grant badges when they're disabled 2016-08-19 15:16:37 -04:00
Arpit Jalan
a590f35982 FEATURE: allow changing post owners without creating post revision 2016-08-19 23:34:21 +05:30
Neil Lalonde
6356c0555c FIX: topic's best post shouldn't be deleted by the author 2016-08-19 13:19:08 -04:00
Neil Lalonde
a1363feec8 FIX: don't show post withdrawn by author in summary emails 2016-08-19 12:11:36 -04:00
Régis Hanol
4960365689 UX: unread/new topic counts under topic counts column in /categories 2016-08-19 18:10:42 +02:00
James Kiesel
386b8b8498 Don't join on tags unnecessarily when matching all tags 2016-08-19 10:37:32 -05:00
Sam
9b1e81cd6d Only display in discovery, correct double highlighting 2016-08-19 12:43:48 +10:00
Sam
11f9a463ac FEATURE: highlight last visited topic in topic list 2016-08-19 11:58:39 +10:00
Régis Hanol
eb953c0904 FIX: /categories page on mobile 2016-08-19 01:47:00 +02:00
Neil Lalonde
7195a103ab FEATURE: digests choose topics you're watching or tracking first 2016-08-18 17:16:52 -04:00
Neil Lalonde
a644602612 FIX: infinite scrolling of topic list when filtered to one tag 2016-08-18 16:36:30 -04:00
Régis Hanol
96b6d342cc FIX: /categories page issues
FIX: endless spinner when /categories is set to homepage and you click the home logo
FIX: latest column should respect topic state for the current user (new, unread, etc.)
FIX: post count should have heat colors applied based on like ratios
FIX: Add "More" button at the bottom of the latest column
UX: The topic count number in the categories panel should be slightly larger
2016-08-18 19:41:21 +02:00
Robin Ward
78e8aa823d UX: Just show "1m" if less than 1m 2016-08-18 12:47:00 -04:00
Neil Lalonde
fb7409f982 FIX: avatar flair position on mobile 2016-08-18 11:18:18 -04:00
Régis Hanol
dd3d8d85d3 FIX: proper logic for 'noTitle' param of the number helper 2016-08-17 23:28:29 +02:00
Régis Hanol
6d1d7b7c8f UX: new /categories layout 2016-08-17 23:23:16 +02:00
Neil Lalonde
36f0bd36f4 remove hard-coded avatar url 2016-08-17 16:57:31 -04:00
Neil Lalonde
2654060c14 sanitize flair style 2016-08-17 15:13:15 -04:00
Neil Lalonde
d079f69b7b FEATURE: add flair to avatars using new settings in the groups admin UI 2016-08-17 15:13:15 -04:00
Sam
79c1d3459b line was there twice 2016-08-17 17:03:48 +10:00
Sam
91b72936c4 Normalize away a requested push if for some reason we can not push there 2016-08-17 16:44:38 +10:00
Rafael dos Santos Silva
16f04d96d4 FIX: Tags on topic crawler view
- Remove tag object id
- Remove duplicate tag list
- Don't display tags when tagging is disabled
2016-08-17 01:28:31 -03:00
Sam
b4dfb84f37 PERF: stop doing work for HEAD requests on topics 2016-08-17 10:04:23 +10:00
Sam
a25a8115e8 FEATURE: support HEAD request to /user-api-key/new
This allows us to cleanly sniff to find if it exists
2016-08-17 09:58:19 +10:00
Neil Lalonde
d29ccb5e48 FIX: navigating from tags intersection route to singular tag route 2016-08-16 14:06:38 -04:00
Neil Lalonde
d835326406 FIX: rendering of tags intersection when show_filter_by_tag is off 2016-08-16 14:02:03 -04:00
Robin Ward
53894daae9 FIX: Timeline should not be clickable when hidden 2016-08-16 12:15:10 -04:00
Sam
416e7e0d1e FEATURE: basic UI to view user api keys 2016-08-16 17:06:52 +10:00
Sam
b7cea24d76 FEATURE: more user API flow, support key creation 2016-08-16 17:06:52 +10:00
Sam
0b334cdf74 FIX: stop removing query params from destination url in sso 2016-08-16 17:06:52 +10:00
Neil Lalonde
37b68f10ae FIX: hide admin controls on tags intersection page 2016-08-15 16:46:16 -04:00
Neil Lalonde
3b792054f2 Merge pull request #4387 from gdpelican/feature/tags-intersection
FEATURE: Tags intersection page
2016-08-15 16:24:29 -04:00
Neil Lalonde
5849c345cc FEATURE: digest emails will try to choose topics from your tracked and watched categories first 2016-08-15 16:16:04 -04:00
James Kiesel
98d300e79c Fix linting error 2016-08-15 15:45:23 -04:00
James Kiesel
5dd9009718 Clean up additionalTags impl 2016-08-15 15:38:23 -04:00
James Kiesel
037e9bb7b8 Support any number of tag intersections 2016-08-15 15:30:17 -04:00
Robin Ward
f60bfe7550 Merge pull request #4389 from gschlager/i18n-patch1
UX: Allow translation of composer icons
2016-08-15 13:38:25 -04:00
Robin Ward
19959c6092 Remove unneccessary return 2016-08-15 12:58:16 -04:00
Gerhard Schlager
1042f1a923
UX: Allow translation of composer icons 2016-08-15 18:57:05 +02:00
Robin Ward
4d8584f427 FIX: Support div dir= in sanitizer 2016-08-15 11:19:10 -04:00
Arpit Jalan
a2220feaea FEATURE: new site setting rebake_old_posts_count 2016-08-15 16:34:13 +05:30
Sam
fc095acaaa Feature: User API key support (server side implementation)
- Supports throttled read and write
- No support for push yet, but data is captured about intent
2016-08-15 17:59:36 +10:00
Sam
d3c8985030 missing annotation 2016-08-15 17:59:36 +10:00
James Kiesel
d3792c0149 Fix linting errors 2016-08-12 16:03:52 -04:00
James Kiesel
e14f3c802b Cleanup 2016-08-12 15:56:56 -04:00
James Kiesel
3471499613 Tighten up tags intersection page 2016-08-12 15:51:09 -04:00
Robin Ward
aef954784a FIX: nofollow was being added during post processing when it shouldn't 2016-08-12 15:35:13 -04:00
James Kiesel
7e73b933c7 First pass 2016-08-12 15:28:46 -04:00
Robin Ward
86c970bac0 FIX: Read FAQ wasn't working with a URL on the same site 2016-08-12 13:47:19 -04:00
Robin Ward
705ab88173 Add a widget setting for the user's avatar size 2016-08-12 11:09:36 -04:00
Régis Hanol
7db2083d45 FIX: 'cancel_scheduled_job' was deleting all jobs in multisite 2016-08-12 13:10:52 +02:00
Sam
7e4503dd99 FEATURE: basic info route for all sites, even ones that require login
This information is public in meta tags already on home page, providing a
route allows consumers to check it way more cheaply
2016-08-12 17:10:35 +10:00
Sam
afaba56de3 FEATURE: missing API endpoint for topic tracking states 2016-08-12 17:10:35 +10:00
Robin Ward
8f19f60588 FIX: Broken acceptance test 2016-08-11 15:03:23 -04:00
Robin Ward
6507246e97 UX: Full page search results weren't linked to users 2016-08-11 14:27:19 -04:00
Robin Ward
cd371fa20e FIX: When faq_url is custom, track the FAQ clicks 2016-08-11 13:43:42 -04:00
Jeff Atwood
d065d4186a very minor CSS tweak to badge h3 2016-08-11 10:00:01 -07:00
Robin Ward
58834663a8 Merge pull request #4383 from cpradio/fix-topic-status-shortcuts
FIX: Permit Timeline Topic Status to receive dispatch events to handle keyboard shortcuts when the topic footer is not loaded
2016-08-11 11:42:53 -04:00
Sam Saffron
58322617ec UX: on mobile devices iOS or Android always use full screen login
This simplifies life for users and embedded browsers and works around
all popup blocking.

There is no point to popup tabs on Android or iOS, it just causes
confusion.
2016-08-11 23:15:45 +10:00
cpradio
46fa70d948 FIX: Permit Timeline Topic Status to receive dispatch events to handle keyboard shortcuts when the topic footer is not loaded 2016-08-11 08:30:37 -04:00
Guo Xiang Tan
8dab20e5b8 SECURITY: Escape image title in lightbox. 2016-08-11 11:15:00 +08:00
Guo Xiang Tan
01d79d9129 Merge pull request #4382 from SafaAlfulaij/fix_plural_strings
Fix Plural Strings That are Not Marked as Plural
2016-08-11 09:18:37 +08:00
Robin Ward
748a9e008f FIX: Missing post_number in searching within a topic 2016-08-10 17:54:30 -04:00
safaalfulaij
291c32aa69 Fix Plural Strings 2016-08-10 20:24:28 +03:00
Régis Hanol
e55e2aff94 FIX: FirstReplyByEmail badge wasn't granted
DEPRECATED: PostProcess badge trigger
2016-08-10 19:24:01 +02:00
Robin Ward
24201d4638 Merge pull request #4379 from caugner/disable-pasting-hack-for-firefox-50
FIX: Disable pasting hack for Firefox 50+
2016-08-10 10:38:48 -04:00
Arpit Jalan
d65f7742a7 FEATURE: better google docs onebox 2016-08-10 19:01:18 +05:30
Claas Augner
ac87a86975
FIX: Disable pasting hack for Firefox 50+ 2016-08-10 01:24:15 +02:00
Robin Ward
8321bdab4e FIX: If you go to full page search, stop loading 2016-08-09 16:11:14 -04:00
Robin Ward
db3ae803c5 UX: Let the user know the search is too short in the header menu 2016-08-09 16:05:58 -04:00
Robin Ward
fd3a8583dd UX: Display a message when the search term is too short on full page 2016-08-09 15:11:58 -04:00
Robin Ward
28436a604a FIX: Prevent tricking the search from ignoring minimum lengths 2016-08-09 14:49:46 -04:00
Robin Ward
c1125c8649 PERF: Use simpler serializer for search, eager load post users 2016-08-09 14:49:46 -04:00
Robin Ward
b2134aa173 Refactor full page search for style, remove lookups 2016-08-09 14:49:46 -04:00
Robin Ward
d8808aa9ab Add back acceptance tests for full page search 2016-08-09 14:49:46 -04:00
Sam
73b6a22f61 UX: link to PM list from pm suggested topics 2016-08-09 10:12:56 +10:00
Robin Ward
5191cbdcbb Merge pull request #4370 from cpradio/keyboard-enhancements
FEATURE: Allow keyboard shortcuts for topic list to start from last viewed topic
2016-08-08 16:52:10 -04:00
Régis Hanol
51322a46b3 FEATURE: retry processing incoming emails on rate limit 2016-08-08 22:28:27 +02:00
cpradio
754e3b2287 Convert boolean to opts object 2016-08-08 15:15:27 -04:00
Neil Lalonde
17b51bb465 FIX: topics tagged with muted tags should not be included in digest emails 2016-08-08 15:14:25 -04:00
Robin Ward
fb1b119462 Merge pull request #4342 from acshi/embeddedhost-localhost
Allow localhost as an embeddable host
2016-08-08 14:31:58 -04:00
Robin Ward
8b252f19d7 Merge pull request #4365 from gdpelican/fix/daily-mlm-notifications
Don't halt notification emails for those on daily mailing list mode
2016-08-08 14:30:56 -04:00
Robin Ward
01ced67ab3 FIX: Focus on usernames if it's blank when composing a message 2016-08-08 13:57:23 -04:00
Guo Xiang Tan
a9ae99bf82 FIX: Admin dashboard problems not displaying when there is one error. 2016-08-09 00:33:37 +08:00
Robin Ward
3db020f95e FIX: Display anonymous counts nicely on badges 2016-08-08 12:24:30 -04:00
Guo Xiang Tan
72b321b7b4 Revert "UX: Centering Badge notification styles on mobile."
This reverts commit fce902ab1e.
2016-08-08 09:02:46 +08:00
Guo Xiang Tan
fce902ab1e UX: Centering Badge notification styles on mobile. 2016-08-08 07:24:09 +08:00
cpradio
d8165d7cee FEATURE: Allow keyboard shortcuts for topic list to start from last viewed topic 2016-08-06 11:24:44 -04:00
Robin Ward
3d62e5dd98 SECURITY: XSS issue on Admin users list 2016-08-05 12:01:16 -04:00
Robin Ward
429f27ec96 SECURITY: Avoid mass assignment on user create 2016-08-05 11:57:13 -04:00
Arpit Jalan
cda108da56 use existing method for target_group_names 2016-08-05 18:57:46 +05:30
Arpit Jalan
c064e946b2 FIX: custom reason for flags were not showing for non-english locales 2016-08-05 18:41:11 +05:30
Régis Hanol
d0962d6e5a FIX: serve category images from the CDN 2016-08-05 13:03:49 +02:00
Guo Xiang Tan
33e7df977d FIX: Row resize zone should be full width of composer. 2016-08-05 10:02:01 +08:00
Sam
9b011cb75d UX: increase mobile line height for readability 2016-08-05 09:22:54 +10:00
Robin Ward
e5b529f8e1 FIX: Couldn't move posts with deleted replies 2016-08-04 11:56:01 -04:00
Guo Xiang Tan
2332422a85 UX: Text wasn't centered properly in badge notification. 2016-08-04 10:51:11 +08:00
Guo Xiang Tan
66f14ab0b8 Draw grippie with CSS. 2016-08-04 10:24:14 +08:00
Guo Xiang Tan
927bf19d93 UX: Disable dismiss notifications button when there is nothing to dismiss. 2016-08-04 09:48:10 +08:00
Robin Ward
331135a88e Deuglify the admin dashboard loading state. Also clean up the code 2016-08-03 15:36:41 -04:00
Robin Ward
19fa24d888 Add a warning if a user tries to PM themselves 2016-08-03 13:58:24 -04:00
Neil Lalonde
5f67cd7b45 FIX: tag input detects when a tag is not allowed and won't offer to create it anyway 2016-08-03 13:18:56 -04:00
James Kiesel
c2819e99f4 Don't halt notification emails for those on daily mailing list mode 2016-08-03 12:29:38 -04:00
Régis Hanol
e92f5e4fbf FEATURE: new email attachment blacklists site settings 2016-08-03 17:55:54 +02:00
Régis Hanol
cb809784df refactor version-check to ES6 2016-08-03 16:13:02 +02:00
Régis Hanol
35c13bca6c Merge pull request #4363 from cpradio/version-link-shows-compare
FEATURE: Installed Version link shows GitHub Compare to branch being followed
2016-08-03 16:03:57 +02:00
Régis Hanol
a21d52951a don't use startsWith just yet 2016-08-03 14:31:52 +02:00
Robin Ward
1ae625ec2e FIX: Archetype class wasn't being applied on refresh 2016-08-02 15:26:07 -04:00
Robin Ward
2d7b036b9a UX: Display nicer looking numbers for unread in categories 2016-08-02 15:16:07 -04:00
Neil Lalonde
37162e476b FIX: remove gtm_ua_domain_name setting because it's preferable to configure it in Google Tag Manager settings 2016-08-02 14:54:35 -04:00
Robin Ward
857d54162b Redirect to Summary when viewing yourself 2016-08-02 13:21:24 -04:00
Neil Lalonde
d38727efb7 FIX: Google Universal Analytics was tracking two page views on first page view 2016-08-02 12:55:02 -04:00
Robin Ward
7a6cd15c4a FIX: Disable events on hidden timeline buttons 2016-08-02 11:34:27 -04:00
Robin Ward
f4c8070d09 FIX: Couldn't update category notification level 2016-08-02 11:22:02 -04:00
cpradio
1b89c2f0ef FEATURE: Installed Version link shows GitHub Compare to branch being followed 2016-08-02 06:18:44 -04:00
Guo Xiang Tan
dc2dae2cc4 FIX: Logs notice was not displaying the right Date. 2016-08-02 12:40:28 +08:00
Guo Xiang Tan
bf683178a8 FIX: Remove tag plugin code from tag hashtag check. 2016-08-02 10:59:12 +08:00
Jeff Atwood
138e2071c5 slightly increase mobile post body font size 2016-08-01 16:23:41 -07:00
Régis Hanol
681f566a66 FIX: staff members should be able to see raw email of deleted posts 2016-08-01 23:55:22 +02:00
Régis Hanol
829143bf88 FIX: 'List-Unsubscribe' header wasn't added to emails sent when mailing_list_mode was enabled 2016-08-01 20:19:00 +02:00
Régis Hanol
c591429868 FIX: don't destroy uploads in queued posts and drafts 2016-08-01 18:35:57 +02:00
Régis Hanol
0fa458c5a7 Merge pull request #4356 from acshi/datapayloadarchetype
data.archetype should be data.payload.archetype in topic_tracking_state.js.es6
2016-08-01 14:10:51 +02:00
Sam
9018de39ed FEATURE: allow shipping bio markdown via SSO
- Also adds site setting for sso_overrides_bio to disable bio editing by end users
2016-08-01 15:29:28 +10:00
Rafael dos Santos Silva
5d91355c97 FIX upload hints 2016-07-30 15:39:11 -03:00
Robin Ward
9cb8d5d19e FIX: Whitelist the big tag 2016-07-29 16:11:18 -04:00
Acshi Haggenmiller
26e8eed83b changed data.archetype typo to data.payload.archetype in topic_tracking_state.js.es6 2016-07-29 11:23:00 -04:00
Neil Lalonde
1f12e41029 FIX: query for tag with no sub-categories 2016-07-28 16:59:00 -04:00
Neil Lalonde
82e170d6a6 FIX: 404 when filtering by category, no sub-category, and a tag 2016-07-28 16:19:03 -04:00
Robin Ward
efc6408b1d FIX: Regression with escaping on badge page 2016-07-28 15:57:06 -04:00
Robin Ward
2891f230d1 SECURITY: Make sure uploaded_urls have corresponding upload records 2016-07-28 13:54:17 -04:00