Commit Graph

13734 Commits

Author SHA1 Message Date
Robin Ward
cd4f0393a8 Add a title tag to the search results page 2017-04-26 15:02:07 -04:00
Robin Ward
bf9c4a7828 FEATURE: secure_email site setting to prevent data going out in email 2017-04-26 13:05:56 -04:00
Guo Xiang Tan
fe0a7d97ca Fix incorrect class name. 2017-04-26 18:12:51 +08:00
Guo Xiang Tan
b00886f5c1 Remove sidekiq-statistic gem.
* We don't really use it and there is an on-going issue
  with the gem not expiring keys in a Redis list which
  hasn't been fully resolved.

  https://github.com/davydovanton/sidekiq-statistic/issues/73
2017-04-26 14:54:47 +08:00
Guo Xiang Tan
daa97c40ce FIX: Clean up unused staged users job not completing. 2017-04-26 10:51:36 +08:00
Guo Xiang Tan
1f6418f907 Track error message in SchedulerStats. 2017-04-26 01:34:25 +08:00
Arpit Jalan
aeead60036 FIX: make TopicEmbed trashable 2017-04-25 18:40:39 +05:30
Régis Hanol
64787e7fa4 Merge pull request #4831 from gdpelican/image-gallery
FEATURE: Use image gallery functionality in magnific
2017-04-25 09:39:10 +02:00
James Kiesel
48c0f3faf3 Use image gallery feature of magnific
commit cc7061e9458d04dd02aad9c02ba3a89306e0fae7
Author: James Kiesel <james.kiesel@gmail.com>
Date:   Tue Apr 25 11:21:08 2017 +0900

    ;

commit 9233be7e432daff605812e6b49042f69d348b6e7
Author: James Kiesel <james.kiesel@gmail.com>
Date:   Tue Apr 25 10:01:26 2017 +0900

    Don't break if $elem is undefined

commit 598a694c070c86df8d9f5ffa1ed84e2f8756e65f
Author: James Kiesel <james.kiesel@gmail.com>
Date:   Tue Apr 25 04:51:14 2017 +0900

    .

commit 1711685a33ccd236011f54d3e652991728530b3a
Author: James Kiesel <james.kiesel@gmail.com>
Date:   Tue Apr 25 04:34:11 2017 +0900

    ;

commit 81703f36c0593250aeac3418fde86660fd307092
Author: James Kiesel <james.kiesel@gmail.com>
Date:   Tue Apr 25 04:12:37 2017 +0900

    Use image gallery functionality in magnific
2017-04-25 11:23:15 +09:00
Guo Xiang Tan
6f7c6b0fd0 FIX: Incorrect error raised. 2017-04-25 09:59:01 +08:00
cpradio
d69122c385 UX: Change banner close button to be floated to the right 2017-04-24 20:51:02 -04:00
Régis Hanol
0d66529d2b PostReply doesn't have a primary key, so no luck here 2017-04-24 23:14:01 +02:00
Régis Hanol
1787c45b38 PERF: don't load all replies in memory when moving posts 2017-04-24 23:00:32 +02:00
Régis Hanol
8fe0bbb238 REFACTOR: improve Notification.ensure_consistency SQL query readability 2017-04-24 23:00:27 +02:00
Régis Hanol
301dd139ae PERF: faster Group.refresh_automatic_group & Group.ensure_consistency 2017-04-24 23:00:21 +02:00
Régis Hanol
3d406b047c PERF: much faster Badge.ensure_consistency 2017-04-24 22:59:49 +02:00
Robin Ward
f41ab98e86 FIX: Scrolling to the bottom was still a bit weird with no suggested 2017-04-24 16:36:43 -04:00
Robin Ward
62966b1023 FIX: Remove duplicate route warning, it's just a noop now 2017-04-24 13:36:05 -04:00
Robin Ward
4e1f8ec72b FIX: Without suggested topics jumping to a post had the wrong offset 2017-04-24 13:21:50 -04:00
Guo Xiang Tan
423f2ab228 FIX: Processing incoming email should be done in a background job. 2017-04-24 13:57:28 +08:00
Arpit Jalan
1f5089e474 FIX: handle invite error in wizard 2017-04-21 20:07:04 +05:30
cpradio
20c2c66dd4 FEATURE: Add normal as a preference for topic subscription state when replying to a topic 2017-04-20 22:33:10 -04:00
Rafael dos Santos Silva
e922623da8 FIX: User Admin screen on mobile style was off 2017-04-20 23:18:01 -03:00
Guo Xiang Tan
8b2e3bf5f1 FIX: Topic title should be included in post webhook payload. 2017-04-21 10:04:21 +08:00
Sam
aec73d4003 correct the spec again 2017-04-20 17:41:35 -04:00
Sam
a9b953ac5a FIX: on create you could not add a theme component 2017-04-20 17:37:13 -04:00
Sam
dcf9459b7c staff should track 2017-04-20 17:32:05 -04:00
Sam
5365973c0a FIX: detection of error changed, so you can clear errors 2017-04-20 16:55:18 -04:00
Neil Lalonde
703e6faf54 Revert "remove important from extra-info-wrapper color" 2017-04-20 16:27:10 -04:00
jomaxro
b3eef0513f Remove console logging 2017-04-20 16:08:16 -04:00
Sam
7a9eee1b71 FEATURE: default notification level for group messages
also fixes it so staff can amend other user's group notification level
2017-04-20 15:47:35 -04:00
Neil Lalonde
05efa7ce68 simplify last_notified_id 2017-04-20 15:26:28 -04:00
Arpit Jalan
5d9d2cf287 FIX: do not explicitly show email of flagger / flagged user 2017-04-20 22:09:30 +05:30
Sam
dfe3c162cc move stylesheet after js 2017-04-20 12:34:50 -04:00
Neil Lalonde
3d32158893 remove important from extra-info-wrapper color 2017-04-20 11:53:41 -04:00
Sam
81c08fe451 missing badge count in dark theme 2017-04-20 11:52:06 -04:00
Sam
bbed29ba57 correct font preloading 2017-04-20 11:18:37 -04:00
Sam
8628a57f4e FIX: colors picker not working with CDN 2017-04-20 11:04:23 -04:00
Guo Xiang Tan
94c7be3ca6 Merge pull request #4824 from tgxworld/fix_optimize_image_timeout
Fix optimize image timeout
2017-04-20 15:53:43 +08:00
Arpit Jalan
ea26c56631 FIX: redirect to login page for anonymous user when profiles are hidden 2017-04-20 13:00:45 +05:30
Guo Xiang Tan
2af1b9e93c Add time out when optimizing images. 2017-04-20 15:21:43 +08:00
Guo Xiang Tan
5c39c8f24b UX: Improve the way users set timers for TopicStatusUpdate. 2017-04-20 14:25:45 +08:00
Sam
7eabb90b71 FEATURE: added error messages for bad theme CSS / JS 2017-04-19 16:46:46 -04:00
Neil Lalonde
3835e16cf7 FIX: New implementation of the "notify about flag after" setting. Only notify about new flags since the last notification. Send a private message to staff. Mention the 3 most active moderators in the message so they get notification emails. 2017-04-19 16:17:45 -04:00
Sam
0930db221f FIX: destroying color scheme could remove wrong item from UI 2017-04-19 15:31:21 -04:00
Sam
c5ee448713 FEATURE: Only show overridden option for theme css
also fixes bad styling of mobile glyph
2017-04-19 15:24:00 -04:00
Sam
c76d780675 FEATURE: show a paintbrush for color schemes 2017-04-19 11:06:21 -04:00
clapmyhands
5d28a1ac0d UX: Make abondon post confirmation button red. 2017-04-19 21:54:58 +08:00
Arpit Jalan
5fa5c18a48 use notification_levels methods for specifying normal notification level 2017-04-19 16:17:24 +05:30
cpradio
2dccaff25d FIX: Correct behavior of auto-notification state updating to exclude when the topic already has a state of normal/muted 2017-04-19 06:29:35 -04:00
Rafael dos Santos Silva
d9ba168420 FIX: Show solved status on category with featured topics view too 2017-04-19 00:54:13 -03:00
Rafael dos Santos Silva
8d3ebfd2ac FIX: Show topic status on category view 2017-04-19 00:41:07 -03:00
Neil Lalonde
e7b0ce1334 FIX: add white space in discourse-tags so tags can wrap 2017-04-18 17:09:46 -04:00
Sam
0a67d859d5 correct watcher so it handles color scheme changes correctly 2017-04-18 16:48:15 -04:00
Sam
bbeb69ddc9 FIX: sort theme by lower case theme name 2017-04-18 15:43:38 -04:00
Sam
8ffb918824 FIX: add more consistent gutter to ace editor
old css hack had issues when line number was higher than 10
2017-04-18 15:43:22 -04:00
Sam
8ee2a500bc FEATURE: add hamburger extensibility 2017-04-18 15:18:03 -04:00
Robin Ward
8b8ee2ad61 Pass a context in when using a HTML builder 2017-04-18 12:35:35 -04:00
Sam Saffron
a19c02f0d3 FEATURE: allow copying of color schemes to clipboard 2017-04-18 09:37:55 -04:00
Arpit Jalan
1c23aedccf FIX: always send password reset email when accepting invite if password is not set 2017-04-18 14:37:06 +05:30
Guo Xiang Tan
60f1169077 REFACTOR: Reduce repetition in code. 2017-04-18 17:03:49 +08:00
Guo Xiang Tan
03762e2828 Merge pull request #4818 from OsamaSayegh/ui/groups-heading-admin-page
The "Groups" section's heading on user admin page was visible to mods
2017-04-18 16:12:33 +08:00
Arpit Jalan
8dea70d354 Revert "FIX: User website allows new TLDs" 2017-04-18 13:18:51 +05:30
Rafael dos Santos Silva
4289dbe3e5 FIX: User website allows new TLDs 2017-04-18 00:30:37 -03:00
Robin Ward
1363988cd7 Support for an HTML builder that can create dynamic HTML 2017-04-17 17:32:55 -04:00
Sam
3ccd5eacb4 prefer multiline \A \z 2017-04-17 16:57:37 -04:00
Sam
86904e9cd6 FIX: better error handling for theme import 2017-04-17 16:55:53 -04:00
Sam
5e3a0846f7 FEATURE: allow themes to share color schemes 2017-04-17 15:56:24 -04:00
osamasayegh
3e048d686e The "Groups" section's heading on user admin page was visible to mods
Since moderators can't manage a user groups, they shouldn't see the Groups heading on the user admin page.

## Before:

![before](https://cloud.githubusercontent.com/assets/17474474/25099135/c0e1d5a4-23b3-11e7-95d1-8036bff057d4.png)


## After:

![after](https://cloud.githubusercontent.com/assets/17474474/25099130/c060a538-23b3-11e7-8428-602fc523e9e8.png)
2017-04-17 21:53:30 +03:00
jomaxro
7b708e5cf2 Disable browser auto-complete for messages 2017-04-17 14:24:09 -04:00
Sam
b43d2e42f4 missing spots 2017-04-17 12:30:20 -04:00
Sam
81ebe853d1 missed a few spots 2017-04-17 12:05:23 -04:00
Sam
5dd752877e FEATURE: try adding some preload hints for chrome 2017-04-17 11:52:43 -04:00
jloh
5f47603b07
FIX: increase host_must_be_valid regex for .technology TLD
.technology is 11 chars long and wasn't being matched previously
2017-04-15 21:06:51 +10:00
Arpit Jalan
0954367bf4 FIX: send activation email when accepting invite if password is set 2017-04-15 14:59:50 +05:30
Guo Xiang Tan
04016f0dec Support Ruby 2.4. 2017-04-15 12:29:00 +08:00
cpradio
4dc4c5bebc FIX: Update auto_notification to also update the subscription state when replying if the current state is less than the state being requested 2017-04-14 15:44:42 -04:00
Sam
ed2e62f845 correct environment handling for test mode 2017-04-14 14:00:46 -04:00
Sam
873a07a625 trigger a stylesheed update 2017-04-14 13:36:49 -04:00
Sam
def7348777 FIX: display custom sections with default theme
also cleans up mechanism for previewing themes, cleans up naming,
gets rid of old janky "preview_style", secures local theme key
2017-04-14 13:35:12 -04:00
Arpit Jalan
fe29fe71c5 FIX: embedding comments was broken 2017-04-14 08:14:22 +05:30
Sam
809fbb25ce FIX: blanking theme field was not properly removing it 2017-04-13 17:24:15 -04:00
Sam
9927489f4e FEATURE: auto focus text editor when editing themes 2017-04-13 16:21:46 -04:00
Sam
43e4fc03ef FIX: clicking on themes while editing left a blank screen 2017-04-13 15:49:46 -04:00
Sam
3f4f0b32a9 FIX: path wizard showing with no style 2017-04-13 15:22:39 -04:00
Sam
37d4dd4a4b use scss mode instead of css mode 2017-04-13 12:05:27 -04:00
Sam
ee950b419f correct transitioning to theme CSS editing 2017-04-13 11:09:31 -04:00
Sam
679b6548e6 FIX: order child themes by name 2017-04-13 10:51:44 -04:00
Sam
e61be7af13 FIX: improve dark theme styling in header for tags 2017-04-13 10:39:36 -04:00
Arpit Jalan
ef093b1610 Merge pull request #4807 from techAPJ/email-token-social
FIX: confirm email token for user created via social login
2017-04-13 16:18:15 +05:30
Guo Xiang Tan
3d76fb9c2c FIX: Don't show category options for reports that can't be scoped to a category. 2017-04-13 17:10:55 +08:00
Arpit Jalan
7fb17b83c4 FIX: confirm email token for user created via social login 2017-04-13 14:15:32 +05:30
Guo Xiang Tan
bda20cc44a FIX: Don't enqueue topic status update job if topic is deleted. 2017-04-13 12:02:35 +08:00
Guo Xiang Tan
ee449b0dd5 Improve SSO verbose log when user record is invalid. 2017-04-13 11:39:26 +08:00
Guo Xiang Tan
72c16967e6 FIX: Check for reserved usernames before hitting DB. 2017-04-13 11:32:20 +08:00
Guo Xiang Tan
57788200ec REFACTOR: Add User.reserved_username?. 2017-04-13 10:44:26 +08:00
Neil Lalonde
07d596ea05 FIX: handle expanding quotes from deleted posts by rendering a trash icon 2017-04-12 16:48:47 -04:00
Neil Lalonde
2916b45666 multiplier should not have been changed 2017-04-12 14:48:30 -04:00
Neil Lalonde
d34dd4ed4f FIX: pasting link into composer with a topic template will onebox the link after the template 2017-04-12 14:48:30 -04:00
Neil Lalonde
8395569b05 FIX: Topic.similar_to error when Search is not loaded 2017-04-12 14:48:30 -04:00
Sam
d0fa8cda76 correct issue where no selected theme would force incorrect selection 2017-04-12 13:00:25 -04:00
Sam
7f2a80bbc8 correct theme selector expiry selection 2017-04-12 11:59:47 -04:00
Sam
a7ed8a0310 correct theme importer to support embedded.scss 2017-04-12 11:30:16 -04:00
Sam
a3e8c3cd7b FEATURE: Native theme support
This feature introduces the concept of themes. Themes are an evolution
of site customizations.

Themes introduce two very big conceptual changes:

- A theme may include other "child themes", children can include grand
children and so on.

- A theme may specify a color scheme

The change does away with the idea of "enabled" color schemes.

It also adds a bunch of big niceties like

- You can source a theme from a git repo

- History for themes is much improved

- You can only have a single enabled theme. Themes can be selected by
    users, if you opt for it.

On a technical level this change comes with a whole bunch of goodies

- All CSS is now compiled using a custom pipeline that uses libsass
    see /lib/stylesheet

- There is a single pipeline for css compilation (in the past we used
    one for customizations and another one for the rest of the app

- The stylesheet pipeline is now divorced of sprockets, there is no
   reliance on sprockets for CSS bundling

- CSS is generated with source maps everywhere (including themes) this
    makes debugging much easier

- Our "live reloader" is smarter and avoid a flash of unstyled content
   we run a file watcher in "puma" in dev so you no longer need to run
   rake autospec to watch for CSS changes
2017-04-12 10:53:49 -04:00
Dean Taylor
1a9afa976d FEATURE: Add AWS S3 EU (London) "eu-west-2" region 2017-04-12 10:38:17 -04:00
Arpit Jalan
30a8c5cca2 FIX: render emoji in topic title 2017-04-12 10:38:17 -04:00
Guo Xiang Tan
5cb64810cd FIX: Changing notification level in topic footer buttons was not updating timeline. 2017-04-12 14:54:03 +08:00
Guo Xiang Tan
7cb389a235 Add DiscourseEvent trigger when user's topic notification level changes. 2017-04-12 11:56:50 +08:00
Guo Xiang Tan
66a7b0c30b FIX: Add web hook DiscourseEvents in initializer. 2017-04-12 11:55:49 +08:00
Neil Lalonde
e5a50a3c98 FIX: rtl locale support for category box style 2017-04-11 15:04:27 -04:00
Arpit Jalan
82dfe4c5d5 FIX: disable browser autocomplete for change-owner modal 2017-04-11 20:43:30 +05:30
Arpit Jalan
8fb41bf5fb FIX: update timestamp when resending invite 2017-04-11 20:02:32 +05:30
Guo Xiang Tan
73180c8a19 FIX: Private message can be set to publish in the future. 2017-04-11 20:44:25 +08:00
Guo Xiang Tan
aadf4805a5 FIX: Topic status update not being deleted once it has been executed. 2017-04-11 10:32:13 +08:00
Régis Hanol
db77640634 FIX: grant first reply by email job was *brokenated* 2017-04-10 22:11:29 +02:00
Régis Hanol
f0778c50bf UX: add href to badge title 2017-04-10 21:39:19 +02:00
Arpit Jalan
b3761653b3 FIX: render emoji in title tag on topic page 2017-04-11 00:25:22 +05:30
Arpit Jalan
028eb8c05a FIX: render emoji in topic title 2017-04-10 23:36:30 +05:30
Neil Lalonde
3957540dd1 FIX: convert emoji to unicode in topic titles in emails 2017-04-10 13:15:25 -04:00
Sam Saffron
0013a23dc1 SECURITY: prefer render plain/html to render text where possible 2017-04-10 08:01:42 -04:00
Arpit Jalan
e7c2f5fd96 UX: show check mark glyph on 'Dismiss New' button on mobile 2017-04-08 10:13:32 +05:30
Robin Ward
40cee37bcc FIX: Don't insert topic status messages unless the status changes 2017-04-07 17:10:43 -04:00
Robin Ward
28c59d754b FIX: Don't update cooked when a like is received. 2017-04-07 15:18:38 -04:00
Robin Ward
616e1dcd16 FIX: Topic Timeline was impossible to close if you used the back button 2017-04-07 14:37:05 -04:00
Robin Ward
397e850fba FIX: Allow replaceState to run on iOS.
Removes a test for unsupported versions.
2017-04-07 11:30:24 -04:00
Guo Xiang Tan
9663a74445 FIX: Ensure username param is valid in NotificationsController. 2017-04-07 17:32:52 +08:00
Guo Xiang Tan
fad04aad6c Missing association. 2017-04-07 17:05:58 +08:00
Régis Hanol
93556bb950 Merge pull request #4793 from rcgordon/smtp-fast-rejection
Added an API to ask if an incoming email should be dropped at the SMTP level.
2017-04-07 09:59:52 +02:00
Guo Xiang Tan
ae1d6e7421 Fix incorrect method usage. 2017-04-07 15:52:08 +08:00
Guo Xiang Tan
71501feaf3 Improve validation for TopicStatusUpdate. 2017-04-07 15:32:00 +08:00
Guo Xiang Tan
cd59db5aa3 UX: Allow topic to be published to the same category when unlisted. 2017-04-07 15:32:00 +08:00
Guo Xiang Tan
690d2f4bd3 UX: Publish topic changes when topic is published. 2017-04-07 15:32:00 +08:00
Guo Xiang Tan
48a9860f07 FIX: Publish topic to a category should unlist it as well. 2017-04-07 13:58:52 +08:00
Neil Lalonde
708f65f740 FIX: web crawlers getting 404 on category pages 2017-04-06 14:52:06 -04:00
Ryan C. Gordon
888d1512ec Corrected indentation. 2017-04-06 01:49:34 -04:00
Guo Xiang Tan
8e794070d2 Fix incorrect method name. 2017-04-06 13:45:59 +08:00
Guo Xiang Tan
9bc6a60503 Merge pull request #4765 from ElTipejoLoco/show_tracked_topics_link
FEATURE: Add "Show tracked topics" to User Prefs
2017-04-06 12:34:10 +08:00
Guo Xiang Tan
0d67b507dc Merge pull request #4788 from davidtaylorhq/user_seen_event
Add a user_seen DiscourseEvent for plugins to hook into
2017-04-06 12:32:16 +08:00
Guo Xiang Tan
e0e06c2992 Merge pull request #4794 from tgxworld/nuke_old_auto_close_jobs
FIX: Add onceoff job to remove old auto close topic sidekiq jobs.
2017-04-06 12:29:42 +08:00
Arpit Jalan
f960505359 FIX: translate badge metadata title 2017-04-06 09:57:52 +05:30
David Rodríguez
934bff43d9 FIX: Copy post actions when moving a topic. 2017-04-06 12:16:22 +08:00
Aashaka Shah
402eaaa773 FEATURE: add og tags to metadata in individual badges page 2017-04-06 09:32:53 +05:30
Guo Xiang Tan
5943543ec3 FIX: Improve checks for non-human users. 2017-04-06 11:29:34 +08:00
cpradio
aeb169bd0e FIX: Do not show User Cannot See Mention dialog when crafting a new topic or a new message
Use the model/composer topic.id to determine what users cannot be mentioned and what message to show as a warning.
2017-04-06 11:20:30 +08:00
Ryan C. Gordon
c51af13338 smtp_should_reject API: use better approach to find user email. 2017-04-05 23:10:36 -04:00
Ryan C. Gordon
a51c191a66 Make Email::Receiver.check_address() into a class method. 2017-04-05 23:10:36 -04:00
Ryan C. Gordon
e15d11df18 Added an API to ask if an incoming email should be dropped at the SMTP level.
This lets an SMTP server optionally decide if it should reject a mail without
passing it on to Discourse at all, possibly before even reading the
email's payload, to prevent spam-induced backscatter and save resources.

This just does the bare minimum sanity checking that could prevent obvious
backscatter. For legit errors from legit users, Discourse will still send a
much more pleasant reply email.
2017-04-05 23:10:36 -04:00
Guo Xiang Tan
e8eaffbd72 FIX: Add onceoff job to remove old auto close topic sidekiq jobs. 2017-04-06 10:52:13 +08:00
Robin Ward
40ab2e5667 FEATURE: Let users update their emails before confirming
This allows users who entered a typo or invalid email address when
signing up an opportunity to fix it and resending the confirmation
email to that address.
2017-04-05 16:44:49 -04:00
Régis Hanol
d1c79372d7 fix permalinks serializer with subfolder setups 2017-04-05 18:45:01 +02:00