Guo Xiang Tan
142571bba0
Remove use of rescue nil.
...
* `rescue nil` is a really bad pattern to use in our code base.
We should rescue errors that we expect the code to throw and
not rescue everything because we're unsure of what errors the
code would throw. This would reduce the amount of pain we face
when debugging why something isn't working as expexted. I've
been bitten countless of times by errors being swallowed as a
result during debugging sessions.
2018-04-02 13:52:51 +08:00
Sam
70aed105a6
FIX: bypass all site setting work for shadowed method
2017-10-27 11:12:44 +11:00
Guo Xiang Tan
d2ac7a9476
Partially revert 4e89d3f778.
...
* SiteSetting uses DistributedCache which depends on MessageBus.
Therefore, we need to initialize MessageBus first.
2017-10-12 15:15:24 +08:00
Guo Xiang Tan
c5850422f0
FIX: SiteSettings defaults cache leaking across multisite.
2017-08-07 15:16:57 +09:00
Guo Xiang Tan
3f24ed2b3e
Can't revert due to incompatibility of new site setting types.
...
Revert "Revert "FEATURE: Site settings defaults per locale""
This reverts commit 439fe8ba24
2017-08-07 10:43:09 +09:00
Guo Xiang Tan
439fe8ba24
Revert "FEATURE: Site settings defaults per locale"
...
This reverts commit 468a8fcd20
2017-08-07 10:31:50 +09:00
Erick Guan
468a8fcd20
FEATURE: Site settings defaults per locale
...
This change-set allows setting different defaults for different locales.
It also:
- Adds extensive testing around site setting validation
- raises deprecation error if site setting has the default property based on env
- relocated site settings for dev and tests in the initializer
- deprecated client_setting in the site setting's loading process
- ensure it raises when a enum site setting being set
- default_locale is promoted to `required` category.
- fixes incorrect default setting and validation
- fixes ensure type check for site settings
- creates a benchmark for site setting
- sets reasonable defaults for Chinese
2017-08-02 12:24:19 -04:00
Guo Xiang Tan
5012d46cbd
Add rubocop to our build. ( #5004 )
2017-07-28 10:20:09 +09:00
Guo Xiang Tan
e82efc7b03
Fix SiteSetingExtension specs to coerce int to string.
2017-07-24 22:54:42 +09:00
Robin Ward
29d529020b
UX: Allow site settings to display as textareas if they like
2017-07-17 16:38:26 -04:00
Guo Xiang Tan
04016f0dec
Support Ruby 2.4.
2017-04-15 12:29:00 +08:00
Neil Lalonde
86522a52b7
FEATURE: add censored_pattern setting to censor posts using regex
2016-11-08 16:39:26 -05:00
Régis Hanol
3841cd9a7f
FEATURE: onebox everything by default
...
FEATURE: new 'max_oneboxes_per_post' site setting
FEATURE: change onebox whitelist to a blacklist
PERF: debounce the loading of oneboxes
PERF: improve perf of mention links in preview
FIX: sort loading of custom oneboxer
2016-10-24 12:46:22 +02:00
Guo Xiang Tan
6075debc90
Add specs to hidding settings when shadowed by a global.
2016-08-11 16:04:45 +08:00
Guo Xiang Tan
b66fc72c18
FIX: Incorrect deprecation message.
2016-07-01 01:18:57 +08:00
Guo Xiang Tan
918b015bdb
Move comment to the right place.
2016-06-29 15:23:29 +08:00
Guo Xiang Tan
20359788dc
Rename SiteSetting#use_https to force_https.
2016-06-29 15:02:43 +08:00
Arpit Jalan
74b3807f60
FEATURE: new bootstrap mode settings for brand new Discourse community ( #4193 )
...
* FEATURE: new bootstrap mode settings for brand new Discourse community
* new SiteSetting.set_and_log method
2016-04-26 13:08:19 -04:00
Sam
da419326be
FIX: nil and blank string should not override a site setting
2016-04-04 16:36:32 +10:00
Sam
b1e68390f4
FIX: false overrides should be permitted via ENV
2016-02-13 17:49:26 +11:00
Guo Xiang Tan
f2c64a3580
FIX: Client settings were not being published.
2016-02-11 17:53:30 +08:00
Sam Saffron
d0dd517f27
FEATURE: blank global settings should not shadow
...
Due to https://github.com/docker/docker/issues/9298 it is a huge pain
to remove ENV vars when composing images, allow us to simply treat "blank"
as a ENV var that is not being shadowed. In general we always supply a
value to ENV vars we are shadowing.
2016-02-10 11:54:40 +11:00
Arpit Jalan
97e4f7f6d3
Enums that are used in tables need to be stable
2016-01-08 20:43:11 +05:30
Robin Ward
5e93140f85
FEATURE: Can override any translation via an admin interface
2015-11-27 11:35:19 -05:00
Sam
1061a9ed06
PERF: introduce full cache for site json when anon
2015-09-28 16:50:24 +10:00
Régis Hanol
31e8309f05
FIX: ensure we never have a string when an enum is Fixnum - Take 2
2015-09-09 14:34:44 +02:00
Régis Hanol
9a999bfe84
FIX: ensure we never have a string when an enum is Fixnum
2015-09-09 12:59:49 +02:00
Robin Ward
da25abfcc9
Merge pull request #3714 from riking/live-settings
...
FEATURE: Live-update site settings
2015-09-01 12:03:30 -04:00
Robin Ward
b41b176bc6
Support for value_list in site settings
2015-09-01 11:54:16 -04:00
Kane York
d4c68f2096
FEATURE: Live-update site settings
2015-08-31 10:40:50 -07:00
Régis Hanol
4ba89eec27
FIX: removing a default category wasn't working
2015-08-26 22:40:16 +02:00
Sam
1c6250bff8
FIX: if an enum is Fixnum do not allow strings to live in it
2015-08-26 16:39:09 +10:00
Régis Hanol
bef80633b1
FEATURE: global admin override of most of the user preferences
2015-08-21 20:39:21 +02:00
Kane York
2363897a25
FEATURE: Arbitrary validations for site settings
2015-08-20 18:27:19 -07:00
Sam
fd63d89753
FEATURE: simpler definition of enum types
2015-08-07 11:41:48 +10:00
Arpit Jalan
e9a81064e7
Revert "FIX: fixnum type site setting can't be more than 20000"
...
This reverts commit 636cc66e1f
2015-07-13 22:53:44 +05:30
Arpit Jalan
636cc66e1f
FIX: fixnum type site setting can't be more than 20000
2015-07-13 18:58:45 +05:30
Robin Ward
7b6d6b76eb
FEATURE: Multiple embeddable hosts
...
- Also refactors two site settings components into one, with tests
2015-06-09 13:25:43 -04:00
Sam
803feefd54
MessageBus handles readonly redis now, no need to wrap it
2015-05-04 12:21:00 +10:00
Robin Ward
5b3f99aa50
Don't blow up if Redis switches to READONLY
2015-04-24 14:37:16 -04:00
Arpit Jalan
2ee033caa5
FIX: validate integer site setting
2015-04-23 18:15:14 +05:30
Sam
a82530012a
FEATURE: Allow selection of highlight js languages
...
PERF: stop loading highlight js on load
To get latest highlight js run bin/rake highlightjs:update
2015-03-13 16:18:59 +11:00
Robin Ward
84b84a9d7c
Support for url_list site setting.
2015-03-03 16:19:29 -05:00
Sam
0742f340f9
FEATURE: allow for a localized error when a regex fails in site settings
...
FEATURE: apply string validation to list site settings (so we get regex)
2015-02-27 11:45:56 +11:00
Sam
5f8e604abc
remove an allocation
2015-02-12 15:07:17 +11:00
Sam
276fd702e8
missed a send which caused code to break
2015-02-12 15:01:14 +11:00
Sam
ab3d4471fe
PERF: remove eval cause it is costing lots of memory
...
see: http://tenderlovemaking.com/2013/03/03/dynamic_method_definitions.html
isolated via memory profiler gem.
2015-02-12 14:44:40 +11:00
Robin Ward
0da022a1ba
FIX: Make sure to observe shadowed settings when refreshing
2015-02-09 17:28:55 -05:00
Robin Ward
5d6f6c4887
Revert "FIX: refresh should work with shadowed globals"
...
This reverts commit 226f4b5bd9
2015-02-09 17:08:52 -05:00
Robin Ward
226f4b5bd9
FIX: refresh should work with shadowed globals
2015-02-09 16:52:21 -05:00
