Alan Guo Xiang Tan
cd82e10d87
FIX: Restrict sidebar specific select kit CSS to sidebar ( #17552 )
...
Follow-up to 0d72a8c458
2022-07-18 16:17:03 +08:00
Alan Guo Xiang Tan
0d72a8c458
FEATURE: API for sidebar ( #17296 )
...
This plugin API can be used to add to sections and links to sidebar
2022-07-18 14:03:37 +10:00
Alan Guo Xiang Tan
54e63b3d31
Revert "UX: Remove experimental sidebar notification text ( #17290 )" ( #17548 )
...
This reverts commit 4df683f88d
.
We've decided to bring back the words for counts in the experimental sidebar.
2022-07-18 10:34:22 +08:00
Jarek Radosz
6a4a7b1d88
UX: Prevent long toolbars from resizing the column ( #17538 )
2022-07-17 20:16:11 +02:00
Jarek Radosz
be6736c940
UX: Make space for scrollbar in mini-profiler ( #17524 )
2022-07-16 10:12:44 +02:00
Kris
9909d001c5
UX: increase text size for mobile exp sidebar ( #17521 )
2022-07-15 17:44:44 -04:00
Kris
e293afad4c
UX: Prevent pre tag from making posts too wide ( #17518 )
2022-07-15 15:51:22 -04:00
Osama Sayegh
3690953a3f
DEV: Assign Mini Profiler badge a z-index below the notifications menu ( #17496 )
...
Follow-up to https://github.com/discourse/discourse/pull/17468 .
The notifications menu has a z-index at the header level, so the badge should be below that.
72889573e6/app/assets/stylesheets/common/base/menu-panel.scss (L26)
2022-07-14 20:14:38 +03:00
Meghna
72889573e6
UX: better account-created page ( #17452 )
...
UX: minor styling updates to accept invite pages
2022-07-14 20:43:00 +05:30
Jarek Radosz
4b935b61eb
FIX: CSS tweak and production position fix for miniprofiler ( #17493 )
...
* DEV: Format miniprofiler html
* FIX: Move miniprofiler to the right in production
* UX: Fix and merge miniprofiler css
2022-07-14 13:03:43 +02:00
Jarek Radosz
abe9b41ddf
DEV: Fix various typos ( #17485 )
2022-07-14 08:56:25 +08:00
Kris
806e0f2885
FIX: adjust topic avatar height to fix stickiness ( #17476 )
2022-07-13 10:00:59 -04:00
Alan Guo Xiang Tan
b4b87454f2
DEV: Move mini profiler badge to the right ( #17468 )
...
In the era where we have left aligned sidebar, the mini profiler badge
gets in the way
2022-07-13 13:40:12 +08:00
Joe
8a3c02c985
FIX: Mobile usability issues in crawler view ( #17465 )
...
Google is complaining about some mobile crawler layout issues. If a post has tables, they extend outside the viewport.
<img height="300" src="https://user-images.githubusercontent.com/33972521/178642976-3d1761ad-d8cb-4c69-92b5-7be799873d5c.png ">
This PR fixes that. We constrain the post to the viewport width (already determined from a parent element) and make it possible to scroll instead.
There is no visual change here, it should act the same as it does today, but it makes Google happy.
This PR also adds a bit of margin to tags in the `/tags` page in the crawler view because Google was complaining about `Clickable elements too close together`
<img height="300" src="https://user-images.githubusercontent.com/33972521/178644327-cc3ff795-24f1-4fef-95c9-e4358a5b37bc.png ">
2022-07-13 11:59:16 +08:00
Jarek Radosz
0e61f332ee
DEV: Make sure testing-container fits in the viewport ( #17446 )
...
This prevents tests failures when the browser viewport is too small.
2022-07-12 15:32:43 +02:00
Chapoi
d90cdba70f
Revert "UX: missing specificity ( #17324 )" ( #17426 )
...
This reverts commit 4730858598
.
2022-07-11 20:20:40 +02:00
Kris
6b57d792bb
UX: Fix exp sidebar toggle alignment, add hovers ( #17414 )
2022-07-11 12:58:48 -04:00
Jarek Radosz
5b70b67e78
FIX: Just inline the QUnit CSS in theme-test html ( #17415 )
...
Side-steps sassc compilation issues.
2022-07-11 12:01:47 +02:00
Jarek Radosz
e5346ed84a
Revert "DEV: Don't vendor old qunit css ( #17410 )" ( #17417 )
...
This reverts commit cf85ccca7d
.
2022-07-11 09:16:00 +10:00
Jarek Radosz
cf85ccca7d
DEV: Don't vendor old qunit css ( #17410 )
2022-07-10 14:57:22 +02:00
Kris
5a26c87fa6
UX: less janky animation for experimental sidebar ( #17396 )
2022-07-08 14:06:01 -04:00
Kris
4c1b8e736d
UX: add border-box to stop padding from overflow ( #17391 )
2022-07-08 10:31:28 -04:00
Kris
7d3b22135c
UX: don't animate experimental sidebar on reload ( #17372 )
2022-07-07 09:33:17 -04:00
Kris
fbc89dd41a
UX: improve experimental sidebar transitions ( #17358 )
2022-07-06 13:31:06 -04:00
Chapoi
63562e8b14
UX: switch highlight/select colours in select-kit ( #17356 )
2022-07-06 16:49:36 +02:00
Jarek Radosz
c3fd91670e
DEV: Update linting setup and fix issues ( #17345 )
...
Re-lands #16119 and #17298
* Update eslint-config-discourse
* Update linting workflow
* Prettier-ignore stuff
* Update template-lint config
* Auto-fix template issues
* Fix various template issues
Mostly incorrect attributes and unused templates
* Prettier js files
* Fix template auto-fix regressions
* Small css tweak
Co-authored-by: Peter Wagenet <peter.wagenet@gmail.com>
2022-07-06 10:37:54 +02:00
Kris
59c8774957
UX: Prevent experimental sidebar scroll jumps ( #17352 )
2022-07-06 10:36:44 +08:00
Kris
7711d140da
UX: staff notice should utilize full post width ( #17346 )
2022-07-05 15:49:47 -04:00
Andrei Prigorshnev
c59f1729a6
FEATURE: auto remove user status after predefined period ( #17236 )
2022-07-05 19:12:22 +04:00
Kris
56c0d8cf92
UX: mobile experimental sidebar improvement ( #17302 )
...
First pass at the mobile experimental sidebar improvement.
Co-authored-by: Alan Guo Xiang Tan <gxtan1990@gmail.com>
2022-07-05 11:45:02 +08:00
Chapoi
408ce1312b
UX: remove hardcoded colour value ( #17323 )
2022-07-05 10:47:29 +08:00
Chapoi
4730858598
UX: missing specificity ( #17324 )
2022-07-05 10:46:54 +08:00
Alan Guo Xiang Tan
ef7a518159
UX: Retain category badge style on categories select kit. ( #17332 )
...
Category badge changes based on the `category style` site setting so we
do not want to forcing all category names to the same color.
Follow-up to 3266350e80
2022-07-05 10:05:44 +08:00
Vinoth Kannan
af3262d70a
UX: made "Dismiss New" button clickable by replacing float
method. ( #17288 )
...
Since we removed the `row:after { clear: both }` CSS we no longer use `float` style here. Instead, we should use `flex` style to align the button in right side.
2022-07-01 09:12:16 +05:30
Kris
199d58461b
UX: hide sidebar li overflow, remove title margin ( #17294 )
2022-06-30 18:24:29 -04:00
Kris
321dc29583
UX: improve experimental sidebar scrollbar ( #17293 )
2022-06-30 16:14:29 -04:00
Kris
b1f7da4fe3
UX: minor experimental sidebar alignment changes ( #17292 )
2022-06-30 16:14:17 -04:00
Kris
4df683f88d
UX: Remove experimental sidebar notification text ( #17290 )
2022-06-30 14:15:39 -04:00
Rafael dos Santos Silva
f130ec35d9
FEATURE: Use full post width for Vimeo embeds ( #17289 )
2022-06-30 13:08:24 -03:00
Alan Guo Xiang Tan
3a6e87ca4f
FEATURE: Store sidebar section display state in local storage ( #17281 )
...
Tests have been intentionally left out as it is hard to test interaction that relies on local storage.
It also isn't the end of the world if the feature regresses.
2022-06-30 15:56:46 +08:00
Alan Guo Xiang Tan
3266350e80
FEATURE: Decouple category/tag presence in sidebar from notifi level ( #17273 )
2022-06-30 14:54:20 +08:00
Kris
f44eb13236
FIX: add clearfix back for admin contents ( #17278 )
2022-06-29 10:17:01 -04:00
Kris
f0005401b7
UX: core adjustments and styles for the experimental sidebar ( #17271 )
2022-06-29 10:49:01 +08:00
Alan Guo Xiang Tan
836b5300fc
DEV: Move sidebar utility class to body tag ( #17259 )
2022-06-28 11:32:06 -04:00
Chapoi
a832c94527
UX: update color on arrow tippy box ( #17263 )
2022-06-28 13:25:40 +02:00
jbrw
9874fe3fb3
FIX: Improve mixcloud oneboxing ( #17237 )
...
- Sets `https://www.mixcloud.com ` as a `requires_iframe_origins` to allow the iframe content to be displayed
- Attempts to render something approximating the Mixcloud content in the preview pane of the Composer, rather than just displaying a large version of the artwork associated with the link
2022-06-27 08:32:24 +10:00
Kris
305c4750df
UX: allow more mobile topic elements to be tapped ( #17234 )
2022-06-24 15:55:52 -04:00
Alan Guo Xiang Tan
7b2ad1b931
UX: Truncate long category names in sidebar ( #17203 )
2022-06-24 10:28:35 +08:00
Joe
293323af38
UX: Splash screen v1 improvements ( #17214 )
...
This commit does six things
* changes the animation for the splash screen. To a more subtle animation.
* defers displaying the splash by 1.5 seconds
* defers displaying the splash "loading" text by 2.5 seconds
* defers removing the splash until all Discourse initializers have run
* fixes a display issue in Firefox
* Inlines the SVG as a base64 and inlines the required CSS.
The encoded SVG is hard coded for now, but we will use a helper to generate that based on the file after some testing.
2022-06-23 14:07:04 +08:00
Kris
6f32d605ba
UX: improve group page grid sizes ( #17208 )
2022-06-22 17:14:22 -04:00
Andrei Prigorshnev
278752fa87
Change the background color of the user status bubble ( #17204 )
2022-06-22 19:40:21 +04:00
Andrei Prigorshnev
033f72c65f
FEATURE: user status emoji ( #17025 )
2022-06-22 18:15:33 +04:00
Joe
e82a2ce9ae
UX: Introduces a splash screen behind a hidden site setting ( #17094 )
...
This PR introduces a new hidden site setting that allows admins to display a splash screen while site assets load.
The splash screen can be enabled via the `splash_screen` hidden site setting.
This is what the splash screen currently looks like
5ceb72f085
.mp4
Once site assets load, the splash screen is automatically removed.
To control the loading text that shows in the splash screen, you can change the preloader_text translation string in admin > customize > text
2022-06-22 04:35:46 +08:00
Jarek Radosz
36c2284dea
DEV: Fix typos "formated" -> "formatted" ( #17156 )
...
(nothing in all-the* relies on these)
2022-06-20 20:02:05 +02:00
Jarek Radosz
a69b914710
FIX: Wizard css was overriding some of core css ( #17126 )
...
* Use `var()`
* Remove imports
* Scope all wizard css to `body.wizard`
2022-06-17 17:28:54 +02:00
Jarek Radosz
fcb4e5a1a1
DEV: Make wizard an ember addon ( #17027 )
...
Co-authored-by: David Taylor <david@taylorhq.com>
2022-06-17 14:50:21 +02:00
Penar Musaraj
4c810ca121
FIX: JSON Schema editor layout issue with subarrays ( #17112 )
2022-06-16 22:33:42 -04:00
Alan Guo Xiang Tan
c625dc0adc
FEATURE: Add messages section links to experimental sidebar. ( #17096 )
2022-06-16 13:33:40 +08:00
Gerhard Schlager
888f50543d
DEV: Fix javascript:update
rake task ( #17098 )
...
* The `javascript:update` rake task failed because recent versions of chart.js use a lowercase filename (`chart.min.js` instead of `Chart.min.js`)
* Changed `loadScript()` to use lowercase keys to lookup scripts
* `svg-arrow.css` seems to have changed slightly (linebreak at the end of file)
2022-06-15 19:49:04 +02:00
Joffrey JAFFEUX
532935043c
FIX: allows image to be displayed at the right size
2022-06-10 16:28:58 +02:00
Alan Guo Xiang Tan
cd8c97debc
FEATURE: Add section links to categories section to exp sidebar ( #17035 )
...
This commit adds a section link to the categories section for each
category that is tracked by the user in the experimental sidebar.
2022-06-09 11:14:01 +08:00
Penar Musaraj
4be67ef9a7
UX: Larger images in mobile emoji picker ( #17013 )
2022-06-07 12:00:09 -04:00
David Taylor
5238f6788c
FEATURE: Allow hotlinked media to be blocked ( #16940 )
...
This commit introduces a new site setting: `block_hotlinked_media`. When enabled, all attempts to hotlink media (images, videos, and audio) will fail, and be replaced with a linked placeholder. Exceptions to the rule can be added via `block_hotlinked_media_exceptions`.
`download_remote_image_to_local` can be used alongside this feature. In that case, hotlinked images will be blocked immediately when the post is created, but will then be replaced with the downloaded version a few seconds later.
This implementation is purely server-side, and does not impact the composer preview.
Technically, there are two stages to this feature:
1. `PrettyText.sanitize_hotlinked_media` is called during `PrettyText.cook`, and whenever new images are introduced by Onebox. It will iterate over all src/srcset attributes in the post HTML and check if they're allowed. If not, the attributes will be removed and replaced with a `data-blocked-hotlinked-src(set)` attribute
2. In the `CookedPostProcessor`, we iterate over all `data-blocked-hotlinked-src(set)` attributes and check whether we have a downloaded version of the media. If yes, we update the src to use the downloaded version. If not, the entire media element is replaced with a placeholder. The placeholder is labelled 'external media', and is a link to the offsite media.
2022-06-07 15:23:04 +01:00
Joe
98671445a7
UX: hide select-kits when the parent element is outside the viewport
...
If the select-kit header is not in the viewport (scrolled out of view), popper adds a data-popper-reference-hidden attribute.
This PR adds the recommended styles to "hide" the select-kit body when that happens. See
https://popper.js.org/docs/v2/modifiers/hide/
2022-06-07 16:57:10 +08:00
Chapoi
69bab5e5a0
UX: update chat menu popover styling ( #16955 )
2022-05-31 09:51:50 +02:00
David Taylor
8fe3934856
UX: Make YouTube playlist onebox full width to match video onebox ( #16936 )
2022-05-27 10:39:12 +01:00
Andrei Prigorshnev
5c596273a0
FEATURE: user status ( #16875 )
2022-05-27 13:15:14 +04:00
Andrei Prigorshnev
28573b504f
UX: align the trash button on the bookmark modal ( #16884 )
2022-05-23 18:51:01 +04:00
Chapoi
a6abf8d07a
UX: update hljs-builtin-name colour ( #16863 )
2022-05-18 16:11:59 -04:00
Chapoi
96d656f450
UX: update hljs-builtin-name highlight ( #16859 )
...
* update hljs-builtin-name highlight
* Move dark-light function to better file
2022-05-18 15:55:40 +02:00
Bianca Nenciu
9ea8a4a9af
FIX: Use CSS transition to make room for composer ( #16750 )
...
The composer is displayed over the bottom part of the page. To make sure
that no content is covered by the composer, a bottom padding is added
equal to the height of the composer. When the composer is opened or
closed that padding is added after around 300ms because of a debounce.
This commit makes sure that the padding is added as soon as the composer
state changes by using a CSS custom property (variable) and transition
property for a smooth user interface.
2022-05-17 22:44:25 +03:00
Meghna
28affa8cba
UX: consistent spacing on group interaction form ( #16851 )
2022-05-17 18:38:46 +05:30
Penar Musaraj
f31301b6de
UX: Fix status icon size in suggested topics ( #16845 )
2022-05-16 15:53:40 -04:00
Alan Guo Xiang Tan
2cc9f0e7d9
DEV: Setup categories section in sidebar for future work ( #16733 )
2022-05-13 09:35:15 +08:00
Martin Brennan
8e9164fb60
DEV: Minor bookmark tweaks for polymorphism ( #16728 )
...
* Make the modal for bookmarks display more consistently
* Make sure bookmark query can handle empty results for certain
bookmarkable queries
2022-05-12 10:29:01 +10:00
Kris
4df4817e13
FIX: auto margins cause too-narrow content ( #16725 )
2022-05-12 08:13:53 +08:00
Alan Guo Xiang Tan
9b420eb6e3
DEV: First pass at side topics section ( #16697 )
...
* Implements everything, tracked and bookmarked links
* Implements unread/new count for everything link
2022-05-11 13:43:24 +08:00
Kris
19677ce3f6
UX: fix various login modal issues on mobile ( #16708 )
2022-05-11 14:36:27 +10:00
Chapoi
6f00feaea0
Fix user nav overflow bug on ipad ( #16702 )
2022-05-10 16:38:14 +01:00
Kris
26c5002144
UX: prevent user grid blowout on full page search ( #16672 )
2022-05-10 09:48:01 +08:00
Kris
4b92175d4e
UX: remove horizontal scoll from narrow screens ( #16657 )
2022-05-05 11:34:01 -04:00
Natalie Tay
8c8b646a59
FIX: Prevent admin theme settings from blowing up ( #16653 )
2022-05-05 20:20:59 +08:00
Alan Guo Xiang Tan
87b970cd22
UX: Ensure #main-outlet-wrapper
takes full width. ( #16650 )
...
For some reason, we're seeing inconsistency between production and
development environment where the computed width of #main-outlet-wrapper
is not taking the full width of the grid column in production.
Follow-up to b35cf7cc0c
.
2022-05-05 16:34:40 +08:00
Alan Guo Xiang Tan
b35cf7cc0c
DEV: First desktop design interface pass at experimental sidebar take 2. ( #16647 )
2022-05-05 14:35:08 +08:00
Alan Guo Xiang Tan
aa5d90a554
Revert "DEV: First desktop design interface pass at experimental sidebar ( #16590 )" ( #16646 )
...
This reverts commit 36dcf80aff
.
2022-05-05 11:56:24 +08:00
Alan Guo Xiang Tan
36dcf80aff
DEV: First desktop design interface pass at experimental sidebar ( #16590 )
...
Co-authored-by: awesomerobot <kris.aubuchon@discourse.org>
2022-05-05 11:19:46 +08:00
Penar Musaraj
749e496a2c
DEV: Minor fixes to json schema editor styling ( #16634 )
2022-05-05 09:52:58 +08:00
Penar Musaraj
4e65e02da6
UX: Fix hover state for flat buttons in WCAG schemes ( #16601 )
2022-05-03 08:48:58 +10:00
Joffrey JAFFEUX
fad94160c7
FIX: uses tippy for popover ( #15409 )
...
Note this commit also introduce a new {{d-popover}} component, example usage:
```hbs
{{#d-popover |state|}}
{{d-button label="foo.things" class="d-popover-trigger"}}
<div class="d-popover-content">
Some content
<div>
{{/d-popover}}
```
2022-05-02 17:10:26 +02:00
Penar Musaraj
c76f684320
UX: Reset mark
element highlight for WCAG schemes ( #16593 )
2022-04-29 14:22:26 -04:00
Bianca Nenciu
14b09c9909
UX: Move post date under title in share-modal ( #16455 )
...
The old position was less than ideal on mobile.
2022-04-27 16:36:08 +03:00
Kris
8dd3d6cb97
UX: Larger clickable area for mobile topic list ( #16473 )
2022-04-26 15:01:43 -04:00
Kris
144b87b17a
UX: fix topic admin menu layout for short screens ( #16565 )
2022-04-26 10:27:45 -04:00
Jarek Radosz
020d862baa
UX: Tweak topic-admin-menu alignment/size ( #16564 )
...
* Increase the space between icons and labels
* Increase the menu width
2022-04-26 16:02:46 +02:00
Kris
329a64969c
UX: prevent group mention from wrapping ( #16558 )
2022-04-26 08:30:55 -04:00
Penar Musaraj
c1d9822003
UX: Fix a few WCAG color scheme contrast issues ( #16554 )
2022-04-25 17:07:35 -04:00
Kris
4157403308
UX: organize topic admin menu into groups ( #16489 )
2022-04-25 16:02:41 -04:00
Andrei Prigorshnev
53e484817e
DEV: drop the unused invite-link-panel component and related unused code ( #16435 )
2022-04-21 14:32:17 +04:00
Kris
5a76a3669b
A11Y: fix WCAG contrast for notification header ( #16507 )
2022-04-19 18:20:50 -04:00
Kris
6b4f4e5387
UX: minor email group chooser alignment fix ( #16487 )
2022-04-18 09:39:27 -04:00