Commit Graph

9763 Commits

Author SHA1 Message Date
getabetterpic
519a50e3a5 Fix bug where create topic is suggested when insufficient permissions
When a user is viewing a category they do not have permission to create
a topic in, they are still prompted to create a topic if they are at the
bottom of the topics. This fixes the issue, as well as disabling the
New Topic button if they don't have permission to create a topic for
that category.
2015-09-18 19:27:49 -04:00
Robin Ward
71bac0c342 Add page title and charset to embedded HTML 2015-09-18 16:12:56 -04:00
Robin Ward
c1d321369b We don't need to allow track and meter 2015-09-18 15:37:56 -04:00
Robin Ward
8489118811 FIX: Cropped embedding footer 2015-09-18 15:36:40 -04:00
Jeff Atwood
32fd5bc696 minor fixes to embed HTML 2015-09-18 12:18:54 -07:00
Robin Ward
d062d64278 FIX: Sometimes posts can't be created. Don't raise errors in that case. 2015-09-18 15:07:31 -04:00
Robin Ward
40934e595a FIX: Some RSS feeds do unsafe redirects
There are people who have RSS feeds set up that do HTTPS -> HTTP
redirects which throw errors. Since RSS feeds are all configured
by admins I think it's OK if they allow an unsafe redirect as the
content is public anyway. This will reduce many server side errors.
2015-09-18 13:25:09 -04:00
Robin Ward
e7af8d2239 FIX: Queued Posts should be ordered by created_at 2015-09-18 13:11:57 -04:00
Robin Ward
c9e8dd87e5 Merge pull request #3786 from gschlager/i18n-sidekiq
FIX: Load fallback locales in Sidekiq jobs
2015-09-18 13:00:33 -04:00
Robin Ward
c1a9e32b48 FIX: When recovering a post, it should recreate user actions 2015-09-18 12:48:43 -04:00
Gerhard Schlager
619d5b1bc1 FIX: Load fallback locales in Sidekiq jobs 2015-09-18 18:21:27 +02:00
Robin Ward
cc516d3be0 Merge pull request #3743 from sitepoint/topic-embed-info
Add embed/info endpoint for TopicEmbed queries
2015-09-18 11:00:01 -04:00
Arpit Jalan
7abd4687e2 FIX: redirect to original URL when logging in via OAuth 2015-09-18 18:34:57 +05:30
Jeff Atwood
f37f6f7673 minor embed style tweak 2015-09-18 02:44:13 -07:00
Jeff Atwood
01782affe2 clearer call to action in embed CSS styles 2015-09-18 00:40:04 -07:00
Jeff Atwood
a58b6c5ac0 Merge pull request #3785 from riking/410
FIX: Return 410 Gone for deleted topics you could otherwise see
2015-09-18 00:21:27 -07:00
Sam
a4ace3f08e FEATURE: ui for ordering search results in full page mode 2015-09-18 17:16:53 +10:00
Sam
d97e78b942 FIX: jitter in ui when expanding select 2 2015-09-18 17:16:53 +10:00
Kane York
c9e4745fe8 FIX: Return 410 Gone for deleted topics you could otherwise see 2015-09-18 00:14:43 -07:00
Guo Xiang Tan
74ca8c3318 UX: Allow users to open search in new tab. 2015-09-18 11:14:56 +08:00
Guo Xiang Tan
f39b9124b6 FEATURE: Log staff actions for Category changes. 2015-09-18 10:53:08 +08:00
Guo Xiang Tan
c29b7ce498 FIX: Set saving to false about model has been saved. 2015-09-18 10:52:49 +08:00
Guo Xiang Tan
25c7450ea7 Use existing function to extract error message. 2015-09-18 10:52:49 +08:00
Sam
086d31d53b UX: when on full page search header search should not pop open
fix `/` handling in full page search to highlight search term
2015-09-18 12:20:59 +10:00
Sam
7067d32c33 protect against bad data 2015-09-18 11:27:56 +10:00
Sam
287411525a PERF: add missing index on group_users 2015-09-18 10:43:53 +10:00
Sam
c1ecd6f4ce update annotations 2015-09-18 10:41:10 +10:00
Jeff Atwood
7468f85818 Merge pull request #3783 from scossar/fix-comment-in-menu-panel-scss
FIX: remove incorrect comment and rule from menu-panel.scss
2015-09-17 14:46:55 -07:00
Jeff Atwood
0dc11e3a26 remove useless extra <div> around topic-avatar 2015-09-17 14:30:28 -07:00
scossar
6b1eb8df8f remove comment, remove unused rule 2015-09-17 14:19:38 -07:00
Robin Ward
4eaaf4198c FIX: Liking a post shouldn't contract who liked it 2015-09-17 16:29:17 -04:00
Neil Lalonde
0aee7b8211 move age beside title on mobile categories page 2015-09-17 15:25:37 -04:00
Régis Hanol
07e7b07b63 FIX: refreshing gravatar wasn't working 2015-09-17 19:42:44 +02:00
Robin Ward
b45af1d6c8 FIX: Replies to whispers should default to whispers 2015-09-17 11:48:37 -04:00
Robin Ward
0a78cdbd83 FIX: Clicking users in Private Messages Map should show card 2015-09-17 11:38:21 -04:00
Robin Ward
901380224b Merge pull request #3775 from xfalcox/patch-2
Fix composer for FF14+
2015-09-17 10:47:35 -04:00
getabetterpic
87725206cd Fix bug when adding new custom group
When adding a new group, if Delete was clicked before saving the
group, the modal would come up, but the Yes confirmation would
do nothing. This fixes that by taking an approach similar to the
Badges and checks to see if the Group is new, and if it is, just
returns to the index instead of invoking the confirm modal.

This also fixes the redirect after saving a new Group.
2015-09-17 10:23:58 -04:00
Régis Hanol
28d3260b30 Merge pull request #3780 from tgxworld/fix_mistake
FIX: Only cancel composer for when editing first post.
2015-09-17 09:58:46 +02:00
Sam
183d72f2e9 correct composer in iPad landscape 2015-09-17 17:19:50 +10:00
Jeff Atwood
518262ce58 allow wider mobile header 2015-09-17 00:17:35 -07:00
Jeff Atwood
0627a58b8b FIX: too much whitespace at bottom of mobile posts 2015-09-17 00:00:53 -07:00
Jeff Atwood
0969bd0f0d tighten up post spacing on mobile 2015-09-16 23:48:15 -07:00
Sam
527c9158eb we must hide the header for iPad 2015-09-17 13:19:08 +10:00
Sam
e254030760 FIX: header undocking when opening mobile view
FIX: make it possible to upload an image on iphone
FIX: mobile can now upload more than 1 image
2015-09-17 13:05:31 +10:00
Sam
faada383fa Merge pull request #3779 from riking/signup-cta
Allow emoji in translated strings
2015-09-17 11:34:41 +10:00
Kane York
7e8f4286e3 FEATURE: Allow emoji in some translated strings 2015-09-16 18:33:17 -07:00
Guo Xiang Tan
bce8d0632a FIX: Only cancel composer for when editing first post. 2015-09-17 09:24:02 +08:00
Sam
ec4a1bb2c4 FIX: page tracking was not properly tracking transitions
PERF: move closure to self contained method so env is released earlier.
2015-09-17 11:06:33 +10:00
Jeff Atwood
2ac9f6a1b0 Merge branch 'master' of https://github.com/discourse/discourse 2015-09-16 17:16:20 -07:00
Jeff Atwood
4714483612 copyedits on anon user call to signup action 2015-09-16 17:16:17 -07:00
Sam
975837cf0d Merge pull request #3769 from tgxworld/disable_button_while_searching
UX: Disable button while searching.
2015-09-17 10:01:27 +10:00
Kane York
4e587eb68f Store nothing if anon cta is disabled 2015-09-16 16:32:15 -07:00
Kane York
e16eebb48c FIX: Don't even bother checking visit count 2015-09-16 15:35:50 -07:00
Kane York
102b6f6fca FIX: Reduce requirements for signup call-to-action
1 visit, 5 minutes, 3 topics
2015-09-16 15:34:39 -07:00
Neil Lalonde
a2e51b0715 FIX: too few topics/posts notice will only show what needs to be done 2015-09-16 17:12:11 -04:00
Neil Lalonde
f321dd2046 UX: mobile /categories page new and unread styles match other topic lists 2015-09-16 17:12:11 -04:00
Régis Hanol
24f09edbed UX: replace cancel uploading link with icon + fix color (Take 2) 2015-09-16 22:04:48 +02:00
Robin Ward
2546ca3c8e FIX: Remove attributes observer, doesn't work in FF/Safari 2015-09-16 15:36:12 -04:00
Robin Ward
97b608f090 FIX: Allow desktop chrome to scroll to bottom of menu panel 2015-09-16 15:30:40 -04:00
Robin Ward
52f7ab3a06 Revert "UX: replace cancel uploading link with icon + fix color"
This reverts commit 1689f436d9.
2015-09-16 15:15:07 -04:00
Robin Ward
63f0247d21 FIX: Better height estimation / observing for menu panels 2015-09-16 14:46:53 -04:00
Robin Ward
d61cfbe2aa Merge pull request #3773 from tgxworld/fix_composer_bug
FIX: Composer being abandoned when transiting between routes.
2015-09-16 14:34:46 -04:00
Robin Ward
62c20ff5f2 Merge pull request #3760 from riking/signup-cta
Signup cta
2015-09-16 14:33:25 -04:00
Robin Ward
91db481fae Merge pull request #3774 from tgxworld/meta_keys_header
Fixes for headers.
2015-09-16 14:33:08 -04:00
Rafael dos Santos Silva
45a7e200a8 Fix composer for FF14+
Fix the preview for old versions of Firefox.
2015-09-16 15:13:44 -03:00
Guo Xiang Tan
a845e0c498 FIX: Highlight posts was broken. 2015-09-17 01:37:48 +08:00
Guo Xiang Tan
2958b4b0a1 FIX: Don't dismiss dropdown when searching within posts context. 2015-09-17 01:22:19 +08:00
Kane York
390af7118a Merge branch 'master' into signup-cta
Conflicts:
	app/assets/javascripts/discourse/templates/topic.hbs
2015-09-16 10:06:47 -07:00
Robin Ward
59c628735f Use container for appending views in Discourse.ContainerView 2015-09-16 13:05:22 -04:00
Guo Xiang Tan
685471303a FIX: Don't dismiss headers on modifier keys. 2015-09-17 00:38:05 +08:00
Guo Xiang Tan
a966546843 FIX: Cancel and reopen composer when editing first post. 2015-09-17 00:13:24 +08:00
Régis Hanol
1689f436d9 UX: replace cancel uploading link with icon + fix color 2015-09-16 17:54:09 +02:00
Robin Ward
f427b6639b FIX: Error showing Unread posts 2015-09-16 10:43:36 -04:00
Régis Hanol
5277ec1ac0 FIX: ensure we have a bucket before enabling backups to S3 2015-09-16 15:55:26 +02:00
Arpit Jalan
f2c1dbaa68 FIX: return 422 if the invite is already redeemed 2015-09-16 17:30:00 +05:30
Régis Hanol
cc75890cd4 UX: disable 'Hide results' button when poll is closed 2015-09-16 13:01:08 +02:00
Guo Xiang Tan
28f0a012ca FIX: Composer being abandoned when transiting between routes. 2015-09-16 18:17:57 +08:00
Régis Hanol
468b04db86 FIX: force wrapping on the filename of lightboxed images 2015-09-16 11:58:06 +02:00
Sam
66ec6b6e17 FIX: not counting new/unread on categories 2015-09-16 17:41:53 +10:00
Guo Xiang Tan
21725cc907 FEATURE: Admin dashboard data for user profile views. 2015-09-16 14:48:31 +08:00
Guo Xiang Tan
7acc93b2a0 FEATURE: Track user profile views. 2015-09-16 14:48:31 +08:00
Guo Xiang Tan
f41bcafe8d FEATURE: Add views to UserProfile. 2015-09-16 14:48:06 +08:00
Guo Xiang Tan
d30f454261 FEATURE: Create UserProfilerView. 2015-09-16 14:48:06 +08:00
Guo Xiang Tan
5d95b38c65 UX: Disable button while searching. 2015-09-16 14:47:35 +08:00
Sam
afdb15f99f fix search screen looks white 2015-09-16 15:02:57 +10:00
Sam
77895473e5 don't select text on focus 2015-09-16 14:40:44 +10:00
Jude Aakjaer
9cca510944 Add embed/info endpoint for TopicEmbed queries 2015-09-16 03:22:24 +00:00
Sam
31d801ce2c don't blur on autocomplete click 2015-09-16 13:16:08 +10:00
Sam
7db4ddcb66 correct disappering header on mobile compose 2015-09-16 12:50:42 +10:00
Sam
8cb9c348f6 live posts counts is only available to logged in users 2015-09-16 12:27:05 +10:00
Sam
0b2fa2b0af FIX: admin menu rendered at incorrect spot
make sure we don't unsubscribe all events when menu is destroyed
2015-09-16 11:37:56 +10:00
Sam
3215273091 Merge pull request #3771 from riking/category-reorder
Do fix positions upon opening dialog
2015-09-16 11:01:06 +10:00
Sam
ca97b325fd FIX: moderators should not have a link to site settings 2015-09-16 09:46:57 +10:00
Sam
ded23cc9c5 FIX: don't auto select context on mobile 2015-09-16 09:02:53 +10:00
Sam
c9398eaef9 fix comment 2015-09-16 08:55:05 +10:00
Sam
59c12ce35b Stop showing wrench for non admins on topics 2015-09-16 08:51:28 +10:00
Jeff Atwood
a14d7f16c8 fix reply glyph color on mobile editor 2015-09-15 15:39:59 -07:00
Jeff Atwood
0a3388d19f on mobile submit-panel must have width 2015-09-15 15:22:22 -07:00
Jeff Atwood
74da57f77f minor category page style tweaks for mobile 2015-09-15 14:37:14 -07:00
Jeff Atwood
a47a71dd82 fix cancel button alignment on mobile editor 2015-09-15 14:28:31 -07:00