github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-30 08:43:45 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
32,045 Commits 214 Branches 500 Tags 960 MiB
41c7423985
Commit Graph

19042 Commits

Author SHA1 Message Date
Kris
6e26358380 REFACTOR: streamline like button styles, clarify for themeing, enable tab focus 2019-03-07 21:09:57 -05:00
Gerhard Schlager
f6ef4f8c3f FEATURE: Add missing S3 regions 2019-03-07 22:42:20 +01:00
Kris
ccff1d2dbb prettier 2019-03-07 13:30:39 -05:00
Kris
837452794b Target active nav pill with single style 2019-03-07 13:21:42 -05:00
Joffrey JAFFEUX
a2fdd4089c
FIX: nav-pills not highlighted on user preferences page (#7126) 2019-03-07 13:40:12 +01:00
David Taylor
fc7938f7e0
REFACTOR: Migrate GoogleOAuth2Authenticator to use ManagedAuthenticator (#7120) 
https://meta.discourse.org/t/future-social-authentication-improvements/94691/3
 2019-03-07 11:31:04 +00:00
Arpit Jalan
2c8e1d3578 FEATURE: remove all expired invitations by default 2019-03-07 15:28:39 +05:30
Arpit Jalan
caef0a56d1 FEATURE: create a new message via URL without specifying user or group 2019-03-07 11:30:24 +05:30
Kris
9d3c7d7b25 prettier 2019-03-06 19:52:34 -05:00
Kris
e233a69db0 Customize nav pill fix 2019-03-06 19:42:44 -05:00
Kris
7d2cc33013 prettier 2019-03-06 17:37:59 -05:00
Kris
a917a93990 fix active class, remove style 2019-03-06 17:29:19 -05:00
Kris
536952f194 adding back active nav pill 2019-03-06 17:14:02 -05:00
Bianca Nenciu
733deba585 FIX: Loading draft also replaces the recipients (#7122) 2019-03-07 08:14:55 +11:00
Kris
078c02cd24 UX: More consistent structure for active nav-pill 2019-03-06 16:10:22 -05:00
Gerhard Schlager
1121514799 UX: Localize date format in "new user of the month" message 2019-03-06 21:58:25 +01:00
Vinoth Kannan
5ba2ef4274 UX: Display error message if no time frame selected in topic status update 2019-03-07 02:17:29 +05:30
Vinoth Kannan
167d85c21f FIX: post & topic destroyed hooks not triggering with tag filter 2019-03-06 22:52:54 +05:30
Kris
2db3652338 UX: Fix redeemed invite table layout 2019-03-06 11:05:45 -05:00
Gerhard Schlager
4000978452 FIX: Failed to save email template with pluralized subject 2019-03-06 16:51:04 +01:00
Kris
5cf63e43c6 FEATURE: Add about-after-description plugin outlet 2019-03-06 10:26:34 -05:00
David Taylor
df474bceee DEV: Further sidekiq logging stability improvements 
- Open the log file in "append" mode. This avoids issues if the file does not exist (and matches standard rails log behavior)
- Correctly parse the interval logging environment variable
 2019-03-06 12:50:15 +00:00
Tarek Khalil
0a9a11094d
FEATURE: Save ignored usernames in user preferences (#7117) 
* FEATURE: Save ignored usernames in user preferences
 2019-03-06 11:21:58 +00:00
Joffrey JAFFEUX
974e756369
FIX: bugs in safari where select-kit is not expanding on iOS (#7118) 2019-03-06 11:29:45 +01:00
David Taylor
fe62de68dd DEV: Correct sidekiq logging to avoid thread leak 2019-03-06 10:11:31 +00:00
Tarek Khalil
b58eea1fcb
FEATURE: Hide ignored user's Original Post content (#7113) 
* FEATURE: Hide ignored user's Original Post content
 2019-03-06 09:20:45 +00:00
Arpit Jalan
05ebb52ec4
FEATURE: defer flags when deleting child replies (#7111) 2019-03-06 14:32:25 +05:30
Sam
8d7c10f7f2 FIX: allow moderators to create categories setting broken 
Mods require visibility to everyone group cause category dialogs need to
know about this.

If the site setting `allow moderators to create categories` will not function
without this

Note there is no security expansion of rights here, the group is technically
empty anyway and it always looks exactly the same on all discourse instances
 2019-03-06 17:44:18 +11:00
Kris
86f9ace0ea UX: Previous positioning was better for the image resizer 2019-03-05 22:10:12 -05:00
Kris
b5804c410e UX: Add slash to mobile category page totals 2019-03-05 20:16:12 -05:00
Kris
2ea77073ae prettier 2019-03-05 15:12:10 -05:00
Kris
84892429ed UX: Improve layout of invite table 2019-03-05 14:50:27 -05:00
Jeff Wong
b0d93a38e8 FEATURE: Add plugin html hook to insert html before any other scripts 2019-03-05 10:41:16 -08:00
David Taylor
8b30ed5b7a DEV: Serialize the job parameters in sidekiq logs 
Otherwise this can lead to some very large data structures when processing the logs later
 2019-03-05 17:44:49 +00:00
Gerhard Schlager
671cec4bd2 DEV: Use Discourse.getURL for creating URL 
follow-up to ccb48bef75
 2019-03-05 17:52:18 +01:00
Tarek Khalil
190b19f3c2
FEATURE: Add ignored user list to the User's preference page (#7107) 
* FEATURE: Add ignored user list to the User's preference page

## Why?

Part of: https://meta.discourse.org/t/ability-to-ignore-a-user/110254

We want to add list of Ignored users under or along with the muted users preferences section.
This way Users can find and update their list of ignored users.

## UI


![gif](https://user-images.githubusercontent.com/45508821/53746179-8e9b3c00-3e98-11e9-9e90-94b8520896a6.gif)

## Open questions

Two of many options to represent a list of ignored users is that we can:

1. We can represent the ignored user list as a table with the ability to `un-ignore` but NOT to add new ignored users.
2. We can keep it functioning as the `muted user list` where you can `un-ignore` or `ignore` users.
 2019-03-05 14:47:51 +00:00
Tarek Khalil
f19d36cbba
REFACTOR: Change watch wording to unignore (#7112) 
* REFACTOR: Change `watch` wording to `unignore`
 2019-03-05 14:40:31 +00:00
Gerhard Schlager
ccb48bef75 UX: Make Uncategorized category less confusing 
* Adds warnings to the "Edit Category" dialog
* Doesn't hide the "Security" tab on the "Edit Category" dialog anymore. Instead, it shows an explanation why permissions can't be changed.
* Makes the category name translatable
* Hides the category name from the edit dialog (it can be customized by overriding the translation)
* Creates a translation override if the category has been renamed in the past
 2019-03-05 14:42:41 +01:00
Gerhard Schlager
68e4aba369 UX: Don't concatenate title on "Edit Category" dialog 2019-03-05 14:42:41 +01:00
David Taylor
35275c137b PERF: Remove final N+1 from theme admin page 
The rails bug previously mentioned only causes an issue when using `pluck`, so this controller is not affected.

Followup to a8ffc02d06
 2019-03-05 12:10:53 +00:00
David Taylor
8963f1af30
FEATURE: Optional detailed performance logging for Sidekiq jobs (#7091) 
By default, this does nothing. Two environment variables are available:

- `DISCOURSE_LOG_SIDEKIQ`

  Set to `"1"` to enable logging. This will log all completed jobs to `log/rails/sidekiq.log`, along with various db/redis/network statistics. This is useful to track down poorly performing jobs.

- `DISCOURSE_LOG_SIDEKIQ_INTERVAL`

  (seconds) Check running jobs periodically, and log their current duration. They will appear in the logs with `status:pending`. This is useful to track down jobs which take a long time, then crash sidekiq before completing.
 2019-03-05 11:19:11 +00:00
Kris
73e4204d20 UX: Image preview resizer style 2019-03-04 21:59:58 -05:00
Tarek Khalil
079b0f4bff
FIX: Remove ignore user feature from user-card-contents component (#7104) 
Based on our discussions, we want to have the `Ignore button will ONLY be on the User’s profile page`.
 2019-03-04 15:21:45 +00:00
Arpit Jalan
ad5f5b931d DEV: deprecate blank files for static modal pages 2019-03-04 15:05:33 +05:30
Joffrey JAFFEUX
2e881adb6e
FIX: select-kit perf and positioning improvements (#7093) 2019-03-04 10:30:22 +01:00
Joffrey JAFFEUX
dc4001370c
FEATURE: displays groups in menu search (#7090) 2019-03-04 10:30:09 +01:00
Joffrey JAFFEUX
075b264338
DEV: replaces DOMNodeInserted by the better MutationObserver (#6884) 2019-03-04 10:28:59 +01:00
Arpit Jalan
824d9402a4 FIX: pending counts were not shown on invites tab 2019-03-04 14:14:13 +05:30
Maja Komel
fea5d4f3ec FIX: any subcategory permissions are valid if everyone has access to parent category (#7097) 2019-03-04 14:49:26 +11:00
Joffrey JAFFEUX
bb39a6f7d7 REFACTOR: topic-list-header-column (#7099) 2019-03-04 14:45:52 +11:00
Arpit Jalan
01e2180548 FIX: /signup and /password-reset direct links were broken 2019-03-04 09:02:22 +05:30
Jeff Atwood
9585e2dff2 change separator from | to • for editor image sizing 2019-03-03 17:55:21 -08:00
Gerhard Schlager
14f9e55977 FIX: Error when filtering site settings 
Happened only when none of the logo settings had an image assigned.
 2019-03-03 20:43:22 +01:00
Dan Ungureanu
fd9671f7fe
DEV: Minor code improvements. 2019-03-02 19:07:54 +02:00
Sam
03a70ef69c FIX: allow underscore and dash in username search 
_ and - are technically punctuations, but we allow them in usernames so
accept them in search
 2019-03-01 15:23:45 +11:00
Sam
cdf34657f6 FEATURE: focus on composer TEXTAREA when iPad has a physical keyboard 
This disables a bunch of hacks that bypassed "focus" on iOS (cause focus
events that involve a virtual keyboard on iOS cause browser havoc unless
a physical keyboard is attached)

Also will focus on title on new topic
 2019-03-01 11:31:52 +11:00
Dan Ungureanu
6bc8382555 FEATURE: Use smooth scrolling for J/K keyboard shortcuts. (#7084) 2019-03-01 09:31:40 +11:00
Vinoth Kannan
be436066ff FIX: Prevent default event and stop bubbling up when card popup is closed in mobile 2019-03-01 01:42:17 +05:30
Penar Musaraj
64a3d63ddc DEV: Rename some icons with deprecated names 2019-02-28 13:03:14 -05:00
Maja Komel
612a0be085 FIX: don't add bottom padding for avatars in composer preview 2019-02-28 18:03:38 +01:00
David Taylor
e67474daf4 UX: Don't link to theme source unless it's http(s) 2019-02-28 17:01:59 +00:00
Joffrey JAFFEUX
1cd64f68f1
FIX: staff/admin shouldn’t be able to create uncategorized topics (#7077) 2019-02-28 15:51:13 +01:00
David Taylor
3517103398 UX: Correct locale key for theme compatibility error 2019-02-28 14:40:33 +00:00
Arpit Jalan
c02956e29c
FIX: when posts are moved to a message then small action post should not be publicly visible (#7085) 
This fix is inspired from what we do in discourse-assigned plugin.
https://github.com/discourse/discourse-assign/blob/master/lib/topic_assigner.rb#L184
https://github.com/discourse/discourse-assign/blob/master/assets/javascripts/discourse-assign/initializers/extend-for-assigns.js.es6#L125-L133
 2019-02-28 19:49:26 +05:30
Maja Komel
bb5119b88f FIX: only profile owner can see links to watched/tracked/muted topics (#7083) 2019-02-28 14:58:49 +01:00
Joffrey JAFFEUX
883a18547e
FIX: shows invite panel on mobile from topic footer buttons (#7080) 2019-02-28 14:56:22 +01:00
David Taylor
6296554ed1 DEV: Add additional hook for theme-creator 2019-02-28 10:48:30 +00:00
Vinoth Kannan
0cc636f648 UX: Don't add padding bottom for emojis in composer preview 2019-02-28 15:53:21 +05:30
Maja Komel
97c0fd0909 FIX: styling for resizable image wrapper in editor preview 2019-02-28 10:24:43 +01:00
Sam
06abecdb41 FEATURE: on iPad bluetooth keyboard use ALT-ENTER for post submit 
Command and Control can not be properly detected via JavaScript so lean on
Alt that can be detected.
 2019-02-28 16:41:31 +11:00
Sam
0b86a99c39 FEATURE: allow iPad users to specify they have a physical keyboard 
Sadly there is no clean way of detecting a keyboard is connected to an iPad

If the keyboard is connected we want to disable all the touch related hacks
on iOS

This allows iPad users to specify they have a keyboard connected. Setting
is per device.
 2019-02-28 15:59:44 +11:00
Kris
cafbb3aea7 UX: Use official Facebook logo 2019-02-27 09:52:06 -05:00
Tarek Khalil
986cc8a0fb FEATURE: Introduce Ignore user (#7072) 2019-02-27 14:49:07 +01:00
Joffrey JAFFEUX
5c476f639c
REFACTOR: user-invited-show (#7078) 2019-02-27 12:59:57 +01:00
Joffrey JAFFEUX
8ff3fc20a6
REFACTOR: tags-show (#7079) 2019-02-27 12:59:39 +01:00
Maja Komel
7d2ea2d4dd FEATURE: image resizing discoverability (#6804) 2019-02-27 11:46:16 +01:00
Dan Ungureanu
f68a7a16a4 FIX: Use field name to name files in theme export. (#7009) 2019-02-27 10:45:22 +01:00
Maja Komel
6f427589b2 FIX: make it possible to use backup code everywhere where 2FA required (#7010) 2019-02-27 10:37:33 +01:00
Erick Guan
e1d1073273 FIX: use * when apply italics in the editor instead of _ (#7063) 2019-02-27 10:36:14 +01:00
Régis Hanol
326d892f5e Aadd 'secondary_emails' field in users export 
FIX: escape_comma wasn't working in CSV exports
FIX: group_names field wasn't properly serialized
 2019-02-27 10:12:20 +01:00
Kris
ef9b249cd2 UX: More consistent table header styles, removing duplicate styles 2019-02-26 21:40:17 -05:00
Kris
1d4e9b08ad UX: Don't override unset flair color 2019-02-26 12:49:54 -05:00
Vinoth Kannan
59c66fd226
REFACTOR: Improve the readability of code (#7076) 2019-02-26 23:03:49 +05:30
Joffrey JAFFEUX
fbedaea5ed
FIX: prevents double network calls and other quirks on admin emails (#7074) 2019-02-26 17:53:52 +01:00
Davide Porrovecchio
75aaae5d5c FEATURE: Allow wildcard in allowed_user_api_auth_redirects setting (#6779) 2019-02-26 17:03:20 +01:00
Joffrey JAFFEUX
8c706b0ff7
fix tests (#7073) 2019-02-26 16:49:29 +01:00
Joffrey JAFFEUX
2a8da03951
FIX: prevents autocomplete from going over search input (#7075) 2019-02-26 15:48:02 +01:00
David Taylor
a8ffc02d06 PERF: Reduce N+1s on theme admin page 2019-02-26 14:22:02 +00:00
Joffrey JAFFEUX
d04c4bf8e7
UX: puts back share-panel as floating pane on post actions (#7066) 2019-02-26 14:15:25 +01:00
Arpit Jalan
6ea9f5c9c5 FIX: do not update tag name on /tags/intersection 2019-02-26 16:43:39 +05:30
Joffrey JAFFEUX
1cee8a86f6
fix prettier (#7071) 2019-02-26 11:24:02 +01:00
Joffrey JAFFEUX
7ccb0b882f
FIX: ensures topic’s category allows topics tags (#7060) 2019-02-26 11:21:55 +01:00
Joffrey JAFFEUX
a206c7f5d5
FIX: attempts to fix an error with EXTEND_PROTOTYPES (#7067) 2019-02-26 11:04:05 +01:00
Joffrey JAFFEUX
71360436ff
FIX: users list show was loading multiple times with different params (#7058) 
A first load was happening in route, which was setting properties on controller. These properties were observed on the controller and were triggering a reload of the AdminUser model.

Not only was it doing loading two times it was also sometimes resulting on the controller model refresh end to happen after route has been changed, resulting in a wrong model.
 2019-02-26 10:43:24 +01:00
Vinoth Kannan
ed0120171c FIX: Hide 'show associated accounts' button if moderators can't see emails 
And minor prettier code alignments
 2019-02-26 13:49:27 +05:30
Simon Cossar
c742d42031 FIX: rtl topic progress wrapper position (#7070) 
* Set left/right topic-progress-wrapper CSS from text-direction

* Remove unnecessary CSS rule
 2019-02-25 20:56:52 -05:00
Kris
d6875a77fb UX: Apply new-user color to full name and username 2019-02-25 17:09:41 -05:00
Kris
34d0cc6ad5 UX: Better alignment of similar topics in composer 2019-02-25 17:04:11 -05:00
Osama Sayegh
d5efe2d7ee UX: make composer resize work on touch devices (#7068) 
* UX: make composer resize work on touch devices

This also replaces a vendor dependency with a small built-in resize mechanism.

* Make blue bar's larger padding specific to touch devices
 2019-02-26 08:04:14 +11:00
Robin Ward
90c09d17b6 FIX: Heisentest - don't memoize on a class variable 
Repeated usage of the same class will have the same memoized results
even if the data has changed.
 2019-02-25 14:49:01 -05:00
Gerhard Schlager
dc961fecb9 FIX: Outgoing emails were not disabled after restoring backup 2019-02-25 16:07:24 +01:00
Joffrey JAFFEUX
5952a6c0ad
DEV: uses find() helper instead of this.$() in js tests (#7062) 2019-02-25 16:04:55 +01:00
Joffrey JAFFEUX
c0dd171cf1
REFACTOR: bread-crumbs (#7064) 2019-02-25 14:51:14 +01:00
Joffrey JAFFEUX
6930706830
REFACTOR: new message route (#7061) 2019-02-25 14:01:00 +01:00
Arpit Jalan
91e771ece6 FIX: send test email doesn't show a status 2019-02-25 17:42:58 +05:30
Joffrey JAFFEUX
900e187627
DEV: removing blank files (#7057) 2019-02-25 09:52:44 +01:00
Joffrey JAFFEUX
919839fd97
FIX: allows {{d-button}} to set a form attribute (#7056) 
This attribute is used when a submit button is out of a form. It makes it explicit which form this button is submitting.

It's currently used in our login modal form.
 2019-02-25 09:49:49 +01:00
Kris
2d031a1beb UX: Improve moderator icon alignment 2019-02-22 21:29:39 -05:00
Joffrey JAFFEUX
87f4ee13ef
UX: puts more emphasis on the shared url on share panel (#7055) 2019-02-22 23:22:11 +01:00
David Taylor
260398d706 FIX: Live refresh parent themes when editing child themes 2019-02-22 21:13:07 +00:00
Jeff Wong
8be7878656 FEATURE: add ability to clear previously set mobile_view with mobile_view=auto 2019-02-22 10:44:49 -08:00
Joffrey JAFFEUX
8aca26cce3
FIX: allows right-click on post-date sharing link (#7054) 2019-02-22 15:18:05 +01:00
Vinoth Kannan
d1bad881ea
FEATURE: Allow moderators to change topic timestamps (#7053) 2019-02-22 14:33:52 +05:30
Kris
87b5003453 UX: Increase width of hamburger menu to 320px 2019-02-21 21:52:21 -05:00
Kris
f44ef82b53 UX: Better wrapping of group header elements 2019-02-21 21:42:39 -05:00
Sam
667d3a3fd6 PERF: include content-length header for CDN 
Attempt to force NGINX to include content length when doing X-SendFile
This does not seem to be required when bypassing NGINX.

Without this header some CDNs may have issues caching
 2019-02-22 11:21:07 +11:00
Sam
31d41f532e PERF: do not include suggested topics when loading new posts 
When a new post is triggered via message bus post stream will attempt to load
it, previously the `/topic/TOPIC_ID/posts.json` would unconditionally include
suggested topics, this caused excessive load on the server.

New pattern defaults to exclude suggested and related topics from this API
unless people explicitly ask for suggested.
 2019-02-22 10:37:18 +11:00
Penar Musaraj
74ed72e825 DEV: Remove d-checkbox component 
Replaces the last occurrence of `d-checkbox` with a regular input element.

Includes a minor refactor of admin site text search.
 2019-02-21 09:54:54 -05:00
Guo Xiang Tan
1dee71d760 UX: Disabled lightbox expand button when loading image meta. 2019-02-21 22:30:57 +08:00
Gerhard Schlager
f8e498f6ad DEV: Fix random build error 2019-02-21 14:53:29 +01:00
Joffrey JAFFEUX
090acb5b11
FIX: s/isMessage/isPM (#7048) 
Regression due to refactoring
 2019-02-21 13:53:50 +01:00
Joffrey JAFFEUX
8d779db270
FIX: allows invite modal from topic-map post-actions (#7047) 2019-02-21 13:48:03 +01:00
Guo Xiang Tan
46e62c0d22
UX: Default user facing routes to /g instead of /groups. (#7042) 2019-02-21 13:44:25 +08:00
Sam
07b856700d REFACTOR: remove disallowEmails option from user-selector 
Negative option was leading to a fair amount of confusion, going forward
if we want to allow selection of emails from user selector it must be
supplied with `allowEmails=true`

This corrects a regression in 1f4ace4f which broke invite by emails and
start PM to email
 2019-02-21 16:37:26 +11:00
Sam
79841cf7dd FEATURE: add missing autocomplete suppressions 
Following 1f4ace4f add a couple more autocomplete suppressions (in polls
and invite ui)
 2019-02-21 16:37:26 +11:00
Guo Xiang Tan
d3cd314a98 Make eslint happy. 2019-02-21 10:26:56 +08:00
Guo Xiang Tan
58b0e945bd
UX: Lightbox support for image uploader. (#7034) 2019-02-21 10:13:37 +08:00
Régis Hanol
e3a23116d2
FIX: don't update gravatar if the user has no email 2019-02-20 22:34:43 +01:00
Penar Musaraj
cc1f9e7be6 Fix share button in post menu 2019-02-20 16:27:59 -05:00
Joffrey JAFFEUX
353eeef72a
fix prettier offense (#7041) 2019-02-20 22:22:38 +01:00
Penar Musaraj
cafe637407
UX: List popular themes and components in admin panel (#6997) 
Reorganizes theme create/upload flows into one install flow
Adds quick list of popular themes/components with one-click installation
 2019-02-20 14:58:31 -05:00
Penar Musaraj
4955ab1689 DEV: add replaceTagRenderer to pluginApi 2019-02-20 14:52:56 -05:00
Joffrey JAFFEUX
18296b4211
FIX: more reliable native sharing (#7039) 2019-02-20 20:43:48 +01:00
Joffrey JAFFEUX
9618300d69
s/share/nativeShare (#7038) 2019-02-20 20:03:30 +01:00
Joffrey JAFFEUX
994a09e5e8
FIX: stricter window.navigator.share check (#7037) 2019-02-20 19:40:51 +01:00
Joffrey JAFFEUX
2e0342dba7
UX: more spacing between social links (#7036) 2019-02-20 19:37:08 +01:00
Joffrey JAFFEUX
28c24631b8
FIX: ensures panel's shareUrl is not erased by topic's shareUrl (#7035) 2019-02-20 19:33:54 +01:00
Gerhard Schlager
66901f67f6 UX: Moderator post wasn't completely translatable 2019-02-20 16:37:47 +01:00
Joffrey JAFFEUX
04a63cfaaa
[WIP] FEATURE: merge share and invite actions together (#7021) 
This commit also:
- removes [+ New Topic] behaviour from share, this feature has been duplicated in composer actions, months ago
- introduces our new experimental spacing standard for css: eg: `s(2)`
- introduces a new panel UI for modals
 2019-02-20 15:42:44 +01:00
Gerhard Schlager
6a8007e5fb FEATURE: Improve handling of backup storage errors 2019-02-20 15:16:49 +01:00
Sam
33269c4172 FEATURE: do no search for groups unless a term is specified 
Do not allow `/u/search/users.json` to list any group matches unless a
specific `term` is specified in the API call.

Adding groups should always be done when an actual search term exists,
blank search is only supported for users within a topic
 2019-02-20 17:28:22 +11:00
Guo Xiang Tan
31ffa5f64e
UX: Allow users to see filename in image-uploader component. (#7022) 
https://meta.discourse.org/t/downsides-of-the-new-logo-ui-in-site-settings/102247/23?u=tgxworld
 2019-02-20 13:55:55 +08:00
Sam
1f4ace4f56 FEATURE: autocomplete usernames early in topic based on participation 
Following this change when a user hits `@` and is replying to a topic they
will see usernames of people who were last seen and participated in the topic

This is somewhat experimental, we may tweak this, or make it optional.

Also, a regression in a423a938 where hitting TAB would eat a post you were writing:

Eg this would eat a post:

``` text
@hello, testing 123 <tab>
```
 2019-02-20 13:34:43 +11:00
Sam
918a0ea3a4 FIX: use autocomplete="discourse" to disable Chrome address autofill 
https://stackoverflow.com/a/47822599/17174

Chrome 63 and up start ignoring `autofill="off"`

Per: https://bugs.chromium.org/p/chromium/issues/detail?id=468153#c164

> The tricky part here is that somewhere along the journey of the web autocomplete=off become a default for many form fields, without any real thought being given as to whether or not that was good for users. This doesn't mean there aren't very valid cases where you don't want the browser autofilling data (e.g. on CRM systems), but by and large, we see those as the minority cases. And as a result, we started ignoring autocomplete=off for Chrome Autofill data

So to work around this decision we now explicitly say: autocomplete="discourse"
when we don't want Chrome to randomly fill in addressed (aka. always)
 2019-02-20 10:15:59 +11:00
Jeff Wong
246997dbd9 FIX: an <a> with a target of _blank wants a new window 2019-02-19 14:44:30 -08:00
David Taylor
49e7073438 FIX: Hide advanced theme fields behind a flag, pending UI improvement 2019-02-19 22:25:00 +00:00
David Taylor
d08939ab05 FIX: Should be possible to save an empty theme_field in the editor 
Removing the theme_field JS object when the value was empty caused the server to maintain the previous value, making it impossible to delete the content of a field.
 2019-02-19 21:49:31 +00:00
Gerhard Schlager
5d75bd4831 FIX: Don't try to rename group when username is taken 
FIX: Always rename groups with the default locale instead of using the user's locale
 2019-02-19 22:31:03 +01:00
David Taylor
dbcf05d62c DEV: Code style improvements following review 
Followup to 05ee1d1aba
 2019-02-19 20:02:29 +00:00
David Taylor
7878e5007a
FIX: Refactor to prevent themes affecting core stylesheets (#7029) 
If a theme setting contained invalid SCSS, it would cause an error 500 on the site, with no way to recover. This commit stops loading theme settings in the core stylesheets, and instead only loads the color scheme variables. This change also makes `common/foundation/variables.scss` available to themes without an explicit import.
 2019-02-19 15:55:59 +00:00
Joffrey JAFFEUX
9ade04b709
FIX: removes legacy browsers-refresh button (#7028) 2019-02-19 16:38:21 +01:00
Gerhard Schlager
84c56e16f9 REFACTOR: Use keyword argument for fallback_to_english flag 2019-02-19 15:28:47 +01:00
David Taylor
05ee1d1aba
FEATURE: Added settings/translations support to theme editor UI (#7026) 
- These advanced fields are hidden behind an 'advanced' button, so will not affect normal use
- The editor has been refactored into a component, and styling cleaned up so menu items do not overlap on small screens
- Styling has been added to indicate which fields are in use for a theme
- Icons have been added to identify which fields have errors
 2019-02-19 12:56:01 +00:00
Joffrey JAFFEUX
0616837a5d
UX: moves wizard's "Finish" button to the left of back and next (#7027) 
This was done to avoid clicking finish when clicking fast on next.
 2019-02-19 13:32:01 +01:00
Joffrey JAFFEUX
8a4cd15e46
REFACTOR: topic model (#7020) 2019-02-19 10:13:46 +01:00
Joffrey JAFFEUX
15fd875855
REFACTOR: color-scheme-color model (#7019) 2019-02-19 09:31:26 +01:00
Joffrey JAFFEUX
cba0dd33ee
REFACTOR: admin-customize-color (#7018) 2019-02-19 09:31:11 +01:00
Joffrey JAFFEUX
2c6bf184bc
REFACTOR: admin-badge-preview (#7017) 2019-02-19 09:30:52 +01:00
Joffrey JAFFEUX
3bf61fca66
REFACTOR: admin-user-field-item (#7016) 2019-02-19 09:30:38 +01:00
Joffrey JAFFEUX
ee692414ce
REFACTORING: admin-edit-badge-groupings (#7015) 2019-02-19 09:30:24 +01:00
Vinoth Kannan
27e7f2bee0 DEV: call 'enqueue_hooks' method only if active webhooks exist 2019-02-19 12:43:08 +05:30
Vinoth Kannan
f2c3415548 FIX: Should not generate payload until active webhooks are exist 2019-02-19 12:23:42 +05:30
Kris
4f5aebc338 UX: reduce subcategory badge spacing 2019-02-18 19:04:36 -05:00
Arpit Jalan
50f833def0 fix the build 
JsPrettier on Sublime was failing because: https://github.com/jonlabelle/SublimeJsPrettier/issues/157#issuecomment-458175837
 2019-02-18 11:52:11 +05:30
Arpit Jalan
dc2776bcdd FIX: do not show "move to new PM" option to moderators 2019-02-18 11:35:00 +05:30
Jeff Atwood
052eaed16a lighten embed blockquote style for consistency 2019-02-17 21:00:46 -08:00
Jeff Atwood
dfba36fdca remove bgcolor from embed quotes for consistency 2019-02-17 20:57:27 -08:00
Guo Xiang Tan
7da7a30e02 PERF: Restore exists? in favor of blank?. 
Regression from dcd7b92532.
 2019-02-18 10:04:21 +08:00
David Taylor
f04471e422 REFACTOR: Proxy letter avatars in rails instead of nginx 
Co-authored-by: Sam Saffron <sam.saffron@gmail.com>
Co-authored-by: David Taylor <david@taylorhq.com>

This gives more control over the request. In particular we can easily
lookup DNS dynamically, instead of only upon NGINX startup.
Previously, NGINX was looking up IP for the letter avatar service and
caching the CDN IP address, this caused issues if CDN changed IP, in
which letter avatars would be broken till a container restarted.

NGINX config has been updated to add caching. This change will require
a container rebuild.

The proxy will now function in development environments, so the patch
for `letter_avatar_proxy` has been removed.
 2019-02-18 08:46:56 +11:00
Gerhard Schlager
b0862bd15d FIX: Push notifications could fail with UnauthorizedRegistration 
The webpush gem by default sets the expiration date of the JWT token to exactly 24 hours in the future. That's not really needed because the token isn't reused. And it might cause UnauthorizedRegistration if the server's clock isn't 100% correct, because the maximum allowed value is 24 hours.
 2019-02-15 21:12:09 +01:00
Gerhard Schlager
17f1a76570 FIX: Delete push subscription on MismatchSenderId error 
This should prevent repeated MismatchSenderId warnings when the VAPID keys have changed.
 2019-02-15 21:12:09 +01:00
peterlamber
159dd69fcb UX: make adding permissions more visible and intuitive to click. (#6999) 2019-02-15 12:01:10 -05:00
Arpit Jalan
99c6db21e6
FEATURE: allow blocking emojis (#7011) 
https://meta.discourse.org/t/blocking-emojis-wont-work/105853
 2019-02-15 20:55:48 +05:30
Dan Ungureanu
a423a9383f FIX: Stop autocomplete for invalid usernames. (#7005) 2019-02-15 11:29:26 +11:00
Sam
f8b70f4ca3 FIX: unable to create new categories 
Previous attempt at 70adb940 missed the critical "everyone" group from
staff, leading to a case where staff was no longer able to create categories
 2019-02-15 10:24:29 +11:00
Kris
3d11064a33 UX: Reduce font size on about pages 2019-02-14 11:01:17 -05:00
Bianca Nenciu
70adb94008 SECURITY: Do not leak private group names. (#7008) 2019-02-14 15:35:58 +01:00
Régis Hanol
fc14847c14 PERF: only require aws-sdk-sns gem when it's being used 2019-02-14 11:08:21 +01:00
Sam
ebd4140492 FIX: logspam due to 404s on CSS files 
We had a missing formats: string on our render partial that caused logs to
spam when CSS files got 404s.

Due to magic discourse_public_exceptions.rb was actually returning the
correct 404 cause it switched format when rendering the error.
 2019-02-14 17:58:16 +11:00
Maja Komel
39522659a6 FIX: validate parent category/subcategories permissions 
See: https://meta.discourse.org/t/subcategories-do-not-inherit-permissions-from-parent-category/17174/23 for more details

This ensures users with access to child category can always at least see parent
 2019-02-14 16:38:52 +11:00
Penar Musaraj
090e9c8432
FIX: make composer full screen shortcut work when inputs have focus (#6907) 
- Uses a Mousetrap plugin for global shortcuts
- Implemented for search `ctrl+alt+f` and composer fullscreen `shift+f11` shortcuts
 2019-02-14 00:19:27 -05:00
Saurabh Patel
ed6f4dfc40 FEATURE: trigger user profile create and update event (#6958) 
Adds `user_profile_created` DiscourseEvent on profile creation and `user_profile_updated` on profile update
 2019-02-14 15:45:12 +11:00
Arpit Jalan
b651605d6e FIX: tags added while editing a pending approval topic do not show up (#6959) 2019-02-14 15:42:40 +11:00
Kris
37666c3d18 UX: Signup form labels were too constrained, minor cleanup 2019-02-13 21:07:34 -05:00
Vinoth Kannan
484bd82278 FIX: Add onceoff job to remove double quotes from s3 etags 2019-02-14 05:19:41 +05:30
Régis Hanol
0476169692 make prettier happy 2019-02-13 22:16:38 +01:00
Régis Hanol
94fe0af900 FIX: upload emojis sequentially to prevent rate limit 2019-02-13 22:07:37 +01:00
Régis Hanol
4d674acc25 FEATURE: AWS SNS bounce notifications webhooks 2019-02-13 21:26:40 +01:00
Joffrey JAFFEUX
560cc4e73e
FIX: sets categoryId but do not scope when replying as new topic (#7002) 2019-02-13 15:19:58 +01:00
Joffrey JAFFEUX
fe4254b8f3
FIX: reverse consolidated pageviews stacked chart order (#7001) 2019-02-13 12:24:18 +01:00
Sam
641b079c78 FIX: add support for missing verbs in user api key 
Previously "write" scope was missing put and delete verbs which should be
allowed.

Also closes: #6982
 2019-02-13 15:49:43 +11:00
Jeff Wong
1328a127ee FIX: translate bootbox confirmation dialog (#6981) 2019-02-13 14:04:56 +11:00
Jeff Wong
467cfc9e08 FIX: remove extra periods (#6998) 
Periods are belong in the translation files not in our templates, if we have them in the templates sentences can not be localized properly.
 2019-02-13 12:54:34 +11:00
Joffrey JAFFEUX
47fe34d794 FEATURE: makes create-account userfields using dropdowns accessible (#6991) 2019-02-13 12:52:55 +11:00
Kris
3da35081e5 UX: Embedded post collapse button hover color fix 2019-02-12 17:21:33 -05:00
Robin Ward
c23411cc69 FIX: Heisentest - suspicious logins report was not ordered by date 
The specs needed an order even though none was supplied.
 2019-02-12 13:17:29 -05:00
David Taylor
86fe423f5e FIX: Clear the cache after destroying theme_fields 2019-02-12 16:39:40 +00:00
David Taylor
91f0468f4e FIX: Allow unbaked theme fields to be destroyed 
The after_commit hook was attempting to re-bake theme_fields after they were destroyed, which caused an exception to be thrown
 2019-02-12 16:14:43 +00:00
David Taylor
59640ef373 DEV: Add additional hooks for theme-creator plugin 2019-02-12 14:17:34 +00:00
Régis Hanol
b8b1759de9 UX: show envelope when tag is only used in PM 
UX: use regular envelope instead of solid envelope

REFACTOR: %s/enveloppe/envelope/g
 2019-02-12 11:34:25 +01:00