Kris
cbf8d85e6b
UX: improve activity column title data ( #23614 )
2023-09-25 15:53:16 -04:00
Jarek Radosz
5484030162
DEV: Use disableImplicitInjections more extensively ( #23579 )
2023-09-25 19:30:07 +02:00
Jarek Radosz
0fb2812414
DEV: Rescue another http error in qunit task ( #23651 )
...
Should take care of a flake issue. Also removes an extraneous `/` character in the used URL.
2023-09-25 19:27:49 +02:00
Bianca Nenciu
3700514819
DEV: Prefer nested queries ( #23464 )
...
Some sites have a large number of categories and fetching the category
IDs or category topic IDs just to build another query can take a long
time or resources (i.e. memory).
2023-09-25 19:38:54 +03:00
Renato Atilio
1cc2c8fcb6
UX: unhide experimental_form_templates ( #23615 )
...
* UX: unhide experimental_form_templates
* UX: add description to experimental_form_templates setting
2023-09-25 13:38:06 -03:00
David Taylor
af30536690
DEV: Allow PluginOutlets to 'wrap' a core implementation ( #23110 )
...
Our existing PluginOutlet system allows theme/plugin developers to easily insert new content into Discourse.
Another common requirement is to **replace** existing content in Discourse. Previously this could be achieved either using template overrides, or by introducing new content via a PluginOutlet and then hiding the old implementation with CSS. Neither of these patterns are ideal from a maintainability or performance standpoint.
This commit introduces a new mode for PluginOutlets. They can now be used to 'wrap' blocks of content in core. If a plugin/theme registers a connector for the outlet, then it will be rendered **instead of** the core implementation. If needed, outlets can use `{{yield}}` to render the core implementation inside their own implementation (e.g. to add a wrapper element).
In this 'wrapper' mode, only one connector can be registered for each outlet. If more than one is registered, only one will be used, and an error will be printed to the console.
To introduce a new PluginOutlet wrapper, this kind of thing can be added to a core template:
```hbs
<PluginOutlet @name="site-logo" @defaultGlimmer={{true}} @outletArgs={{hash title=title}}>
<h1>This is the default core implementation: {{title}}</h1>
</PluginOutlet>
```
A plugin/theme can then register a connector for the `site-logo` outlet:
```hbs
{{! connectors/site-logo/my-site-logo-override.hbs }}
<h2>This is the plugin implementation: {{@outletArgs.title}}</h2>
```
Care should be taken when introducing new wrapper PluginOutlets. We need to ensure that
1) They are properly sized. In general it's preferable for each outlet to wrap a small amount of core code, so that plugin/themes only need to re-implement what they want to change
2) The `@outletArgs` are carefully chosen. It may be tempting to pass through lots of core implementation into the outletArgs (or worse, use `this` to pass a reference to the wrapping component/controller). Doing this will significantly increase the API surface area, and make it hard to refactor core. Instead, we should aim to keep `@outletArgs` to a minimum, even if that means re-implementing some very simple things in themes/plugins.
2023-09-25 14:56:06 +01:00
David Taylor
88ec2320dc
UX: Only close modal for full 'click' events outside ( #23566 )
...
Previously we were using 'mouseup', which meant that if you started the click inside, and then dragged to outside the modal, it would still close. This kind of dragging action is common when selecting text, and having it close the modal can be very frustrating.
Simply switching to a 'click' listener doesn't totally solve the problem, because when a click event involves dragging from one element to another, the browser will fire the event on "the most specific ancestor element that contained both elements". For modals, the most specific common ancestor was still the `modal-middle-container`, which would cause the modal to close.
Therefore, this commit sets the modal containers to have `pointer-events: none`, and sets up the click listener on the `.modal-backdrop` element, which is **adjacent** to the modal in the DOM. That means that click events fired on any ancestors of the modal will not accidentally trigger closure.
2023-09-25 14:23:59 +01:00
David Taylor
6ad810c991
DEV: Install ember-route-template ( #23532 )
...
This will allow us to use `<template>` for route templates. For more details, see the README at https://github.com/discourse/ember-route-template
2023-09-25 14:14:24 +01:00
Jarek Radosz
837cec6c3d
DEV: Consistently call setupTest(hooks) in unit tests ( #23610 )
2023-09-25 12:43:41 +02:00
Joffrey JAFFEUX
92839dc722
FIX: ensures an empty last message won't cause errors ( #23647 )
...
This would cause an error when deleting the original message of a thread, due to the non existing `last_message`. This fix is implemented using the null pattern.
Note this commit is also using this opportunity to unify naming of null objects, `Chat::DeletedUser` becomes `Chat::NullUser`, it feels better to have a name describing what is the object, instead of a name describing why this object has to be used, which can change depending on cases.
2023-09-25 12:43:04 +02:00
dependabot[bot]
da1f1a92dd
Build(deps-dev): Bump terser in /app/assets/javascripts ( #23631 )
...
Bumps [terser](https://github.com/terser/terser ) from 5.19.4 to 5.20.0.
- [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md )
- [Commits](https://github.com/terser/terser/compare/v5.19.4...v5.20.0 )
---
updated-dependencies:
- dependency-name: terser
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-09-25 12:36:33 +02:00
dependabot[bot]
48f8bc6280
Build(deps): Bump net-smtp from 0.3.3 to 0.4.0 ( #23632 )
...
Bumps [net-smtp](https://github.com/ruby/net-smtp ) from 0.3.3 to 0.4.0.
- [Release notes](https://github.com/ruby/net-smtp/releases )
- [Changelog](https://github.com/ruby/net-smtp/blob/master/NEWS.md )
- [Commits](https://github.com/ruby/net-smtp/compare/v0.3.3...v0.4.0 )
---
updated-dependencies:
- dependency-name: net-smtp
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-09-25 12:35:55 +02:00
dependabot[bot]
3f3e1f6278
Build(deps-dev): Bump rubocop-rspec from 2.24.0 to 2.24.1 ( #23644 )
...
Bumps [rubocop-rspec](https://github.com/rubocop/rubocop-rspec ) from 2.24.0 to 2.24.1.
- [Release notes](https://github.com/rubocop/rubocop-rspec/releases )
- [Changelog](https://github.com/rubocop/rubocop-rspec/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop-rspec/compare/v2.24.0...v2.24.1 )
---
updated-dependencies:
- dependency-name: rubocop-rspec
dependency-type: indirect
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-09-25 12:34:17 +02:00
dependabot[bot]
05eab9f99b
Build(deps-dev): Bump rubocop-factory_bot from 2.23.1 to 2.24.0 ( #23626 )
...
Bumps [rubocop-factory_bot](https://github.com/rubocop/rubocop-factory_bot ) from 2.23.1 to 2.24.0.
- [Release notes](https://github.com/rubocop/rubocop-factory_bot/releases )
- [Changelog](https://github.com/rubocop/rubocop-factory_bot/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop-factory_bot/compare/v2.23.1...v2.24.0 )
---
updated-dependencies:
- dependency-name: rubocop-factory_bot
dependency-type: indirect
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-09-25 12:33:53 +02:00
Ted Johansson
c42257b47d
DEV: Prettify negative numbers in reviewable score explanation ( #23642 )
...
This is an aesthetic change. Currently, if one of the scores involved in the reviewable score explanation is negative, we display it as: + -value. This changes that.
I also made an attempt at converting the component into GJS format. This is done as a separate commit.
2023-09-25 10:34:51 +01:00
dependabot[bot]
efce57e23d
Build(deps-dev): Bump the babel group ( #23622 )
...
Bumps the babel group in /app/assets/javascripts with 2 updates: [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core ) and [@babel/standalone](https://github.com/babel/babel/tree/HEAD/packages/babel-standalone ).
Updates `@babel/core` from 7.22.19 to 7.22.20
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.22.20/packages/babel-core )
Updates `@babel/standalone` from 7.22.19 to 7.22.20
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.22.20/packages/babel-standalone )
---
updated-dependencies:
- dependency-name: "@babel/core"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: babel
- dependency-name: "@babel/standalone"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: babel
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-09-25 10:21:55 +02:00
dependabot[bot]
15b57a57a3
Build(deps): Bump puma from 6.3.1 to 6.4.0 ( #23635 )
...
Bumps [puma](https://github.com/puma/puma ) from 6.3.1 to 6.4.0.
- [Release notes](https://github.com/puma/puma/releases )
- [Changelog](https://github.com/puma/puma/blob/master/History.md )
- [Commits](https://github.com/puma/puma/compare/v6.3.1...v6.4.0 )
---
updated-dependencies:
- dependency-name: puma
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-09-25 10:20:29 +02:00
dependabot[bot]
9ce021d234
Build(deps): Bump execjs from 2.9.0 to 2.9.1 ( #23621 )
...
Bumps [execjs](https://github.com/rails/execjs ) from 2.9.0 to 2.9.1.
- [Release notes](https://github.com/rails/execjs/releases )
- [Commits](https://github.com/rails/execjs/compare/v2.9.0...v2.9.1 )
---
updated-dependencies:
- dependency-name: execjs
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-09-25 10:17:43 +02:00
dependabot[bot]
2f0133e4a4
Build(deps): Bump ffi from 1.15.5 to 1.16.1 ( #23643 )
...
Bumps [ffi](https://github.com/ffi/ffi ) from 1.15.5 to 1.16.1.
- [Changelog](https://github.com/ffi/ffi/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ffi/ffi/compare/v1.15.5...v1.16.1 )
---
updated-dependencies:
- dependency-name: ffi
dependency-type: indirect
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-09-25 10:16:50 +02:00
dependabot[bot]
1f1adf7446
Build(deps): Bump openssl from 3.1.0 to 3.2.0 ( #23636 )
...
Bumps [openssl](https://github.com/ruby/openssl ) from 3.1.0 to 3.2.0.
- [Release notes](https://github.com/ruby/openssl/releases )
- [Changelog](https://github.com/ruby/openssl/blob/master/History.md )
- [Commits](https://github.com/ruby/openssl/compare/v3.1.0...v3.2.0 )
---
updated-dependencies:
- dependency-name: openssl
dependency-type: indirect
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-09-25 10:16:13 +02:00
dependabot[bot]
3c6742e8c2
Build(deps-dev): Bump rubocop-capybara from 2.18.0 to 2.19.0 ( #23629 )
...
Bumps [rubocop-capybara](https://github.com/rubocop/rubocop-capybara ) from 2.18.0 to 2.19.0.
- [Release notes](https://github.com/rubocop/rubocop-capybara/releases )
- [Changelog](https://github.com/rubocop/rubocop-capybara/blob/main/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop-capybara/compare/v2.18.0...v2.19.0 )
---
updated-dependencies:
- dependency-name: rubocop-capybara
dependency-type: indirect
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-09-25 10:15:32 +02:00
dependabot[bot]
89d5204aad
Build(deps-dev): Bump websocket from 1.2.9 to 1.2.10 ( #23630 )
...
Bumps [websocket](https://github.com/imanel/websocket-ruby ) from 1.2.9 to 1.2.10.
- [Release notes](https://github.com/imanel/websocket-ruby/releases )
- [Changelog](https://github.com/imanel/websocket-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/imanel/websocket-ruby/compare/v1.2.9...v1.2.10 )
---
updated-dependencies:
- dependency-name: websocket
dependency-type: indirect
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-09-25 10:15:02 +02:00
dependabot[bot]
8c0639a8fb
Build(deps-dev): Bump qunit in /app/assets/javascripts ( #23645 )
...
Bumps [qunit](https://github.com/qunitjs/qunit ) from 2.19.4 to 2.20.0.
- [Release notes](https://github.com/qunitjs/qunit/releases )
- [Changelog](https://github.com/qunitjs/qunit/blob/main/History.md )
- [Commits](https://github.com/qunitjs/qunit/compare/2.19.4...2.20.0 )
---
updated-dependencies:
- dependency-name: qunit
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-09-25 10:14:21 +02:00
dependabot[bot]
f4b0a48952
Build(deps-dev): Bump eslint in /app/assets/javascripts ( #23646 )
...
Bumps [eslint](https://github.com/eslint/eslint ) from 8.49.0 to 8.50.0.
- [Release notes](https://github.com/eslint/eslint/releases )
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md )
- [Commits](https://github.com/eslint/eslint/compare/v8.49.0...v8.50.0 )
---
updated-dependencies:
- dependency-name: eslint
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-09-25 10:13:52 +02:00
Ted Johansson
950357391a
DEV: Remove deprecated PostAction.act method ( #23641 )
...
The PostAction.act class method was deprecated four years ago and marked for removal in 2.9.0. This PR removes it.
2023-09-24 08:16:32 +01:00
Osama Sayegh
83621ccbe7
FIX: Parse the digest_suppress_tags setting correctly ( #23623 )
...
Meta topic: https://meta.discourse.org/t/suppress-these-tags-from-summary-emails-settings-is-not-working-in-preview-digest-email/279196?u=osama
Follow-up to 477a5dd371
2023-09-18 10:45:43 +03:00
David Taylor
2791e75072
FEATURE: Link chat notifications directly to message ( #23617 )
...
- Updates `Chat::Message#url` to work in threads and for subfolder
- Updates Jobs::Chat::NotifyWatching to use message URL instead of channel url
2023-09-16 20:37:35 +01:00
Kris
ebe68e15fc
UX: fix "More" menu at small tablet width ( #23616 )
2023-09-15 17:21:24 -04:00
Renato Atilio
d93c2cb3d2
FEATURE: site settings to revoke api keys older than a number of days ( #23595 )
...
* FEATURE: site settings to revoke api keys older than a number of days
2023-09-15 16:31:29 -03:00
Joffrey JAFFEUX
c8fff19b99
DEV: removes the notion of staged thread ( #23612 )
...
While very fast and powerful staged threads forces a lot of gymnastic and edge cases. This patch adds a new service `Chat::CreateThread` and uses it to create a thread unconditionally when a user replies to a message in a threading enabled channel. If the user actually doesn’t send a message we will have a thread with no messages which has no important impact and could even be periodically cleaned if necessary.
Note that this commit also moves message actions to .gjs as it was the original goal of this PR to correctly check for staged thread to show the menu or not.
2023-09-15 18:09:45 +02:00
Kris
1d14474e1d
A11Y: "more" nav link should use aria-expanded ( #23613 )
2023-09-15 11:27:02 -04:00
Renato Atilio
aa9510a731
FIX: use the destination_url cookie as return_path if present ( #23594 )
2023-09-15 12:11:03 -03:00
chapoi
8823b5e504
UX: fix overflow channel row + mobile remove styling tweak ( #23611 )
...
* UX: fix missing overflow ellipsis
* cleanup double declaration
* UX: add missing border-radius
*UX: delete icon animation tweak
2023-09-15 14:06:31 +02:00
Ted Johansson
68c891609b
FIX: Add back missing 'delete spammer' flag option ( #23605 )
2023-09-15 17:21:03 +08:00
David Battersby
e6c97ffece
FIX: message date is incorrect when replying as new thread ( #23608 )
...
When creating a new thread by clicking the reply button on a chat message, it shows an invalid date on the OP timestamp.
2023-09-15 16:22:49 +08:00
chapoi
02de223da8
UX: chat-channel-row alignment ( #23607 )
2023-09-15 10:09:50 +02:00
Alan Guo Xiang Tan
9b5ab7a764
DEV: Allow Capybara's server port to be configurable ( #23606 )
...
Why this change?
This allows scripts to configure the server port and avoid hardcoding
the default port that is used in Discourse core.
2023-09-15 11:46:03 +08:00
Canapin
bbad09df0e
UX: creates a vertical space between the title and the back link ( #23558 )
...
The link was to close to the title, there was no vertical space. Adding a space make elements spacing more even on the page.
2023-09-15 12:16:23 +10:00
Jarek Radosz
d811e96fa9
Revert "Build(deps): Bump sass-embedded from 1.66.1 to 1.67.0 ( #23599 )" ( #23604 )
...
This reverts commit de32dfb780
2023-09-15 01:21:39 +02:00
dependabot[bot]
89baf98143
Build(deps): Bump sanitize from 6.0.2 to 6.1.0 ( #23601 )
...
Bumps [sanitize](https://github.com/rgrove/sanitize ) from 6.0.2 to 6.1.0.
- [Release notes](https://github.com/rgrove/sanitize/releases )
- [Changelog](https://github.com/rgrove/sanitize/blob/main/HISTORY.md )
- [Commits](https://github.com/rgrove/sanitize/compare/v6.0.2...v6.1.0 )
---
updated-dependencies:
- dependency-name: sanitize
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-09-15 01:04:59 +02:00
dependabot[bot]
f60c01b7e4
Build(deps-dev): Bump the babel group ( #23602 )
...
Bumps the babel group in /app/assets/javascripts with 2 updates: [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core ) and [@babel/standalone](https://github.com/babel/babel/tree/HEAD/packages/babel-standalone ).
Updates `@babel/core` from 7.22.17 to 7.22.19
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.22.19/packages/babel-core )
Updates `@babel/standalone` from 7.22.17 to 7.22.19
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.22.19/packages/babel-standalone )
---
updated-dependencies:
- dependency-name: "@babel/core"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: babel
- dependency-name: "@babel/standalone"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: babel
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-09-15 01:00:18 +02:00
Jarek Radosz
8cb8f130d9
DEV: Convert request-group-membership-form to new modal api ( #23600 )
2023-09-15 00:39:52 +02:00
dependabot[bot]
ab8915afe0
Build(deps): Bump tilt from 2.2.0 to 2.3.0 ( #23598 )
...
Bumps [tilt](https://github.com/jeremyevans/tilt ) from 2.2.0 to 2.3.0.
- [Changelog](https://github.com/jeremyevans/tilt/blob/master/CHANGELOG.md )
- [Commits](https://github.com/jeremyevans/tilt/compare/v2.2.0...v2.3.0 )
---
updated-dependencies:
- dependency-name: tilt
dependency-type: indirect
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-09-15 00:22:48 +02:00
dependabot[bot]
de32dfb780
Build(deps): Bump sass-embedded from 1.66.1 to 1.67.0 ( #23599 )
...
Bumps [sass-embedded](https://github.com/ntkme/sass-embedded-host-ruby ) from 1.66.1 to 1.67.0.
- [Commits](https://github.com/ntkme/sass-embedded-host-ruby/compare/v1.66.1...v1.67.0 )
---
updated-dependencies:
- dependency-name: sass-embedded
dependency-type: indirect
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-09-15 00:22:40 +02:00
Kris
98c8dcecba
A11Y: disable non-essential CSS animations for reduced-motion users ( #23571 )
2023-09-14 17:31:43 -04:00
Jarek Radosz
4a1621c677
DEV: Use the Store to create User records ( #23584 )
2023-09-14 23:26:51 +02:00
Jarek Radosz
c75b379d6f
DEV: Future-proof htmlSafe interactions ( #23596 )
...
See https://github.com/discourse/discourse-encrypt/pull/282
> `cooked` was an Ember SafeString. The internal storage of the string changed from `.string` to `.__string` at some point between Ember 3.28 and Ember 5. Instead, we can use `toString()` which is guaranteed to work in all situations
2023-09-14 23:04:57 +02:00
Jarek Radosz
ed8d0656f9
DEV: Convert tag-upload to the new modal API ( #23590 )
2023-09-14 21:32:45 +02:00
Kris
e1c3b14b1a
A11Y: Activate user menu tab on keydown too ( #23593 )
2023-09-14 14:07:35 -04:00
Joffrey JAFFEUX
ae27beb01a
UI: improves remove channel animation ( #23585 )
...
Co-authored-by: chapoi <101828855+chapoi@users.noreply.github.com>
2023-09-14 18:48:29 +02:00
