github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-28 13:14:04 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
30,309 Commits 214 Branches 500 Tags 960 MiB
467be59d75
Commit Graph

12169 Commits

Author SHA1 Message Date
Guto Foletto
0abc932056 add styles so permalinks admin could fit mobile screen (#6496) 2018-10-17 17:37:14 +02:00
Bianca Nenciu
f60b10d090 UX: Warn users if the post that's currently edited has changed. (#6498) 2018-10-17 15:35:32 +02:00
David Taylor
065bf0762c FEATURE: New plugin outlets for user card customization 2018-10-17 14:15:48 +01:00
Joe
1b5ba899a1
UX: header items wrap on small screens for anon 2018-10-17 14:19:20 +08:00
Joe
5815a33a9a
FIX: closing an empty fullscreen composer with toggler prevents scrolling 2018-10-17 13:52:47 +08:00
Kris
b23ebf10c2 Minor post alignment fixes 2018-10-16 12:39:55 -04:00
Vinoth Kannan
e3c6dd26c4 FIX: Do not set null value to remove cookie 2018-10-16 06:48:54 +05:30
Vinoth Kannan
08c404e138 FIX: Do not set null value to remove cookie 2018-10-16 06:12:32 +05:30
Maja Komel
c104256991 FIX: SSO provider secrets - check wildcard domains last, toggle secrets visibility 2018-10-15 16:18:29 +02:00
David Taylor
7ac08f936e
FEATURE: Upload tags from CSV (#6484) 2018-10-15 09:12:54 +01:00
Maja Komel
27e732a58d FEATURE: allow multiple secrets for Discourse SSO provider 
This splits off the logic between SSO keys used incoming vs outgoing, it allows to far better restrict who is allowed to log in using a site.

This allows for better auditing of the SSO provider feature
 2018-10-15 16:03:53 +11:00
Joe
2acb885c72 FEATURE: fullscreen composer mode on desktop 
Adds keyboard shortcut and icon that allows expanding composer to full screen.
 2018-10-15 13:59:49 +11:00
Maja Komel
57b52cd1de FIX: keep emoji syntax for custom emojis in quotes (#6488) 2018-10-15 10:57:15 +08:00
Guo Xiang Tan
84d4c81a26 FEATURE: Support backup uploads/downloads directly to/from S3. 
This reverts commit 3c59106bac.
 2018-10-15 09:43:31 +08:00
Joe
6a59187ae8
UX: images should be responsive in embedded comments 2018-10-14 23:38:07 +08:00
Robin Ward
2178f7768f FIX: Don't show empty user stats in the card when profile is hidden 2018-10-12 12:33:27 -04:00
Bianca Nenciu
e68ecf1f1d UX: Add link to Groups in admin dashboard. (#6480) 
* UX: Add link to Groups in admin dashboard.

* UX: Site settings have immediate effect.
 2018-10-12 10:34:47 +11:00
Bianca Nenciu
ded5ff90aa FIX: Groups list does not refresh when query changes. (#6481) 2018-10-11 21:20:17 +08:00
David Taylor
1b0fbc4d30 FIX: Allow theme edit route name to be overridden 
This is required for the theme-creator plugin, this change won't have
any effect on regular Discourse installations
 2018-10-11 13:20:04 +01:00
Bianca Nenciu
f1a52138d6 UX: Move Recently Used Devices to the bottom. (#6483) 2018-10-11 19:22:30 +08:00
Jeff Wong
b5b382dcd6 Feature: add boxes with subcategories option for desktop categories page (#6471) 
* Feature: add boxes with subcategories option for desktop categories page

* only add subclass div when subclasses exist
 2018-10-11 15:59:37 +08:00
Bianca Nenciu
6275e745a7 FIX: Fix open quote links in new window. (#6477) 2018-10-11 15:51:14 +08:00
Guo Xiang Tan
3c59106bac Revert "FEATURE: Support backup uploads/downloads directly to/from S3." 
This reverts commit c29a4dddc1.

We're doing a beta bump soon so un-revert this after that is done.
 2018-10-11 11:08:23 +08:00
Gerhard Schlager
c29a4dddc1 FEATURE: Support backup uploads/downloads directly to/from S3. 2018-10-11 10:38:43 +08:00
Kyle Zhao
ffc241eb25
FIX: multiple loadScript to the same url may resolve prematurely (#6474) 
This is how `loadScript(url)` currently deals with multiple concurrent requests

1. Check existing `<script>` tags, and mark existing scripts (other than the 
   input `url`) as loaded
2. Find "true" `url` of the requested resource (CDN, subfolder path, etc)
3. Check if we have loaded the resource with that "true" `url`, and resolve 
   immediately if we have
4. Otherwise insert a `<script>` tag with the "true" `url` to load it

For example, in a subfolder install:

- Input `url` = `/javascripts/script.js`
- "True" `url` = `/subfolder/javascript/script.js`

And the _very_ subtle bug here is that we should use also use the true `url` 
for step (1), because:

- Since the input and true `url` are different, we mistakenly mark the true 
  `url` as loaded in step one 
- After finding the true `url`, and setting `loaded[trueUrl] = true` in (1), we
  resolve the promise prematurely, when the resource could still be loading
 2018-10-11 08:55:36 +08:00
Robin Ward
a566ed42ae FEATURE: Option to disable user presence and profile 
This allows users who are privacy conscious to disable the presence
features of the forum as well as their public profile.
 2018-10-10 17:34:33 -04:00
Kris
34e8d17ad0 Fixing left alignment of post controls 2018-10-10 12:11:47 -04:00
David Taylor
98211f945f FIX: 'none' tag page would not load 2018-10-10 16:00:33 +01:00
Kris
94b115f7d9 increase contrast for $danger-medium on dark themes 2018-10-10 09:51:50 -04:00
Arpit Jalan
c84415b1f2 FEATURE: support category slug when creating new topic via URL 2018-10-10 17:06:02 +05:30
Penar Musaraj
0ea8c1943f Let plugins decorate banner topic, fixes local dates in banners (#6452) 2018-10-10 17:27:23 +08:00
Kris
1f14fb5e1e Don't override category badge icon color in similar topic JIT 2018-10-09 15:38:49 -04:00
Bianca Nenciu
1d26a473e7 FEATURE: Show "Recently used devices" in user preferences (#6335) 
* FEATURE: Added MaxMindDb to resolve IP information.

* FEATURE: Added browser detection based on user agent.

* FEATURE: Added recently used devices in user preferences.

* DEV: Added acceptance test for recently used devices.

* UX: Do not show 'Show more' button if there aren't more tokens.

* DEV: Fix unit tests.

* DEV: Make changes after code review.

* Add more detailed unit tests.

* Improve logging messages.

* Minor coding style fixes.

* DEV: Use DropdownSelectBoxComponent and run Prettier.

* DEV: Fix unit tests.
 2018-10-09 22:21:41 +08:00
Erin Kosewic
51aba32651 FEATURE: add branch option to remote theme import 
* FEATURE: add branch option to remote theme import

* FIX: Add missing variable in params

* FIX: Add missing param for import_theme method

* SPEC: Add test methods for branch support in git import

* FIX: Add missing space to scss style

* Do not assume default branch as master

* Change branch field placeholder

* FIX: add missing div start tag
 2018-10-09 17:01:08 +11:00
Kyle Zhao
acba7d2a5d Extract discourse_javascript.html.erb to a scrip include 
* extract omniauth auth complete inline JS

* extract Ember error logging inline JS

* transpile `authentication-complete`

This is CSP related work
 2018-10-09 16:50:45 +11:00
Kyle Zhao
8b2a379e4e
DEV: transpile certain ES6 files without producing a module (#6460) 
`.js.no-module.es6` files will be transpiled without producing a module.

import/export statements are deliberately not supported, so one would still need to use 
`const module = require('moduleName').default.`
 2018-10-09 09:18:23 +08:00
Kris
c889c0daee Only prevent checkbox/radio from flex-grow 2018-10-08 13:10:51 -04:00
Gerhard Schlager
97ad9e9d9b UX: Prompt for custom invite message was hard to translate 2018-10-08 18:01:21 +02:00
Kris
ec33b46d31 IE11 doesn't support nested calc 2018-10-08 11:55:54 -04:00
Joffrey JAFFEUX
da8916aecd
FIX: adds a title attribute on value list input (#6463) 2018-10-08 12:08:36 +02:00
Guo Xiang Tan
3c0ec317ac DEV: Fix wizard qunit tests not running. 2018-10-08 14:45:56 +08:00
Guo Xiang Tan
43512e9865
Merge pull request #6457 from pmusaraj/yarn-manage-test-vendor-dependencies 
DEV: Use Yarn managed test vendor dependencies
 2018-10-08 09:26:26 +08:00
Kris
41ceb6ca88 topic body and small action widths inconsistent 2018-10-05 18:37:23 -04:00
David Taylor
cbb8f6f0fe UX: Use 'trash' icon instead of 'times' for deleting small actions 2018-10-05 22:31:56 +01:00
Kris
0a1ac88f2c last visit line needs more contrast 2018-10-05 15:28:10 -04:00
Kris
fa21b39875 FIX: topic admin menu was clipped on short posts due to overflow hidden 2018-10-05 10:51:27 -04:00
Penar Musaraj
be56f18cdd
Replace deprecated dropdown-button with DropdownSelectBoxComponent (#6451) 2018-10-05 09:48:17 -04:00
David Taylor
75488257c5 FIX: Redirect users to top when latest is the homepage 2018-10-05 12:14:57 +01:00
David Taylor
9bf522f227
FEATURE: Mixed case tagging (#6454) 
- By default, behaviour is not changed: tags are made lowercase upon creation and edit.

- If force_lowercase_tags is disabled, then mixed case tags are allowed.

- Tags must remain case-insensitively unique. This is enforced by ActiveRecord and Postgres.

- A migration is added to provide a `UNIQUE` index on `lower(name)`. Migration includes a safety to correct any current tags that do not meet the criteria.

- A `where_name` scope is added to `models/tag.rb`, to allow easy case-insensitive lookups. This is used instead of `Tag.where(name: "blah")`.

- URLs remain lowercase. Mixed case URLs are functional, but have the lowercase equivalent as the canonical.
 2018-10-05 10:23:52 +01:00
Kris
948c556cc6 decrease contrast on danger-low color 2018-10-04 17:30:10 -04:00
Kris
98b9913033 UX: Disable button hover effects on touch devices 2018-10-04 17:15:37 -04:00
Kris
ab1e5732d7 UX: Category colorpicker restyle 2018-10-04 15:47:46 -04:00
Penar Musaraj
4ae9cb28e4 remove probes.js, highlight.pack.js 2018-10-04 13:50:54 -04:00
Kris
2e28116243 Period-chooser should have visible overflow 2018-10-04 12:28:48 -04:00
Kris
09caf95e7d create account inputs too wide on iOS 2018-10-04 12:02:28 -04:00
Kris
8e0fe32f37 Minor login layout fixes 2018-10-04 11:54:51 -04:00
David Taylor
3c2608d41c
FIX: Correctly censor strings starting or ending with non-word characters (#6445) 2018-10-04 15:15:10 +01:00
Bianca Nenciu
6ad13e5ae9 FIX: Avoid redirection when not leaving forum. (#6419) 
* FIX: Avoid redirection when not leaving forum.

* DEV: Updated click-track's tests.
 2018-10-04 22:06:31 +08:00
Kris
ff47609141 UX: Improve custom field layout on signup 2018-10-03 22:26:05 -04:00
Vinoth Kannan
a651d39b8a
FIX: Display errors in single theme pages (#6449) 
Currently the errors are not well handled. So it breaks the whole UI of admin themes list page.
 2018-10-04 02:33:06 +05:30
Penar Musaraj
b5bdd42838 Progress bar CSS refactoring (#6444) 
* Less magic in calculating topic progress bar

* more minor adjustments to topic progress CSS

* Bounce back button again

* Fix prettier warning
 2018-10-03 13:21:57 -04:00
Kris
46563082a9 FIX: Move overflow from cooked to parent element to allow for slight overflow of blur/italic/shadow 2018-10-03 10:18:36 -04:00
Penar Musaraj
dc8a16b43b
Use Yarn to manage dependencies, cleanup unused bootstrap libs (#6436) 2018-10-03 10:15:43 -04:00
Vinoth Kannan
23b4ab9bf9 DEV: Do not use concatenation in translations 2018-10-03 11:59:21 +05:30
Vinoth Kannan
2912170e9e Update placeholder github url in correct format 2018-10-03 11:14:36 +05:30
Maja Komel
73443d889c FIX: keep files in order when adding multiple uploads (#6306) 
* FIX: keep files in order when adding multiple uploads

* use filename in the placeholder when uploading files

* add tests

* add consecutive nr to the placeholder when multiple uploads with the same filename
 2018-10-03 11:12:36 +10:00
Kris
07be8e5447 caret icon is redundant on hamburger menu button 2018-10-02 15:06:50 -04:00
Neil Lalonde
dc1e7bb645 UX: when admin is deleted, make it clear in staff action logs when records belong to a deleted user and show their username in the details 2018-10-02 13:46:54 -04:00
Penar Musaraj
98aaad6675 Improve "hit area" for topic progress bar on mobile (#6442) 
* Improve "hit area" for topic progress bar on mobile

* Only target admin wrench on mobile
 2018-10-02 12:26:16 -04:00
Kris
7228c4964c Flag reason "something else" fix 2018-10-02 12:05:21 -04:00
Kris
324b57c207 Prevent flexbox from shrinking inputs 2018-10-02 10:42:49 -04:00
Gerhard Schlager
7fe17e93e2 UX: Label of checkbox site setting needs a span for nested HTML 2018-10-02 16:25:05 +02:00
Jeff Atwood
40d0fc9259 UX: slightly taller progress bar for mobile 2018-10-02 03:21:08 -07:00
Joffrey JAFFEUX
f34d9202b4
UX: makes reports fade in when loading is done (#6440) 2018-10-02 09:20:04 +02:00
Kyle Zhao
7591da1e64 FIX: s3BaseUrl with small s 2018-10-02 13:06:33 +08:00
Bianca Nenciu
719a433c03 FIX: Sync client & server rules regarding tag names. (#6400) 2018-10-01 21:45:44 -07:00
Kyle Zhao
d9bea66365 UX: confirmation before changing group membership in admin (#6426) 2018-10-01 21:34:08 -07:00
Kyle Zhao
ab448ca8f3 extract client side Discourse setup inline JS (#6409) 2018-10-01 21:29:04 -07:00
Sam
580c923ff3 UX: remove flex basis from first item 
We do not want to take up 100% width for name/username on first line
 2018-10-02 13:16:51 +10:00
Sam
120c220c18 UX: correct ordering of username / fullname in UX 2018-10-02 12:56:50 +10:00
Penar Musaraj
533315a607 Fix progress bar position when theme has header elements outside #main (#6425) 2018-10-02 10:45:23 +10:00
Kris
42066e407d UX: updating style of mobile navigation dropdown 2018-10-01 14:49:00 -04:00
Kris
eeffac3186 label needs a span to contain nested HTML in description 2018-10-01 13:42:35 -04:00
Kris
1897155479 prettier 2018-10-01 11:59:21 -04:00
Kris
eca671b972 Prevent category dropdowns from cropping text, simplify styles 2018-10-01 11:53:18 -04:00
Maja Komel
1add11d8c9 FIX: don't send multiple requests when changing category notification (#6435) 2018-10-01 23:41:23 +08:00
Kris
fc4a6ca724 Prevent adming setting input from being too small in Safari 2018-10-01 10:39:55 -04:00
Prssanna Desai
8bb0bca808 UX: Improve spacing & alignment for Category edit modal (#6432) 2018-10-01 10:21:40 -04:00
Prssanna Desai
f1bc1780a6 FIX: hide Delete Category button while creating a new category 2018-10-01 14:31:05 +02:00
Kyle Zhao
373d6e3fe6
always loadScript with a script tag (#6411) 
to avoid Content Security Policy unsafe-line violations
 2018-10-01 10:06:01 +08:00
Gerhard Schlager
b0a383561e FEATURE: Add Lithuanian locale 2018-09-27 05:26:38 +02:00
Kyle Zhao
e2462ada68
FIX: make theme import's public key field readonly (#6424) 
`disabled` attribute prevents the user from clicking or selecting in the
control whereas `readonly` does not.
 2018-09-24 09:12:49 +08:00
Joe
b44bcdefd9
UX: improves topic-title flexbox alignment 2018-09-21 12:41:35 +08:00
Sam
e622adfb89 correct warning 2018-09-21 12:05:08 +10:00
Sam
ae674dcb4e Merge branch 'theme-select-mobile' of https://github.com/jjaffeux/discourse 2018-09-21 12:04:07 +10:00
Kyle Zhao
4bb980b9f7
FEATURE: do not allow moderators to export user list (#6418) 2018-09-21 09:07:13 +08:00
Kris
5f042a2c8d Prevent move to new topic tag input from becoming too wide on click 2018-09-20 16:12:08 -04:00
Kris
e43a05fa10 Timeline back button too tall 2018-09-20 10:28:26 -04:00
Joffrey JAFFEUX
87a97cbf4b
Merge branch 'master' into theme-select-mobile 2018-09-20 10:31:41 +02:00
Kris
dfbc93aa2e Prevent post date from overflowing with long usernames 2018-09-19 18:53:48 -04:00
Gerhard Schlager
681262ddce FIX: Backup logs were usually missing the first few lines 
And because of debouncing, the log wasn't always reset at the beginning of a backup or restore.
 2018-09-19 20:27:35 +02:00
Gerhard Schlager
18d5d51d98 UX: Remove double scrollbars from backup logs 
* Removes the wrapping, because the log is easier to read without it.
* Fixes the automatic scrolling to the bottom, which didn't work anymore
 2018-09-19 20:27:34 +02:00
Joe
8d6ccde402
UX: removes bottom margins from inputs in admin controls 2018-09-20 00:32:41 +08:00
Joe
2144009520
UX: ensure ac-wrap input height matches other inputs 2018-09-20 00:02:45 +08:00
Joe
0010e7ddd2
UX: better padding for multi-select items 2018-09-19 23:56:26 +08:00
Joe
026bab116a
UX: label alignment for Firefox / IE 2018-09-19 23:48:48 +08:00
Guo Xiang Tan
d41f74578a Fix JS build. 2018-09-19 23:12:34 +08:00
Joe
b64436ba09
UX: select-kit filter input size fix 2018-09-19 22:05:56 +08:00
Joe
0ac64b6d50
UX: radio / checkbox inputs margin fix 2018-09-19 21:22:40 +08:00
Joe
8fb50a7e8b
UX: last-seen input alignment fix 2018-09-19 21:20:04 +08:00
Joe
9e9fdac023
UX: multi-select items alignment fixes 2018-09-19 21:14:27 +08:00
Joe
acd18ff9d8
Fixes typo 2018-09-19 21:08:03 +08:00
Joe
e844fa5370
UX: general cleanup of inputs, buttons and select elements - part 1 2018-09-19 20:37:04 +08:00
Jeff Atwood
f43b5bb3c1 considerably simplify copy for change owner 2018-09-18 14:15:08 -07:00
Kris
e95d6a12c5 prettier 2018-09-18 13:39:58 -04:00
Kris
8bfb016386 remove trailing spaces 2018-09-18 13:25:50 -04:00
Kris
d20a174a6b UX: Lighter style for category and tag dropdown nav 2018-09-18 13:11:00 -04:00
Kris
4cf3ef53bc Prevent spinner in tag dropdown from being squished 2018-09-18 11:27:01 -04:00
Joffrey JAFFEUX
a713c0d366
FIX: ensures onSelect/onDeselect are called 
This commit also add a FIX and a test for toolbar-popup-menu-options which had a behavior slightly specific.
 2018-09-18 11:31:23 +02:00
Joffrey JAFFEUX
2ff2c49908 Revert "FIX: ensures onSelect/onDeselect are called" 
This reverts commit 52eed73294.
 2018-09-17 22:14:41 +02:00
Kris
7f420b61cb Removing unneeded theme intro text 2018-09-17 12:00:20 -04:00
Joffrey JAFFEUX
52eed73294
FIX: ensures onSelect/onDeselect are called 2018-09-17 10:36:14 +02:00
Kyle Zhao
7a0232249a
extract inline JS that's used to store preloaded data (#6370) 2018-09-17 16:31:46 +08:00
Joffrey JAFFEUX
01913b9dc0 FIX: improves themes/components UI on mobile 2018-09-17 10:05:18 +02:00
Sam
b63630d70b use Mixin postfix when importing tags mixin 2018-09-17 10:46:57 +10:00
pmusaraj
0a2efd8ff1 Add async search to tags dropdown, always show selected tag 2018-09-17 10:40:47 +10:00
Joffrey JAFFEUX
e51c676135 refactors trending search report to use SearchLog 2018-09-17 10:19:40 +10:00
Bianca Nenciu
8f39cf6bfc FIX: Permit unpinning an unlisted topic. 2018-09-17 10:03:06 +10:00
Kyle Zhao
f666d72606 extract inline JS for google tag manager 2018-09-17 09:56:00 +10:00
Kyle Zhao
38c70bfda2 extract inline JS for google analytics 2018-09-17 09:56:00 +10:00
OsamaSayegh
c9a5438a88 use woman_artist emoji 2018-09-17 09:49:53 +10:00
OsamaSayegh
c7d81e2682 FIX/FEATURE: don't blow up when can't reach theme's repo, show problem themes on dashboard 2018-09-17 09:49:53 +10:00
OsamaSayegh
ca28548762 feedback (see commit description for details) 
* fill blank space when no theme is selected
* animate row's height in themes/components list when selecting, and hide children list
* show warning when you move to a different page and have unsaved changes
* refactor `adminCustomizeThemes.show` controller
* allow collapsing/expanding children lists
* fix a bug when adding components to a theme (changed the way it works slightly)
* a bunch of other minor things
 2018-09-17 09:49:53 +10:00
OsamaSayegh
a4f057a589 UX: improvements to admin theme UI 2018-09-17 09:49:53 +10:00
Kris
2ef16d0719 button missing no-text class 2018-09-14 20:52:25 -04:00
Jeff Atwood
7e5000b472 change close to delete glyph on associated accounts 2018-09-14 12:01:49 -07:00
Kris
acddbe22c6 FIX: Poll modal date selector width 2018-09-14 13:38:58 -04:00
Joffrey JAFFEUX
7bf8b0d305
FIX: treats users_(by_type|tl) as other reports (#6391) 2018-09-13 17:35:54 +02:00
Sam
daa02431df FIX: remove div used to measure textarea position 
Also corrects the positioning of autocomplete (when typing @ or emoji)

Previously there were edge conditions where autocomplete would be hundreds
of pixels away due to a bug measuring.


This correct an issue where Firefox ends up having an enormous blank space
at the bottom of topics after editing.
 2018-09-13 14:53:32 +10:00
Joffrey JAFFEUX
38668818a5
FIX: allows forcing unsafe string in select-kit (#6386) 
forceEscape will be defaulted to true before next release.
 2018-09-12 12:19:04 +02:00
Guo Xiang Tan
a033327b93 Manage qunit via yarn. 2018-09-11 15:07:28 +08:00
Kris
2b7e50cab8 Prevent fade-out from overlapping button in admin nav 2018-09-10 11:25:41 -04:00
Joffrey JAFFEUX
d4080c020f
FIX: sets trends to 7 days instead of 3 (#6379) 2018-09-10 10:40:19 +02:00
Joffrey JAFFEUX
2ad882113e
FIX: corrects top-referred and trending-search dates (#6372) 2018-09-07 16:49:44 +02:00
Guo Xiang Tan
d788555994 DEV: Manage pretender with yarn. 2018-09-07 16:01:49 +08:00
Guo Xiang Tan
039afe0d2c Apply prettier. 2018-09-07 15:19:34 +08:00
Joffrey JAFFEUX
6c1e70d554
FIX: do no reset tags selection on category selection (#6369) 
We will instead implement a server side solution to this in the future.
 2018-09-06 10:35:07 +02:00
Sam
56b6a4779d FIX: make route to tag more robust 
There are some edge cases where code would fail here, so adding protection
 2018-09-06 17:24:32 +10:00
Sam
5bdc00c3be FIX: do not automatically route all actions to hovered posts 
This feature (hitting d when a post is hovered with mouse deletes) causes a lot of confusion and is very risky.
 2018-09-06 10:34:58 +10:00
Kris
8cff3c9bbc UX: Prevent long names from overflowing post 2018-09-05 17:48:31 -04:00