Joffrey JAFFEUX
467ecbabf5
FIX: supports escape sequence in chat ( #29659 )
...
Writing `\*test\*` will now correctly cook `*test*`, and not `<em>test</em>`.
2024-11-08 15:28:50 +09:00
Joffrey JAFFEUX
032b1f871b
DEV: cook grid bbcode in chat ( #29658 )
...
This change will only prevent a cooked message with [grid] to show [grid] instead the content will be wrapped in `div class="d-image-grid"`. This is only enabled on messages made by bot, as regular users could use grid but have no reason to use it ATM. It will also not apply the decoration which shouldn't change the behavior more than just remove grid markup from the message
2024-11-08 14:43:28 +09:00
Alan Guo Xiang Tan
af642d0d69
Revert "FEATURE: Mark bad uploads with :invalid_url ( #29640 )" ( #29657 )
...
This reverts commit 5a00a041f1
2024-11-08 13:04:52 +08:00
Osama Sayegh
4bc030f76f
FIX: Add back the option to create invite without emailing ( #29641 )
...
Follow-up to a5497b74be
2024-11-08 07:59:24 +03:00
Natalie Tay
6c36af9f62
DEV: Add verbose logging for google oauth ( #29459 )
Tests / core frontend (${{ matrix.browser }}) (Chrome) (push) Has been cancelled
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, plugins) (push) Has been cancelled
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, themes) (push) Has been cancelled
Licenses / run (push) Has been cancelled
Linting / run (push) Has been cancelled
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (annotations, core) (push) Has been cancelled
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (backend, core) (push) Has been cancelled
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (backend, plugins) (push) Has been cancelled
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (frontend, plugins) (push) Has been cancelled
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (frontend, themes) (push) Has been cancelled
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, chat) (push) Has been cancelled
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, core) (push) Has been cancelled
Tests / core frontend (${{ matrix.browser }}) (Firefox ESR) (push) Has been cancelled
Tests / core frontend (${{ matrix.browser }}) (Firefox Evergreen) (push) Has been cancelled
2024-11-08 11:03:17 +08:00
Joffrey JAFFEUX
1d9f064d83
FIX: correctly account for composer height in PWA ( #29656 )
2024-11-08 11:16:15 +09:00
Martin Brennan
97cf069a06
FIX: S3 custom endpoint incompatible with dualstack ( #29654 )
...
Followup 0568d36133
2024-11-08 11:12:49 +10:00
Kris
64291fedf8
UX: lower min_post_count to show bottom topic map ( #29649 )
2024-11-07 20:10:18 -05:00
Joffrey JAFFEUX
79254c59f9
FIX: correctly render unicode in channel page title ( #29653 )
...
Before this fix we would render the emoji as text, eg: `🐱 `
2024-11-08 09:41:14 +09:00
Keegan George
5a23a74bbc
DEV: Show confirmation dialog when admins disable 2FA ( #29652 )
...
This PR ensures that admins are shown a confirmation dialog when clicking to disable 2FA for a user. The 2FA button is right below the "Grant Badge" button and as such it can easily be clicked accidentally. It's also good practice to ask for confirmation before removing important functionality.
2024-11-07 16:39:42 -08:00
Joffrey JAFFEUX
fc5c0270f7
FIX: ensures thread panel closes on escape ( #29651 )
...
`chatThreadPane.isOpened` was returning `false` when it should return `true` due to an incorrect matching on the route.
Note that visiting a thread will focus the composer and the first escape will blur the input, only the second will close the panel.
2024-11-08 09:19:24 +09:00
Bianca Nenciu
5a00a041f1
FEATURE: Mark bad uploads with :invalid_url ( #29640 )
...
A "bad upload" in this context is a upload with a mismatched URL. This can happen when changing the S3 bucket used for uploads and the upload records in the database have not been remapped correctly.
2024-11-08 08:05:14 +08:00
dependabot[bot]
81e171070d
Build(deps): Bump excon from 1.1.1 to 1.2.0 ( #29646 )
...
Bumps [excon](https://github.com/excon/excon ) from 1.1.1 to 1.2.0.
- [Changelog](https://github.com/excon/excon/blob/master/changelog.txt )
- [Commits](https://github.com/excon/excon/compare/v1.1.1...v1.2.0 )
---
updated-dependencies:
- dependency-name: excon
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-08 07:45:25 +08:00
dependabot[bot]
4f3423ab35
Build(deps): Bump net-http from 0.4.1 to 0.5.0 ( #29647 )
...
Bumps [net-http](https://github.com/ruby/net-http ) from 0.4.1 to 0.5.0.
- [Release notes](https://github.com/ruby/net-http/releases )
- [Commits](https://github.com/ruby/net-http/compare/v0.4.1...v0.5.0 )
---
updated-dependencies:
- dependency-name: net-http
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-08 00:14:56 +01:00
dependabot[bot]
5f44839928
Build(deps): Bump uri from 0.13.1 to 1.0.0 ( #29645 )
...
Bumps [uri](https://github.com/ruby/uri ) from 0.13.1 to 1.0.0.
- [Release notes](https://github.com/ruby/uri/releases )
- [Commits](https://github.com/ruby/uri/compare/v0.13.1...v1.0.0 )
---
updated-dependencies:
- dependency-name: uri
dependency-type: indirect
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-08 00:14:28 +01:00
dependabot[bot]
dd82da8939
Build(deps): Bump psych from 5.1.2 to 5.2.0 ( #29642 )
...
Bumps [psych](https://github.com/ruby/psych ) from 5.1.2 to 5.2.0.
- [Release notes](https://github.com/ruby/psych/releases )
- [Commits](https://github.com/ruby/psych/compare/v5.1.2...v5.2.0 )
---
updated-dependencies:
- dependency-name: psych
dependency-type: indirect
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-08 00:12:43 +01:00
dependabot[bot]
353f6cdf09
Build(deps-dev): Bump rubocop-ast from 1.34.0 to 1.34.1 ( #29643 )
...
Bumps [rubocop-ast](https://github.com/rubocop/rubocop-ast ) from 1.34.0 to 1.34.1.
- [Release notes](https://github.com/rubocop/rubocop-ast/releases )
- [Changelog](https://github.com/rubocop/rubocop-ast/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop-ast/compare/v1.34.0...v1.34.1 )
---
updated-dependencies:
- dependency-name: rubocop-ast
dependency-type: indirect
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-08 00:11:30 +01:00
dependabot[bot]
322e2a218d
Build(deps-dev): Bump puppeteer-core from 23.7.0 to 23.7.1 ( #29648 )
...
Bumps [puppeteer-core](https://github.com/puppeteer/puppeteer ) from 23.7.0 to 23.7.1.
- [Release notes](https://github.com/puppeteer/puppeteer/releases )
- [Changelog](https://github.com/puppeteer/puppeteer/blob/main/release-please-config.json )
- [Commits](https://github.com/puppeteer/puppeteer/compare/puppeteer-core-v23.7.0...puppeteer-core-v23.7.1 )
---
updated-dependencies:
- dependency-name: puppeteer-core
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-08 00:11:11 +01:00
dependabot[bot]
94cf3bafc3
Build(deps): Bump stringio from 3.1.1 to 3.1.2 ( #29644 )
...
Bumps [stringio](https://github.com/ruby/stringio ) from 3.1.1 to 3.1.2.
- [Release notes](https://github.com/ruby/stringio/releases )
- [Changelog](https://github.com/ruby/stringio/blob/master/NEWS.md )
- [Commits](https://github.com/ruby/stringio/compare/v3.1.1...v3.1.2 )
---
updated-dependencies:
- dependency-name: stringio
dependency-type: indirect
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-08 00:10:28 +01:00
Renato Atilio
7568e732cc
FIX: resume editing when through /new-message ( #29637 )
...
"Resume editing" would do nothing when going through the `/new-message` flow.
This seems to be broken since [this commit](b0f6d074be
2024-11-07 17:39:58 -03:00
Joffrey JAFFEUX
4840060568
DEV: fix flakey by duplicating constant ( #29636 )
...
Tests / core frontend (${{ matrix.browser }}) (Firefox ESR) (push) Waiting to run
Tests / core frontend (${{ matrix.browser }}) (Firefox Evergreen) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (annotations, core) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (backend, core) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (backend, plugins) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (frontend, plugins) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (frontend, themes) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, chat) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, core) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, plugins) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, themes) (push) Waiting to run
Licenses / run (push) Waiting to run
Linting / run (push) Waiting to run
Tests / core frontend (${{ matrix.browser }}) (Chrome) (push) Waiting to run
This is because rules is pointing to the same array MARKDOWN_IT_RULES, which is modified directly. Modifying rules with << changes the original MARKDOWN_IT_RULES array, so every call to something works with the altered array state from previous calls.
2024-11-07 23:51:17 +09:00
Joffrey JAFFEUX
5010fced92
DEV: only supports headings in messages for bots ( #29585 )
...
The markdown it rule "heading" will only be used when the message is done by a bot, which means an id < 0.
This commit also adds a is-bot css class on messages made by a bot, for finer control.
---------
Co-authored-by: Martin Brennan <mjrbrennan@gmail.com>
2024-11-07 22:27:35 +09:00
dependabot[bot]
193d25df00
Build(deps): Bump webrick from 1.8.2 to 1.9.0
...
Licenses / run (push) Waiting to run
Linting / run (push) Waiting to run
Tests / core frontend (${{ matrix.browser }}) (Chrome) (push) Waiting to run
Tests / core frontend (${{ matrix.browser }}) (Firefox ESR) (push) Waiting to run
Tests / core frontend (${{ matrix.browser }}) (Firefox Evergreen) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (annotations, core) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (backend, core) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (backend, plugins) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (frontend, plugins) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (frontend, themes) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, chat) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, core) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, plugins) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, themes) (push) Waiting to run
Bumps [webrick](https://github.com/ruby/webrick ) from 1.8.2 to 1.9.0.
- [Release notes](https://github.com/ruby/webrick/releases )
- [Commits](https://github.com/ruby/webrick/compare/v1.8.2...v1.9.0 )
---
updated-dependencies:
- dependency-name: webrick
dependency-type: indirect
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-11-07 10:51:54 +01:00
chapoi
75ee73f969
UX: remove icons indicating time in userstatus, bookmarks, topic timer ( #29635 )
2024-11-07 06:54:40 +01:00
Joffrey JAFFEUX
3d1571a852
UX: do not hide topic composer in mobile chat ( #29633 )
2024-11-07 14:49:59 +09:00
Ella E.
b4f7a1b761
UX: Apply admin table classes for consistent mobile styling on the API keys page ( #29630 )
...
Licenses / run (push) Waiting to run
Linting / run (push) Waiting to run
Tests / core frontend (${{ matrix.browser }}) (Chrome) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (annotations, core) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (backend, core) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (backend, plugins) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (frontend, plugins) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (frontend, themes) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, chat) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, core) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, plugins) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, themes) (push) Waiting to run
Tests / core frontend (${{ matrix.browser }}) (Firefox ESR) (push) Waiting to run
Tests / core frontend (${{ matrix.browser }}) (Firefox Evergreen) (push) Waiting to run
* UX: Apply admin table classes for consistent mobile styling on the API keys page
* apply prettier
2024-11-06 18:38:25 -07:00
Martin Brennan
0568d36133
FIX: Use dualstack S3 endpoint for direct uploads ( #29611 )
...
When we added direct S3 uploads to Discourse, which use
presigned URLs, we never took into account the dualstack
endpoints for IPv6 on S3.
This commit fixes the issue by using the dualstack endpoints
for presigned URLs and requests, which are used in the
get-presigned-put and batch-presign-urls endpoints used when
directly uploading to S3.
It also makes regular S3 requests for `put` and so on use
dualstack URLs. It doesn't seem like there is a downside to
doing this, but a bunch of specs needed to be updated to reflect this.
2024-11-07 11:06:39 +10:00
dependabot[bot]
cc01555fce
Build(deps-dev): Bump @embroider/compat in the embroider group ( #29626 )
...
Bumps the embroider group with 1 update: [@embroider/compat](https://github.com/embroider-build/embroider/tree/HEAD/packages/compat ).
Updates `@embroider/compat` from 3.6.5 to 3.7.0
- [Release notes](https://github.com/embroider-build/embroider/releases )
- [Changelog](https://github.com/embroider-build/embroider/blob/main/CHANGELOG.md )
- [Commits](https://github.com/embroider-build/embroider/commits/HEAD/packages/compat )
---
updated-dependencies:
- dependency-name: "@embroider/compat"
dependency-type: direct:development
update-type: version-update:semver-minor
dependency-group: embroider
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-07 00:38:09 +01:00
dependabot[bot]
fa959b0b54
Build(deps-dev): Bump jsuites from 5.6.6 to 5.7.1 ( #29627 )
...
Bumps [jsuites](https://github.com/jsuites/jsuites ) from 5.6.6 to 5.7.1.
- [Release notes](https://github.com/jsuites/jsuites/releases )
- [Changelog](https://github.com/jsuites/jsuites/blob/master/changelog.md )
- [Commits](https://github.com/jsuites/jsuites/commits )
---
updated-dependencies:
- dependency-name: jsuites
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-07 00:30:33 +01:00
Keegan George
fad0d2ec62
UX: New experimental features should be marked clearly ( #29622 )
...
This PR adds a small visual change to the new feature item on the `/admin/whats-new` page. When features are marked with an experimental site setting, they should show an indication on the feature item that it is "Experimental"
2024-11-06 15:26:30 -08:00
dependabot[bot]
39198afa49
Build(deps): Bump timeout from 0.4.1 to 0.4.2 ( #29625 )
...
Bumps [timeout](https://github.com/ruby/timeout ) from 0.4.1 to 0.4.2.
- [Release notes](https://github.com/ruby/timeout/releases )
- [Commits](https://github.com/ruby/timeout/compare/v0.4.1...v0.4.2 )
---
updated-dependencies:
- dependency-name: timeout
dependency-type: indirect
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-07 00:13:09 +01:00
dependabot[bot]
4205b06fcd
Build(deps): Bump json from 2.7.6 to 2.8.1 ( #29624 )
...
Bumps [json](https://github.com/ruby/json ) from 2.7.6 to 2.8.1.
- [Release notes](https://github.com/ruby/json/releases )
- [Changelog](https://github.com/ruby/json/blob/master/CHANGES.md )
- [Commits](https://github.com/ruby/json/compare/v2.7.6...v2.8.1 )
---
updated-dependencies:
- dependency-name: json
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-07 00:11:07 +01:00
dependabot[bot]
b8295b8b70
Build(deps-dev): Bump @swc/core from 1.8.0 to 1.9.1 ( #29628 )
...
Bumps [@swc/core](https://github.com/swc-project/swc ) from 1.8.0 to 1.9.1.
- [Release notes](https://github.com/swc-project/swc/releases )
- [Changelog](https://github.com/swc-project/swc/blob/main/CHANGELOG.md )
- [Commits](https://github.com/swc-project/swc/compare/v1.8.0...v1.9.1 )
---
updated-dependencies:
- dependency-name: "@swc/core"
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-07 00:06:08 +01:00
Kris
f24c274867
UX: replace broken link SVG with new Font Awesome 6 name ( #29623 )
2024-11-06 13:35:07 -05:00
Renato Atilio
ac33ecdc8c
FIX: pass topic+category to @-mention user search ( #29620 )
...
When replying to a topic, the @-mention userSearch needs the topicId and the categoryId so they can trigger immediately, with sane suggestions.
This was broken when the mentions were moved from ComposerEditor to DEditor.
2024-11-06 15:20:54 -03:00
Bianca Nenciu
635faaaf59
DEV: Add system spec for categories page ( #29621 )
...
Licenses / run (push) Waiting to run
Linting / run (push) Waiting to run
Tests / core frontend (${{ matrix.browser }}) (Chrome) (push) Waiting to run
Tests / core frontend (${{ matrix.browser }}) (Firefox ESR) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, plugins) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, themes) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (annotations, core) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (backend, core) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (backend, plugins) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (frontend, plugins) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (frontend, themes) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, chat) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, core) (push) Waiting to run
Tests / core frontend (${{ matrix.browser }}) (Firefox Evergreen) (push) Waiting to run
Follow up to commit 948e283e0f
2024-11-06 20:01:27 +02:00
Bianca Nenciu
da43deb9ea
DEV: Fix mismatched column types ( #29477 )
...
The primary key is usually a bigint column, but the foreign key columns
are usually of integer type. This can lead to issues when joining these
columns due to mismatched types and different value ranges.
This was using a temporary plugin / test API to make tests pass. After
more careful consideration, we concluded that it is safe to alter the
tables directly.
Even for larger communities, with about 1M chat messages, the
slowest `ALTER` query runs in about 15 seconds, which well under the 30
seconds query timeout limit. As a result, chat messages will be delayed
for a few seconds, but the system will remain operational.
2024-11-06 20:00:40 +02:00
Jean
708533b1e0
FEATURE: Add links to searchable user fields in users directory and user profile ( #29338 )
...
* FEATURE: Add links to searchable user fields in users directory and user profile
2024-11-06 13:35:30 -04:00
Ella E.
13c7773036
UX: Make the emojis in the admin page table list work better on mobile ( #29619 )
...
* UX: Apply admin table classes for consistent mobile styling on the emojis page
* UX: remove icon from the button
* UX: styling tweaks on the emoji uploader form
* UX: right align table button controls
* apply prettier
2024-11-06 10:25:03 -07:00
Loïc Guitaut
6158a1ae29
DEV: Refactor the Chat::CreateThread service a bit
...
Follow best practices from our docs.
2024-11-06 15:53:43 +01:00
Gabriel Grubba
45ecb34aec
UX: update create_post_for_category_and_tag_changes to include that it needs whispers enabled to work ( #29618 )
...
* UX: update `create_post_for_category_and_tag_changes` to include that it needs whispers enabled to work
* DEV: update phrasing in `create_post_for_category_and_tag_changes`
2024-11-06 11:18:20 -03:00
David Taylor
0237ef80bd
DEV: Enable ember/no-classic-classes eslint rule ( #28610 )
2024-11-06 13:31:01 +00:00
Jarek Radosz
1ba6f6f1ae
DEV: Update content-tag to 2.0.3 ( #29616 )
2024-11-06 13:29:24 +01:00
Gabriel Grubba
75beb5a84f
FIX: Change create_post_for_category_and_tag_changes setting to use whispers instead of small actions ( #29602 )
...
It currently can leak private tags/categories, to address this we are moving to whispers.
2024-11-06 09:28:28 -03:00
Loïc Guitaut
5177aef37d
FIX: Don’t try to serialize associations in PostRevisionSerializer
...
Licenses / run (push) Waiting to run
Linting / run (push) Waiting to run
Tests / core frontend (${{ matrix.browser }}) (Firefox Evergreen) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, plugins) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, themes) (push) Waiting to run
Tests / core frontend (${{ matrix.browser }}) (Chrome) (push) Waiting to run
Tests / core frontend (${{ matrix.browser }}) (Firefox ESR) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (annotations, core) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (backend, core) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (backend, plugins) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (frontend, plugins) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (frontend, themes) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, chat) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, core) (push) Waiting to run
Currently, if an association is added as a tracked field in
`PostRevisor`, the `PostRevisionSerializer` class will try to serialize
it somehow. This will raise an error as ActiveRecord collection proxies
can't be serialized.
This patch addresses this issue by skipping any association tracked by
the `PostRevisor` class.
2024-11-06 10:38:41 +01:00
Ted Johansson
3be925e161
DEV: Untangle award badge admin CSS ( #29614 )
...
I was skimming through existing pages to get a feel for the admin UI guidelines. I noticed that this part was missing its margin. On some further investigation, it seems that a single CSS selector, .award-badge was being used both for the section and for the button in the header, so I decided to 1) separate the two and 2) add in the missing margin.
2024-11-06 16:10:39 +08:00
chapoi
a097d86eea
UX: fix visibility of grant badge modal dropdowns ( #29613 )
2024-11-06 07:30:13 +01:00
Krzysztof Kotlarek
d57b7abe67
FIX: setup with db:create db:migrate ( #29609 )
...
After data seed, we should reset Redis cache to ensure that the correct flags are cached.
However, `db:create` is skipping Redis
https://github.com/discourse/discourse/blob/main/lib/tasks/db.rake#L39
And uses `ActiveSupport::Cache::MemoryStore.new`
e2292d4c59/lib/discourse.rb (L523)https://meta.discourse.org/t/development-install-fails-when-running-bin-rails-db-migrate/332754
2024-11-06 15:06:17 +11:00
Osama Sayegh
6f8f6a7726
FIX: Pass upload type correctly to uploads#create ( #29600 )
...
Prior to Uppy, the `uploads#create` endpoint used to receive a `type` param that indicated the purpose/target of the upload, such as `avatar`, `site_setting` and so on. With the introduction of Uppy, the `type` param became the MIME type of the file being uploaded, and the purpose/target of the upload became a new param called `upload_type`, however the backend could still use the `type` param (which now contains MIME type) as the purpose/target of the upload if `upload_type` is absent.
We technically don't need to send the MIME type over the network, but it seems like it's done by Uppy and we have no control over the `type` param that Uppy includes:
758de8167b/app/assets/javascripts/discourse/app/lib/uppy/uppy-upload.js (L146-L151)
2024-11-06 07:00:35 +03:00
Osama Sayegh
ae721bd0f1
DEV: Fetch settings by area name instead of individual settings ( #29604 )
...
This commit switches the route for the about config page to retrieve the list of site settings that control the /about page by their area instead of their individual names.
Internal topic: t/136384.
2024-11-06 06:56:27 +03:00
