Guo Xiang Tan
4752ddc908
Avoid DB query when there are no mentions.
2018-11-22 16:44:17 +08:00
Guo Xiang Tan
a57baeec2a
Fix the build.
2018-11-22 16:37:24 +08:00
Guo Xiang Tan
28a6cf8228
FIX: Mention lookup should be case insensitive.
2018-11-22 16:32:56 +08:00
Guo Xiang Tan
3f636b2d19
FIX: Check whether group is mentionable by user when cooking post.
2018-11-22 16:16:33 +08:00
Sam
0739c3b1d1
DEV: this introduces a script capable of caching critical DNS locally
...
This is useful for cases where you want to add resiliency to DNS lookups
for redis and postgres, so they will continue to work even if there is
a DNS outage
2018-11-22 18:46:59 +11:00
Vinoth Kannan
036790d13c
FIX: Assign default value for category.findByIds method
2018-11-22 12:51:04 +05:30
Guo Xiang Tan
672e95bcb4
FIX: Staged users should not be mentionable.
2018-11-22 15:00:46 +08:00
Guo Xiang Tan
6111b285d9
DEV: Remove comment that links to a private topic.
...
Not going to be useful for other developers.
2018-11-22 14:55:02 +08:00
Guo Xiang Tan
c5a70eca6e
PERF: Move mention lookups out of the V8 context. ( #6640 )
...
We were looking up each mention one by one without any form of caching and that results
in a problem somewhat similar to an N+1. When we have to do alot of DB
lookups, it also increased the time spent in the V8 context which may
eventually lead to a timeout. The change here makes it such that mention lookups only does a single
DB query per post that happens outside of the V8 context.
2018-11-22 14:28:48 +08:00
Guo Xiang Tan
596e09aaf9
FIX: Wizard icons step fields have incorrect values.
...
https://meta.discourse.org/t/is-the-wizard-supposed-to-not-let-you-skip-adding-icons/102417
2018-11-22 14:19:36 +08:00
Guo Xiang Tan
ba280f9cf3
FIX: Give up migrating url site setting if endpoint doesn't return data.
2018-11-22 12:16:52 +08:00
Guo Xiang Tan
a8603e04ab
FIX: Give up migration of URL site settings if there is an SSL error.
2018-11-22 12:14:27 +08:00
Maja Komel
993d8f346e
FIX notifications for flag PMs ( #6641 )
2018-11-22 10:25:19 +08:00
Kyle Zhao
8e32aa1483
FEATURE: show post approvals in Moderation History ( #6643 )
2018-11-22 10:22:23 +08:00
Joe
ee6c0170ce
FEATURE: Scroll-based logo on mobile ( #6632 )
2018-11-21 21:21:49 -05:00
Saurabh Patel
d984323e23
FEATURE: Show change name of user in staff logs ( #6647 )
...
https://meta.discourse.org/t/admins-changing-users-name-not-username-should-be-logged/99511
2018-11-22 10:13:02 +08:00
Guo Xiang Tan
d298f00046
DEV: Improve specs to be more specific about what has changed.
2018-11-22 10:10:07 +08:00
Gerhard Schlager
a3f8ef89a6
FIX: Setting DISCOURSE_S3_REGION env variable had no effect
2018-11-21 23:15:28 +01:00
Kris
0381e99b71
UX: improving theme upload modal alignment, markup
2018-11-21 16:50:49 -05:00
Gerhard Schlager
c376670bd2
FIX: a search term containing '& could lead to errors
...
This also makes sure that the search term in front or after special characters isn't ignored.
2018-11-21 22:07:56 +01:00
Joffrey JAFFEUX
58c795ef30
DEV: adds test for image-short-url ( #6642 )
2018-11-22 07:48:52 +11:00
Régis Hanol
a0f0bac752
Add a comment to run the 'import:ensure_consistency' rake task after a bulk import
2018-11-21 16:28:35 +01:00
Maja Komel
715b2e85fc
FIX: make danger locale warning work with plugin locales ( #6639 )
2018-11-21 10:13:25 +01:00
Arpit Jalan
61eff22b29
FIX: raise Discourse::NotFound
unless the user is present
2018-11-21 10:57:42 +05:30
Arpit Jalan
10cc698df3
FIX: respond with proper error message if user not found
2018-11-21 10:47:37 +05:30
Arpit Jalan
539f1c6252
FIX: raise Discourse::NotFound
unless the topic is present
2018-11-21 09:48:38 +05:30
Guo Xiang Tan
439b3fe10a
Fix MigratePollsData
failing when poll-votes have duplicated options.
2018-11-21 10:52:21 +08:00
Guo Xiang Tan
f4020d9134
UX: Contain site setting uploads within the div.
2018-11-21 10:09:53 +08:00
Sam
966d3c8437
remove unneeded code
...
```
irb(main):001:0> def test; if false; puts "hi"; end; end
=> :test
irb(main):002:0> test
=> nil
```
2018-11-21 12:57:34 +11:00
Guo Xiang Tan
598ac69773
Stop Sidekiq first before reloading unicorn master.
2018-11-21 09:53:00 +08:00
Sam
0a86ef69bb
FIX: browser infinite recursion when editing post
...
This was a result of:
c4ed353fae
jQuery map on a jQuery object, returns a jQuery object http://api.jquery.com/map/
So you need to convert it to an array prior to mapping
2018-11-21 12:51:14 +11:00
Sam
20268385a5
FIX: never attempt to log invalid post numbers
...
Previously in some cases we would queue logging of invalid post numbers
The impact would be we would miss logging an incoming link and would leak
an error.
2018-11-21 11:58:47 +11:00
Sam
86255faa08
FEATURE: do not switch to JPEG unless you meet 75k byte savings
...
This also adjusts the algorithm to expect
- 30% saving for JPEG conversion
AND
- Minimum of 75K bytes saved
The reasoning for increase of saving requirements is cause PNG may have been
uploaded unoptimized, 30% saving on PNG is very possible
2018-11-21 11:01:08 +11:00
Guo Xiang Tan
1def6c08ec
Fix copy due to 050dd57494
.
2018-11-21 08:00:15 +08:00
Guo Xiang Tan
df72674f24
Warn when migrate url site settings job encounters an error.
2018-11-21 07:55:50 +08:00
Kyle E. Mitchell
15e793fd3b
FEATURE: Terms of Service v1.0.0
...
Co-authored-by: Gerhard Schlager <mail@gerhard-schlager.at>
2018-11-21 00:45:16 +01:00
Claas Augner
52a5a5983a
Update narrative bot copy
2018-11-21 00:04:54 +01:00
Jeff Atwood
050dd57494
update wizard intro copy step
2018-11-20 13:43:18 -08:00
Kris
17bc21abff
trashing an empty wrapper
2018-11-20 15:42:18 -05:00
Kris
17f3080d01
UX: More consistent category setting layout
2018-11-20 15:16:17 -05:00
Arpit Jalan
5951e111ad
FIX: handle nil topic value when removing allowed users
2018-11-20 22:55:39 +05:30
Régis Hanol
92100f82eb
FIX: properly disable serializable attributes when poll plugin is disabled
2018-11-20 17:28:41 +01:00
Arpit Jalan
22a7f1e7f2
FIX: handle nil user value on password reset
2018-11-20 21:49:47 +05:30
Maja Komel
592f8c1637
FIX: escape sso_secret string when migrating to sso_provider_secret ( #6634 )
2018-11-20 15:28:37 +01:00
Joffrey JAFFEUX
9672c92045
DEV: removes _.each from codebase ( #6629 )
2018-11-20 14:46:58 +01:00
Erick Guan
a2042c8e7d
strip unused string from an deleted site setting
2018-11-20 14:28:42 +01:00
Bianca Nenciu
a0022a1771
FIX: Use count variable for pluralized string.
2018-11-20 14:17:31 +02:00
Rishabh
eacbe28f55
FIX: Skip gsub for normalizing whitespaces when text is nil ( #6631 )
2018-11-20 09:12:32 +01:00
Vinoth Kannan
bc41057949
minor copy edit
2018-11-20 12:07:56 +05:30
Guo Xiang Tan
1a57be3248
Avoid deprecated site setting logging in SiteSetting.settings_hash
.
2018-11-20 11:59:38 +08:00