github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-29 03:03:44 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
33,643 Commits 214 Branches 500 Tags 960 MiB
48b9e0d749
Commit Graph

10748 Commits

Author SHA1 Message Date
Maja Komel
77af097ce0 FIX: add short description to title on client side 2019-05-08 15:03:33 +02:00
David Taylor
b717e23ceb FIX: Dynamically adjust scale when rendering wizard canvases 
This was a typo in fd0de64
 2019-05-08 13:14:28 +01:00
Bianca Nenciu
861023f0d6 FIX: Skip attachments in click track. 2019-05-08 11:55:31 +03:00
Guo Xiang Tan
46ea69a73c UX: Initialize client side category model with right search_priority. 
This is strictly a UX change since the default value of the column is 0.
 2019-05-08 14:16:20 +08:00
Robin Ward
5af7c90bab FEATURE: Hide Reviewable scores, change score filter to Priority 
We found score hard to understand. It is still there behind the scenes
for sorting purposes, but it is no longer shown.

You can now filter by minimum priority (low, med, high) instead of
score.
 2019-05-07 14:05:23 -04:00
Roman Rizzi
0a66065774
FIX: Move default options that were in the bufferedRender function. This will fix shortcut navigation for discourse-assign (#7497) 2019-05-07 12:25:10 -03:00
Penar Musaraj
446ec1b44a
Set input and textarea font size to 16px on iOS (#7480) 2019-05-07 10:44:43 -04:00
Bianca Nenciu
98a75906c8
FIX: Close topics deleted by users and ensure topic stubs are destroyed. (#7430) 2019-05-07 16:25:52 +03:00
Arpit Jalan
ed70595314 UX: add information about the use of permalinks 2019-05-07 17:13:26 +05:30
Bianca Nenciu
71fb8a4195 DEV: Fix failing click-track tests. 2019-05-07 13:54:12 +03:00
Joffrey JAFFEUX
4bbb34f7cb
REFACTOR: admin-user (#7475) 2019-05-07 10:53:21 +02:00
Joffrey JAFFEUX
f73ed45429
REFACTOR: color-scheme model (#7477) 2019-05-07 10:51:52 +02:00
Joffrey JAFFEUX
9507eff927
REFACTOR: resumable-upload (#7474) 2019-05-07 10:51:11 +02:00
Bianca Nenciu
4ff1195537 FEATURE: Use Beacon API for tracking clicks. (#7483) 2019-05-07 16:37:43 +10:00
Guo Xiang Tan
abbc639e0d FIX: Only unregister service workers that belongs to Discourse. 2019-05-07 13:08:06 +08:00
Arpit Jalan
03169401ff UX: correct order of site statistics on /about page 2019-05-07 09:50:41 +05:30
Robin Ward
47995d2d89 FIX: Your own likes were missing on posts 2019-05-06 20:03:50 -04:00
Robin Ward
31e100530f FEATURE: Flag count in post menu 
This change shows a notification number besides the flag icon in the
post menu if there is reviewable content associated with the post.
Additionally, if there is pending stuff to review, the icon has a red
background.

We have also removed the list of links below a post with the flag
status. A reviewer is meant to click the number beside the flag icon to
view the flags. As a consequence of losing those links, we've removed
the ability to undo or ignore flags below a post.
 2019-05-06 16:13:31 -04:00
Dan Ungureanu
33e06dd796
FIX: Make select all and below skip small actions. (#7425) 2019-05-06 16:22:11 +03:00
Guo Xiang Tan
8217d5be78 UX: Switch mobile header back for 5s when notification comes in. 2019-05-06 16:58:25 +08:00
Guo Xiang Tan
ba3cf7109c DEV: Remove unused lines of code. 2019-05-06 13:48:51 +08:00
Sam Saffron
267d129f38 FEATURE: only scroll to bottom for discobot 
Non discobot replies on PMs triggering scroll cause confusion.
 2019-05-06 10:55:58 +10:00
Robin Ward
99a2a769d4 FIX: Conflict error (version was already used) 2019-05-03 16:36:37 -04:00
Robin Ward
15c9b00307 FEATURE: Show edit indicator on review queue 
If a flagged post has edits, show the pencil icon and pop up the history
window when clicked.
 2019-05-03 11:21:33 -04:00
Joffrey JAFFEUX
5f78bbebe9
FIX: forces a reload of emoji list if clicked on more (#7473) 
This is a bit hacky but it's much more simple and reliable than many other solutions and doesnt involve having to manage some variable state.
 2019-05-03 16:11:03 +02:00
Penar Musaraj
b948d97c8f
FEATURE: Show diff of local changes before updating remote theme (#7443) 2019-05-02 21:43:54 -04:00
Robin Ward
3cb0d27d38 DEV: Upgrade our widget handlebars compiler 
Now supports subexpressions such as i18n and concat, plus automatic
attaching of widgets similar to ember.
 2019-05-02 15:47:57 -04:00
Joffrey JAFFEUX
e696903c31
FIX: uses translatedTitle to check validity of topic footer btn (#7472) 2019-05-02 20:56:27 +02:00
Joffrey JAFFEUX
75591664e7
FIX: better handling of category filter deselection (#7468) 2019-05-02 10:03:12 +02:00
Guo Xiang Tan
d5c9ac7196 PERF: Use cdn when serving site settings upload. 2019-05-02 15:35:07 +08:00
Guo Xiang Tan
24347ace10 FIX: Properly associate user_profiles background urls via upload id. 
`Upload#url` is more likely and can change from time to time. When it
does changes, we don't want to have to look through multiple tables to
ensure that the URLs are all up to date. Instead, we simply associate
uploads properly to `UserProfile` so that it does not have to replicate
the URLs in the table.
 2019-05-02 14:58:24 +08:00
Sam Saffron
157dc5e298 FEATURE: disable native share API on non tablets/phones 
Native share API works fantastically on phones/tablets but on full desktop
it is confusing.
 2019-05-02 13:18:29 +10:00
Arpit Jalan
b5ea50a154
FIX: use full screen login for new-topic route (#7467) 
DEV: add javascript tests for new-topic and new-message routes

DEV: fix an existing test that was being skipped
 2019-05-01 22:54:29 +05:30
Vinoth Kannan
7869a10d18 Revert "FEATURE: Added unlisted topics option to advanced search (#7447)" 
This reverts commit 539723f8ff since it is failing the build.
 2019-05-01 21:06:20 +05:30
Joffrey JAFFEUX
ae493f4722
UX: fills picker with emoji autocomplete state on more click (#7466) 2019-05-01 16:19:45 +02:00
David Taylor
0e303c7f5d
FEATURE: Automatically generate optimized site metadata icons (#7372) 
This change automatically resizes icons for various purposes. Admins can now upload `logo` and `logo_small`, and everything else will be auto-generated. Specific icons can still be uploaded separately if required.

## Core

- Adds an SiteIconManager module which manages automatic resizing and fallback

- Icons are looked up in the OptimizedImage table at runtime, and then cached in Redis. If the resized version is missing for some reason, then most icons will fall back to the original files. Some icons (e.g. PWA Manifest) will return `nil` (because an incorrectly sized icon is worse than a missing icon). 

- `SiteSetting.site_large_icon_url` will return the optimized version, including any fallback. `SiteSetting.large_icon` continues to return the upload object. This means that (almost) no changes are required in core/plugins to support this new system.

- Icons are resized whenever a relevant site setting is changed, and during post-deploy migrations

## Wizard

- Allows `requiresRefresh` wizard steps to reload data via AJAX instead of a full page reload

- Add placeholders to the **icons** step of the wizard, which automatically update from the "Square Logo"

- Various copy updates to support the changes

- Remove the "upload-time" resizing for `large_icon`. This is no longer required.

## Site Settings UX

- Move logo/icon settings under a new "Branding" tab

- Various copy changes to support the changes

- Adds placeholder support to the `image-uploader` component

- Automatically reloads site settings after saving. This allows setting placeholders to change based on changes to other settings

- Upload site settings will be assigned a placeholder if SiteIconManager `responds_to?` an icon of the same name

## Dashboard Warnings

- Remove PWA icon and PWA title warnings. Both are now handled automatically.

## Bonus

- Updated the sketch logos to use @awesomerobot's new high-res designs
 2019-05-01 14:44:45 +01:00
Arpit Jalan
c6409fd2cc FIX: pass correct date arguments to server when exporting CSV 2019-05-01 10:46:30 +05:30
Arpit Jalan
002e1f560a FIX: initialize empty object if no custom filters are present 2019-05-01 10:27:19 +05:30
Tim Lange
539723f8ff FEATURE: Added unlisted topics option to advanced search (#7447) 2019-05-01 12:31:13 +10:00
Robin Ward
404b35bd04 FEATURE: Category Reviewable by Group 
Allow a group to review content in a particular category.
 2019-04-30 15:23:06 -04:00
Robin Ward
dd29af4475 REFACTOR: {{avatar}} and {{date}} helpers in vdom templates 
This is a step towards a nicer flag display under posts.
 2019-04-30 15:22:38 -04:00
Roman Rizzi
404666c9e9
DEV: Export the default behaviour of a topic-list-item so it can be reused by the discourse-assign plugin (#7433) 2019-04-30 15:36:54 -03:00
David Taylor
583226d295 FIX: Linking to /new-topic from /latest 
`/new-topic` redirects back to `/latest`, so the ember router considers this to be a 'refresh'. This triggers the `resetParams()` logic, which would cause the transition to abort, and the composer would never open.

This commit fixes the `resetParams()` logic so that it uses the default values, instead of setting everything to `null`. Therefore the transition is no longer aborted, and the composer opens successfully.

Unfortunately I have not been able to reproduce the issue in a QUnit test.
 2019-04-30 16:25:25 +01:00
Joffrey JAFFEUX
8e68244eea
FIX: prevents google to track certain pages (#7463) 2019-04-30 15:57:51 +02:00
Joffrey JAFFEUX
726dd0fe37 Revert "FIX: prevents google to track certain pages (#7455)" 
This reverts commit c863e62998.
 2019-04-30 10:17:12 +02:00
Joffrey JAFFEUX
c863e62998 FIX: prevents google to track certain pages (#7455) 2019-04-30 13:59:55 +08:00
Guo Xiang Tan
dca7f8ecf2 FIX: Loading more broken on groups page. 
Regressed in 1f17d52f55.
 2019-04-30 10:35:17 +08:00
Neil Lalonde
a00354f11f Prettier site-settings/group-list.js.es6 2019-04-29 16:26:13 -04:00
Neil Lalonde
1ba72ccab8 DEV: add site setting type group_list for a list of groups 
Add a js test
 2019-04-29 16:15:22 -04:00
Penar Musaraj
b75720d911 FIX: skip click-tracking for mentions 2019-04-29 12:05:47 -04:00
Joffrey JAFFEUX
5768011cad
FIX: prevents exception in the composer with regexp flags 2019-04-29 16:58:17 +02:00
Penar Musaraj
629ae7a5b7 FIX: Revert tracking links in quotes 2019-04-29 10:30:04 -04:00
Bianca Nenciu
aef35faefc FIX: Open links in external tabs. (#7444) 2019-04-29 10:27:29 -04:00
Penar Musaraj
ca9fd95a08 FIX: Respect "open external links in new window" in quotes and edit history 2019-04-29 10:13:53 -04:00
Joffrey JAFFEUX
286f2abc65
FIX: prevents exception when clicking directly on site text 2019-04-29 12:07:30 +02:00
Tim Lange
574f39f9d0 FIX: Fixed uploadPlaceholder regex failing on not escaped characters (#7442) 2019-04-29 12:32:48 +10:00
Joffrey JAFFEUX
6952510fc4
FIX: restores skipHeader computed property 2019-04-26 23:43:49 +02:00
Tim Lange
1486328756 UX: Changed post stream placeholder to animation (#7434) 2019-04-26 17:29:48 +01:00
Joffrey JAFFEUX
bcca2b5d73
FEATURE: initial implementation of generic filters for reports 2019-04-26 12:17:10 +02:00
Maja Komel
4b455e741e DEV: Ember 3.8.0 
Co-Authored-By: majakomel <maja.komel@gmail.com>
 2019-04-26 12:16:21 +02:00
Vinoth Kannan
be0ae2e487 FIX: plain text table detection should work even if html content not found. 2019-04-26 11:16:41 +05:30
Vinoth Kannan
dc2ee78f7a UX: Only do plain text table detection in outside code if HTML pasting enabled 
Co-authored-by: Tim Lange <tim.lange@titanhq.de>
PR: https://github.com/discourse/discourse/pull/7436
 2019-04-26 09:20:21 +05:30
romanrizzi
34b772575e FIX: Return 'failed' attribute when catching an ajax error and the attribute is present 2019-04-25 14:49:52 -03:00
Joffrey JAFFEUX
7cbc4c1e46
FIX: uses no tags label for tag-drop header (#7438) 2019-04-25 13:16:06 +02:00
Joffrey JAFFEUX
e386fa7674
FIX: ensures we have touches when starting pan event (#7435) 2019-04-25 10:36:41 +02:00
Tarek Khalil
d8ff94ecaa
FEATURE: Ignoring users from the preferences page in a cleaner way (#7289) 
* FEATURE: Ignoring users from the preferences page in a cleaner way
 2019-04-25 09:26:49 +01:00
Dan Ungureanu
3aa143a52c
SECURITY: Fix tab nabbing. 2019-04-25 00:11:28 +03:00
Tarek Khalil
e4d8d80cf8
FIX: Make sure we hide the first post in a topic by an ignored user (#7428) 2019-04-24 16:00:20 +01:00
Penar Musaraj
1a8c6577e0 FIX: refactor padding when exiting composer 
Previously, when existing composer, the `#main-outlet` element padding was set to zero. This inline style would override any CSS set for that element, causing issues with the mobile footer nav.

The fix removes the inline padding style instead of setting it to zero. It also uses integers for the set values, and removes a duplicate style.
 2019-04-24 10:26:35 -04:00
Tarek Khalil
ad61d87ffb
FIX: Do not replace text of collapsed ignore posts (#7422) 2019-04-24 13:54:46 +01:00
Penar Musaraj
a452933071 FIX: disable input zoom on search in iOS 2019-04-24 08:41:20 -04:00
Tim Lange
104a9e79f9 UX: User card loading (#7404) 2019-04-24 11:55:09 +03:00
Joffrey JAFFEUX
7334362b77
FEATURE: generic theme component bbcode wrapper (#7400) 
Usage:

```
[wrap=name foo=bar]
hello world
[/wrap]
```
 2019-04-24 10:37:34 +02:00
Bianca Nenciu
b9339e15a1 FIX: Do not track a elements with no href. 2019-04-23 23:13:23 +03:00
Bianca Nenciu
b81d169e2a FIX: Do not track user mentions. 2019-04-23 23:08:00 +03:00
Joffrey JAFFEUX
c99faa6b25
FIX: improves locale support in tag-drop (#7418) 2019-04-23 17:53:59 +02:00
Joffrey JAFFEUX
d4e788c136
FIX: improves share/invite behavior on mobile and especially iOS (#7416) 2019-04-23 17:07:31 +02:00
Tarek Khalil
dc60128355
FIX: Hide ignoring users in preference for users with TL less than a member (#7415) 
* FIX: Hide ignoring users in preference for users with TL less than a member
 2019-04-23 14:47:37 +01:00
Gerhard Schlager
a7bc1ecbae FEATURE: Add support for Unicode usernames and group names 
Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com>
 2019-04-23 13:00:27 +02:00
Bianca Nenciu
1867f2dda0
FEATURE: Always track clicks using AJAX. (#7373) 2019-04-23 12:41:36 +03:00
Dan Ungureanu
c048b71b29
UX: Replace staff notice icon with user-shield. 2019-04-23 10:37:33 +03:00
Guo Xiang Tan
3ac18b92b3 UX: Editing theme name stays active when switching themes. 
* Also fix length of input field.
 2019-04-23 14:57:14 +08:00
Bianca Nenciu
58fe45ffd9 UX: Do not close login modal and search menu on outside mouse up event. (#7366) 2019-04-23 13:01:44 +10:00
Arpit Jalan
a63ef4cfc8
FEATURE: better wizard privacy controls (#7391) 2019-04-22 19:47:29 +05:30
Dan Ungureanu
f112f279ae
UX: Reorder post admin actions for greater consistency. 2019-04-22 10:57:14 +03:00
Guo Xiang Tan
caeb035b61 FIX: Automatic scrolling in PM not working. 
See https://stackoverflow.com/questions/18779708/scrolltop-with-animate-not-working
 2019-04-22 10:52:46 +08:00
Joffrey JAFFEUX
151da50e7c
FIX: prevents exception when the node doesnt exist anymore (#7408) 2019-04-19 18:27:23 +02:00
Dan Ungureanu
57d1dea8a2
FEATURE: Let staff add custom post notices. (#7377) 2019-04-19 17:53:58 +03:00
Joe
b150a57383
UX: don't clip staff shield in user cards (#7398) 2019-04-19 01:53:23 -07:00
Régis Hanol
19905e587b
Revert "UX: Show user card on load (#7380)" (#7403) 
This reverts commit 66789d73c9.
 2019-04-19 10:45:25 +02:00
Tim Lange
66789d73c9 UX: Show user card on load (#7380) 2019-04-19 09:20:03 +02:00
Tim Lange
1d0816b2cf UX: Changed error draft status to icon (#7369) 2019-04-19 09:18:01 +02:00
Kris
cbe7166d87 UX: Move total user count 2019-04-19 00:35:50 -04:00
Robin Ward
85d8d5d092 FIX: Lint 2019-04-18 13:49:28 -04:00
Robin Ward
8e77b4d58e FIX: Replace references to flags in the header with review 2019-04-18 13:25:23 -04:00
Sam Saffron
7068b58e85 PERF: flush topic timings less frequently 
This is a first step of a performance optimisation, more will follow

Previously we did not properly account for previously read topics while
"rushing" marking times on posts.

The new mechanism now avoids "rushing" sending timings to server if all
the posts were read.

Also to alleviate some server load we only "ping" the server with old timings
once a minute (it used to be every 20 seconds)
 2019-04-18 17:31:08 +10:00
Maja Komel
1f17d52f55 UX: new layout for groups page, allow changes to automatic group bio (#7350) 2019-04-17 22:44:30 -04:00
Robin Ward
cd2e93b598 FIX: Show when a post has been deleted in the flag review queue 2019-04-17 16:14:36 -04:00
Joe
ee808dc682
UX: replace lightbox loading text with spinner (#7393) 2019-04-17 10:24:03 -07:00
Dannii Willis
16bfc29164 Move the trend icons on the admin dashboard inside the span (#7367) 
so that it will have the tooltip as well
 2019-04-17 18:11:01 +10:00
Maja Komel
5c795bc480 FIX: prevent anonymous users from changing their email/username/name (#7311) 2019-04-17 18:05:02 +10:00
Gerhard Schlager
7e8579b8aa UX: Add translations for lightbox 2019-04-16 17:03:01 +02:00
Joffrey JAFFEUX
5ec19987b4
FIX: attempts to fix a regression making touchs on emojis less reliable (#7383) 2019-04-16 12:31:33 +02:00
Guo Xiang Tan
347663e852 UX: Switch ellipsis direction when expanding web hook event details. 2019-04-16 14:28:23 +08:00
Robin Ward
3ceff0a92a FEATURE: Send the user a notification when their post is approved 2019-04-15 16:20:16 -04:00
Penar Musaraj
de10bd7fb4 UI: Footer nav fixes 
- moves footer nav to the header on iPads
- disables scrolling events for iPads
- removes footer nav entirely on Chrome PWAs
- toggles DiscourseHub iOS app status bar styling (dark/light) when opening/closing lightboxes and modals
 2019-04-15 15:25:40 -04:00
Robin Ward
fca3044b10 UX: When editing a reviewable, show created_by 2019-04-15 15:11:34 -04:00
Robin Ward
d859e1594e UX: Add a description for scores 2019-04-15 14:21:25 -04:00
Kris
4b74525446 FIX: Group requests page missing wrapper 2019-04-15 14:16:02 -04:00
Penar Musaraj
14eb8eea01 FIX: Prevent input zooming in iOS 
Since enabling pinch-to-zoom in iOS (eae22548de), there was an issue with inputs: Safari auto-zooms inputs with font-size under 16px. Now zooming will be disabled while focus is on an input.

This commit also removes a) a lightbox zoom-enabling event (no longer needed) and b) a comment about iOS zoom issues.
 2019-04-15 13:05:43 -04:00
David Taylor
fd0de64e0d UX: Render wizard previews for high-DPI displays (#7371) 
* UX: Render wizard previews for high-DPI displays

Sets up a canvas element of twice the required dimensions, scales all coordinates by 2x, then shrinks the display in css.

* Use window.devicePixelRatio to determine scale factor
 2019-04-15 16:16:05 +10:00
Tim Lange
00ee68f799 FIX: Fixed category reordering using arrow icons (#7374) 2019-04-15 10:56:21 +10:00
Robin Ward
a5d9afe397 FEATURE: Include a user's pending posts in the topic view 
Also includes a refactor to TopicView's serializer which was not
building our attributes using serializers properly.
 2019-04-12 14:25:12 -04:00
Penar Musaraj
51630b5187 Footer nav tweaks 2019-04-12 12:29:54 -04:00
David Taylor
268d4d4c82
FEATURE: Multiple SCSS file support for themes (#7351) 
Theme developers can include any number of scss files within the /scss/ directory of a theme. These can then be imported from the main common/desktop/mobile scss.
 2019-04-12 11:36:08 +01:00
Dan Ungureanu
0e9a0a31f5
FIX: Show email for staged users in user cards. (#7354) 2019-04-12 12:50:43 +03:00
Sam Saffron
9bd3afda5d FIX: display conextual count on favicon if selected 
This also corrects the test suite and moves the two notification counts
so they are closer together.
 2019-04-12 10:04:23 +10:00
David Taylor
24ef4f7b2b Remove support for disable_jump_reply user setting (#7359) 2019-04-12 09:03:06 +10:00
David Taylor
dc703adad7 FEATURE: Add user preference for title counter mode (#7364) 2019-04-12 09:02:18 +10:00
Penar Musaraj
60db57acc0 Make Prettier happy 2019-04-11 14:15:47 -04:00
Penar Musaraj
f060c9b3ff UI: improvements to footer nav for app and PWAs 
Adds support for iPad and Chrome PWAs

Better scroll direction logic when reaching bottom of the page
 2019-04-11 14:11:26 -04:00
Robin Ward
331a809738 FEATURE: Display the reason for many reviewable items 
Queued Posts and Users will now display a reason why they are in the
review queue.
 2019-04-11 12:04:45 -04:00
Arpit Jalan
7143572e0c
FIX: correctly retrieve 'login required' setting value on wizard (#7355) 
* FIX: correctly retrieve 'login required' setting value on wizard

FEATURE: extract 'invite only' setting in a separate checkbox control

* Update invite_only checkbox locale on wizard.

Co-Authored-By: techAPJ <arpit@techapj.com>
 2019-04-11 20:25:08 +05:30
Tim Lange
9a428acce4 UX: Switched composer draft saving to animations (#7356) 2019-04-11 10:03:36 -04:00
Joffrey JAFFEUX
7226240df3
UX: full revamp of local-dates form (#7357) 2019-04-11 11:14:34 +02:00
Kris
abd34882d5 UX: Better organization of category settings 2019-04-10 23:00:31 -04:00
Dan Ungureanu
7a7c6af21e
FIX: Fallback to last post when the in-view post cannot be detected. 
In certain situations the detection method fails. For example, it fails
for a topic containing: a long post (~1600px height), gap, small action
(focus on this), hidden reply.
 2019-04-11 01:14:59 +03:00
Kris
689c7f5410 Minor reviewable alignment fixes 2019-04-10 14:22:46 -04:00
Kris
1b6f18396b UX: Simplify merged reviewable table 2019-04-10 13:22:28 -04:00
Tim Lange
fe9c271d44 FIX: Fixed deleted posts layout (#7348) 2019-04-10 19:00:39 +02:00
Penar Musaraj
eae22548de
Footer navigation for iOS PWAs and DiscourseHub app (#7347) 2019-04-10 12:23:18 -04:00
Roman Rizzi
536b90e0ef
FEATURE: Support searching custom staff actions (#7346) 2019-04-10 09:53:17 -03:00
Tarek Khalil
442fb2facb FEATURE: Remove ignore feature SiteSetting and enable ignore by default (#7349) 2019-04-10 12:54:59 +02:00
Roman Rizzi
82e051077d Show link to the original topic when it was deleted (#7319) 
* Moved i18n keys to core. We show a links that points to the original topic when it was deleted

* Use link-to since it's more idiomatic
 2019-04-10 11:25:45 +02:00
Bianca Nenciu
b5008586c5 DEV: Remove HTML parser from Tautologistics. (#7344) 2019-04-10 11:21:22 +02:00
Sam Saffron
88f8c9f43e FIX: when banner is removed update all clients 
Previously removing a banner raised a null "banner" in the message bus
channel.

Then Ember.Object.create would fail cause it always expects an object in
constructor.
 2019-04-10 15:59:29 +10:00
Kris
df85d4593e UX: Unify admin intro styles for badges/customize, improve mobile 2019-04-09 20:32:24 -04:00
Robin Ward
9ebfdaa356 UX: Unify reviewable scores + history 2019-04-09 16:43:08 -04:00
Kris
8e9d0ceb67 UX: Mobile - fix editor button space, divider, extra upload icon 2019-04-09 13:15:31 -04:00
Tarek Khalil
307499e48b FIX: Keep highlighted text for quoted replies by ignored users (#7345) 2019-04-09 17:33:12 +02:00
Robin Ward
4552d86605 FIX: Broken tests 2019-04-09 08:33:10 -04:00
Joffrey JAFFEUX
a89c90ed5d
FIX: removes link to old dashboard (#7341) 2019-04-09 09:24:41 +02:00
Vinoth Kannan
f0f659286f UX: move up profile picture field next to the username 2019-04-09 11:46:03 +05:30
Robin Ward
bc949cf684 FIX: Display the username instead of {{username}} 2019-04-08 16:46:05 -04:00
Robin Ward
32a0346069 UX: Don't show the username of the first user in the conversation 2019-04-08 16:39:53 -04:00
Robin Ward
cc53f902c6 FIX: Missing translation key for Reviewable -> Deleted 2019-04-08 16:12:41 -04:00
Robin Ward
0fc798c2ef UX: Show the score status 
If a review review score has been Approved/Rejected/Ignored then show it
 2019-04-08 12:08:18 -04:00
Tarek Khalil
5957991340 FIX: Remove quoted post text and block realtime replies from ignored users (#7336) 2019-04-08 17:44:42 +02:00
Tarek Khalil
02394e9170
FIX: assign decoratorHelper (#7338) 2019-04-08 16:17:09 +01:00
Joffrey JAFFEUX
9d2e2867cc
s/fa-icon/d-icon (#7337) 2019-04-08 15:51:38 +02:00
Tarek Khalil
0d2a1fce51
REFACTOR: Pass down currentUser to post-cooked widget (#7333) 
* REFACTOR: Pass down `currentUser` to `post-cooked` widget
 2019-04-08 14:50:53 +01:00
David Taylor
f524f8f811
Remove Yahoo login support from core and deprecate OpenID2.0 (#7310) 
- Plugin developers using OpenID2.0 should migrate to OAuth2 or OIDC. OpenID2.0 APIs will be removed in v2.4.0

- For sites requiring Yahoo login, it can be implemented using the OpenID Connect plugin: https://meta.discourse.org/t/103632

For more information, see https://meta.discourse.org/t/113249
 2019-04-08 10:38:25 +01:00
Vinoth Kannan
ca57e18f42 UX: display signup cta even if 'must_approve_users' setting enabled. 2019-04-08 12:27:56 +05:30
Guo Xiang Tan
33fa249fa5 SECURITY: Remove XSS in composer preview when applying image scale buttons. 2019-04-08 11:22:14 +08:00
Robin Ward
a6f283da30 UX: Show tags on flags too 2019-04-05 14:22:45 -04:00
Régis Hanol
06e3b25d04
FIX: 'currentUser' is a property of the 'widget' 2019-04-05 18:43:04 +02:00
Robin Ward
b005a84530 FIX: decoratorHelper.widget is not always present 2019-04-05 12:07:24 -04:00
Kris
acce7330a3 Typo fix 2019-04-05 11:23:22 -04:00
Kris
43a905279f FIX: Layout was off in single-page user-preferences 2019-04-05 10:59:52 -04:00
Robin Ward
cbc311e4ed UX: Update the reviewable count before the message bus 
In certain edge cases, the message bus won't send the message to the
user about the updated review count and it can go out of sync.

This patch synchronizes the review count every time:

1. The user visits the "Needs Review" page

2. Every time the user performs an action
 2019-04-05 10:35:38 -04:00
Tarek Khalil
19a1d35f66
fix linting (#7329) 2019-04-05 15:28:41 +01:00
Tarek Khalil
131eba0366 FIX: Hide post replies content for ignored users (#7320) 2019-04-05 16:13:36 +02:00
Joffrey JAFFEUX
0bd480c600
UX: displays exact date on title attribute of topic timer info (#7326) 2019-04-05 09:44:10 +02:00
Angus McLeod
6f1652bb53 add header cloak after all panels are added (#7325) 2019-04-04 22:54:05 -07:00
Robin Ward
aa4a38b08a FIX: computed is not used 2019-04-04 17:38:27 -04:00
Neil Lalonde
83996fc8ea FEATURE: ability to restrict some tags to a category while allowing all others 
A new checkbox has been added to the Tags tab of the category settings modal
which is used when some tags and/or tag groups are restricted to the category,
and all other unrestricted tags should also be allowed.
Default is the same as the previous behaviour: only allow the specified set of
tags and tag groups in the category.
 2019-04-04 16:40:15 -04:00
Kris
9faebfcfe0 UX: Adjust layout, allow additional responsiveness 2019-04-04 16:20:25 -04:00
Robin Ward
dd5b8bd85e FIX: Show replies to the post, not the topic 
This makes more sense when reviewing. How many people replied to this
objectionable thing?
 2019-04-04 15:13:59 -04:00
Robin Ward
9c8cc73c39 UX: Show user fields when reviewing a user 2019-04-04 14:45:40 -04:00
Robin Ward
a5182b0d6c FIX: Rewrite old /admin/flags links to use the review queue 
Such links might be in present in old PMs. For example, a notification of
outstanding flags.

New PMs should receive the correct link but this prevents 404s in the
other case.
 2019-04-04 10:15:23 -04:00
Bianca Nenciu
63fcd445f4 FIX: Use unfiltered URL when viewing all badges. 2019-04-04 12:35:03 +03:00
Robin Ward
a4ff593506 UX: Slightly improved reviewable user display, plus link to admin if possible 2019-04-03 17:07:48 -04:00
Robin Ward
111a502231 FIX: Deleting Users should work nicely with Reviewable Users 
"Rejecting" a user in the queue is equivalent to deleting them, which
would then making it impossible to review rejected users. Now we store
information about the user in the payload so if they are deleted things
still display in the Rejected view.

Secondly, if a user is destroyed outside of the review queue, it will
now automatically "Reject" that queue item.
 2019-04-03 16:42:39 -04:00
Joffrey JAFFEUX
974007a3cc
FIX: reverts href removal from user/group cards links (#7318) 2019-04-03 19:16:48 +02:00
Bianca Nenciu
bb2005d466 FIX: Add more links to bandge cards. 2019-04-03 18:37:11 +03:00
Robin Ward
62956003c3 FEATURE: Allow users to customize bonuses for reviewable types 
A new settings section in the review queue allows admins to specify that
certain types of flags should be weighted higher than others.
 2019-04-03 11:18:34 -04:00
Bianca Nenciu
1e1adb1afa FIX: Links in badge summary were not clickable. (#7303) 2019-04-03 11:35:27 +02:00
Maja Komel
d32aaf374e UX: add awaiting-approval class to login modal 
when local logins are disabled and account is awaiting approval
 2019-04-03 11:30:43 +02:00
Guo Xiang Tan
d1fa2b71cf FIX: Letters between words incorrectly highlighted within post. 2019-04-03 15:57:51 +08:00
Kris
14cbbc5e13 UX: Reviewables fixes 2019-04-02 16:25:53 -04:00
Penar Musaraj
44fe2eec03 Better fix for Safari user card position 
Better than a2c6683e3b
 2019-04-02 15:36:47 -04:00
Kris
ba727b2875 UX: Restructure queued posts to match flags, fix text 2019-04-02 14:54:55 -04:00
Kris
2ab6eb58c5 UX: Reviewable layout improvements 2019-04-02 13:51:03 -04:00
Penar Musaraj
15e27d9e2c Prettier fix 2019-04-02 11:56:21 -04:00
Joffrey JAFFEUX
40e1ba9d9a
FIX: ensures click on emoji in picker doesnt propagate (#7308) 2019-04-02 17:40:13 +02:00
Joffrey JAFFEUX
d8dd130477
UX: gives aria-label to topics count in category-row (#7307) 2019-04-02 17:38:21 +02:00
Joffrey JAFFEUX
e77b1cf7ff
UX: ensures only <li> are used as top level in breadcrumb (#7306) 2019-04-02 17:37:53 +02:00
Penar Musaraj
a2c6683e3b FIX: inconsistent user card position in Safari 
User cards triggered in header were incorrectly positioned in Safari desktop.

Using `position()` instead of `offset()` is more consistent, since header is a fixed element in this scenario.
 2019-04-02 10:32:50 -04:00
Arpit Jalan
d68d29f37a FIX: only staff can banner topics 2019-04-02 12:46:55 +05:30
Tim Lange
a9a35d2c19 FIX: Uncategorized pm not allowing edit (#7276) 2019-04-02 12:54:53 +08:00
Guo Xiang Tan
4175de5071 UX: Wrap title on search log term page with a proper div. 
Search log filter selector was not floating right as it should.
 2019-04-02 11:55:57 +08:00
Guo Xiang Tan
1a9452f24d UX: Pass period params when looking at search logs for a given term. 2019-04-02 11:51:41 +08:00
Kris
9603c906ec Moving staff counters back to the top of profiles 2019-04-01 21:04:37 -04:00
Robin Ward
6470c85fda UX: Link directly to the post, not to the topic 2019-04-01 14:29:14 -04:00
Penar Musaraj
fdf4145d4b
FEATURE: Delegated authentication via user api keys (#7272) 2019-04-01 13:18:53 -04:00
Joffrey JAFFEUX
13a6a04cad
FIX: ensures popover is hidden when changing route (#7300) 2019-04-01 16:23:57 +02:00
Joffrey JAFFEUX
4b1b135ede
FIX: handles boolean with popupMenuOption (#7299) 
Handle the case of https://github.com/discourse/DiscoTOC doing this kind of setup:

```
return {
    action: "insertDtoc",
    icon: "align-left",
    label: themePrefix("insert_table_of_contents"),
    condition: !composerController.get("model.canCategorize")
  };
```

In this case there's no function to call, it's already set.
 2019-04-01 16:08:14 +02:00
Joffrey JAFFEUX
e986e96227
DEV: removes old dashboard (#7295) 2019-04-01 12:39:49 +02:00
Joe
541a15e357 UX: user-card adjustments for users with hidden profiles (#7293) 
* adds styles for profile hidden message

* Disable profile links for hidden profiles and add message to indicate the profile is hidden
 2019-04-01 10:50:48 +02:00
Dan Ungureanu
d59abff2d8
UX: Always use relative age for post notices. 2019-03-31 18:07:05 +03:00
Joe
8b8d528b88 Hide mobile cards when user scrolls (#7291) 2019-03-31 11:16:52 +02:00
Robin Ward
c0780434f8 FIX: Better display if the topic is deleted 2019-03-29 16:59:00 -04:00
Robin Ward
a55e7ebe8f UX: Better display for deleted users in the review queue 2019-03-29 16:52:58 -04:00
Robin Ward
67454c71c9 FIX: Missing translations for agree/disagree details 2019-03-29 14:14:59 -04:00
Kris
814aee343b UX: Minor profile page restructure 2019-03-29 12:52:42 -04:00
Tim Lange
2c4b3c21a9 UX: Unified emoji escape regex 2019-03-29 12:17:11 -04:00
Bianca Nenciu
31053f30de FEATURE: Let users delete their own topics. (#7267) 2019-03-29 17:10:05 +01:00
Tarek Khalil
d26d1b387e
FEATURE: Add ignore duration selection for user notifications preferences page (#7269) 
* FEATURE: Introducing new UI for tracking User's ignored or muted states
 2019-03-29 13:33:08 +00:00
Tarek Khalil
b1cb95fc23
FEATURE: Introduce ignore duration selection (#7266) 
* FEATURE: Introducing new UI for tracking User's ignored or muted states
 2019-03-29 10:14:53 +00:00
Guo Xiang Tan
a6d93f6317 FIX: Avoid error on ajax.abort() when client has not opened the request. 2019-03-29 15:38:38 +08:00
Guo Xiang Tan
8cfd887f33 Make eslint happy. 2019-03-29 12:59:40 +08:00
Guo Xiang Tan
4fa8fe575b UX: Use a step size of 1. 
Follow up to 634a213e6d.
 2019-03-29 12:14:11 +08:00
Guo Xiang Tan
634a213e6d FIX: Admin chart y axis labels being rounded up/down when value is small. 2019-03-29 12:03:41 +08:00
Guo Xiang Tan
e2ad374e5b UX: USe bar chart for admin search logs details page. 
A bar chart is better when comparing the values across the X axis.
 2019-03-29 11:54:49 +08:00
Guo Xiang Tan
947495e70d Follow up to 8c2fa99f78. 
`/search_logs/term?term` is alittle weird looking but unless we add
proper slug support to term, we're going to have to live with this
first.
 2019-03-29 10:39:44 +08:00
Guo Xiang Tan
c42df7ddd7 UX: Use the same default period for search logs index and term. 
If the period is different, clicking through to view a term is confusing
because a different period will show a different set of stats.
 2019-03-29 09:59:28 +08:00
Guo Xiang Tan
8c2fa99f78 FIX: Remove :term from admin/search_logs/term/:term route. 
Search log terms is a string that can contain characters like `/` which
messes with the route.
 2019-03-29 09:48:20 +08:00
Guo Xiang Tan
c836d67cac UX: Collapse advanced search on mobile when searching. 
On smaller mobile devices, the height of the advanced search filters takes up
the whole real estate that it requires the user to scroll down
significantly in order to view the results.
 2019-03-29 08:59:02 +08:00
Robin Ward
3660b85614 FIX: Regressions in JS test suite 2019-03-28 14:15:52 -04:00
Robin Ward
8c98c18c2b FIX: Remove old flagging scss, fix more linting 2019-03-28 13:48:35 -04:00
Robin Ward
7ec74afc43 FIX: Lint on JS 2019-03-28 13:36:30 -04:00
Robin Ward
b58867b6e9 FEATURE: New 'Reviewable' model to make reviewable items generic 
Includes support for flags, reviewable users and queued posts, with REST API
backwards compatibility.

Co-Authored-By: romanrizzi <romanalejandro@gmail.com>
Co-Authored-By: jjaffeux <j.jaffeux@gmail.com>
 2019-03-28 12:45:10 -04:00
Gerhard Schlager
d43f4206c7 FEATURE: Add Armenian language 2019-03-28 14:24:14 +01:00
Tim Lange
1b0267b077 FIX: Switching composer action shouldn't trigger abandon popup (#7261) 2019-03-27 21:55:09 +01:00
David Taylor
0d3531c2f1 FEATURE: Allow auth providers to define specific icons 
Previously we relied on the provider name matching the name of the icon. Now icon names are explicitly set. Plugin providers which do not define an icon will get the default "sign-in-alt" icon
 2019-03-27 13:25:04 +00:00
Bianca Nenciu
a9798f0c47
FEATURE: Add page for all group membership requests. (#6909) 2019-03-27 13:30:59 +02:00
Tarek Khalil
ef2362a30f
FEATURE: Introducing new UI for changing User's notification levels (#7248) 
* FEATURE: Introducing new UI for tracking User's ignored or muted states
 2019-03-27 09:41:50 +00:00
Joffrey JAFFEUX
675d950eab
FIX: corrects link to moderators_activity report (#7265) 2019-03-27 10:14:42 +01:00
Gerhard Schlager
de011b53b5 UX: Hide link to incoming email when there is no bounce key 
For example, webhooks mark email log entries as bounced without there ever being an incoming email.
 2019-03-26 18:00:27 +01:00
Joffrey JAFFEUX
b2cacc5b0e
FIX: check can_create_tags on mini-tag-chooser as tag-chooser (#7260) 2019-03-26 16:45:38 +01:00
Joffrey JAFFEUX
8fb63b2706
FEATURE: unified popover implementation (#7244) 2019-03-26 15:43:27 +01:00
Maja Komel
3aa32c3170 FIX: send only one post request when changing topic notification level (#7254) 2019-03-26 12:04:33 +01:00
Guo Xiang Tan
e0cb2a434a Fix regression introduced in dae0bb4c67. 
Add tests so it doesn't bite me again.
 2019-03-26 17:52:37 +08:00
Guo Xiang Tan
dae0bb4c67 FIX: Post blurb incorrect when search contains a phrase match. 
If the blurb generated is not around the search term, we will not be
able to highlight it on the client side.
 2019-03-26 17:01:52 +08:00
Penar Musaraj
47a0e4b906 UX: improve mobile search 
Improves usability of header search icon while user is already in full page search in mobile.

Currently, hitting search icon a second time empties input and does not scroll up to show search form.

This commit scrolls up to show form and sets focus on input.
 2019-03-25 14:42:54 -04:00
Kris
df279251b7 REFACTOR: More consistent user/group page layouts 2019-03-25 14:40:22 -04:00
Gerhard Schlager
60e6070c27 UX: Show spinner during text replacement 2019-03-25 16:47:55 +01:00
Joe
ec2123809f FEATURE: user and group cards on mobile (#7246) 2019-03-25 13:37:17 +01:00
Bianca Nenciu
f072da1bfe
FEATURE: Add every month / 6 months options to email digest. (#7247) 2019-03-25 12:45:01 +02:00
Tim Lange
dcd56cf593 FIX: Fixed changing composer mode escaping title (#7191) 2019-03-25 13:14:26 +05:30
Guo Xiang Tan
ac661e856a
FEATURE: Allow categories to be prioritized/deprioritized in search. (#7209) 2019-03-25 10:59:55 +08:00
Guo Xiang Tan
ce75e30bf5 UX: Indent category badges to indicate sub-categories. 2019-03-25 10:36:29 +08:00
Tim Lange
da187f0967 FIX: Clear unsaved groups when switching user (#7236) 2019-03-22 12:46:36 +01:00
tshenry
48d0465f72 FEATURE: Improve avatar education link (#7240) 
* Make profile_path more direct to setting

* Add id to profile picture setting for easy linking
 2019-03-22 02:20:48 -07:00
Sam Saffron
68fe6b8d53 FIX: suppress autocomplete on group filter 2019-03-22 17:02:04 +11:00
Guo Xiang Tan
7aab7e9062 Revert "UX: Don't reload page after saving settings when editing category." 
This reverts commit dd142eec03.

We need a fully reload when reordering.
 2019-03-22 13:10:30 +08:00
Osama Sayegh
67b96ad2ff FIX: discourse client should know about Logster (simpler approach) (#7237) 
* Revert "FIX: discourse client should know about Logster (#7232)"

This reverts commit bfcbc4d2d6.

* FIX: discourse client should know about Logster (simpler approach)
 2019-03-22 08:48:57 +11:00
Régis Hanol
e1e46f0dff FIX: topic with no tags 2019-03-21 19:40:10 +01:00
Maja Komel
1f1d3909e5 UX: add more tag classes to topic view (#7228) 
adds tag classes where there is already category-* class
 2019-03-21 17:49:50 +01:00
Maja Komel
34730a0b16 UX: show if webhook is disabled (#7217) 
+ show in staff logs when webhook is created/updated/destroyed
 2019-03-21 16:13:09 +01:00