Sam
2cd95bc649
lets try out annotations
2013-05-24 12:35:14 +10:00
Robin Ward
eb0c102931
Migration logic from SearchView to a controller, where it should be.
2013-05-23 17:42:57 -04:00
Robin Ward
9d0e830786
Search code now uses ActiveRecord instead of SQL.
2013-05-23 16:26:51 -04:00
Konrad Borowski
8bc4264c98
Thread title fixer should ignore special cases like iLetter
2013-05-23 21:31:08 +02:00
Robin Ward
8e8d9af2bf
Use classes instead of a complicated nested hash for search results
2013-05-23 12:44:47 -04:00
Robin Ward
0bd61df34c
Merge pull request #884 from mattvanhorn/refactor_topic
...
Refactor topic
2013-05-23 07:26:22 -07:00
Matt Van Horn
806255b3c4
refactor Topic validation
...
introduce a couple of custom validators
fix minor discrepancies in tests
copy I18n error message keys to default location
clean up validation invocation
move some responsibilities out of validator into class
2013-05-22 22:31:52 -07:00
Sam
fcc7192fd2
User tracking state implementation progress for live unread / new counts
2013-05-23 15:22:06 +10:00
Robin Ward
7a31630837
Search Refactor: Remove some manual SQL, make search data tables more idomatic Rails/AR
2013-05-22 16:31:13 -04:00
Robin Ward
b9a310f4b1
Search Refactor: Let's use a class to keep track of our state rather
...
than passing params everywhere. Also make the private API private.
2013-05-22 15:22:06 -04:00
Matt Van Horn
872995db57
refactor guardian class for clarity & correctness
...
introduce NullUser to avoid type-checking
DRY up code
reduce number of multiple returns
remove some redundant/impossible logic branches
add pending test for possible bug
add test & fix for ability to flag archived posts
add #secure_category? method to topic class
Fix bug that prevented flagging of archived topics
Rename NullUser to AnonymousUser
DRY up can_<action>? methods
Fix some ownership logic, and a test, for Guardian
2013-05-22 01:09:34 -07:00
Sam
da6a88634b
improve best filter so it properly excludes all admin messages from count as well
2013-05-22 15:14:47 +10:00
Sam
c4d8085fc5
remove moderator status posts from best feed
2013-05-22 15:04:53 +10:00
Robin Ward
27828c5ec2
Merge pull request #871 from avdi/refactoring-with-josh-and-avdi
...
Various refactorings towards Ruby/Rails idiom from Josh Susser and Avdi Grimm
2013-05-21 07:18:50 -07:00
Sam
b5eff93a9d
update message bus to support per client filtering
...
start work on user_tracking_state
fix can_ban? in guardian
expose protected scopes on topic_query we need
move guardian spec to use build as opposed to creating topics / posts / users
start work on user tracking spec
2013-05-21 16:39:51 +10:00
Sam
559c1e52aa
protect against crash in prd
2013-05-21 10:08:33 +10:00
Sam
e91ed83586
the private message stream is different to normal streams, improving the ui a bit and collapsing conversations
2013-05-20 16:44:06 +10:00
Sam
b9c4bf9870
I fixed the multithreading issue with connection management a while back, remove mutex, it only slows down job processing
2013-05-20 10:31:17 +10:00
Sam
80fb20816c
get rid of nonsense 404.html
...
correct 404 handling for invalid pages
2013-05-20 10:29:49 +10:00
Sam
24c997966e
Merge pull request #861 from sanderdatema/post_creator
...
Set created_at manually through PostCreator
2013-05-19 16:34:45 -07:00
Sam
e068edf362
Merge pull request #860 from chrishunt/chrishunt/page-out-of-range
...
Show posts for last page when page out of range
2013-05-19 16:33:57 -07:00
Sam
ceddb6e0da
fix bug where non-multisite environment would run out of connections
2013-05-20 00:23:10 +10:00
Chris Hunt
c2a4f16f24
Show posts for last page when page out of range
2013-05-18 13:11:01 -07:00
Sander Datema
286a06bd4e
Set created_at manually through PostCreator
2013-05-18 21:24:29 +02:00
Chris Hunt
9c092366e0
Add explicit 'spec' rake tasks
...
This doesn't require auto-loading of rspec-rails and puts the 'spec'
task in the rake task list (rake -T)
2013-05-17 16:02:43 -07:00
Josh Susser and Avdi Grimm
5659b66729
Refactor select().map() to use pluck.
...
Remove a method already provided by ActiveRecord.
2013-05-17 15:11:37 -04:00
Neil Lalonde
f3282e33a3
Add tabs to category create/edit modal. Categories can have a default auto-close setting that applies to all new topics created in the category. Add rspec-given and write some integration tests. Tests for topic auto-close with category default
2013-05-17 11:05:35 -04:00
Sam
8f46653345
refactor
2013-05-17 09:03:52 +10:00
Robin Ward
d554a59102
Support for a new site setting: newuser_spam_host_threshold. If a new user posts a link
...
to the same host enough tiles, they will not be able to post the same link again.
Additionally, the site will flag all their previous posts with links as spam and they will
be instantly hidden via the auto hide workflow.
2013-05-16 12:19:50 -04:00
Sam
04b8cd5c95
consistency check, need to also ensure delete cleans stuff up, maybe make notifications trashable
2013-05-16 17:50:14 +10:00
Sam
8b63c82f64
Merge pull request #852 from avdi/avoid-exceptions-for-flow-control
...
Replace exceptions for flow control with idiomatic throw/catch
2013-05-15 22:27:33 -07:00
Josh Susser and Avdi Grimm
c793684d4c
Replace exception used for flow control with idiomatic throw/catch.
2013-05-16 01:19:34 -04:00
Avdi Grimm
9acc0cd678
Replace exception used for flow control with idiomatic throw/catch.
2013-05-16 01:19:34 -04:00
Sam
8ac1d17c6f
Merge pull request #846 from ZogStriP/fix-onebox-link-target-is-discourse-instance
...
FIX: Onebox link target is discourse instance
2013-05-15 22:19:22 -07:00
Sam
e9ebadb414
Nuke message_bus_observer move to service class and classes
...
Secure all messages triggered by post creation and all user actions so they don't leak
(meaning, if you have a browser open and secure topics are created you will only get them if you are allowed to see them)
2013-05-16 15:03:16 +10:00
Robin Ward
b1bfda0e11
Don't show new user education when editing a reply.
2013-05-15 15:16:42 -04:00
Neil Lalonde
2df46a9d0a
Show a more useful message when redis config can't be found during init.
2013-05-15 10:08:08 -04:00
Régis Hanol
336d59391e
FIX: Oneboix link target is discourse instance
...
This is the quickest fix to get Techcrunch oneboxing working.
The right fix would be to update the oembed onebox to work properly for the "link" type.
2013-05-13 23:12:05 +02:00
Robin Ward
fff46cf5aa
Can search by URL or ID
2013-05-13 17:07:58 -04:00
Robin Ward
be234ce9b9
You can now 'move' the first post of a topic to another topic as a merge. In that
...
case, the first post is cloned instead of being deleted from the original topic.
2013-05-13 14:07:31 -04:00
Neil Lalonde
9828c87525
Topic Auto-Close: admins and mods can set a topic to automatically close after a number of days
2013-05-13 12:53:52 -04:00
Sam
b6bf95e741
speed up startup (avoid loading some gems on startup)
...
correct group permission leaks
add Discourse.cache for richer caching support
2013-05-13 18:04:03 +10:00
Sam
9b33e826f2
clear flags on reply to notify moderators
2013-05-13 11:48:01 +10:00
Sam
30501e943c
fix search
2013-05-13 11:07:21 +10:00
Neil Lalonde
ba8d40d24b
Version bump to v0.9.0
2013-05-10 15:31:53 -04:00
Robin Ward
cf01c98d81
Experimental: Interface to Move Posts to an Existing Topic
2013-05-10 14:55:51 -04:00
Régis Hanol
297680c28d
FIX: pinned topic excerpt is not properly truncated
2013-05-10 12:28:17 +02:00
Sam
5280b3a01b
more group progress, UI getting there, controller mostly done
...
changed it so notify moderators goes to the moderators group
allow admins to grant self moderation and revoke self moderation
2013-05-09 17:37:34 +10:00
Sam
0f0fd281a8
group progress, never email banned users
2013-05-09 11:34:58 +10:00
Neil Lalonde
f35a44aeae
Add ability for admins and mods to send another activation email to a user, to activate an account, and deactivate an account
2013-05-08 10:10:47 -04:00
Sam
6b536dcde5
work in progress ... groups
2013-05-08 15:20:38 +10:00
Sam
381c42724f
comments
2013-05-07 14:50:02 +10:00
Sam
066c2bed42
better comments
2013-05-07 14:46:46 +10:00
Sam
e9fc272db7
remove acts_as_paranoid, use .trash! , .recover! and .with_deleted as needed
...
makes upgrading to rails 4 possible
2013-05-07 14:39:01 +10:00
Sam
b0945599b7
enter will either run all specs or tell you which failed
2013-05-06 15:16:53 +10:00
Sam
be1ab8b275
automatic group infrustructure
2013-05-06 14:49:56 +10:00
Sam
d4a0d4f5dd
Merge pull request #814 from ZogStriP/keep-reloaders-happy
...
prevent warning message about already defined constants
2013-05-05 17:52:22 -07:00
Sam
caa3cae535
remove pointless to_sym
2013-05-06 09:51:09 +10:00
Michael Witrant
6018c2f98b
use symbols in redis proxy methods
2013-05-05 15:58:37 +02:00
Michael Witrant
2031b69e6e
use method name instead of __method__ (which is wrong in this situation on Debian Squeeze Ruby 1.9)
2013-05-05 13:34:54 +02:00
Régis Hanol
bda04664b0
prevent warning message about already defined constants
2013-05-04 01:06:05 +02:00
Neil Lalonde
74a238b7e9
Version bump to v0.8.9
2013-05-03 16:42:29 -04:00
Sam
3eab0be4a8
deleting posts as an admin was bust
2013-05-03 17:56:23 +10:00
Sam
5ec52bd2e9
:s/moderator?/staff/g ... our naming was kind of crazy, renamed moderator? to staff
2013-05-02 17:22:27 +10:00
Sam
65cd00cf25
moderators now have teeth, more at http://meta.discourse.org/t/moderator-permission-set/6307/5
...
allow pms to be targetted at groups
2013-05-02 15:15:53 +10:00
David Celis
6be26f5316
Update to Imgur API v3
...
Version 2 of Imgur's API is deprecated. Their documentation for v2 is no
longer online, and applications can only be registered under version 3.
Version 3 of their API has a slightly different endpoint but, more
importantly, uses a Client ID/Secret pair instead of an API Key.
This PR updates Discourse to use the new version of Imgur's API.
Signed-off-by: David Celis <me@davidcel.is>
2013-05-01 21:39:10 -07:00
Neil Lalonde
5f4dbd6ddc
Use tos_url site setting in flag modal if it's set
2013-05-01 11:49:18 -04:00
Sam
e4a76812a6
this is a slightly round about way of making our self oneboxes sane
...
shrunk avatar to 60px, added global whitelisting
2013-05-01 16:38:13 +10:00
Sam
fc07fcbd9d
oops
2013-05-01 10:34:22 +10:00
Sam
8b419794f9
added option to force polling instead of messing with the detection
2013-05-01 10:29:39 +10:00
Sam
2c4bd484af
vagrant detection attempt
2013-05-01 10:04:47 +10:00
Neil Lalonde
ea5d86a533
Remove imdb onebox for legal reasons
2013-04-30 11:59:22 -04:00
Sam
acc4f73ba0
very subtle, autospec was not using inotify if guard was already running
2013-04-30 22:54:52 +10:00
Sam
b25a5a20bb
option to strip links from excerpts
2013-04-30 13:25:55 +10:00
Sam Saffron
94a578e4b2
ignore assets
...
fix runner so it works on mac
get rid of some test warnings
2013-04-30 12:43:59 +10:00
Neil Lalonde
6e48f5afbe
Version bump to v0.8.8
2013-04-29 17:55:27 -04:00
Neil Lalonde
ba93220e2a
Merge pull request #788 from PabloC/master
...
Fix to add Slideshare's URL to oneboxer's whitelist
2013-04-29 11:24:03 -07:00
Pablo Corral
d27164f045
fix to add slideshare to the whitelist
2013-04-29 19:42:52 +02:00
Neil Lalonde
eb151d440b
Don't call discourse hub during user destroy if hub integration is disabled
2013-04-29 11:39:05 -04:00
Pablo Corral
2ff244a7ca
new oneboxer for Slideshare
2013-04-29 15:31:29 +02:00
Sam
5cfcdc7ef0
backend for secure categories mostly done (todo pm groups)
2013-04-29 16:33:43 +10:00
Ryan Boland
9bc8faeaf2
added rottentomatoes.com onebox
2013-04-28 16:24:03 -04:00
Sam
a6d2c9db03
Merge pull request #776 from jroes/use-oj
...
Use oj for json encoding
2013-04-28 00:42:10 -07:00
Jon Roes
abfcb93904
use oj for json encoding
2013-04-26 21:45:53 -04:00
Sam
b82e408351
add list unsubscribe
2013-04-26 16:56:28 +10:00
Sam
7d9fd350d3
dup is critical cause people are mucking with stuff that comes out of the cache
2013-04-26 16:18:55 +10:00
Sam
5ccc3edcbe
bug fixes with test runner
2013-04-26 16:18:54 +10:00
Sam
eb085beea8
attempt to fix the UTF-8 warn in the log, turns out this runs really deep, when you hit deliver in test it clones the mail not setting charset properly, leaving as is for today but fixing prod at least
2013-04-26 16:18:54 +10:00
Sam
9cf03b352c
fix rspec runner for neil
2013-04-26 16:18:54 +10:00
Neil Lalonde
e864e4141d
Fix topic_count in version check request
2013-04-25 17:19:06 -04:00
Sam
7abdd61354
truncate gist titles at 120
2013-04-25 18:00:02 +10:00
Sam
ef875bba12
a spec that works like the fsm intended
2013-04-25 17:24:54 +10:00
Neil Lalonde
2310851ad2
Send topic_count with version check requests
2013-04-24 14:13:20 -04:00
Neil Lalonde
e6ad51adce
Send contact_email along with version check
2013-04-24 12:55:01 -04:00
Sam
27edebfaef
This patch probably belongs in AR discussing with rails team
2013-04-24 14:40:55 +10:00
Sam
737bb96737
translation accelerator
2013-04-24 14:40:09 +10:00
Sam
c9ed7100b1
bug fix
2013-04-24 12:26:39 +10:00
Sam
0b76166ad1
inflector backport
2013-04-24 12:02:36 +10:00
Neil Lalonde
631ed3df58
Checking size of some gifs throws a Zlib::BufError. Tolerate it until we can figure out why.
2013-04-23 14:08:05 -04:00
Neil Lalonde
2e8e4b7c6e
Don't send an email for a topic that has been deleted
2013-04-23 13:10:11 -04:00
Neil Lalonde
439877bdb9
Show a warning if there are email jobs in the retry queue
2013-04-22 13:37:16 -04:00
Neil Lalonde
82b03a1661
Version bump to v0.8.7
2013-04-19 17:33:33 -04:00
Jeff Atwood
0cd7c592ec
remove HTML from amazon byline
2013-04-19 13:45:22 -07:00
Jeff Atwood
ec0525ff37
add HTG to the onebox opengraph whitelist
2013-04-19 12:51:06 -07:00
Sam
1bd3744676
disable image optimization for now
2013-04-19 09:50:23 +10:00
Régis Hanol
4a94f12a33
FIX: optimized images url when using a CDN
2013-04-19 00:19:08 +02:00
Sam
28d111d370
typo
2013-04-18 17:23:52 +10:00
Sam
8367951000
sprockets upgrade
...
stop bundling all js files in dev, replace with turbo boosted serving of assets
2013-04-18 16:33:25 +10:00
Sam
0c65c4d92e
fix error
2013-04-18 11:34:40 +10:00
Sam
2a65dd41d4
some safety
2013-04-18 10:04:42 +10:00
Sam
723df0b964
deleted topics get no notifications
2013-04-18 10:00:55 +10:00
Sam
cb8f3f1a6f
fix feature job so it does not fail out when a topic is deleted
2013-04-18 09:35:15 +10:00
Jeff Atwood
b64a4100fa
change "visitor" trust level to "new user"
...
I blame me for this mistake.. visitor means other stuff in practice. New
User is correct meaning.
2013-04-17 16:11:24 -07:00
Régis Hanol
e76f629df8
Text Cleaner now removes all periods from the end of the title
2013-04-18 00:19:42 +02:00
Neil Lalonde
ee23a088ea
Add SoundcloudOnebox to support http and https
2013-04-17 16:24:00 -04:00
Neil Lalonde
3b6aeb14c7
Add subtype to topics to classify private messages
2013-04-16 16:56:18 -04:00
Régis Hanol
c2e58b61c9
automatically resizes images
2013-04-15 23:32:26 +02:00
Régis Hanol
b24c1a1ad9
better consistency around email case sensitivity
2013-04-15 02:20:33 +02:00
Neil Lalonde
c6ab9fec9d
Unregister forum membership at Discourse Hub when deleting a user
2013-04-15 14:52:07 -04:00
Neil Lalonde
56c858e58b
Use transaction around deleting a user and logging that action
2013-04-15 11:39:30 -04:00
Sam
dec6b9970a
guard failed me
2013-04-15 15:37:31 +10:00
Neil Lalonde
4413d2a92b
Version bump to v0.8.6
2013-04-12 16:55:24 -04:00
Neil Lalonde
651cfba93f
Add ability to destroy a user with 0 posts
2013-04-12 16:53:00 -04:00
Sam
e969eb14e8
added 2 new flag types: notify user and notify moderators
...
fixed up messed up user navigation
refactored
2013-04-12 17:55:45 +10:00
Sam
e1b958d483
oops
2013-04-11 21:31:56 +10:00
Sam
850b042cab
introduce rack:cache as a default, so users don't need to configure apache or nginx
...
under rack cache we are able to serve 620reqs a second per thin (on my machine) before it 12 (on my machine)
reorganised so mini profilers can be cleanly disabled from config file
added caching for categories index
move production.rb to production.sample.rb
2013-04-11 16:24:21 +10:00
Sam
5f30ea7463
Merge pull request #684 from ZogStriP/auto-replace-rules-in-titles
...
auto replace rules in titles
2013-04-10 21:12:20 -07:00
Kuba Brecka
17becd0e5f
update the list of i18n postgre stemmers
2013-04-10 19:45:29 +02:00
Régis Hanol
c5cf8be864
auto replace rules in titles
2013-04-10 11:00:50 +02:00
Sam
33e3ad1603
clean up onebox application so it uses a single code path
...
use fragments for oneboxes
strip parent <p> if <div> is in it
clean some tests
2013-04-10 17:52:38 +10:00
Robin Ward
00f9e628e0
Don't apply markdown to content of [quote] -- it messes up spacing.
2013-04-09 17:32:50 -04:00
Sam
47fb99198a
path to asset is insanely slow cause it is pluralizing the word "javascript" over and over and over and over again.
2013-04-09 11:54:00 +10:00
Robin Ward
8942d9a094
Okay, THIS time the specs should pass. Geez.
2013-04-08 11:23:03 -04:00
Robin Ward
9c461aced4
Safer code - check that topic is present.
2013-04-08 11:01:55 -04:00
Robin Ward
1715aa66d9
Fixes issue with featuring topic users
2013-04-08 10:51:01 -04:00
Sam
9ad320768e
Merge pull request #667 from ZogStriP/dont-track-links-in-oneboxes
...
don't track links in oneboxes
2013-04-07 18:30:24 -07:00
Régis Hanol
d080ae4d2d
don't track links in oneboxes
2013-04-08 02:24:12 +02:00
Sam
3d3b589b4d
for now, run seed fu automatically after migrate ... still think there should be a cleaner way
2013-04-08 09:56:42 +10:00
Robin Ward
a14f62766e
Replace MultisiteI18n hack with SiteContent and admin editing.
2013-04-05 16:48:15 -04:00
Robin Ward
72b4f41254
Can change TOS content via site content editor
2013-04-05 15:21:55 -04:00
Robin Ward
af9b27358c
If an admin or moderator edits a visitor's post, the restrictions should be based
...
on the *editors* access rights, not the original poster.
2013-04-05 13:59:00 -04:00
Wojciech Kocjan
68bdab6635
Post processing of images adds prefix second time when post processing a post with one or more images if running with a prefix
2013-04-05 12:38:20 +02:00
Sam
a2cca2540e
some minimal site settings diags
...
fix issue where days_visited was totally out of sync
2013-04-05 17:47:54 +11:00
Sam
a7f92ec0c1
topic reply count resync for each new post
2013-04-05 17:47:54 +11:00
Sam
bf8e756175
Merge pull request #637 from wojciechka/master
...
Putting rootURL in JavaScript using Discourse::base_uri and erb
2013-04-04 21:42:54 -07:00
Sam
4fbf017272
get regular trust level going, self heal inconsistent topic timings
2013-04-05 15:30:28 +11:00
Robin Ward
fa1ba6791b
Work in Progress: Content Editing in Admin Section
2013-04-04 17:26:22 -04:00
Wojciech Kocjan
a875b1c44a
Store base URI in Discourse.BaseUri and use it in all places where rootURL was previously used
2013-04-04 11:16:38 +02:00
Régis Hanol
7105349f1f
FIX: accessing a topic with a 'page' parameter
2013-04-04 00:12:27 +02:00
Robin Ward
738789f336
Admins can't lock themselves out of a site by setting approval.
2013-04-03 12:23:28 -04:00
