159 Commits

Author	SHA1	Message	Date
Sam Saffron	e2bcf55077	DEV: move send => public_send in lib folder ... This handles most of the cases in `lib` where we were using send instead of public_send	2019-05-07 12:25:44 +10:00
Neil Lalonde	1ba72ccab8	DEV: add site setting type group_list for a list of groups ... Add a js test	2019-04-29 16:15:22 -04:00
David Taylor	c687e2b921	FIX: Use saved_change_to_value? in site_setting_saved event ... Since Rails 5.2, the behavior of `attribute_changed?` inside `after_save` callbacks has changed, so we need to use `saved_change_to_attribute` instead. The site setting local_process_provider in test mode was covering up the issue.	2019-04-17 10:07:00 -04:00
Robin Ward	ba6d4b2a8d	FIX: Better handling for toggling must_approve_users ... If you turn it on now, default all users to approved since they were previously. Also support approving a user that doesn't have a reviewable record (it will be created first.) This also includes a refactor to move class method calls to `DiscourseEvent` into an initializer. Otherwise the load order of classes makes a difference in the test environment and some settings might be triggered and others not, randomly.	2019-04-16 15:56:35 -04:00
Guo Xiang Tan	ac661e856a	FEATURE: Allow categories to be prioritized/deprioritized in search. (#7209)	2019-03-25 10:59:55 +08:00
Gerhard Schlager	c34a6ba674	REFACTOR: Rename site settings to make them less confusing	2019-03-14 13:40:14 +01:00
Bianca Nenciu	76a14c47ac	FEATURE: Add site contact group. (#7152)	2019-03-13 11:34:47 +01:00
Guo Xiang Tan	b0c8fdd7da	FIX: Properly support defaults for upload site settings.	2019-03-13 16:36:57 +08:00
Guo Xiang Tan	8a3d12dd34	DEV: Fix incorrect version for removing deprecated code. ... It should be deprecated in version 2.2 and removed in version 2.3.	2019-02-21 14:05:00 +08:00
Penar Musaraj	edcdbe1946	DEV: Restore textarea type for site settings ... Currenty, no settings in core use this, but textareas will be useful in theme settings and plugins.	2019-02-04 15:41:58 -05:00
Vinoth Kannan	565b524b02	FIX: don't raise error if s3 set via global setting	2019-02-01 14:17:10 +05:30
Vinoth Kannan	b4f713ca52	FEATURE: Use amazon s3 inventory to manage upload stats (#6867)	2019-02-01 10:10:48 +05:30
Gerhard Schlager	01cdbd3a13	FEATURE: Prohibit S3 bucket reusage ... This validation makes sure that the s3_upload_bucket and the s3_backup_bucket have different values. The backup bucket is allowed to be a subfolder of the upload bucket. The other way around is forbidden because the backup system searches by prefix and would return all files stored within the backup bucket and its subfolders.	2018-12-17 11:35:28 +01:00
Guo Xiang Tan	1a57be3248	Avoid deprecated site setting logging in SiteSetting.settings_hash.	2018-11-20 11:59:38 +08:00
Guo Xiang Tan	861b52b6f3	Fix the build take 2.	2018-11-14 18:07:04 +08:00
Guo Xiang Tan	2220345a8b	Fix the build.	2018-11-14 17:32:32 +08:00
Guo Xiang Tan	72370b9c36	Add deprecation warnings for url based site settings.	2018-11-14 16:09:26 +08:00
Guo Xiang Tan	44391ee8ab	FEATURE: Upload Site Settings. (#6573)	2018-11-14 15:03:02 +08:00
Guo Xiang Tan	dfc0519cd3	Remove deprecation notice for old site settings.	2018-11-07 14:36:59 +08:00
Guo Xiang Tan	84d4c81a26	FEATURE: Support backup uploads/downloads directly to/from S3. ... This reverts commit 3c59106bac.	2018-10-15 09:43:31 +08:00
Guo Xiang Tan	3c59106bac	Revert "FEATURE: Support backup uploads/downloads directly to/from S3." ... This reverts commit c29a4dddc1. We're doing a beta bump soon so un-revert this after that is done.	2018-10-11 11:08:23 +08:00
Gerhard Schlager	c29a4dddc1	FEATURE: Support backup uploads/downloads directly to/from S3.	2018-10-11 10:38:43 +08:00
Bianca Nenciu	e0d7cdac12	UX: Improve error messages for minimum and maximum username lengths.	2018-10-02 13:10:20 +08:00
Gerhard Schlager	1a01385e88	FIX: "false" didn't work as locale_default	2018-09-11 13:42:10 +02:00
Joffrey JAFFEUX	066010db7d	FEATURE: introduces list/compact_list components	2018-08-03 16:41:37 -04:00
Gerhard Schlager	84d14fd8a0	FIX: Don't rely on setting data type read from database	2018-07-25 11:40:59 +02:00
Guo Xiang Tan	b165cfdfbe	FIX: Raise a better error in SiteSettings::TypeSupervisor.	2018-07-19 16:41:00 +08:00
Régis Hanol	6d6e026e3c	FEATURE: selectable avatars	2018-07-18 12:57:43 +02:00
Sam	cb824a6b33	DEV: remove all calls to SqlBuilder use DB.build instead ... This is part of the migration to mini_sql, SqlBuilder.new is being deprecated and replaced with DB.build	2018-06-20 17:53:49 +10:00
Sam	54c0aa788c	FIX: db:create was failing due to site settings	2018-06-07 14:51:14 +10:00
Sam	f331d2603d	DEV: improve design of site setting default provider ... This refactors it so "Defaults provider" is only responsible for "defaults" Locale handling and management of locale settings is moved back into SiteSettingExtension This eliminates complex state management using DistributedCache and makes it way easier to test SiteSettingExtension	2018-06-07 14:33:41 +10:00
Sam	88f5251415	FIX: disallow invalid top_menu and post_menu and share_links ... In the past any text could be entered there causing big potential issues	2018-04-26 17:00:56 +10:00
Guo Xiang Tan	ad4c25e004	PERF: Only save site setting if values have been changed.	2018-04-17 21:07:39 +08:00
Robin Ward	b9abd7dc9e	FEATURE: Shared Drafts ... This feature can be enabled by choosing a destination for the `shared drafts category` site setting. * Staff members can create shared drafts, choosing a destination category for the topic when it is published. * Shared Drafts can be viewed in their category, or above the topic list for the destination category where it will end up. * When the shared draft is ready, it can be published to the appropriate category by clicking a button on the topic view. * When published, Drafts change their timestamps to the current time, and any edits to the original post are removed.	2018-03-20 17:15:26 -04:00
Arpit Jalan	350cbb1700	deprecate existing site settings	2018-02-01 13:25:29 +05:30
Guo Xiang Tan	07bfe3d053	FIX: Use a distrbuted cache for site locale.	2017-09-12 19:36:17 +08:00
Guo Xiang Tan	0b2d65f77a	Include the site setting file path for which a default value is missing.	2017-08-16 11:42:08 +09:00
Erick Guan	1646bc0031	FIX: fails loud if default setting is not set ... Noted: - `push_api_secret_key` is set in initializer. Shimed with '' - `default_theme_key` is set in seeding. Shimed with ''	2017-08-15 12:07:25 +02:00
Guo Xiang Tan	2c39743d5d	Introduce multisite tests for better coverage.	2017-08-08 12:58:22 +09:00
Guo Xiang Tan	764957dfc4	Merge pull request #5030 from tgxworld/fix_defaults_cache_cross_talk ... FIX: SiteSettings defaults cache leaking across multisite.	2017-08-07 17:07:31 +09:00
Guo Xiang Tan	22a1db7b8a	FIX: Make DbProvider#table_exits? work with multisite.	2017-08-07 16:37:42 +09:00
Guo Xiang Tan	c5850422f0	FIX: SiteSettings defaults cache leaking across multisite.	2017-08-07 15:16:57 +09:00
Guo Xiang Tan	412fa78b1f	FIX: default_locale cross talk in multisite setup.	2017-08-07 11:14:28 +09:00
Guo Xiang Tan	3f24ed2b3e	Can't revert due to incompatibility of new site setting types. ... Revert "Revert "FEATURE: Site settings defaults per locale"" This reverts commit 439fe8ba24.	2017-08-07 10:43:09 +09:00
Guo Xiang Tan	439fe8ba24	Revert "FEATURE: Site settings defaults per locale" ... This reverts commit 468a8fcd20.	2017-08-07 10:31:50 +09:00
Erick Guan	468a8fcd20	FEATURE: Site settings defaults per locale ... This change-set allows setting different defaults for different locales. It also: - Adds extensive testing around site setting validation - raises deprecation error if site setting has the default property based on env - relocated site settings for dev and tests in the initializer - deprecated client_setting in the site setting's loading process - ensure it raises when a enum site setting being set - default_locale is promoted to `required` category. - fixes incorrect default setting and validation - fixes ensure type check for site settings - creates a benchmark for site setting - sets reasonable defaults for Chinese	2017-08-02 12:24:19 -04:00
Guo Xiang Tan	5012d46cbd	Add rubocop to our build. (#5004)	2017-07-28 10:20:09 +09:00
Régis Hanol	3ee5cea9e2	fix the build	2015-09-09 15:34:53 +02:00
Régis Hanol	9a999bfe84	FIX: ensure we never have a string when an enum is Fixnum	2015-09-09 12:59:49 +02:00
Tan Le	9fbc763902	Replace Hash#keys.each with Hash#each_key for some perf boost	2015-04-18 21:53:53 +10:00
Sam	65156bd8f6	FIX: hide dangerous dev only site settings in production ... (port/force hostname/queue jobs)	2014-10-03 15:53:01 +10:00
Sam	9aec32688b	BUGFIX: when RTT is short likes may not appear to work ... BUGFIX: site settings db provider not triggering updates at the correct point	2014-03-31 12:34:13 +11:00
Sam	8fc2549873	Stop using global vars where not needed ... Simplify local process site setting provider Stop setting up methods over and over Centralize cache clearing	2014-03-31 12:34:13 +11:00
Neil Lalonde	791f5ac94e	Load site settings from config/site_settings.yml	2013-11-14 16:02:13 -05:00
Sam	34be27f425	table_exists should be called aggresively while it is false or nil, to avoid bootstrapping issues ... don't test 1.9.3 in travis, it blows up randomly due to incorrect implementation of weak refs in 1.9.3	2013-10-30 11:02:10 +11:00
Sam	666264879c	change it so all topics MUST include a category, we store a special uncategorized category to compensate ... this cleans up a bunch of internals and removes some settings	2013-10-24 12:08:02 +11:00
Sam	f9120f1250	let us not fail the spec suite cause the local provider for site settings reloads.	2013-07-04 16:49:17 +10:00
Stephan Kaag	89b621d31a	Refactor update_all statements in order to prevent deprecation warnings in Rails 4	2013-07-02 18:36:47 +02:00
Sam	0b94c3c456	fix all sorts of issues with random spec order ... SiteSetting no longer persisted across tests	2013-06-23 13:35:25 +10:00