Commit Graph

55887 Commits

Author SHA1 Message Date
Tobias Eigen
ca232d834b
removed periods from one-liner instructions on signup form (#27902)
* removed periods from one-liner instructions on signup form

we want to skip periods and unnecessary punctuation on single sentence instructions in the UI, to make them easier to scan for users

* Update client.en.yml
2024-09-12 09:01:52 -07:00
Kris
06b9e58542
UX: tell 1Password to ignore the link name input (#28559) 2024-09-12 11:13:43 -04:00
David Taylor
a7cd220704
PERF: Use insertText more efficiently in replaceText (#28880)
Followup to e25578d702

Using execCommand to replace the entire contents of the textarea is very slow for larger posts (it seems the browser does a reflow after every 'virtual keypress'.

This commit updates the `replaceText` function to be more surgical with its `insertAt` calls. Now it only selects & replaces the characters which are actually being replaced.
2024-09-12 16:11:39 +01:00
David Taylor
600801f194
DEV: Automatically add --ignore-workspace when pnpm used in plugins (#28878) 2024-09-12 13:45:25 +01:00
Jarek Radosz
00ae6cc430
DEV: Update ember-resolver to 13.0.0 (#28876)
See: https://github.com/ember-cli/ember-resolver/releases/tag/v13.0.0
2024-09-12 12:09:11 +02:00
Loïc Guitaut
b806dce13d DEV: Refactor suspend/silence user services
- fetch models inside services
- validate `user_id` in contracts
- use policy objects
- extract more logic to actions
- write specs for services and action
2024-09-12 10:28:48 +02:00
dependabot[bot]
04645c458d
Build(deps): Bump google-protobuf from 4.28.0 to 4.28.1 (#28867) 2024-09-12 09:40:47 +02:00
Martin Brennan
d9af873f0d
UX: Fix confusing "claim reviewable" positioning (#28870)
Previously for reviewables that could be claimed, we positioned
the "you can claim / you must claim" message and button underneath
the "Is there something wrong with this post?" message but _before_
the reviewable action buttons like Yes/No/Ignore. This was a confusing
flow.

This commit fixes the issue, and also makes it so if claiming is
required and the reviewable has not been claimed, we don't show
the "Is there something wrong with this post?" which was showing
with no buttons.
2024-09-12 16:44:12 +10:00
Martin Brennan
5df402f153
UX: Fix admin report filter stacking (#28875)
Followup 5a8e7c5f29

The admin report results need to be side by side
with the filter for the report, which sits on the
right. The previous commit made it stacked.
2024-09-12 16:40:48 +10:00
Martin Brennan
7ced4fccc7
FIX: Support date field in FormKit page object (#28872)
Adds support for `input-date` field when calling
`fill_in` on a FormKit field. Capybara supports passing
a Date object to `fill_in(with: value)` for date inputs,
so there is nothing fancy that needs to be done to support this.
2024-09-12 13:35:33 +10:00
Martin Brennan
78268ca767
DEV: Fix another report flaky (#28868)
Followup 0323b366f3

This was happening because another spec was adding a
report using the plugin API, but there was nothing
resetting that, so later in the reports controller
when we did Report.singleton_methods, we ended up
with another report with no translation, causing another
error.
2024-09-12 10:34:38 +10:00
chapoi
bca82e9dec
UX: fix double li-element in mobile list control (#28840) 2024-09-12 02:22:32 +02:00
Jarek Radosz
18fca966c5
FIX: Incorrect titles in two components (#28865) 2024-09-11 22:45:41 +02:00
Penar Musaraj
d7679f8aa3
DEV: Shorter PR draft template (#28862) 2024-09-11 16:25:00 -04:00
Ella E.
4094e90190
FIX: Align bulk award button with the other header action buttons (#28859)
* FIX: Align bulk award button with the other header action buttons

* UX: Make bulk award button to be full width on mobile
2024-09-11 13:17:50 -06:00
Gabriel Grubba
a4359d274e
DEV: update pull request template with more details of what is expected in a PR (#28857)
* DEV: update pull request template with more details of what is expected in a PR

Added information:
- We expected the pr to have a title that is descriptive of the changes
- Good commit messages and prefixes
- If the pull request had UX/UI changes to include screenshots
- If changing flaky tests to include the reason for the change

* Update .github/pull_request_template.md

Co-authored-by: David Taylor <david@taylorhq.com>

---------

Co-authored-by: David Taylor <david@taylorhq.com>
2024-09-11 13:57:45 -03:00
Blake Erickson
2bc31bc45a
DEV: Add plugin api for customizing api key and webhook pages (#28835)
Adding these plugin outlets so that the admin pages for api keys and
webhooks can be customized.
2024-09-11 11:24:40 -04:00
dependabot[bot]
8b343b9603
Build(deps-dev): Bump jsuites from 5.5.2 to 5.6.0 (#28855)
Bumps [jsuites](https://github.com/jsuites/jsuites) from 5.5.2 to 5.6.0.
- [Release notes](https://github.com/jsuites/jsuites/releases)
- [Changelog](https://github.com/jsuites/jsuites/blob/master/changelog.md)
- [Commits](https://github.com/jsuites/jsuites/commits)

---
updated-dependencies:
- dependency-name: jsuites
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-11 16:55:52 +02:00
David Taylor
6107ba89b5
DEV: Remove corepack config for now (#28856)
For people with corepack enabled, this causes problems when trying to `yarn install` in plugin directories.

Perhaps that can be improved in future by adding `packageManager` config in each plugin's own `package.json`, but that won't happen overnight. Removing the config for now to stop the bleeding.
2024-09-11 15:09:52 +01:00
Jarek Radosz
cfbfcc7b81
DEV: Update licensee to 11.1.0 (#28850) 2024-09-11 15:56:22 +02:00
dependabot[bot]
994afecc8a
Build(deps): Bump sprockets from 3.7.3 to 3.7.4 (#28852)
Bumps [sprockets](https://github.com/rails/sprockets) from 3.7.3 to 3.7.4.
- [Release notes](https://github.com/rails/sprockets/releases)
- [Changelog](https://github.com/rails/sprockets/blob/v3.7.4/CHANGELOG.md)
- [Commits](https://github.com/rails/sprockets/compare/v3.7.3...v3.7.4)

---
updated-dependencies:
- dependency-name: sprockets
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-11 14:27:50 +02:00
dependabot[bot]
9ee9a4c201
Build(deps-dev): Bump parallel_tests from 4.7.1 to 4.7.2 (#28854)
Bumps [parallel_tests](https://github.com/grosser/parallel_tests) from 4.7.1 to 4.7.2.
- [Changelog](https://github.com/grosser/parallel_tests/blob/master/CHANGELOG.md)
- [Commits](https://github.com/grosser/parallel_tests/compare/v4.7.1...v4.7.2)

---
updated-dependencies:
- dependency-name: parallel_tests
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-11 14:25:37 +02:00
dependabot[bot]
92fe872988
Build(deps-dev): Bump simplecov-html from 0.13.0 to 0.13.1 (#28849)
Bumps [simplecov-html](https://github.com/simplecov-ruby/simplecov-html) from 0.13.0 to 0.13.1.
- [Release notes](https://github.com/simplecov-ruby/simplecov-html/releases)
- [Changelog](https://github.com/simplecov-ruby/simplecov-html/blob/main/CHANGELOG.md)
- [Commits](https://github.com/simplecov-ruby/simplecov-html/compare/v0.13.0...v0.13.1)

---
updated-dependencies:
- dependency-name: simplecov-html
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-11 14:24:43 +02:00
dependabot[bot]
e0899d9ef0
Build(deps): Bump oj from 3.16.5 to 3.16.6 (#28851)
Bumps [oj](https://github.com/ohler55/oj) from 3.16.5 to 3.16.6.
- [Release notes](https://github.com/ohler55/oj/releases)
- [Changelog](https://github.com/ohler55/oj/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/ohler55/oj/compare/v3.16.5...v3.16.6)

---
updated-dependencies:
- dependency-name: oj
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-11 14:24:33 +02:00
Jarek Radosz
2c80203ab9
DEV: Avoid extra after-test cleanup (#28846) 2024-09-11 13:43:19 +02:00
Jarek Radosz
6a677d1cfc
DEV: Remove dynamic inclusions from Gemfile (#28847)
Added in 7c3a29c, broke Dependabot parsing.
2024-09-11 13:39:15 +02:00
dependabot[bot]
691d872c4b
Build(deps-dev): Bump testem from 3.10.1 to 3.15.2 (#28844)
Bumps [testem](https://github.com/testem/testem) from 3.10.1 to 3.15.2.
- [Release notes](https://github.com/testem/testem/releases)
- [Commits](https://github.com/testem/testem/compare/v3.10.1...v3.15.2)

---
updated-dependencies:
- dependency-name: testem
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-11 12:54:01 +02:00
dependabot[bot]
c33d75c2d5
Build(deps-dev): Bump @swc/core from 1.7.24 to 1.7.26 (#28845)
Bumps [@swc/core](https://github.com/swc-project/swc) from 1.7.24 to 1.7.26.
- [Release notes](https://github.com/swc-project/swc/releases)
- [Changelog](https://github.com/swc-project/swc/blob/main/CHANGELOG.md)
- [Commits](https://github.com/swc-project/swc/compare/v1.7.24...v1.7.26)

---
updated-dependencies:
- dependency-name: "@swc/core"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-11 12:52:00 +02:00
Jarek Radosz
83acd8b80a
DEV: Change qunit_parallel to 2 for frontend themes (#28842)
This seems to mitigate the flaky timeouts we've been seeing recently, while not affecting the speed in any meaningful way.
2024-09-11 11:39:26 +02:00
Jarek Radosz
e87d0addf7
DEV: Run theme tests in random order (#28841)
that is: randomize the order in which theme test suites are scheduled
2024-09-11 10:45:12 +02:00
Bianca Nenciu
38592dc48e
PERF: Preload user options when status is enabled (#28827)
The user option 'hide_profile_and_presence' is necessary to figure out
if the user status has to be displayed or not. In order to avoid N+1s
generated by `include_status?` method, both `user_status` and
`user_option` relations have to be included.
2024-09-11 10:39:14 +03:00
Bianca Nenciu
d63ffe22f4
DEV: Track SQL queries from MiniSql (#28824)
`track_sql_queries` only returned queries that were executed by
ActiveRecord. All queries executed through DB.exec, DB.query and others
were not returned.
2024-09-11 10:14:53 +03:00
Krzysztof Kotlarek
1f1709d249
FIX: use a custom prefix for custom flags (#28839)
Currently, when the custom flag has the same name as the system flag (which is disabled) then it is not displayed. To fix the problem, `custom_` prefix as `name_key` is used to distinguish between the system and the custom flag.

I considered writing a migration to fix existing custom flags name key. However, at the end of migration I would need to run rails code to reset cache `Flag.reset_flag_settings!`. I decided to skip that step as it is a very edge case. If someone has the same flag name as the system flag, then all they have to do is edit the flag and click save.

In addition, I made 2 small fixes:
- edit flag title was missing translation;
- flag form UI was not showing that description is the required field.
2024-09-11 15:30:20 +10:00
Martin Brennan
0323b366f3
DEV: Fix report flakys (#28838)
The Report model spec was directly adding methods
to the Report class, which was causing errors in the
admin reports controller because it would look for
a translation of the report name (e.g. report_timeout_test)
like so `I18n.t("reports.#{type}.title")`, then get an
error because the translation did not exist.

This is fixed by using `Report.stubs` instead, which is
cleaned up after every test.
2024-09-11 15:24:19 +10:00
Martin Brennan
894f146b3a
DEV: Add component tests for admin page header components (#28837)
These components will be used in many places and are quite
independent, adding component tests is sensible.
2024-09-11 13:27:58 +10:00
Alan Guo Xiang Tan
279ffb3351
DEV: JOBS should be cap at 2 in assets:precompile:build (#28834)
This fixes a mistake I introduced in
b652f66378. I wanted to cap it at 2 not 4.
2024-09-11 08:18:42 +08:00
dependabot[bot]
9b465e1914
Build(deps-dev): Bump sinon from 18.0.0 to 18.0.1 (#28833)
Bumps [sinon](https://github.com/sinonjs/sinon) from 18.0.0 to 18.0.1.
- [Release notes](https://github.com/sinonjs/sinon/releases)
- [Changelog](https://github.com/sinonjs/sinon/blob/main/docs/changelog.md)
- [Commits](https://github.com/sinonjs/sinon/compare/v18.0.0...v18.0.1)

---
updated-dependencies:
- dependency-name: sinon
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-11 02:04:21 +02:00
dependabot[bot]
be682767d1
Build(deps-dev): Bump express from 4.19.2 to 4.20.0 (#28832)
Bumps [express](https://github.com/expressjs/express) from 4.19.2 to 4.20.0.
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/master/History.md)
- [Commits](https://github.com/expressjs/express/compare/4.19.2...4.20.0)

---
updated-dependencies:
- dependency-name: express
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-11 02:02:58 +02:00
Alan Guo Xiang Tan
b652f66378
DEV: Cap number of thread-loader workers in assets:precompile:build (#28830)
We were running into errors running `ember build` on machines with high
CPU counts. It was then noted that `thread-loader`, which embroider uses, defaults to spinning
up x workers where x is number of physical CPU cores - 1. That is
probably too much so we set out to find out an optimial count to set for
the `JOBS` env which embroider will use to set the number of
`thread-loader` workers.

I first built an image using the following Dockerfile.

```
FROM discourse/base:release

RUN cd /var/www/discourse && sudo -EH -u discourse bundle exec rake plugin:install_all_official
RUN cd /var/www/discourse && sudo -EH -u discourse bundle exec rake assets:precompile:prereqs
```

I then ran the following command on my M3 Max Macbook Pro that has 14
phyisal CPU cores.

```
for j in 1 2 4 8 14; do echo "JOBS=$j"; time docker run --rm -it -e JOBS=$j test:latest /bin/bash -c "su discourse -c 'cd /var/www/discourse && bundle exec rake assets:precompile:build'"; done
```

These are the results I got:

```
JOBS=1 0.04s user 0.03s system 0% cpu 1:01.92 total
JOBS=2 0.04s user 0.02s system 0% cpu 42.605 total
JOBS=4 0.04s user 0.02s system 0% cpu 37.012 total
JOBS=8 0.04s user 0.02s system 0% cpu 35.199 total
JOBs=14 0.04s user 0.02s system 0% cpu 37.941 total
```

We think JOBS=2 is a good default when the `JOBS` env has not been set.
Anything above just consumes more resources for little benefit.
2024-09-11 07:58:36 +08:00
Osama Sayegh
d760403bfd
DEV: Fix the build on github (#28831) 2024-09-11 07:52:23 +08:00
Osama Sayegh
91ba2a4aab
DEV: Add debug logging for automation recurring trigger (#28829)
We're seeing a problem where some recurring automations end up in a state where they don't have any `pending_automations` records scheduled which effectively makes the recurring automation dead. We need to add some debugging to figure out what might be causing this problem.

Internal topic: t/138045.
2024-09-11 01:29:15 +03:00
Jarek Radosz
917621ed80
FIX: Errors may be null-ish (#28826) 2024-09-10 20:42:02 +02:00
Ella E.
995931b6ec
UX: Update banner to handle responsive images with aspect ratio scaling (#28825) 2024-09-10 12:19:40 -06:00
Penar Musaraj
1a88728d39
FIX: Poll voters list wasn't expanding properly (#28823) 2024-09-10 11:46:12 -04:00
Bianca Nenciu
9b0300a647
PERF: Preload voters_count and has_voted (#28808)
These fields are often used when serializing topics which may contain
multiple polls. On average, serializing a poll took 2+N queries where N
is the number of options. This change reduces the number of queries to
3, one for each field (Poll#voters_count, PollOption#voters_count and
Poll#has_voted?).
2024-09-10 18:41:08 +03:00
Keegan George
f2059bf15f
FIX: Form template limit validation (#28791) 2024-09-10 08:11:44 -07:00
Osama Sayegh
0a994a9221
FEATURE: Add setting to exclude groups from /about page (#28809)
This commit adds a new `about_page_hidden_groups` setting to exclude members of specific groups from the admin and moderator lists on the /about page.

Internal topic: t/137717.
2024-09-10 14:43:41 +03:00
Robert
88e1690d86
FIX: poll preview list styling remove redundant bullets (#28592) 2024-09-10 10:54:59 +02:00
Jarek Radosz
086169c1cb
DEV: Update test-prof from 1.4.1 to 1.4.2 (#28819)
The update introduced a small regression in d-data-explorer that was handled in https://github.com/discourse/discourse-data-explorer/pull/326
2024-09-10 10:44:18 +02:00
David Battersby
c697e70892
FIX: prevent chat channel not found ajax error (#28818)
On occasion we get an error popup on desktop due to the channel not being found.

This change means that we only check the cached channels in ChatChannelsManager for the matching channel id, but we skip doing manual lookup which results in ajax popup when it fails.
2024-09-10 11:52:25 +04:00