Martin Brennan
de983796e1
FIX: Introduce Guardian::BasicUser for oneboxing checks ( #24681 )
...
Through internal discussion, it has become clear that
we need a conceptual Guardian user that bridges the
gap between anon users and a logged in forum user with
an absolute baseline level of access to public topics,
which can be used in cases where:
1. Automated systems are running which shouldn't see any
private data
1. A baseline level of user access is needed
In this case we are fixing the latter; when oneboxing a local
topic, and we are linking to a topic in another category from
the current one, we need to operate off a baseline level of
access, since not all users have access to the same categories,
and we don't want e.g. editing a post with an internal link to
expose sensitive internal information.
2023-12-05 09:25:23 +10:00
Keegan George
7756c210da
FIX: Flaky table builder spec ( #24700 )
2023-12-04 12:14:07 -08:00
Isaac Janzen
b9110c5a71
FIX: Don't refresh on topic search result click ( #24697 )
...
Fixes an issue where when selecting a topic search result we were refreshing the page rather than letting `DiscourseURL` redirect us to the given topic. This was because we were leaning on a `a` tag and it's href to handle the redirect
3aeff56faf/app/assets/javascripts/discourse/app/components/search-menu/results/types.hbs (L15-L16)
2023-12-04 11:27:38 -07:00
David Taylor
87d850948f
PERF: Only apply terser to production assets ( #24699 )
...
We funnel vendored javascript through ember-cli, but that's only used for the testem environment. Therefore, there's no need to minify it in production builds. In my tests, this reduces peak RSS of a production build from 3.53GB to 3.15GB.
2023-12-04 18:05:55 +00:00
Kris
c4381e0265
FIX: don't apply extraClassName to all popup menus ( #24695 )
2023-12-04 11:40:57 -06:00
Joffrey JAFFEUX
c805bcc7ba
DEV: adds a chat-join-channel-button outlet ( #24698 )
...
This outlet allows to redefine the button displayed when asking the user to join a channel.
The following outletArgs are sent to the outlet:
```
onJoinChannel
channel
icon
title
label
disabled
```
2023-12-04 18:11:33 +01:00
David Taylor
3aeff56faf
DEV: Run assets:precompile ember build with CI=1 ( #24696 )
...
This will improve the output to print the current step (rather than the existing behavior which just says 'building...')
2023-12-04 15:49:50 +00:00
David Taylor
fa35ce9caa
DEV: remove duplicate spec ( #24691 )
2023-12-04 15:45:11 +00:00
Roman Rizzi
037622fc7f
DEV: reviewable_user spec should assert on delete_user_block instead of delete_user ( #24692 )
2023-12-04 12:44:32 -03:00
Jan Cernik
0af8bbd378
FIX: Multiple nested threads and duplicated messages in chat transcripts ( #24685 )
2023-12-04 12:43:04 -03:00
David Taylor
cf8961e1c1
DEV: Correct forums_controller success spec ( #24690 )
...
The implementation did not match the name of the spec
2023-12-04 14:26:29 +00:00
David Taylor
9479b30ada
FIX: Ensure 'untagged' document title is set correctly ( #24689 )
...
https://meta.discourse.org/t/286130/4
2023-12-04 13:43:02 +00:00
Jarek Radosz
7196613e2e
DEV: Fix various spec linting issues ( #24672 )
...
Duplicated specs, incorrect descriptions, incorrect assertions, incorrect filenames, old todo
2023-12-04 13:45:19 +01:00
David Taylor
c2887d3f8c
DEV: Remove unused Ember::Handlebars freedom patch ( #24688 )
...
We no longer compile Ember templates in ruby, so this is unused
2023-12-04 12:40:08 +00:00
David Taylor
cdb904a1b0
DEV: Remove unused htmlbars-inline-precompile shim ( #24687 )
...
Since 4425e99bf9
2023-12-04 12:34:45 +00:00
Jarek Radosz
e0c876696a
DEV: Fix some qunit linting issues ( #24686 )
...
`qunit/literal-compare-order`
`qunit/no-compare-relation-boolean`
`qunit/assert-args`
2023-12-04 13:32:16 +01:00
Jarek Radosz
2029777b86
DEV: Replace AdminWrapper with body-class/html-class ( #24683 )
...
AdminWrapper isn't used (directly) in all-the*
Co-authored-by: David Taylor <david@taylorhq.com>
2023-12-04 12:53:07 +01:00
Joffrey JAFFEUX
3ed1528327
FIX: failing spec in sidebar tags ( #24682 )
...
The modal is now larger and more tags will be shown by default, we need more tags to correctly test the scroll behavior.
2023-12-04 12:46:53 +01:00
dependabot[bot]
e9e6c4e5d6
Build(deps): Bump nio4r from 2.6.1 to 2.7.0 ( #24678 )
...
Bumps [nio4r](https://github.com/socketry/nio4r ) from 2.6.1 to 2.7.0.
- [Release notes](https://github.com/socketry/nio4r/releases )
- [Changelog](https://github.com/socketry/nio4r/blob/main/changes.md )
- [Commits](https://github.com/socketry/nio4r/compare/v2.6.1...v2.7.0 )
---
updated-dependencies:
- dependency-name: nio4r
dependency-type: indirect
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-12-04 10:36:34 +01:00
dependabot[bot]
ec4491cc3b
Build(deps-dev): Bump rubocop from 1.57.2 to 1.58.0 ( #24675 )
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.57.2 to 1.58.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.57.2...v1.58.0 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: indirect
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-12-04 10:13:20 +01:00
dependabot[bot]
364216cab3
Build(deps): Bump rbtrace from 0.4.14 to 0.5.0 ( #24677 )
...
Bumps [rbtrace](https://github.com/tmm1/rbtrace ) from 0.4.14 to 0.5.0.
- [Changelog](https://github.com/tmm1/rbtrace/blob/master/CHANGELOG )
- [Commits](https://github.com/tmm1/rbtrace/compare/v0.4.14...v0.5.0 )
---
updated-dependencies:
- dependency-name: rbtrace
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-12-04 10:11:55 +01:00
dependabot[bot]
af30d3dc7c
Build(deps-dev): Bump shoulda-matchers from 7e069cf to 3654e5c ( #24679 )
...
Bumps [shoulda-matchers](https://github.com/thoughtbot/shoulda-matchers ) from `7e069cf` to `3654e5c`.
- [Release notes](https://github.com/thoughtbot/shoulda-matchers/releases )
- [Commits](7e069cf205...3654e5ca7f
2023-12-04 10:11:15 +01:00
chapoi
1df1a9490d
UX: fix sidebar modal ( #24646 )
...
* UX: fix modal width
2023-12-04 08:10:17 +01:00
Martin Brennan
adb75cf3a9
DEV: Delete redundant bookmark test ( #24680 )
...
Cases were identical and also already covered on L63
2023-12-04 12:27:35 +10:00
Jarek Radosz
74011232e9
FIX: Request html when fetching inline onebox data ( #24674 )
...
We do expect to receive html
2023-12-04 11:36:42 +10:00
PhilippRenner
eada155dcd
DOCS: Update INSTALL-email to point to Brevo correctly
...
Brevo changed their DNS Names
2023-12-04 11:46:33 +11:00
Krzysztof Kotlarek
d9ac0c33ff
FIX: update tag description field placeholder ( #24644 )
...
Improvements after https://github.com/discourse/discourse/pull/24561
1. Make placeholder more descriptive
2. Respect new line breaks in description
2023-12-04 09:38:20 +11:00
Kris
56795f5c07
UX: improve btn-transparent styling ( #24666 )
2023-12-02 14:21:22 +11:00
David Taylor
aba3acf4cc
DEV: Correct deprecation id for discovery-controller-shims ( #24671 )
2023-12-01 19:11:48 +00:00
Mark VanLandingham
fb06cd6712
DEV: Add JS API to adjust desktop topic timeline min/max height ( #24669 )
2023-12-01 10:29:12 -06:00
David Taylor
d636ff216a
DEV: Resolve transitionTo deprecation in chat-channel route ( #24668 )
2023-12-01 16:01:59 +00:00
David Taylor
9f9c82ea97
DEV: Only add ember-global deprecation for Ember 3 ( #24667 )
...
(otherwise, we're accidentally extending support into Ember 5!)
Followup to 106c1c317f
2023-12-01 14:50:15 +00:00
chapoi
f8bf4bda00
UX: fix info text color on custom field for login ( #24665 )
2023-12-01 14:41:44 +01:00
David Taylor
106c1c317f
DEV: Restore ember-global deprecation in production ( #24664 )
...
Even with our patch to the deprecate() macro, this is optimized out of the production build because it's wrapped in an `if(DEBUG)` statement. (https://github.com/davidtaylorhq/ember.js/blob/14c02f53b8/packages/%40ember/-internals/bootstrap/index.ts#L19-L19 )
2023-12-01 13:07:57 +00:00
David Taylor
ecf7a4f0c6
FIX: Ensure app-cdn CORS is not overridden by cors_origin setting ( #24661 )
...
We add `Access-Control-Allow-Origin: *` to all asset requests which are requested via a configured CDN. This is particularly important now that we're using browser-native `import()` to load the highlightjs bundle. Unfortunately, user-configurable 'cors_origins' site setting was overriding the wldcard value on CDN assets and causing CORS errors.
This commit updates the logic to give the `*` value precedence, and adds a spec for the situation. It also invalidates the cache of hljs assets (because CDNs will have cached the bad Access-Control-Allow-Origin header).
The rack-cors middleware is also slightly tweaked so that it is always inserted. This makes things easier to test and more consistent.
2023-12-01 12:57:11 +00:00
David Taylor
b72a177fb3
DEV: Exclude deprecation-collector plugin from source identifier ( #24662 )
2023-12-01 12:21:19 +00:00
dependabot[bot]
4df672a541
Build(deps-dev): Bump jsdom from 23.0.0 to 23.0.1 in /app/assets/javascripts ( #24657 )
...
* Build(deps-dev): Bump jsdom in /app/assets/javascripts
Bumps [jsdom](https://github.com/jsdom/jsdom ) from 23.0.0 to 23.0.1.
- [Release notes](https://github.com/jsdom/jsdom/releases )
- [Changelog](https://github.com/jsdom/jsdom/blob/main/Changelog.md )
- [Commits](https://github.com/jsdom/jsdom/compare/23.0.0...23.0.1 )
---
updated-dependencies:
- dependency-name: jsdom
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
* Update lockfiles for ember version flag
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: discoursebuild <build@discourse.org>
2023-12-01 11:11:16 +01:00
Ted Johansson
54e813e964
FIX: Don't error out when trying to retrieve title and URL won't encode ( #24660 )
2023-12-01 15:03:06 +08:00
Isaac Janzen
aadc104817
FIX: Flashing when loading glimer search results ( #24658 )
2023-11-30 20:54:32 -07:00
Isaac Janzen
7539b457b2
DEV: Add forceDropdownForMenuPanels to plugin api ( #24655 )
2023-11-30 15:26:13 -07:00
PhilippRenner
5123ff96cf
Update INSTALL-email.md ( #24481 )
...
added a gdpr compliant smtp provider
2023-11-30 16:19:01 -05:00
Gerhard Schlager
ca296c4926
Fix typos ( #24656 )
...
@discourse-translator-bot keep_translations
2023-11-30 22:13:28 +01:00
Keegan George
d2b53ccac2
DEV: Port discourse-table-builder theme component to core ( #24441 )
2023-11-30 10:54:29 -08:00
Joffrey JAFFEUX
bcca1692c6
FIX: disables tooltip on desktop message menu’s reaction ( #24650 )
2023-11-30 19:41:28 +01:00
Joffrey JAFFEUX
a7a7d8e41e
DEV: correctly uses link to message endpoint in spec ( #24652 )
...
- correctly uses link to message endpoint in spec
- correctly uses "chat with"
2023-11-30 19:33:41 +01:00
Joffrey JAFFEUX
4fa1b0e978
FIX: show leave channel notice only on group channels ( #24653 )
2023-11-30 19:24:14 +01:00
Joffrey JAFFEUX
a1ae9f6ab0
FIX: correctly show "chat with" and not "chat in" for users ( #24651 )
...
Prior to this fix direct message would always show "Chat in ..." when hovering the channel even if you were hovering a direct message channel with another user (or yourself).
We will now correctly show:
- `Chat in ...` for group channels
- `Chat with ...` for direct message channels
2023-11-30 19:02:19 +01:00
chapoi
9fb4175008
UX: make summary 100% height ( #24649 )
2023-11-30 12:29:26 +01:00
Joffrey JAFFEUX
a1690e0401
DEV: removes dead code (message_link) ( #24648 )
...
Linking to a message ID is now handled by the frontend router: `chat.channel.near-message`
2023-11-30 11:13:37 +01:00
Joffrey JAFFEUX
0b65aa8b77
DEV: ensures we have error message before message check ( #24647 )
...
Previously the spec could be flakey as the long message could show on the screen while we await for processing. Now we will first check to have the error message on screen, at this point the erroneous message should never be visible.
2023-11-30 10:55:05 +01:00
