David Taylor
78626d2832
FIX: Do not attempt to pull_hotlinked on emoji images when CDN enabled
2020-06-19 12:45:06 +01:00
Daniel Waterworth
9cf77372a2
FIX: Guardian#can_remove_allowed_users? shouldn't break for ownerless topics
...
A topic can outlive its original author. TopicGuardian should still work
in this situation.
2020-06-19 10:35:52 +01:00
Joffrey JAFFEUX
3e161e372a
FEATURE: allows to have header/footer in publshed pages ( #10067 )
...
Usage: fill Header/Footer sections of your theme.
2020-06-19 09:51:03 +02:00
Martin Brennan
b5495b8e9c
FIX: Do not incorrectly add topic bookmark on Escape ( #10088 )
...
* The first post was showing as bookmarked incorrectly after pressing f to open the topic modal then pressing escape to cancel without saving, because the closeWithoutSaving option was not being respected.
* Also re-introduce the enter shortcut when the name input is focused to saveAndClose the bookmark modal by pressing enter.
2020-06-19 11:17:18 +10:00
Kris
5faf074e61
minor fix to post admin menu button class
2020-06-18 19:18:00 -04:00
Vinoth Kannan
ae47bcb269
DEV: move user references deletion code to before_destroy
. ( #10085 )
...
Moving the `delete_source_user_references` method code from user merger service to user model.
2020-06-18 17:42:39 -04:00
Bianca Nenciu
a1df68d4c4
FIX: Do not change tracked categories for staged users ( #10076 )
2020-06-18 21:09:54 +03:00
Cassius
d13d5e2b99
FIX: Allow multiple hyphens in host ( #10078 )
...
* FIX: Allow multiple hyphens in host
* FIX: added spec for multiple hyphens
2020-06-18 13:58:47 -04:00
Robin Ward
494a27dc27
FIX: A much nicer error message if you can't ignore/mute a user
2020-06-18 13:41:27 -04:00
Robin Ward
6cb6faff29
UX: Ignore modal margin was too tight
2020-06-18 13:26:25 -04:00
Gerhard Schlager
2da6faf281
FEATURE: Add before_email_send
event
...
Plugins can use it to customize the message (e.g. add header) before the email is sent.
2020-06-18 18:58:51 +02:00
Régis Hanol
5143309014
DEV: ensure values are converted to integers in bulk importer
2020-06-18 17:42:14 +02:00
Patrick Schleizer
2d63d7d05e
make unix domain sockets listening example match web.socketed.template.yml ( #10060 )
2020-06-18 11:30:08 -04:00
dependabot-preview[bot]
3a780bc49d
Build(deps-dev): Bump mock_redis from 0.23.0 to 0.24.0 ( #10075 )
...
Bumps [mock_redis](https://github.com/sds/mock_redis ) from 0.23.0 to 0.24.0.
- [Release notes](https://github.com/sds/mock_redis/releases )
- [Changelog](https://github.com/sds/mock_redis/blob/master/CHANGELOG.md )
- [Commits](https://github.com/sds/mock_redis/compare/v0.23.0...v0.24.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-06-18 11:25:16 -04:00
Joffrey JAFFEUX
b8c676e727
FEATURE: allows to ignore a user forever ( #10074 )
2020-06-18 11:24:07 -04:00
Bernhard Suttner
e31471585a
DEV: allow to have duplicate topic titles if categegory is different ( #10034 )
...
Co-authored-by: Robin Ward <robin.ward@gmail.com>
Co-authored-by: Robin Ward <robin.ward@gmail.com>
2020-06-18 11:19:47 -04:00
Mark VanLandingham
ec794c7f29
DEV: Plugin outlet after user-info ( #10072 )
2020-06-18 10:18:34 -05:00
dependabot-preview[bot]
332a7bb59c
Build(deps): Bump aws-sigv4 from 1.1.4 to 1.2.0 ( #10070 )
...
Bumps [aws-sigv4](https://github.com/aws/aws-sdk-ruby ) from 1.1.4 to 1.2.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/master/gems/aws-sigv4/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/compare/1.1.4...1.2.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-06-18 11:11:17 -04:00
Régis Hanol
823b940b9d
PERF: improve loading of indexes in bulk import
...
Similar strategy as for c52191d
in which we stream the results from the database into
an automatically growing array instead of using a hash.
2020-06-18 16:32:27 +02:00
Bianca Nenciu
db1bebddce
FIX: Hide the post history for TL4 ( #10065 )
2020-06-18 13:27:51 +03:00
Dan Ungureanu
d21a08c284
DEV: Deprecate Category#url_with_id in favor of Category#url ( #9972 )
2020-06-18 11:32:14 +03:00
Dan Ungureanu
62faa0f5fe
FIX: Do not show Add or Change buttons if email is not editable ( #10068 )
2020-06-18 11:15:44 +03:00
Joffrey JAFFEUX
75991a249e
fix spec ( #10069 )
2020-06-18 09:02:08 +02:00
Jeff Atwood
978aba632e
minor copyedit on site setting description
2020-06-17 14:13:52 -07:00
Penar Musaraj
d72ed8c5a8
UX: Include category name in hyperlink modal results on mobile
2020-06-17 14:46:01 -04:00
Dan Ungureanu
79ab1493c8
DEV: Add test ( #10066 )
...
Follow-up-to f1b97202d4
2020-06-17 21:41:29 +03:00
Dan Ungureanu
7ed7b1ef64
DEV: Add test ( #10064 )
...
Follow-up-to 84dfaad137
2020-06-17 21:41:16 +03:00
Dan Ungureanu
a60a67c431
FIX: Show unconfirmed emails too when checking emails ( #10062 )
...
When checking emails through user preferences, it did not display the
unconfirmed emails.
2020-06-17 21:41:01 +03:00
Robin Ward
e8756e1a95
FIX: Muted/Ignore should prevent PMs regardless of case sensitivity
2020-06-17 14:26:14 -04:00
Jeff Wong
81a3129ffb
ARIA - add aria-label on topic input and post textarea ( #10057 )
...
Add reply form role with label as create/reply, and aria-labels on text inputs
2020-06-17 08:55:19 -07:00
Penar Musaraj
76b05ef8ad
DEV: Use short_date helper for email post template ( #10063 )
2020-06-17 11:29:37 -04:00
David Taylor
e29afa200a
FIX: Cleanup migrations with timestamps in the future
...
A future-dated migration was accidently introduced by me in 45c399f0
. This was removed in b9762afc
, but other migrations had already been generated based on its incorrect date. This commit removes the offending data in the schema_migrations table, and corrects the version in the published_pages migration.
This commit also adds a check to db:migrate which raises an error when invalid migration timestamps are used.
2020-06-17 15:58:22 +01:00
David Taylor
159fc41f40
FIX: Restore missing translation keys
...
These were accidentally removed/renamed in 5bfe1ee4
2020-06-17 14:24:22 +01:00
Joffrey JAFFEUX
9518d6b587
fix spec ( #10061 )
2020-06-17 15:10:07 +02:00
David Taylor
6caad5c083
FIX: Do not send staff welcome message if user already has role
2020-06-17 12:12:55 +01:00
Joffrey JAFFEUX
9da3a7f436
FEATURE: allows published pages to be public ( #10053 )
2020-06-17 12:42:20 +02:00
Jarek Radosz
7d289a4f3e
UX: Style video elements, show descriptions ( #10040 )
...
It's a stop gap – ideally we would generate a thumbnail for uploaded videos. For now, a bit of intentionality in the style and a pinch of context should do.
2020-06-17 12:38:00 +02:00
Jarek Radosz
a859d507e7
FIX: Prevent producing "undefined" strings ( #10042 )
...
Fixes a bug in search-menu-results (type: "group"), where:
```javascript
const fullName = escapeExpression(group.fullName);
const name = escapeExpression(group.name);
const groupNames = [h("span.name", fullName || name)];
```
`groupNames` could end up having value "undefined" if a group doesn't have a `fullName`.
2020-06-17 12:37:06 +02:00
Faizaan Gagan
d66ccabdb1
DEV: Added topic-list-after-title outlet in the mobile template ( #10059 )
2020-06-17 10:05:37 +01:00
Guo Xiang Tan
45eb97c202
FIX: Thread safety issues with multisite:migrate
and SeedFu
.
2020-06-17 16:15:43 +08:00
Guo Xiang Tan
86b43c5329
DEV: Remove rubocop_todo which doesn't seem to work with plugins.
2020-06-17 15:47:44 +08:00
Guo Xiang Tan
828ceab64b
DEV: Make rubocop happy.
2020-06-17 15:47:05 +08:00
Guo Xiang Tan
28f6c59612
DEV: Load rubocop_todo after default config.
2020-06-17 15:31:26 +08:00
Guo Xiang Tan
9c385a3599
Update rubocop_todo.
2020-06-17 15:19:50 +08:00
Guo Xiang Tan
f096181653
Upgrade rubocop and generate rubocop todo.
2020-06-17 14:50:34 +08:00
Guo Xiang Tan
3e888cbb5d
DEV: Properly reset column information before seeding.
2020-06-17 13:23:45 +08:00
Guo Xiang Tan
52580605d8
FIX: select-kit components not being hidden.
2020-06-17 09:39:51 +08:00
dependabot-preview[bot]
ad447677ed
Build(deps): Bump sanitize from 5.2.0 to 5.2.1
...
Bumps [sanitize](https://github.com/rgrove/sanitize ) from 5.2.0 to 5.2.1.
- [Release notes](https://github.com/rgrove/sanitize/releases )
- [Changelog](https://github.com/rgrove/sanitize/blob/master/HISTORY.md )
- [Commits](https://github.com/rgrove/sanitize/compare/v5.2.0...v5.2.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-06-17 09:39:04 +08:00
dependabot-preview[bot]
5610792704
Build(deps): Bump loofah from 2.5.0 to 2.6.0
...
Bumps [loofah](https://github.com/flavorjones/loofah ) from 2.5.0 to 2.6.0.
- [Release notes](https://github.com/flavorjones/loofah/releases )
- [Changelog](https://github.com/flavorjones/loofah/blob/master/CHANGELOG.md )
- [Commits](https://github.com/flavorjones/loofah/compare/v2.5.0...v2.6.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-06-17 09:38:41 +08:00
Martin Brennan
e5da2d24e5
FIX: Add attachment content-disposition for all non-image files ( #10058 )
...
This will make it so the original filename is used when downloading all non-image files, bringing S3Store into line with the to_s3 migration and local storage. Video and audio files will still stream correctly in HTML players as well.
See https://meta.discourse.org/t/cannot-download-non-image-media-files-original-filenames-lost-when-uploaded-to-s3/152797 for a lot of extra context.
2020-06-17 11:16:37 +10:00