Commit Graph

23521 Commits

Author SHA1 Message Date
Guo Xiang Tan
cbedc1a2ca FIX: Notification backdrop does not display when user menu has been toggled.
https://meta.discourse.org/t/first-pm-spotlight-does-not-work-with-welcome-message-delay/64927/16?u=tgxworld
2017-06-23 11:35:06 +09:00
Guo Xiang Tan
3f4b5e0246 Bump eslint for travis to 4.0. 2017-06-23 09:06:21 +09:00
Rafael dos Santos Silva
f02bf8e4c3 FIX: Make .eslintrc file compatible with eslint 4 take 2 2017-06-22 17:22:42 -03:00
Rafael dos Santos Silva
2e9ab29817 FIX: Make .eslintrc file compatible with eslint 4 2017-06-22 17:09:16 -03:00
Robin Ward
94ab194a7f Adds support for Github oneboxes to commits in pull requests 2017-06-22 15:46:07 -04:00
Robin Ward
5fda2b84e1 FIX: If the progress bar is docked, set the progress to 100% 2017-06-22 14:43:15 -04:00
Robin Ward
b22df9f166 FIX: Double header rendering issues, redux 2017-06-22 12:50:46 -04:00
Régis Hanol
94cee37edd FIX: uploads:recover_from_tombstone rake task 2017-06-22 17:00:05 +02:00
Régis Hanol
6e5c59e5ec FIX: image orientation wasn't properly working 2017-06-22 16:53:49 +02:00
Régis Hanol
66920cfafd Merge pull request #4938 from LeoMcA/ses-fix
FEATURE: setting to only use the key when finding the related post of…
2017-06-22 16:15:57 +02:00
Régis Hanol
a916f6b0c8 remove some warnings with already declared constants 2017-06-22 12:55:58 +02:00
Régis Hanol
94a0d43f31 add 'ico' and 'webp' to image extensions list in order to bypass rails 2017-06-22 12:55:27 +02:00
Régis Hanol
2e7753c27f User 'FileHelper.is_image?' to check wether a link is poiting to an image 2017-06-22 12:54:42 +02:00
Régis Hanol
ca539854c8 FIX: use 'jpg' instead of 'jpe' extension for 'image/jpeg' content type 2017-06-22 12:53:56 +02:00
Régis Hanol
e50bd38013 Merge pull request #4936 from meldsza/patch-1
Optimize import script - vanilla_mysql.rb
2017-06-22 10:26:58 +02:00
Guo Xiang Tan
80e348d226 PERF: Speed up slow tests in our test suite.
Before

```
Finished in 7 minutes 23 seconds (files took 4.15 seconds to load)
7145 examples, 0 failures, 10 pending
```

After

```
Finished in 6 minutes 12 seconds (files took 4.41 seconds to load)
7145 examples, 0 failures, 10 pending
```
2017-06-22 11:23:31 +09:00
Neil Lalonde
8fd915a11a Revert "FIX: add path to cookies so sessions on the same domain but different subfolders don't log each other out" 2017-06-21 16:18:24 -04:00
Robin Ward
aaaa93c216 FIX: Full page search was removing advanced search terms 2017-06-21 15:51:15 -04:00
Robin Ward
1a02f5154f FIX: Dirty keys should become to a widget, not global 2017-06-21 14:27:08 -04:00
Robin Ward
287cb4bfc5 FEATURE: Allow truncated group posts to be expanded 2017-06-21 12:56:38 -04:00
Robin Ward
32756060bb REFACTOR: Remove unused component 2017-06-21 12:32:56 -04:00
Robin Ward
d09bed0d76 FIX: Some stream items don't have post_id, so expand by topic id / post number 2017-06-21 12:27:39 -04:00
Arpit Jalan
6796de8bf2 FIX: replace site_name with email_prefix in subject when use_site_subject is true 2017-06-21 21:15:49 +05:30
Guo Xiang Tan
4c98bd9d5f FIX: Can't update status_type of topic timers.
https://meta.discourse.org/t/topic-timers-internal-error-500/64805
2017-06-21 15:31:15 +09:00
Guo Xiang Tan
dd85c1098b Remove comment that is no longer valid. 2017-06-21 14:10:30 +09:00
Guo Xiang Tan
47ca0f7f09 FIX: Foward requests to /u/new to our Ember router. 2017-06-21 13:06:28 +09:00
Jeff Atwood
0dd1d736c8 user stream UI should match time color 2017-06-20 17:19:53 -07:00
Neil Lalonde
1b3501b39b FIX: discourse hub calls 2017-06-20 17:15:59 -04:00
Sam
492eed70ab correct with brackets 2017-06-20 15:53:14 -04:00
Robin Ward
a289ae67e1 FEATURE: Expand truncated posts in the user stream 2017-06-20 15:45:41 -04:00
Robin Ward
ae7734707e REFACTOR: Merge different templates from rendering user stream items 2017-06-20 15:45:41 -04:00
Sam
9f8388c2eb FIX: start filesystem watcher when running under rails s 2017-06-20 15:44:01 -04:00
Neil Lalonde
1716747810 FIX: add path to cookies so sessions on the same domain but different subfolders don't log each other out 2017-06-20 13:30:36 -04:00
Guo Xiang Tan
482365b943 Merge pull request #4939 from tgxworld/memory_emoji
Reduce allocations in `Emoji.unicode_replacements`
2017-06-20 14:10:10 +09:00
Guo Xiang Tan
fa35137d3a PERF: Reduce allocations in Emoji.unicode_replacements.
```
MemoryProfiler.report { Emoji.unicode_replacements }.pretty_print
```

Before:

```
Total allocated: 2032131 bytes (30219 objects)
Total retained:  798059 bytes (10734 objects)

allocated memory by gem
-----------------------------------
   1270762  discourse/app
    690149  2.4.1/lib
     48764  activesupport-4.2.8
     11405  bootsnap-1.0.0
      5266  logster-1.2.7
      2473  hiredis-0.6.1
      2056  redis-3.3.3
       840  discourse/lib
       240  activerecord-4.2.8
       176  thread_safe-0.3.6
```

After:

```
Total allocated: 1715713 bytes (22449 objects)
Total retained:  797985 bytes (10737 objects)

allocated memory by gem
-----------------------------------
    957250  discourse/app
    690028  2.4.1/lib
     48764  activesupport-4.2.8
     11445  bootsnap-1.0.0
      2745  hiredis-0.6.1
      2624  redis-3.3.3
      1473  logster-1.2.7
       928  discourse/lib
       280  activerecord-4.2.8
       176  thread_safe-0.3.6
```
2017-06-20 13:50:37 +09:00
Guo Xiang Tan
40ef5c4f14 PERF: Reduce memory allocation by Emoji.unicode_replacements.
Calling `Emoji.tonable_emojis` fetches from the cache but creates
a giant array each time it is called.

```
MemoryProfiler.report { Emoji.unicode_replacements }.pretty_print
```

Before:

```
Total allocated: 16560770 bytes (246364 objects)
Total retained:  784793 bytes (10624 objects)

allocated memory by gem
-----------------------------------
  10224581  activesupport-4.2.8
   3504241  hiredis-0.6.1
   1449466  discourse/app
    679314  2.4.1/lib
    419592  discourse/lib
    226720  redis-3.3.3
     56680  activerecord-4.2.8
       176  thread_safe-0.3.6
```

After:

```
Total allocated: 2127703 bytes (30556 objects)
Total retained:  798099 bytes (10735 objects)

allocated memory by gem
-----------------------------------
   1270762  discourse/app
    690149  2.4.1/lib
    106977  bootsnap-1.0.0
     48764  activesupport-4.2.8
      5266  logster-1.2.7
      2473  hiredis-0.6.1
      2056  redis-3.3.3
       840  discourse/lib
       240  activerecord-4.2.8
       176  thread_safe-0.3.6
```
2017-06-20 13:10:44 +09:00
Guo Xiang Tan
8dbe2c3ec4 FIX: Incorrect way to use Excon in DiscourseHub. 2017-06-20 08:32:45 +09:00
Robin Ward
394efb3290 FIX: Docking of progress component on iOS was a bit off 2017-06-19 15:53:51 -04:00
Neil Lalonde
14256e11e7 FIX: topic list wrapping under category list on some screens 2017-06-19 15:23:32 -04:00
Sam
2181e995f1 remove sinatra 2017-06-19 13:49:11 -04:00
Arpit Jalan
34126eb9e0 optimize 'hide help button' code 2017-06-19 22:20:09 +05:30
Leo McArdle
5e0efb3410 FEATURE: setting to only use the key when finding the related post of an email reply
this fixes email-in threading problems when using a SMTP server which modifies the message_id
header, like Amazon SES
2017-06-19 12:22:44 +01:00
Arpit Jalan
2bf2d506bf UX: hide help button after click 2017-06-19 16:27:31 +05:30
Arpit Jalan
ee1f3a4b25 UX: make font size consistent on password reset modal 2017-06-19 16:09:29 +05:30
Arpit Jalan
e6b7458b54 remove trailing dot in help text 2017-06-19 15:49:51 +05:30
Jeff Atwood
1c688c9eae copyedit on login help text 2017-06-19 03:08:20 -07:00
Arpit Jalan
0829bb8658 Merge pull request #4937 from techAPJ/forgot-password-help
FEATURE: offer help on forgot password modal
2017-06-19 14:53:31 +05:30
Arpit Jalan
74e6717b40 FEATURE: offer help on forgot password modal 2017-06-19 14:05:45 +05:30
Guo Xiang Tan
7ea288140d Allow multiple host when restricting Sidekiq queues. 2017-06-19 14:45:51 +09:00
Guo Xiang Tan
be44e4b730 Update Sidekiq. 2017-06-19 14:20:54 +09:00