github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-24 02:09:54 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
31,660 Commits 190 Branches 500 Tags 938 MiB
4fb9ca3bc9
Commit Graph

18785 Commits

Author SHA1 Message Date
Joffrey JAFFEUX
2c6bf184bc
REFACTOR: admin-badge-preview (#7017) 2019-02-19 09:30:52 +01:00
Joffrey JAFFEUX
3bf61fca66
REFACTOR: admin-user-field-item (#7016) 2019-02-19 09:30:38 +01:00
Joffrey JAFFEUX
ee692414ce
REFACTORING: admin-edit-badge-groupings (#7015) 2019-02-19 09:30:24 +01:00
Vinoth Kannan
27e7f2bee0 DEV: call 'enqueue_hooks' method only if active webhooks exist 2019-02-19 12:43:08 +05:30
Vinoth Kannan
f2c3415548 FIX: Should not generate payload until active webhooks are exist 2019-02-19 12:23:42 +05:30
Kris
4f5aebc338 UX: reduce subcategory badge spacing 2019-02-18 19:04:36 -05:00
Arpit Jalan
50f833def0 fix the build 
JsPrettier on Sublime was failing because: https://github.com/jonlabelle/SublimeJsPrettier/issues/157#issuecomment-458175837
 2019-02-18 11:52:11 +05:30
Arpit Jalan
dc2776bcdd FIX: do not show "move to new PM" option to moderators 2019-02-18 11:35:00 +05:30
Jeff Atwood
052eaed16a lighten embed blockquote style for consistency 2019-02-17 21:00:46 -08:00
Jeff Atwood
dfba36fdca remove bgcolor from embed quotes for consistency 2019-02-17 20:57:27 -08:00
Guo Xiang Tan
7da7a30e02 PERF: Restore exists? in favor of blank?. 
Regression from dcd7b92532.
 2019-02-18 10:04:21 +08:00
David Taylor
f04471e422 REFACTOR: Proxy letter avatars in rails instead of nginx 
Co-authored-by: Sam Saffron <sam.saffron@gmail.com>
Co-authored-by: David Taylor <david@taylorhq.com>

This gives more control over the request. In particular we can easily
lookup DNS dynamically, instead of only upon NGINX startup.
Previously, NGINX was looking up IP for the letter avatar service and
caching the CDN IP address, this caused issues if CDN changed IP, in
which letter avatars would be broken till a container restarted.

NGINX config has been updated to add caching. This change will require
a container rebuild.

The proxy will now function in development environments, so the patch
for `letter_avatar_proxy` has been removed.
 2019-02-18 08:46:56 +11:00
Gerhard Schlager
b0862bd15d FIX: Push notifications could fail with UnauthorizedRegistration 
The webpush gem by default sets the expiration date of the JWT token to exactly 24 hours in the future. That's not really needed because the token isn't reused. And it might cause UnauthorizedRegistration if the server's clock isn't 100% correct, because the maximum allowed value is 24 hours.
 2019-02-15 21:12:09 +01:00
Gerhard Schlager
17f1a76570 FIX: Delete push subscription on MismatchSenderId error 
This should prevent repeated MismatchSenderId warnings when the VAPID keys have changed.
 2019-02-15 21:12:09 +01:00
peterlamber
159dd69fcb UX: make adding permissions more visible and intuitive to click. (#6999) 2019-02-15 12:01:10 -05:00
Arpit Jalan
99c6db21e6
FEATURE: allow blocking emojis (#7011) 
https://meta.discourse.org/t/blocking-emojis-wont-work/105853
 2019-02-15 20:55:48 +05:30
Dan Ungureanu
a423a9383f FIX: Stop autocomplete for invalid usernames. (#7005) 2019-02-15 11:29:26 +11:00
Sam
f8b70f4ca3 FIX: unable to create new categories 
Previous attempt at 70adb940 missed the critical "everyone" group from
staff, leading to a case where staff was no longer able to create categories
 2019-02-15 10:24:29 +11:00
Kris
3d11064a33 UX: Reduce font size on about pages 2019-02-14 11:01:17 -05:00
Bianca Nenciu
70adb94008 SECURITY: Do not leak private group names. (#7008) 2019-02-14 15:35:58 +01:00
Régis Hanol
fc14847c14 PERF: only require aws-sdk-sns gem when it's being used 2019-02-14 11:08:21 +01:00
Sam
ebd4140492 FIX: logspam due to 404s on CSS files 
We had a missing formats: string on our render partial that caused logs to
spam when CSS files got 404s.

Due to magic discourse_public_exceptions.rb was actually returning the
correct 404 cause it switched format when rendering the error.
 2019-02-14 17:58:16 +11:00
Maja Komel
39522659a6 FIX: validate parent category/subcategories permissions 
See: https://meta.discourse.org/t/subcategories-do-not-inherit-permissions-from-parent-category/17174/23 for more details

This ensures users with access to child category can always at least see parent
 2019-02-14 16:38:52 +11:00
Penar Musaraj
090e9c8432
FIX: make composer full screen shortcut work when inputs have focus (#6907) 
- Uses a Mousetrap plugin for global shortcuts
- Implemented for search `ctrl+alt+f` and composer fullscreen `shift+f11` shortcuts
 2019-02-14 00:19:27 -05:00
Saurabh Patel
ed6f4dfc40 FEATURE: trigger user profile create and update event (#6958) 
Adds `user_profile_created` DiscourseEvent on profile creation and `user_profile_updated` on profile update
 2019-02-14 15:45:12 +11:00
Arpit Jalan
b651605d6e FIX: tags added while editing a pending approval topic do not show up (#6959) 2019-02-14 15:42:40 +11:00
Kris
37666c3d18 UX: Signup form labels were too constrained, minor cleanup 2019-02-13 21:07:34 -05:00
Vinoth Kannan
484bd82278 FIX: Add onceoff job to remove double quotes from s3 etags 2019-02-14 05:19:41 +05:30
Régis Hanol
0476169692 make prettier happy 2019-02-13 22:16:38 +01:00
Régis Hanol
94fe0af900 FIX: upload emojis sequentially to prevent rate limit 2019-02-13 22:07:37 +01:00
Régis Hanol
4d674acc25 FEATURE: AWS SNS bounce notifications webhooks 2019-02-13 21:26:40 +01:00
Joffrey JAFFEUX
560cc4e73e
FIX: sets categoryId but do not scope when replying as new topic (#7002) 2019-02-13 15:19:58 +01:00
Joffrey JAFFEUX
fe4254b8f3
FIX: reverse consolidated pageviews stacked chart order (#7001) 2019-02-13 12:24:18 +01:00
Sam
641b079c78 FIX: add support for missing verbs in user api key 
Previously "write" scope was missing put and delete verbs which should be
allowed.

Also closes: #6982
 2019-02-13 15:49:43 +11:00
Jeff Wong
1328a127ee FIX: translate bootbox confirmation dialog (#6981) 2019-02-13 14:04:56 +11:00
Jeff Wong
467cfc9e08 FIX: remove extra periods (#6998) 
Periods are belong in the translation files not in our templates, if we have them in the templates sentences can not be localized properly.
 2019-02-13 12:54:34 +11:00
Joffrey JAFFEUX
47fe34d794 FEATURE: makes create-account userfields using dropdowns accessible (#6991) 2019-02-13 12:52:55 +11:00
Kris
3da35081e5 UX: Embedded post collapse button hover color fix 2019-02-12 17:21:33 -05:00
Robin Ward
c23411cc69 FIX: Heisentest - suspicious logins report was not ordered by date 
The specs needed an order even though none was supplied.
 2019-02-12 13:17:29 -05:00
David Taylor
86fe423f5e FIX: Clear the cache after destroying theme_fields 2019-02-12 16:39:40 +00:00
David Taylor
91f0468f4e FIX: Allow unbaked theme fields to be destroyed 
The after_commit hook was attempting to re-bake theme_fields after they were destroyed, which caused an exception to be thrown
 2019-02-12 16:14:43 +00:00
David Taylor
59640ef373 DEV: Add additional hooks for theme-creator plugin 2019-02-12 14:17:34 +00:00
Régis Hanol
b8b1759de9 UX: show envelope when tag is only used in PM 
UX: use regular envelope instead of solid envelope

REFACTOR: %s/enveloppe/envelope/g
 2019-02-12 11:34:25 +01:00
Dan Ungureanu
90ce448675 PERF: Cache build_not_found_page 2019-02-12 21:20:33 +11:00
Jeff Wong
d997b01a24 FIX: Scale down swipe in detection to 20px from edge of the screen 
...and slightly increase velocity required for menu actions
 2019-02-11 21:22:50 -08:00
Jeff Wong
c3cbff55be FIX: only respond to menu open swipes on Andorid 2019-02-11 20:56:25 -08:00
Vinoth Kannan
e0c16d3a8a minor refactoring to improve code readability 2019-02-11 17:24:02 +05:30
Arpit Jalan
dcd7b92532 FIX: some posters were not getting added to topic_allowed_users when moving posts to a new PM 
If a user posted twice in a topic then subsequent posters were not getting added as topic_allowed_users.
 2019-02-11 17:05:21 +05:30
Vinoth Kannan
2c12336c6b FIX: Display post updated date in non-JS view for crawler 2019-02-11 16:48:22 +05:30
Penar Musaraj
c50db76f5d FIX: do not treat TIFF, BMP, WEBP as images 
Treating TIFF and BMP as images cause us to add them to IMG tags, this is very inconsistent across browsers.

You can still upload these files they will simply not be displayed in IMG tags.
 2019-02-11 16:28:43 +11:00
Robin Ward
c719658f9f human? helper method on a user 
This is cleaner than hard coding `id > 0` in ruby code.
 2019-02-08 13:34:54 -05:00
David Taylor
60fa4fe692 DEV: Make interface route/controller more resilient to missing values 2019-02-08 16:54:15 +00:00
Kris
0d1fa54957 compensate for border overhang in category list alignment 2019-02-08 11:49:06 -05:00
Robin Ward
72b5ab0454 Don't wrap exceptions in test mode unless specifically requested. 
This helps debugging reports with invalid SQL, which would otherwise
return no results instead of a useful error message while running
tests.
 2019-02-08 11:26:26 -05:00
Kris
7c55de6e6f UX: Alignment fix for names with emoji 2019-02-08 11:07:04 -05:00
David Taylor
747fea8458 DEV: Remove unused import 2019-02-08 16:05:39 +00:00
David Taylor
95eb4c67f2 FIX: Allow reverting theme/text settings from cookie back to default 2019-02-08 15:39:44 +00:00
Penar Musaraj
62043e6904 UX: Hide branch/private repo options in admin theme import modal 2019-02-08 10:17:29 -05:00
Régis Hanol
7aecd3c2f5 Update app/services/user_silencer.rb 
Co-Authored-By: eviltrout <robin.ward@gmail.com>
 2019-02-08 08:50:50 -05:00
Robin Ward
bc3efab816 FIX: When disagreeing with a flag that silenced a user, unsilence them 
Previously it would unhide their post but leave them silenced.

This fix also cleans up some of the helper classes to make it easier
to pass extra data to the silencing code (for example, a link to the
post that caused the user to be silenced.)

This patch also refactors the auto_silence specs to avoid using
stubs.
 2019-02-08 08:50:50 -05:00
Joffrey JAFFEUX
44d9bc12c9
FEATURE: color-palettes component (#6992) 2019-02-08 14:01:14 +01:00
David Taylor
babd80dfd1 FIX: Allow subexpressions in raw handlebars helpers 
Helpers registered via `registerUnbound` did not receive parameters if they were subexpressions.
For example: `{{helper1 key=(helper2 value)}}`
 2019-02-08 12:58:10 +00:00
David Taylor
95b5c5898e FIX: Prevent duplicate params for raw template theme handlebars helpers 2019-02-08 12:54:00 +00:00
Joffrey JAFFEUX
e3324737ee
FIX: position invite footer button before archive (#6990) 2019-02-08 12:21:51 +01:00
Gerhard Schlager
e9ec5238fc DEV: Remove ignored columns 2019-02-08 12:12:38 +01:00
Joffrey JAFFEUX
8a152566e3
FIX: improves positioning of footer buttons on mobile (#6989) 2019-02-08 12:09:56 +01:00
Joffrey JAFFEUX
e54612c914
fix tests (#6987) 2019-02-08 11:38:15 +01:00
Kris
f849169619 UX: Modifications to admin/customize layout 2019-02-07 22:27:35 -05:00
Gerhard Schlager
cbedb6a1ac FEATURE: Hidden site setting to always include topic excerpt 2019-02-07 22:45:21 +01:00
Penar Musaraj
2a007bafa2 FEAT: Allow image resize by width or height 
`|150x` resizes to 150px wide + auto-height. `x150` resizes to 150px tall and auto-width.

Resize value can be from 1 to 999 (incl. for percentages).
 2019-02-07 15:04:39 -05:00
Joffrey JAFFEUX
c0ccf21970
FIX: hides topic-footer-mobile-dropdown when no content (#6985) 2019-02-07 18:37:20 +01:00
Joffrey JAFFEUX
6c195640b9
FEATURE: adds an API to register topic footer buttons 2019-02-07 14:43:33 +01:00
Joffrey JAFFEUX
92c52c0724
FEATURE: displays report description when hovering activity metrics (#6983) 2019-02-07 13:33:05 +01:00
Kris
1cacfddda4 Prevent usercard badge section from overflowing 2019-02-06 22:39:10 -05:00
Kris
984f1d96b0 Add max-width so long badges don't force short badges to truncate 2019-02-06 20:51:54 -05:00
Kris
94f8c4ecac UX: Truncate (don't wrap) badges in user cards if the text is long 2019-02-06 20:18:12 -05:00
Dan Ungureanu
fc4c015bee FEATURE: Shortcut 'g s' goes to first suggested topic 2019-02-07 08:43:07 +11:00
Kris
56a9f777cb UX: Turn off autocomplete on composer title 2019-02-06 14:37:29 -05:00
Arpit Jalan
ab2c2ea605
FIX: validate Invite email against EmailValidator.email_regex (#6975) 2019-02-06 22:38:06 +05:30
Robin Ward
ca03b2ff30 Move SCSS variables for topic post width 
This allows them to be re-used by other components, for example the
upcoming review queue.
 2019-02-06 11:37:59 -05:00
Régis Hanol
057d1dc077 UX: disable browser's autocomplete in search menu 2019-02-06 17:06:23 +01:00
David Taylor
f3cfce4a93
FEATURE: Calculate sprite-sheet based on currently active themes (#6973) 
Previously there was only one sprite sheet, which always included icons from all themes even if they were disabled
 2019-02-06 15:51:23 +00:00
Arpit Jalan
381793243e FIX: include error message if the "accept invite" process fails 2019-02-06 19:20:25 +05:30
Kris
1a72242746 line-height adjustment 2019-02-05 21:44:06 -05:00
Kris
a52b2c9625 UX: Moving the create theme buttons, adding buttons to theme index 2019-02-05 21:40:17 -05:00
Vinoth Kannan
e7821a63e7 FIX: Users should able check the emails for self 2019-02-05 23:31:19 +05:30
Gerhard Schlager
ba724d7f25 FIX: S3 endpoint broke bucket creation in non-default region 2019-02-05 18:17:02 +01:00
David Taylor
a3b47c1dd1 FEATURE: Allow string theme settings to display with multiple lines 
To use, add `textarea: true` to the theme settings.yml. For example:

```
my_setting:
  default: "some string"
  textarea: true
```
 2019-02-05 14:14:53 +00:00
David Taylor
7b7bc3db39 FIX: Rescue and display import errors when updating theme via git 2019-02-05 13:49:16 +00:00
Dan Ungureanu
31ffcf989c
UX: Use translatedLabel for aria-label in buttons. 2019-02-05 13:11:07 +02:00
Dan Ungureanu
2c222e16fe FEATURE: Returning falsy value from upload handler stops upload. (#6969) 2019-02-05 10:54:11 +01:00
Kris
b6e3ef4a90 Minor icon color fix 2019-02-04 22:14:18 -05:00
Kris
58d5fc3632 UX: Minor button icon color fixes 2019-02-04 12:46:12 -05:00
Jeff Wong
9de906ddab
FIX: Register pan events for touch only 
* touch events - only register touch, not pointer events
* immediately request redraw frame, do not wait for after render to fire.
 2019-02-04 08:27:40 -08:00
Bianca Nenciu
e0e91fad87 FIX: Fix delete button for Tag Groups. (#6965) 2019-02-04 12:46:39 +01:00
Kris
2a2be093ca UX: checkboxes were too close to other inputs 2019-02-01 21:07:57 -05:00
Robin Ward
e75b240390 FIX: Some brittle tests with hardcoded ids 
If we're going to use hardcoded ids, we should make sure the records are
not saved, or that the ID will not come up during normal use.
 2019-02-01 11:44:37 -05:00
Kris
37c28cf0b7 UX: Header icon color fix 2019-02-01 09:51:12 -05:00
David Taylor
eb617dea4b DEV: Run prettier on report.js.es6 
The prettier version I was running was different to the CI pipeline
 2019-02-01 13:22:31 +00:00
David Taylor
5c9426be48 SECURITY: Escape HTML in dashboard report tables 2019-02-01 13:10:59 +00:00