github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-12-17 15:48:45 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
23,451 Commits 214 Branches 500 Tags 960 MiB
504bcf4550
Commit Graph

14006 Commits

Author SHA1 Message Date
Sam
4b449914b8 FIX: admins could never remove self from messages 2017-05-16 16:06:24 -04:00
Sam
6ddd8d9166 FIX: when entering topics "tracking" would not be set 
There was a timing issue when subscribing to messages for topics.

Old flow:

- We generate JSON for topic
- We subscribe to messages for topic

New flow:

- We keep track of last id in the topic message bus channel
- We generate JSON
- We subscribe to messages for topic starting at saved message id

This ensures that there is complete overlap for message consumption
and that there are no cases where an update may go missing due to timing
 2017-05-16 15:04:21 -04:00
Neil Lalonde
7821400141 FEATURE: staff can set a timer to remind them about a topic 2017-05-16 14:49:50 -04:00
Leo McArdle
59922ce0a4 FEATURE: remove table wrapping posts in notification emails 2017-05-16 10:37:53 -04:00
Robin Ward
941adca958 FIX: If you refresh New, clear the incoming topics text 2017-05-15 16:57:09 -04:00
Sam
c40ac5abe6 FIX: resize events for ace were not triggered correctly 2017-05-15 16:10:07 -04:00
Sam
7a4e825671 we should use fancy title if available 2017-05-15 15:45:29 -04:00
Sam
be8dd403df FEATURE: use fancy title in notifications 2017-05-15 15:38:30 -04:00
Robin Ward
f7c46df804 FIX: Only mark all as rendered after *everything* is rendered 2017-05-15 15:12:10 -04:00
Sam
f114d63de4 correctly pick the selected theme based on what is loaded 2017-05-15 14:34:24 -04:00
Robin Ward
bd0bb879e5 FIX: Don't count likes from system users in the new user of the month 2017-05-15 13:14:32 -04:00
Sam
e1dd543a93 FEATURE: allow users to select theme on single device 2017-05-15 12:48:16 -04:00
Robin Ward
a0c936dadb UX: Take header height into account when positioning the timeline 2017-05-15 12:08:42 -04:00
Sam
44d7fe89ed FIX: unescape emoji in pretty title 
This makes emoji in title consistent, it is later escaped back when needed
 2017-05-15 10:28:05 -04:00
Guo Xiang Tan
dfc9a27dc4 FIX: Quote button broken on windows. 2017-05-15 08:26:48 +08:00
Robin Ward
42de1cc977 FIX: Don't warn if the link is in the post you are editing 2017-05-12 20:05:30 -04:00
Neil Lalonde
dd0c34c4b9 move background photo user prefs to be lower in the profile tab 2017-05-12 15:43:21 -04:00
Sam
ff6b9aee47 no opacity rule for btn-primary 2017-05-12 15:11:44 -04:00
Sam
baf011cbf6 annotate models 2017-05-12 14:47:08 -04:00
Robin Ward
a9d5d2aee6 UX: Fix improper aspect ratio for xkcd oneboxes 2017-05-12 13:21:44 -04:00
Sam
b92b654ea3 FIX: collapse mobile nav on outside click 2017-05-12 13:15:04 -04:00
Sam
3113a6a18a FIX: hide theme selector if only 1 theme 2017-05-12 12:50:56 -04:00
Sam
2d96a0785d FEATURE: theme selection is now global per-user 2017-05-12 12:41:34 -04:00
Robin Ward
b301b69d00 FIX: Don't warn users about duplicate links for: 
- The original post
- If the post is older than (x) (Two Weeks for now)
 2017-05-12 12:37:02 -04:00
Sam
ee71786057 PERF: we do not need to ship down the total number of unread 
Total number of unread notification from the beginning of time
is not an interesting number
 2017-05-12 11:11:38 -04:00
Sam
e232f87cde PERF: avoid query as admin 
As admin no need to query categories over and over
 2017-05-12 11:09:41 -04:00
Chris Gavin
fca166524b Fix the padding on the login and register buttons. 2017-05-12 09:51:48 +01:00
Guo Xiang Tan
8eecd42856 FIX: Delete topic timer after completion. 2017-05-12 10:28:51 +08:00
Guo Xiang Tan
e63614024d FIX: Users can't request to join group due to alias level restriction. 
https://meta.discourse.org/t/request-to-join-group-not-working/62371
 2017-05-12 09:26:26 +08:00
Neil Lalonde
55b61e9bea rename topic_status_update to topic_timer 2017-05-11 18:27:53 -04:00
Robin Ward
92d63b59a7 FIX: Videos were missing from expanded quotes 2017-05-11 16:54:32 -04:00
Robin Ward
f3c535b945 PERF: Dirty checking was broken and re-rendering too often 2017-05-11 16:22:15 -04:00
Robin Ward
ea0ecb67f3 UX: Move delete button to end and mark it as dangerous 2017-05-11 16:22:15 -04:00
Sam
52ae63d5d7 FIX: when searching PMs also search group PMs 
Users belonging to a group could not search for PMs unless explicitly added
to the PM unless admin
 2017-05-11 15:59:03 -04:00
Pat David
aa009dd2b5 Add @embeddable_css_class from embed_controller 2017-05-11 15:16:16 -04:00
Pat David
18de62b015 Add get_embeddable_css_class to assist multi-site embed styling 
If present, pass embeddable_host.class_name to view for inclusion
on the <html> element as a class for targeted styling.
 2017-05-11 15:16:16 -04:00
Pat David
4bf8548dc5 Add embed class name setup for embeddable hosts 2017-05-11 15:16:16 -04:00
Robin Ward
5bbc477baa UX: Better looking bulk actions modal 2017-05-11 14:48:06 -04:00
Neil Lalonde
1019bbda46 FEATURE: set a timer to delete a topic 2017-05-11 12:52:29 -04:00
Robin Ward
21238692d9 Remove unused file 2017-05-11 12:36:57 -04:00
Robin Ward
3ade46de0b FIX: Don't send system message for new user of the month if disabled 2017-05-11 11:33:16 -04:00
Robin Ward
006b35d2f3 FIX: Don't redirect for users/account-created path 2017-05-11 11:04:45 -04:00
Arpit Jalan
f4b2677a19 FEATURE: ask for confirmation before resending all invites 2017-05-11 18:07:28 +05:30
Guo Xiang Tan
ce9fe213fd FIX: Can't quote last paragraph. 2017-05-11 16:49:46 +08:00
Arpit Jalan
8c337ecf82 FIX: allow uploading of category logo and background 2017-05-11 12:48:54 +05:30
Régis Hanol
214939bb87 freeze array constants 2017-05-11 09:08:59 +02:00
Régis Hanol
4b7be137cb don't generate errors if 'upload_id' is invalid 2017-05-11 09:07:04 +02:00
Régis Hanol
9641d2413d REFACTOR: upload workflow creation into UploadCreator 
- Automatically convert large-ish PNG/BMP to JPEG
- Updated fast_image to latest version
 2017-05-11 00:16:57 +02:00
Sam
a5c4ddd334 oops my linter is not running automatically 2017-05-10 16:09:33 -04:00
Sam
2e13c2453b FIX: maximize css editor not working 2017-05-10 15:47:11 -04:00
Sam
04b5516bf2 improve upload functionality 2017-05-10 15:47:11 -04:00
Sam
bc0b9af576 FEATURE: support uploads for themes 
This allows themes to bundle various assets
 2017-05-10 15:47:11 -04:00
Sam
f709899a1d Allow theme field object model to support uploads 2017-05-10 15:46:42 -04:00
OsamaSayegh
26209354e3 Don't hardcode code button index and remove the for loop and use .some() 2017-05-10 14:53:54 -04:00
osamasayegh
2f8b1e33f4 FEATURE: bulk relist 2017-05-10 14:53:54 -04:00
Robin Ward
f7e8bc6216 UX: Tweak explanations for multiple_grant and allow_title 2017-05-10 14:39:23 -04:00
Robin Ward
4db76796b9 FEATURE: Setting to poll feeds more frequently 2017-05-10 14:30:12 -04:00
Neil Lalonde
5be7a2dad4 FIX: invalid html in notification emails when template has been customized 2017-05-10 14:01:26 -04:00
Guo Xiang Tan
41fb76cc66 Don't rescue all errors. 2017-05-10 09:12:44 +08:00
Robin Ward
907f6cd76b FIX: Select2 retina icons were broken 2017-05-09 15:51:39 -04:00
Robin Ward
a1baf73956 FIX: Better error message for when your bookmark rate limit is exceeded 2017-05-09 15:42:55 -04:00
Robin Ward
ae15b10cf8 FIX: The keyboard shortcut to bookmark the first post wasn't refreshing 2017-05-09 15:37:36 -04:00
Robin Ward
6e4ba8a33e Catch RSS Parsing errors 2017-05-09 15:07:06 -04:00
Robin Ward
c2bf525a06 Make CloseTopic a no-op just in case 2017-05-09 15:02:05 -04:00
Robin Ward
24e1892d28 Silence logs for OptimizedImage failures 2017-05-09 14:59:46 -04:00
Robin Ward
ba1868b051 FIX: There are still jobs enqueued for CloseTopic 2017-05-09 14:58:37 -04:00
Robin Ward
da92f35e08 Don't log a gravatar failure that is a socket error 2017-05-09 14:44:53 -04:00
Robin Ward
bcf1a9d43f We don't need to log when we can't download a Gravatar 2017-05-09 14:43:39 -04:00
Robin Ward
6fdbd29882 FIX: Dismiss all button was not updating the UI 2017-05-09 13:46:26 -04:00
Arpit Jalan
e6e0025326 FIX: handle BOM in bulk import CSV file 2017-05-09 22:38:07 +05:30
Sam Saffron
c2829dce22 FIX: base sql vanishes after badge creation 2017-05-09 09:25:57 -04:00
Arpit Jalan
94683b33b8 FIX: sanitize bulk invite error log 2017-05-09 17:41:59 +05:30
Robin Ward
afe04b8bbb FIX: Possible 500 error if category saved incorrectly 2017-05-08 15:17:58 -04:00
Robin Ward
4f6e5fed2a We don't need to raise an error when no post is present. Just noop. 2017-05-08 15:08:29 -04:00
Robin Ward
7a0501c0c0 UX: Wrap really long titles on user stream pages 2017-05-08 14:45:34 -04:00
Robin Ward
96c59c5b82 FIX: Don't notify or return flags on system users 2017-05-08 13:13:35 -04:00
Sam
a7471fe85f FIX: page scroll lock not clearing properly on chrome 
For some reason Chrome renamed "mousewheel" to "wheel"
 2017-05-08 09:50:07 -04:00
Sam
257c0dea70 Merge pull request #4852 from tgxworld/pull_the_plug_on_daily_mailing_list 
Remove daily mailing mode option as it doesn't scale.
 2017-05-08 09:10:46 -04:00
Arpit Jalan
e89d0a6b20 FIX: importing a theme via file was broken 2017-05-08 12:03:24 +05:30
Jeff Atwood
cfb30bca80 UX: simplify delete gap style 2017-05-05 17:06:13 -07:00
Jeff Atwood
27e52bc66d user page stats too "buttony" 2017-05-05 15:36:13 -07:00
Neil Lalonde
b7322b05a0 FIX: some changes in composer affect all visible text editors 2017-05-05 12:59:45 -04:00
Neil Lalonde
3edea3d226 automatically unpin topics setting doesn't need its own section 2017-05-05 10:25:02 -04:00
Régis Hanol
8bc47d0bae fix build (cc @tgxworld) 2017-05-05 13:13:49 +02:00
Guo Xiang Tan
e61959e6a8 FIX: CustomEmoji may contain an invalid upload_id. 
https://meta.discourse.org/t/white-screen-after-deleting-custom-emoji/61608
 2017-05-05 14:53:38 +08:00
Guo Xiang Tan
2b21e5ea7e UX: Display translated group name for automatic groups. 2017-05-05 14:34:47 +08:00
Guo Xiang Tan
71a266b673 Remove daily mailing mode option as it doesn't scale. 
https://meta.discourse.org/t/daily-updates-option-for-mailing-list-mode/45029/14?u=tgxworld
 2017-05-05 12:21:50 +08:00
Guo Xiang Tan
50c8ae2c10 Load user records in batches. 2017-05-05 10:57:31 +08:00
Robin Ward
777f1f0f47 FIX: Return a 404 if the auth session is not present 2017-05-04 15:35:24 -04:00
Sam Saffron
c182dcc64c FEATURE: add .admin-interface class to BODY when in admin 
removes some dead code as well
 2017-05-04 15:13:32 -04:00
Neil Lalonde
66cc4fff2c fix style of custom field labels on dropdowns and confirm 2017-05-04 14:08:15 -04:00
Sam
4ebbad991e FIX: properly clean up related color schemes on delete 2017-05-04 14:03:17 -04:00
Robin Ward
067a54f0df FIX: Regression when clicking on post date 2017-05-04 13:51:24 -04:00
Robin Ward
81326f85e5 FIX: Regression when clicking on post date 2017-05-04 13:51:02 -04:00
Neil Lalonde
c576e49230 fix blank name field 2017-05-04 13:45:16 -04:00
Robin Ward
55ca5df96b FIX: If the host can't be extracted don't raise an error 2017-05-04 13:26:37 -04:00
Robin Ward
1768c45a33 FIX: If we can't proxy to a CDN due to HTTP error, render blank 2017-05-04 12:42:46 -04:00
Robin Ward
57a2042ef6 FIX: Quiet server side errors for requesting json for account-created 2017-05-04 12:30:13 -04:00
Robin Ward
b3165f8435 FIX: If badges are disabled don't show "Top Badges" on summary view 2017-05-04 12:14:32 -04:00
Neil Lalonde
c98601129b Move name, avatar, and title fields from profile tab to account tab 2017-05-04 12:04:07 -04:00
Robin Ward
de0d13e4ef FIX: Badge filtering was always to the currentUser 2017-05-04 11:58:56 -04:00
Neil Lalonde
f4c09e9e90 fix select input widths regression in user preferences 2017-05-04 11:25:22 -04:00
Guo Xiang Tan
989d52a854 FIX: Show share popup only for valid buttons. 2017-05-04 11:20:06 -04:00
Guo Xiang Tan
790acfd99f SECURITY: XSS issue in share popup if invalid link is passed in. 2017-05-04 11:07:49 -04:00
Arpit Jalan
0bdced165a UX: change timestamp button on mobile was hidden behind date selector 2017-05-04 18:47:25 +05:30
Guo Xiang Tan
58edd203a9 SECURITY: XSS issue in share popup if invalid link is passed in. 2017-05-04 10:33:59 +08:00
Guo Xiang Tan
94c8410521 FIX: Show share popup only for valid buttons. 2017-05-04 10:31:09 +08:00
Robin Ward
b3908a1d7f FIX: The user might be anonymous 2017-05-03 18:39:02 -04:00
Robin Ward
60693240e1 FIX: Filter badges to user on their badges page too 2017-05-03 17:58:59 -04:00
Guo Xiang Tan
3eb920e2b0 Merge pull request #4841 from fantasticfears/webhook-ping 
add event name for ping webhooks in the header
 2017-05-04 04:54:40 +08:00
Neil Lalonde
7f09bc9a09 Merge pull request #4849 from discourse/prefs 
User preferences in tabs
 2017-05-03 16:53:26 -04:00
Neil Lalonde
389a0e1a1c FIX: emails should use default theme colors 2017-05-03 14:35:13 -04:00
Robin Ward
b705634ee1 FIX: If you have a badge, filter to you when clicking on it 2017-05-03 13:35:20 -04:00
Robin Ward
09cb61b533 FIX: Jumping to a post that doesn't exist should jump to closest 2017-05-03 13:24:30 -04:00
Neil Lalonde
8bcfea3b0d new outlets for plugins 2017-05-03 11:41:01 -04:00
Sam
342ef5f81a FEATURE: out-of-the-box dark/light user selectable themes 2017-05-03 11:31:33 -04:00
Robin Ward
81190f5d66 FIX: Redirect away from account-created if you're logged in 2017-05-03 11:18:01 -04:00
Robin Ward
12fb20fe1b FEATURE: Allow users to resend/update email from confirmation page 2017-05-03 11:18:01 -04:00
Robin Ward
b381372184 Use Ember.js for the /u/account-created path so we can add controls 2017-05-03 11:18:01 -04:00
Arpit Jalan
86f1cc8c92 FIX: don't apply max_emails_per_day_per_user on critical emails 2017-05-03 17:07:39 +05:30
Guo Xiang Tan
982e3d04f6 PERF: Allow memory to be freed instead of fetching all the objects into memory at once. 
```
MemoryProfiler.report do
  Jobs::UserEmail.new.execute(type: :mailing_list, user_id: user.id)
end.pretty_print
```

Before:
```
Total allocated: 180096119 bytes (1962025 objects)
Total retained:  2194 bytes (16 objects)

allocated memory by gem
-----------------------------------
  66979096  activerecord-4.2.8
  43507184  nokogiri-1.7.1
  43365188  mail-2.6.4
   5960201  activesupport-4.2.8
   5056267  discourse/lib
   4835284  rack-mini-profiler-0.10.1
   3825817  arel-6.0.4
   2186088  i18n-0.8.1
   1719330  discourse/app
```

After:
```
Total allocated: 161935975 bytes (1473940 objects)
Total retained:  2234 bytes (17 objects)

allocated memory by gem
-----------------------------------
  45430264  activerecord-4.2.8
  43568627  nokogiri-1.7.1
  43430754  mail-2.6.4
  11233878  rack-mini-profiler-0.10.1
   5260825  activesupport-4.2.8
   5054491  discourse/lib
   2186088  i18n-0.8.1
   1822494  arel-6.0.4
```
 2017-05-03 17:01:57 +08:00
Arpit Jalan
cdce060a38 FIX: don't apply max emails per day per user to forgot password 2017-05-03 14:02:37 +05:30
Neil Lalonde
2503241ce5 FEATURE: rebuild user preferences page to use tabs 2017-05-02 16:52:18 -04:00
Sam
946f25098f Refactor theme fields so they support custom theme defined vars 
This paves the way to allowing themes to specify uploads and so on.
 2017-05-02 16:02:14 -04:00
Arpit Jalan
77a8cae094 FIX: rescue specific errors on invite failure 2017-05-02 15:13:33 +05:30
Erick Guan
9f8a917d65 add event name for ping webhooks in the header 2017-05-02 08:13:23 +02:00
Guo Xiang Tan
f5b11cb429 PERF: Don't allocate extra array. 2017-05-02 11:54:23 +08:00
Robin Ward
3736b440cb FIX: Quoting an expanded first post would force it to reload the cooked 2017-05-01 15:01:35 -04:00
Neil Lalonde
0722ffadf1 Remove site settings enforce_global_nicknames and discourse_org_access_key 2017-05-01 14:53:16 -04:00
Neil Lalonde
ca224ed8e9 FIX: pending flags message should go to moderators group, not staff 2017-05-01 14:53:16 -04:00
Sam
556ef4cfbd FIX: case sensitive unconditional add of exact match in user search 2017-05-01 14:37:16 -04:00
Robin Ward
dfe1174137 FIX: The dates for retroactive anniversary badges were wrong 2017-05-01 12:06:18 -04:00
Arpit Jalan
9e9ead0954 FIX: incorrect label for top topics dropdown on mobile when filtering 2017-05-01 16:43:23 +05:30
Jeff Atwood
a4815047c0 purge scheduler_stats every 1 month instead of 3 2017-04-28 15:05:15 -07:00
Robin Ward
f05f1a24d3 Change Anniversary badge to be multiple grant, once per year 2017-04-28 14:22:54 -04:00
Neil Lalonde
bb82e0a041 FIX: theme preview from preferences wasn't working 2017-04-28 14:01:57 -04:00
Neil Lalonde
b193ae2d15 FIX: missing link in unsubscribe text of summary emails 2017-04-28 10:37:52 -04:00
Robin Ward
cb8f91ca21 FIX: Scrolling offset was broken when entering some topics 2017-04-27 16:22:25 -04:00
Robin Ward
5774a9a2c8 Revert offset calculation, was working poorly. 2017-04-27 12:20:32 -04:00
Robin Ward
a545117d2e FIX: Forgot to clear out a topic excerpt 2017-04-27 11:49:39 -04:00
Robin Ward
2efe0442bf FIX: Messed up i18n key 2017-04-27 11:45:59 -04:00
Guo Xiang Tan
304ace926e FIX: Raise right response when post_action does not exist. 2017-04-27 17:29:53 +08:00
Guo Xiang Tan
e4b9f72f9e FIX: Force the right encoding when handling email. 2017-04-27 16:51:54 +08:00
Guo Xiang Tan
7873a2efb7 Merge pull request #4843 from tgxworld/disable_post_min_length_for_pm 
FEATURE: Disable minimum post length check when in PM with non human …
 2017-04-27 16:35:19 +08:00
Guo Xiang Tan
59b906ab0d FEATURE: Disable minimum post length check when in PM with non human users. 
https://meta.discourse.org/t/discourse-narrative-bot-beta-feedback/58621/65?u=tgxworld
 2017-04-27 16:00:22 +08:00
Guo Xiang Tan
85d9342ff0 Merge pull request #4836 from tgxworld/fix_clean_up_staged_users_job 
FIX: Clean up unused staged users job not completing.
 2017-04-27 15:41:46 +08:00
Arpit Jalan
b755279cf0 remove unneeded code 2017-04-27 08:47:47 +05:30
Arpit Jalan
e3f82140d8 more readable code for filtering username/email when bulk adding to group 2017-04-27 08:43:28 +05:30
Arpit Jalan
b41d96fac1 FIX: properly initialize hashes 2017-04-27 02:56:14 +05:30
Arpit Jalan
9b0ecdaf7e Merge pull request #4839 from techAPJ/bulk-add-group 
FEATURE: provide more details when performing a bulk add to group
 2017-04-27 02:39:57 +05:30