Commit Graph

636 Commits

Author SHA1 Message Date
Régis Hanol
a06bf0b7be fix the build 2014-11-17 15:47:07 +01:00
Marcin Rataj
9dccd975d9 UX: whitelist OpenStreetMap iframes 2014-11-17 14:30:25 +01:00
Robin Ward
564e7a988c Merge pull request #2848 from riking/whitelist-api
Improve Markdown.whiteListTag, code dialect
2014-11-07 11:33:37 -05:00
Sam
d4224a64e8 correct spec 2014-10-22 15:50:04 +11:00
Robin Ward
1cf4a0d604 Rename "User Expansion" to the much clearer "User Card" 2014-10-20 12:11:59 -04:00
Sam
a0f74daf6b correct dodgy test 2014-10-18 20:16:19 +11:00
Jeff Atwood
92b615b503 reorganize site settings a bit 2014-10-19 23:14:50 -07:00
Dean Taylor
c2614543b1 Correct minor spelling mistakes
@sam highlighted I made a spelling mistake in a commit - thought I would throw a few more in.
2014-10-19 23:55:19 +01:00
Robin Ward
0cbdf6f5bb FIX: Many bugs with admin badges interface
* Editing a badge's title would show it as changed in the side even if
  you didn't hit save

* Clicking a badge would not scroll to the top

* If there was an error saving a badge there was a missing i18n key

* URLs were using queryParams instead of paths

* User `label` tags for checkboxes for larger click targets

* Saved! text would persist when viewing another badge

* After creating a new badge it would show nothing

* Validation errors were not being properly released to the client

* Query errors were surrounded by an extra array
2014-10-17 16:14:49 -04:00
Dean Taylor
b023e81078 FIX: Censored word match fail if earlier partial match
Previously a list containing `one|two|three|four|twoagain` would fail to censor the word `twoagain` in the text `test1 twoagain test2`.
2014-10-17 03:10:30 +01:00
Robin Ward
d2ac5a9ac6 Rename /category/xyz paths to /c/xyz -- @SamSaffron did most of the
work even though I'm merging the patch!
2014-10-16 12:15:31 -04:00
Robin Ward
27e68518df FIX: BBCode was trimming leading space in [code] blocks 2014-10-10 15:11:30 -04:00
Robin Ward
3b38667274 FIX: Check for word boundaries with censored words. 2014-10-09 16:35:27 -04:00
Robin Ward
285c66b899 FIX: Say the file uploaded is too large, not "image" as you can upload
other kinds of files.
2014-10-09 16:03:04 -04:00
Robin Ward
f9a8f6d6ce FEATURE: Support for a required setting on user fields. 2014-10-08 15:10:19 -04:00
Robin Ward
11b52d1334 More deprecations to allow us to work on future versions of Ember 2014-10-07 16:04:19 -04:00
riking
ef36a619c3 Update Markdown tests 2014-10-05 17:30:29 -07:00
Robin Ward
9564ecde76 FEATURE: Site setting for words to censor in posts 2014-10-02 13:58:58 -04:00
Robin Ward
edb34c178a FEATURE: Show user fields when the user is signing up 2014-09-30 10:45:18 -04:00
Sam
8371837b21 Merge pull request #2808 from gschlager/i18n_fix07
FIX: Category creation failed when translation was missing
2014-09-29 16:20:02 +10:00
Sam
1d2c7206e6 Merge pull request #2820 from Elberet/fix-url-bbcode
FIX: reworked handling URL bbcode tags
2014-09-25 09:36:55 +10:00
Robin Ward
98d21ed21f Remove deprecated Ember.Deferred 2014-09-24 14:17:29 -04:00
Jens Maier
dcd7a149e2 FIX: reworked handling URL bbcode tags 2014-09-24 20:02:02 +02:00
Robin Ward
d1d3e5dd8c Remove broken debouncePromise and clean up some deprecations 2014-09-23 16:16:44 -04:00
Arpit Jalan
b3838c2c1c Trigger browser password manager after sigining up 2014-09-24 01:04:36 +05:30
Robin Ward
537e6b193d FIX: Allow proper escaping of bold and italics markdown, even when
nested.
2014-09-22 16:52:14 -04:00
Robin Ward
914217f78a FIX: Allow BBCode images within BBCode links 2014-09-22 14:42:24 -04:00
Jens Maier
9cca64cf69 FIX: BBCode blocks parser no longer mangles JsonML arrays 2014-09-22 03:27:39 +02:00
Gerhard Schlager
a6714e252e FIX: Category creation failed when translation was missing 2014-09-20 22:06:00 +02:00
Jeff Atwood
5646ebf4c7 fix tests expecting "name said:" to "name:" 2014-09-18 20:39:27 -07:00
Jens Maier
543bc53598 FIX: double-escaped single quotes in URLs 2014-09-18 22:07:42 +02:00
Sam Saffron
33c6a2d341 correct tests 2014-09-18 15:26:45 +10:00
Robin Ward
c16b8364ab FIX: Support ember app routing to topics with only slugs 2014-09-17 11:18:59 -04:00
Sam
306d31b92e fix test 2014-09-11 11:15:49 +10:00
Jens Maier
30dbb570e5 FIX: fix dialect block ordering 2014-09-10 13:29:40 +02:00
riking
69bc552054 FEATURE: Actually show more notifications
The "Show more notifications..." link in the notifications dropdown now
links to /my/notifications, which is a historical view of all
notifications you have recieved.

Notification history is loaded in blocks of 60 at a time.

Admins can see others' notification history. (This was requested for
'debugging purposes', though that's what impersonation is for, IMO.)
2014-09-09 16:29:08 -07:00
Robin Ward
504d61de94 FIX: Clicking on expanded user actions uses user expansion. Also added
integration test.
2014-09-09 15:18:04 -04:00
Robin Ward
2f04b53c9f FIX: Clicking outside of modal wasn't closing it 2014-09-08 16:53:05 -04:00
Robin Ward
4bec839d9d Using Discourse.XYZ in templates is deprecated. This fixes that, plus
adds some more integration tests to make sure login required is working.
2014-09-05 13:09:01 -04:00
Jeff Atwood
fad0394a40 more renaming of trust level settings 2014-09-04 13:32:00 -07:00
Jeff Atwood
fcca64c0cf rename site settings for trust levels as numbers 2014-09-04 13:16:51 -07:00
Robin Ward
dac4ed5a1e Prune dead code for search keyboard navigation in search, remove bad
tests.
2014-09-03 15:05:22 -04:00
Robin Ward
40b1558f83 Merge pull request #2747 from cpradio/remove-additional-search-code
FIX: Remove additional search code related to the up/down navigation
2014-09-03 14:46:09 -04:00
Robin Ward
a71640c15f Add the integration test for search back using a fixture. 2014-09-03 13:43:26 -04:00
cpradio
44a25271f1 FIX: Remove additional search code related to the up/down navigation
Removed additional search code that was related to the up/down navigation and their related tests.
https://meta.discourse.org/t/magic-search-code-for-keyboard-shortcuts/19563
2014-09-03 06:51:52 -04:00
Sam
921dd75dd9 FIX: anonymous had <a> items for pin/unpin
FEATURE: display category in search results
FEATURE: display topic state (locked/pinned/etc) in search results

UI cleanup for search results, clearing floats and so on.
2014-09-03 12:13:26 +10:00
Jens Maier
9be5c98c8c FIX: Markdown parser: empty links and bbcode parsed as link refs 2014-08-31 02:55:43 +02:00
Arpit Jalan
289d9e4fe1 FIX: use short date format for topic summary 2014-08-30 12:07:43 +05:30
cpradio
2e200ffbf0 Merge remote-tracking branch 'origin/master' into keyboard-binding-incoming-updated-topics
Conflicts:
	config/locales/client.en.yml
2014-08-29 20:05:59 -04:00
cpradio
875b39fb5f Merge remote-tracking branch 'origin/master' into keyboard-binding-incoming-updated-topics 2014-08-29 19:56:39 -04:00
cpradio
8a8552019a Fixed qunit test assertion 2014-08-29 18:03:27 -04:00
cpradio
80cb8f3a96 Fixed qunit test assertion 2014-08-29 17:54:50 -04:00
Neil Lalonde
1291e94c78 Merge pull request #2715 from cpradio/master
UX: Add focus to menu only if it comes from a keyboard shortcut and improve keyboard functionality for search
2014-08-29 17:04:52 -04:00
cpradio
096bc0c0ae Merge branch 'keyboard-binding-new-topics-banner' into dismiss-keyboard-bindings
Conflicts:
	app/assets/javascripts/discourse/lib/keyboard_shortcuts.js
2014-08-29 09:36:34 -04:00
cpradio
723798cc30 Correct Perform Search Test 2014-08-28 23:32:56 -04:00
cpradio
185769c07b Correct Perform Search Test 2014-08-28 23:21:43 -04:00
Robin Ward
69cb5bc425 FIX: Centralize Top rendering, remove old code paths. Fix some bugs. 2014-08-28 14:34:31 -04:00
Sam
53e60030bc FIX: broken tests 2014-08-27 14:47:23 +10:00
Jens Maier
c58565d09f Fix: dialect block parser should not eat next block's whitespace 2014-08-26 14:11:23 +02:00
Jens Maier
b8f5c21df0 Workaround markdown-js links parser bug 2014-08-24 01:56:14 +02:00
Robin Ward
2ae46b4742 REMOVE: Auto quoting confused more people than it helped. 2014-08-22 14:51:31 -04:00
Robin Ward
300dbdc88b FIX: BBCode contents can span multiple lines 2014-08-22 14:32:29 -04:00
Robin Ward
104b39540a FIX: BBCode with params couldn't span lines 2014-08-22 12:14:10 -04:00
Régis Hanol
5b1785157d TRIVIAL: fix deprecations due to momentjs upgrade 2014-08-20 22:22:58 +02:00
Robin Ward
49f0eaea13 Merge pull request #2650 from Elberet/fix-parser
Fix: block parser uses regexes for stop tags, allows stricter matching
2014-08-18 11:06:08 -04:00
Robin Ward
a0d0f859ba Add login buttons to create account template. 2014-08-14 12:51:16 -04:00
Jens Maier
23002ae01c Fix: block parser now uses regexes for end tags. solves code block case, where end tag must be on a line of its own. 2014-08-14 01:58:01 +02:00
Robin Ward
0adfeb1cff ES6: Mega update of controllers 2014-08-13 10:22:47 -04:00
Robin Ward
233305e96f FIX: On devices with a weird pixel ratio, tests were failing. 2014-08-12 17:29:18 -04:00
Robin Ward
11e43bd434 FIX: Don't show Sign Up button in cases where users can't sign up 2014-08-12 16:55:23 -04:00
Robin Ward
1684ff3015 UX: Add a separate "Sign Up" button 2014-08-12 13:47:23 -04:00
Robin Ward
d1f6c31382 TESTS: Adds integration test for new about route 2014-08-12 11:15:32 -04:00
Robin Ward
37a9747f53 ES6: Convert Discourse.Resolver to ES6 2014-08-07 11:48:02 -04:00
Robin Ward
b323c86302 TESTS: Remove home logo tests, they are written in the incorrect way and
don't test much of value.
2014-08-07 11:48:02 -04:00
Robin Ward
8279752d3c REFACTOR: Don't use Discourse.Capabilities, instead use injection.
Also fix broken test. /cc @Sam
2014-08-06 18:28:02 -04:00
Robin Ward
f977843391 ES6: Convert all test files over 2014-08-06 17:51:03 -04:00
Robin Ward
417d287813 FIX: Don't link to notifications without URLs 2014-08-06 15:24:20 -04:00
Régis Hanol
3330f5907c FEATURE: restructure notification HTML layout 2014-08-05 23:36:37 +02:00
Robin Ward
d29822e4cb TWEAK: Sum new and unread in the site map category list 2014-08-05 16:01:49 -04:00
Robin Ward
3c66e48573 TESTS: Remove URL_FIXTURES constant for pretender 2014-08-01 17:27:01 -04:00
Neil Lalonde
443caaa8f7 FIX: don't let admins skip post validations, unless it's faq, tos, or privacy 2014-08-01 14:53:35 -04:00
Robin Ward
d7ad3bb2b6 TESTS: Integration tests for badge pages 2014-07-31 18:44:47 -04:00
Robin Ward
77332e8b57 TESTS: Add integration test for /top 2014-07-31 18:44:47 -04:00
Robin Ward
adea5b36a0 TESTS: Integration tests for login_required 2014-07-31 17:59:52 -04:00
Robin Ward
e63cdc50bb TESTS: Add JSON.stringify step to prepareBody where it should be. 2014-07-31 17:26:44 -04:00
Robin Ward
c30ab6d428 Return a CSRF in case it's requested 2014-07-31 17:06:16 -04:00
Robin Ward
d3cc85c784 TESTS: Use Pretender in test mode for more flexible server responses 2014-07-31 16:49:30 -04:00
Robin Ward
bf16ff275a TESTS: Sign in tests 2014-07-31 14:17:18 -04:00
Robin Ward
c5b5db48cf TESTS: Reset the preload store for testing 2014-07-31 13:25:40 -04:00
Robin Ward
c3e1dd4707 TESTS: Remove non-idiomatic tests. Too much pain to maintain or convert. 2014-07-31 13:25:40 -04:00
Robin Ward
b8bfbcb3cb ES6: Tests 2014-07-31 13:25:39 -04:00
Robin Ward
6f36d5996d Lots of work on tests 2014-07-30 20:09:45 -04:00
Robin Ward
b6684e7168 Upgrade to ember-qunit 2014-07-30 20:09:44 -04:00
Robin Ward
d29157dab9 TESTS: Refactored integration tests 2014-07-30 20:09:44 -04:00
Robin Ward
aeb0ea1f25 FIX: Broken test 2014-07-30 12:08:07 -04:00
Régis Hanol
b196de0821 TRIVIAL: use class instead of id for the 'topic-list' 2014-07-29 23:38:36 +02:00
Sam
b00b5609e6 Merge pull request #2599 from riking/disable-logster
Disable logster error reporting during tests
2014-07-29 12:29:23 +10:00
riking
f80502ea0e Disable logster error reporting during tests 2014-07-28 13:41:45 -07:00
Neil Lalonde
e1be478ef4 FIX: admins bypass some post validations. This allows them to edit legal docs even if those docs are longer than max post length, for example. 2014-07-28 16:40:14 -04:00
Robin Ward
717f57c968 Revert "FIX: You couldn't span multiple lines with bold or italics"
This reverts commit 423d37a2b6.

Conflicts:
	test/javascripts/lib/markdown_test.js
2014-07-28 13:17:39 -04:00
Robin Ward
8866141ba2 Merge pull request #2592 from Elberet/fix-parser
Fixes for quirky markdown parser behaviours
2014-07-28 13:12:22 -04:00
Sam
f7c7d38a30 FIX: broken tests 2014-07-28 12:05:27 +10:00
Jens Maier
479eb64a76 FIX: rewrite replaceBlock logic to better handle mismatched nested quotes. 2014-07-27 16:07:47 +02:00
Jens Maier
9124cf0eaf FIX: auto-quote should not trigger when the first " is preceded by bbcode-like garbage. 2014-07-27 16:05:29 +02:00
riking
5841e10b59 Extra test for spanning italics 2014-07-25 13:15:14 -07:00
Robin Ward
423d37a2b6 FIX: You couldn't span multiple lines with bold or italics 2014-07-25 16:08:00 -04:00
Robin Ward
b2f2e7b1d2 REFACTOR: Move Markdown tests to Javascript land 2014-07-25 16:08:00 -04:00
Joshua Gorner
e242368266 Convert admin section controllers to ES6 modules 2014-07-25 14:17:58 -04:00
Robin Ward
f3bb8902c1 Make a mocked test that broke pending for now. The logic works, will
replace with a new test later.
2014-07-24 15:14:36 -04:00
Jens Maier
b19ad15086 FIX: improve list bbcodes: ignore newlines resulting in unnecessary blank lines 2014-07-24 19:39:16 +02:00
Jens Maier
79dc68512f FIX: dialects accept nested inline markup 2014-07-24 17:34:13 +02:00
Sam
ec03d135fa FEATURE: allow advanced badge options in admin screen
clean up serializer, allow simplistic preview
2014-07-24 18:28:23 +10:00
Robin Ward
0a0d32efb4 TRIVIAL: Rename map to idMap because map means something for
enumerables.
2014-07-23 11:11:13 -04:00
Peter Le Bek
f63e6e6dab Optimize Category find-by-id by using a hash. 2014-07-22 23:49:49 -04:00
Robin Ward
7c0e723464 TWEAK: If show_subcategory_list is enabled, hide subcategories from
the site map.
2014-07-22 16:27:33 -04:00
Robin Ward
4c51258526 PERF: Speed up JSHint tests by using local buffers instead of AJAX
requests.
2014-07-22 14:13:37 -04:00
Neil Lalonde
386b6213a5 FEATURE: warn when caps lock is on during password input 2014-07-22 13:53:58 -04:00
Robin Ward
d9e5c2317f FIX: If a topic title edit fails, revert to previous title. 2014-07-21 13:39:23 -04:00
Régis Hanol
7ebfe86100 TEST: allows data images 2014-07-18 20:38:01 +02:00
Robin Ward
75f6b43e62 ES6: Discourse.ContainerView 2014-07-18 12:20:07 -04:00
riking
de3633235b Add JS tests for deleted post hiding (fix the build) 2014-07-17 11:13:42 -07:00
Sam
fecb9ddb43 FIX: invalid test 2014-07-17 16:11:10 +10:00
Robin Ward
d6589d4c53 FIX: Cooking issue with paragraphs in a list 2014-07-15 16:42:14 -04:00
Régis Hanol
a9342dbf92 SECURITY: fix XSS in link's href 2014-07-15 16:11:37 +02:00
Robin Ward
1886ffaff2 FIX: Work with phpBB import style links with ellipsis 2014-07-14 14:27:17 -04:00
Robin Ward
186ce78cb5 FIX: BBCode sanitization and tests 2014-07-14 11:24:25 -04:00
Neil Lalonde
e565ae2528 FEATURE: /guidelines route will always show our FAQ, ignoring the faq_url site setting 2014-07-10 12:58:41 -04:00
Régis Hanol
6b45b635f8 FIX: properly whitelist <code> classes needed for syntax highlighting 2014-07-09 16:27:47 +02:00
Robin Ward
7ab98bb0e7 FIX: Missing formatting for oneboxes in preview 2014-07-04 14:15:07 -04:00
Robin Ward
fc1ce96dbb FIX: Change the approach to sanitization. Includes a more detailed API
for allowing classes and attributes for only certain tag names.
2014-07-03 16:55:36 -04:00
Robin Ward
9c48f8f154 FIX: Don't surround <aside> with <p> as that is malformed HTML. 2014-06-30 18:11:22 -04:00
Robin Ward
a7ad7f6a45 Remove some obscure HTML tags from sanitization 2014-06-24 11:03:45 -04:00
Robin Ward
ff55a30dd7 FIX: <pre> blocks were adding too many new lines. 2014-06-23 15:21:07 -04:00
Robin Ward
42d1fcbbc2 [code] should work just like other kinda of code formatting. 2014-06-23 13:19:27 -04:00
Arpit Jalan
7e946a718e Make bookmarks menu appear all the time 2014-06-23 10:21:33 +05:30
Robin Ward
9d82111813 TRIVIAL: Remove some output from qunit test suite. 2014-06-19 16:00:01 -04:00
Sam
806ddb4ccb FEATURE: Quote reply at cursor 2014-06-18 15:17:55 +10:00
Sam
a288ff331d BUGFIX/FEATURE: call out context for search. 2014-06-17 17:53:45 +10:00
Jeff Atwood
5db621c5fe normalize to search.title for search help 2014-06-16 16:20:57 -07:00
Jeff Atwood
6ceebc3f1c Merge pull request #2435 from techAPJ/add-bookmark-menu
FEATURE: Add Bookmarks menu to user dropdown
2014-06-12 03:28:40 -07:00
Sam
8ff4536a08 BUGFIX: fragile test corrected, stubbing is not needed here. 2014-06-12 10:59:07 +10:00
Arpit Jalan
aed2483bb9 FEATURE: User Bookmarks Menu 2014-06-12 01:54:54 +05:30
Robin Ward
176120cbc1 REFACTOR: Keyboard Shortcuts should send their actions directly to
posts, not by activating clicks on buttons.
2014-06-11 14:31:03 -04:00
Robin Ward
580a1bf8b0 ES6: Migrated and deprecated a bunch of views 2014-06-10 11:54:38 -04:00
Neil Lalonde
56cd60f226 FIX: there are site settings for username min and max lengths. Neat. 2014-06-09 18:26:42 -04:00
Robin Ward
c6b92f0ef7 FIX: Support for nested bold/italics in MD 2014-06-09 17:46:36 -04:00
Neil Lalonde
78d46a81e1 FIX: js needs to use same max username length as server 2014-06-09 15:28:03 -04:00
Robin Ward
a63ac64931 FIX: Obscure emoji fail with a colon surrounded by spaces 2014-06-09 14:44:34 -04:00
Robin Ward
7adb545168 ES6: Convert {{pagedown}} to {{pagedown-editor}} with deprecations 2014-06-09 12:16:27 -04:00
Robin Ward
1df3214773 ES6: Convert header view 2014-06-09 11:34:38 -04:00