Andrei Prigorshnev
52d4de7b45
DEV: fix a linting issue ( #20453 )
2023-02-26 01:52:19 +04:00
TheJammiestDodger
9c669f3bdc
Fix typo ( #20452 )
...
Remove extraneous `>` from Views section
2023-02-25 11:50:39 +00:00
tshenry
720cf7c424
DEV: Add classes to user profile's collapsed-info-panel ( #20451 )
...
Some of the dt and dd elements already included classes (e.g. invited-by and groups). This simply makes things consistent by adding classes to the other dt and dd elements and should allow for easier customization.
2023-02-24 15:37:38 -08:00
Kris
90ed30b3ff
UX: fix tag & category clicks on mobile topic list ( #20449 )
2023-02-24 15:29:57 -05:00
Kris
d3983d94a3
UX: only allow scroll grab if nav is scrollable ( #20447 )
2023-02-24 14:25:38 -05:00
Jarek Radosz
5a384e60ac
DEV: Clean up showModal() calls ( #20442 )
2023-02-24 15:53:04 +01:00
Jarek Radosz
d5cf128dbd
DEV: Fix an error in topic deletion ( #20440 )
...
Spotted as log entry in tests:
```
TypeError: Cannot read properties of undefined (reading 'force_destroy')
```
2023-02-24 13:48:08 +01:00
Jarek Radosz
04659b0e41
DEV: Fix decorator deprecations ( #20438 )
...
…and correctly fix the decorateCookedElement id arg
2023-02-24 10:50:52 +01:00
David Taylor
1dca7b8b0a
FIX: Correct issues in admin-embeddable-host ( #20439 )
...
Classic Component arguments are not available in the constructor. Switch back to using `init()` for this component
Followup to a433b30650
2023-02-24 09:44:50 +00:00
David Taylor
4cadad9a53
FIX: Correct issues in admin-styles-editor ( #20435 ) ( #20437 )
...
The save action clashed with the save component argument
Followup to a433b30650
2023-02-24 09:34:56 +00:00
dependabot[bot]
ba5e0924db
Build(deps): Bump terser in /app/assets/javascripts ( #20434 )
...
Bumps [terser](https://github.com/terser/terser ) from 5.16.4 to 5.16.5.
- [Release notes](https://github.com/terser/terser/releases )
- [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md )
- [Commits](https://github.com/terser/terser/compare/v5.16.4...v5.16.5 )
---
updated-dependencies:
- dependency-name: terser
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-02-24 10:13:43 +01:00
dependabot[bot]
f9150bc701
Build(deps): Bump @babel/standalone in /app/assets/javascripts ( #20433 )
...
Bumps [@babel/standalone](https://github.com/babel/babel/tree/HEAD/packages/babel-standalone ) from 7.21.1 to 7.21.2.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.21.2/packages/babel-standalone )
---
updated-dependencies:
- dependency-name: "@babel/standalone"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-02-24 10:13:29 +01:00
Krzysztof Kotlarek
9fb5bfd93d
FIX: use category description for sidebar link title ( #20436 )
...
Value in `description_text` is escaped. We would like to display `/` properly in link title.
2023-02-24 16:11:45 +11:00
David Taylor
ad0fd9919b
FIX: Correct issues in admin-theme-editor ( #20435 )
...
Followup to a433b30650
2023-02-23 23:03:27 +00:00
Penar Musaraj
c052df412a
DEV: Add support for aliases in HighlightJS languages ( #20380 )
...
We were only supporting the main name of each HighlightJS language. So, by default, you could not use `js` or `jsx` to highlight Javascript, given they are aliases for `javascript`.
This PR adds a list of aliases as a constant to core (built via a rake task), and then checks against the `highlighted_languages` site settings plus the list of aliases when processing a code block.
2023-02-23 15:06:06 -05:00
Keegan George
6108eee31d
DEV: Apply form template to categories ( #20337 )
2023-02-23 11:18:14 -08:00
Loïc Guitaut
a9f2c6db64
SECURITY: Show only visible tags in metadata
...
Currently, the topic metadata show both public and private
tags whereas only visible ones should be exposed.
2023-02-23 17:22:20 +01:00
Blake Erickson
5dbdcb3f23
FEATURE: Adding some more api scopes ( #20420 )
...
Adds api scopes for
- deleting a topic
- deleting a post
- listing tags
2023-02-23 08:33:29 -07:00
David Taylor
a433b30650
DEV: Convert admin component definitions to native class syntax ( #20311 )
...
This conversion was achieved using the ember-native-class-codemod, plus a handful of manual fixes/tweaks
2023-02-23 15:32:53 +00:00
Bianca Nenciu
a0ca10fa17
FIX: Make sure regular users can delete their PMs ( #20424 )
...
Regular users should be redirected to the homepage after the topic is
no longer accessible by them (only staff members can view deleted
topics). There was a problem with permission checking for category
moderators which stopped the redirect from happening.
2023-02-23 16:39:51 +02:00
Alan Guo Xiang Tan
925a7bd48b
DEV: Port sidebar mobile view acceptance tests to system tests ( #20421 )
...
The acceptance tests are flaky so I've decided to port them to system
test which makes them easier to work with and reason about.
2023-02-23 15:01:39 +08:00
carsick
da43b60510
Update period-title.js ( #20422 )
...
(A petty but important typography fix)
Use en dash (–) instead of hyphen (-) for ranges (including dates)
For example — 1–2, May–June, 1:00pm–2:00pm
A space in before and after the dash is usually not present in writing but for user interfaces can be stylistic choice. (The space is left unchanged here.)
References
- https://learn.microsoft.com/en-us/style-guide/punctuation/dashes-hyphens/enes
- https://www.thepunctuationguide.com/en-dash.html
2023-02-23 15:00:41 +08:00
David Battersby
0a619d8c88
FIX: Fast edit doesn’t work on content with certain characters ( #20410 )
...
Small js fix for fast edit to allow posts to save changes when the post contains apostrophes and quotation marks. Replaces unicode characters in text prior to saving the edit.
Includes system tests for fast edit and introduces a new system spec component for fast edit usage.
2023-02-23 11:30:16 +08:00
Alan Guo Xiang Tan
576745637e
DEV: Remove redesigned_user_page_nav_enabled property ( #20409 )
...
This commit removes all references to the
`redesigned_user_page_nav_enabled` which was used as a feature flag for
developing the new user profile navigation menu previously.
2023-02-23 10:35:02 +08:00
chapoi
ab46a05d77
UX: User badges tweaks ( #20408 )
...
* UX: fix standalone badge padding
* UX: badge number formatting
* UX: copy
* DEV: Add LinkTo for the admin-badges/show count text
* UX: user badge awarded style update
---------
Co-authored-by: Martin Brennan <martin@discourse.org>
2023-02-23 03:21:26 +01:00
dependabot[bot]
64d1192bff
Build(deps): Bump ember-auto-import in /app/assets/javascripts ( #20419 )
...
Bumps [ember-auto-import](https://github.com/ef4/ember-auto-import/tree/HEAD/packages/ember-auto-import ) from 2.6.0 to 2.6.1.
- [Release notes](https://github.com/ef4/ember-auto-import/releases )
- [Changelog](https://github.com/ef4/ember-auto-import/blob/main/packages/ember-auto-import/CHANGELOG.md )
- [Commits](https://github.com/ef4/ember-auto-import/commits/v2.6.1/packages/ember-auto-import )
---
updated-dependencies:
- dependency-name: ember-auto-import
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-02-22 23:38:32 +01:00
Isaac Janzen
f03186dc79
DEV: Rename glimmer-topic-timeline -> topic-timeline ( #20395 )
2023-02-22 15:55:23 -06:00
Blake Erickson
51a7cd899e
FEATURE: Add API scopes for group endpoints ( #20401 )
...
Added two new api scopes for managing and administering groups.
See https://meta.discourse.org/t/249710
2023-02-22 09:06:49 -07:00
David Taylor
8d2fa1c184
DEV: Add native class shims for on/observes decorators
2023-02-22 09:32:48 +00:00
David Taylor
89c6296638
DEV: Introduce ember-decorators addon
...
This provides Classic Component decorators for use with native class syntax (e.g. `@tagName`), and also provides native-class-compatible decorators for `@on` and `@observes`.
2023-02-22 09:32:48 +00:00
David Taylor
e9ef4900ca
DEV: Correct test waiter for requestAnimationFrame ( #20413 )
...
Followup to 207c0dd88c
2023-02-22 09:29:49 +00:00
David Taylor
cf0c73d1b7
DEV: Silence discourse.custom_html_template in its own test ( #20414 )
2023-02-22 09:29:36 +00:00
Alan Guo Xiang Tan
64cf7e444b
DEV: Remove use of deprecated prop from user notifications templates ( #20404 )
...
The redesigned_user_page_nav_enabled property has been deprecated and will be dropped from Discourse core soon.
2023-02-22 13:56:08 +08:00
Alan Guo Xiang Tan
2fc2d7d828
DEV: Remove use of deprecated prop from user preferences templates ( #20403 )
...
The `redesigned_user_page_nav_enabled` property has been deprecated and will be dropped from Discourse core soon.
2023-02-22 13:23:56 +08:00
Martin Brennan
a3712781e1
FIX: Text selection breaking with hashtag SVG in Firefox ( #20406 )
...
The new hashtags render with an `<svg>` element inside a `<a>`
tag, which is an icon to indicate the "type" of the hashtag.
In Firefox, this was disrupting both triple-click text selection
and simple dragging cursor text selection. The selection would
stop at the SVG rather than continuing past it. This works fine
in Chrome -- either Chrome is not doing the right thing or Firefox
is.
Either way the issue is fixed by simply making the `svg` an inline
element inside the link, which it should be anyway.
2023-02-22 13:56:08 +10:00
Alan Guo Xiang Tan
dc9af48942
DEV: Remove use of redesigned_user_page_nav_enabled prop client side 2 ( #20388 )
...
The property has been deprecated and will be dropped from Discourse core
soon.
2023-02-22 08:13:07 +08:00
Keegan George
c43cb0c571
DEV: Apply optimistic update pattern to badge toggle ( #20399 )
2023-02-21 15:27:59 -08:00
Alan Guo Xiang Tan
c11fd4fdf9
FIX: Override navigation menu to "legacy" via query param not working ( #20402 )
...
When the `navigation_menu` site setting has been set to `sidebar` or
`header dropdown`, overriding the site setting via the `navigation_menu`
query params did not work.
Follow-up to c47015b861
2023-02-22 06:43:14 +08:00
Krzysztof Kotlarek
b9d037770c
DEV: configurable public sidebar sections ( #20303 )
...
Extension of https://github.com/discourse/discourse/pull/20057
Admin can create a public session visible to everyone. An additional checkbox is displayed for staff members.
2023-02-22 08:55:44 +11:00
dependabot[bot]
e3ee81aa3c
Build(deps): Bump @babel/standalone in /app/assets/javascripts ( #20398 )
2023-02-21 20:59:02 +01:00
Daniel Waterworth
b96a23978a
PERF: Add index to speed up ReindexSearch job ( #20151 )
2023-02-21 13:16:43 -05:00
dependabot[bot]
692e843832
Build(deps): Bump @babel/core in /app/assets/javascripts ( #20381 )
...
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core ) from 7.20.12 to 7.21.0.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.21.0/packages/babel-core )
---
updated-dependencies:
- dependency-name: "@babel/core"
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-02-21 19:13:50 +01:00
David Taylor
207c0dd88c
DEV: Resolve flaky test caused by requestAnimationFrame use ( #20396 )
...
We need to register a waiter so that any calls to `await settled()` will wait for the `requestAnimationFrame` call to return. Wrapping in `DEBUG` as well as `isTesting()` means that this extra logic will be totally optimized out of production builds.
2023-02-21 18:02:04 +00:00
David Taylor
235edfd07b
UX: Restore wider search dropdown width ( #20391 )
...
Followup to c82094cd9d
2023-02-21 15:40:22 +00:00
Isaac Janzen
64975a6ecb
DEV: Remove deprecated topic timeline ( #20314 )
...
Continuing from https://github.com/discourse/discourse/pull/20313
- Drop deprecated topic timeline widget / component logic
2023-02-21 08:23:40 -06:00
David Taylor
c82094cd9d
PERF: Refactor slide-in menu sizing for improved performance ( #20377 )
...
Using Javascript to read and recalculate sizing is prone to causing 'forced reflows', which are very expensive, especially on slower devices. This PR refactors the slide-in menus so that all of the height calculation is done using CSS. This is made possible by the new dvh (dynamic view height) units and env(safe-area-inset-bottom), both of which are supported on all of our target browsers.
In tests on a moto g50, on a sidebar with 16 categories, 15 tags, and 2 chat channels, this improves the sidebar opening time by around 50ms (6%).
2023-02-21 13:55:38 +00:00
Loïc Guitaut
f7c57fbc19
DEV: Enable unless cops
...
We discussed the use of `unless` internally and decided to enforce
available rules from rubocop to restrict its most problematic uses.
2023-02-21 10:30:48 +01:00
chapoi
87de3c2319
UX: highlight vars updates ( #20346 )
...
* UX: replace highlight vars in popup menu
* UX: replace highlight vars in autcomplete
* UX: replace highlight vars in menu-panel
* UX: update style guide
* UX: bulk replace highlight vars in various small appearances
2023-02-21 10:15:49 +01:00
Alan Guo Xiang Tan
452539bf5b
DEV: Remove use of redesigned_user_page_nav_enabled prop client side ( #20387 )
...
Since 359dc1c532
2023-02-21 14:09:48 +08:00
Alan Guo Xiang Tan
c1486790d6
DEV: Remove old user profile navigation menu tests ( #20386 )
...
Since 359dc1c532
2023-02-21 14:03:40 +08:00
