github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-30 14:05:37 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
44,578 Commits 214 Branches 500 Tags 960 MiB
5599f0c93e
Commit Graph

44578 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
David Taylor
839639326c
DEV: Install the @ember/jquery package to remove warning (#16165) 
Eventually we want to remove JQuery, but that's a long way off. Installing this package will stop ember-cli printing the deprecation warning on every boot

```
DEPRECATION: The integration of jQuery into Ember has been deprecated and will be removed with Ember 4.0. You can either opt-out of using jQuery, or install the `@ember/jquery` addon to provide the jQuery integration. Please consult the deprecation guide for further details: https://emberjs.com/deprecations/v3.x#toc_jquery-apis
```
 2022-03-14 10:25:52 +00:00
dependabot[bot]
989144c87e
Build(deps): Bump excon from 0.91.0 to 0.92.0 (#16174) 
Bumps [excon](https://github.com/excon/excon) from 0.91.0 to 0.92.0.
- [Release notes](https://github.com/excon/excon/releases)
- [Changelog](https://github.com/excon/excon/blob/master/changelog.txt)
- [Commits](https://github.com/excon/excon/compare/v0.91.0...v0.92.0)

---
updated-dependencies:
- dependency-name: excon
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2022-03-13 23:00:14 +01:00
dependabot[bot]
ca8eb41b1b
Build(deps): Bump logster from 2.10.1 to 2.11.0 (#16173) 
Bumps [logster](https://github.com/discourse/logster) from 2.10.1 to 2.11.0.
- [Release notes](https://github.com/discourse/logster/releases)
- [Changelog](https://github.com/discourse/logster/blob/main/CHANGELOG.md)
- [Commits](https://github.com/discourse/logster/compare/v2.10.1...v2.11.0)

---
updated-dependencies:
- dependency-name: logster
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2022-03-13 22:21:31 +01:00
dependabot[bot]
e5ff21855a
Build(deps): Bump unf_ext from 0.0.8 to 0.0.8.1 (#16172) 
Bumps [unf_ext](https://github.com/knu/ruby-unf_ext) from 0.0.8 to 0.0.8.1.
- [Release notes](https://github.com/knu/ruby-unf_ext/releases)
- [Changelog](https://github.com/knu/ruby-unf_ext/blob/master/CHANGELOG.md)
- [Commits](https://github.com/knu/ruby-unf_ext/compare/v0.0.8...v0.0.8.1)

---
updated-dependencies:
- dependency-name: unf_ext
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2022-03-13 22:21:16 +01:00
Jarek Radosz
44f7a61c2c
UX: Tweak the "new" badge size, position, color (#16168) 2022-03-13 12:50:06 +01:00
Jarek Radosz
47319ad9b2
DEV: Bump chrome-launcher/chrome-remote-interface (#16160) 2022-03-12 19:52:07 +01:00
Osama Sayegh
ddde94f925
FIX: return nil when RetrieveTitle.crawl fails (#16167) 2022-03-11 23:53:10 +03:00
Blake Erickson
02fa04e333
FIX: Update topic route id param (#16166) 
This update topic route has never worked. Better late than never. I am
in favor of using non-slug urls when using the api so I do think we
should fix this route.

Just thought I would update the `:id` param to `:topic_id` here in the
routes file instead of updating the controller to handle both params.

Added a spec to test this route.

Also added the same constraint we have on other topic routes to ensure
we only pass in an ID that is a digit.
 2022-03-11 11:01:08 -07:00
Jarek Radosz
4dc5500fa6
UX: Allow d-editor to be shrunk (#16164) 
…e.g. when resizing the composer. Previously it wouldn't go below a certain size and would overlap the element below it.
 2022-03-11 18:18:27 +01:00
Bianca Nenciu
7a416257df
FIX: Invalidate site settings cache in all instances (#16155) 
Previous cache implementation did not support multisite instances and
the cache was invalidated only in the instance where the change took
place.
 2022-03-11 17:16:56 +02:00
Penar Musaraj
94750c81fa
FIX: Update group inbox notifications on archive/unarchive (#16152) 2022-03-11 11:57:47 +01:00
Osama Sayegh
b0656f3ed0
FIX: Apply onebox blocked domain checks on every redirect (#16150) 
The `blocked onebox domains` setting lets site owners change what sites
are allowed to be oneboxed. When a link is entered into a post,
Discourse checks the domain of the link against that setting and blocks
the onebox if the domain is blocked. But if there's a chain of
redirects, then only the final destination website is checked against
the site setting.

This commit amends that behavior so that every website in the redirect
chain is checked against the site setting, and if anything is blocked
the original link doesn't onebox at all in the post. The
`Discourse-No-Onebox` header is also checked in every response and the
onebox is blocked if the header is set to "1".

Additionally, Discourse will now include the `Discourse-No-Onebox`
header with every response if the site requires login to access content.
This is done to signal to a Discourse instance that it shouldn't attempt
to onebox other Discourse instances if they're login-only. Non-Discourse
websites can also use include that header if they don't wish to have
Discourse onebox their content.

Internal ticket: t59305.
 2022-03-11 09:18:12 +03:00
maiki
8e010aecfb
Remove a few words for clarity (#16162) 
Remove extra words from two descriptions for user like reports
 2022-03-11 09:33:16 +08:00
dependabot[bot]
799f35a49d
Build(deps): Bump pg from 1.3.3 to 1.3.4 (#16161) 
Bumps [pg](https://github.com/ged/ruby-pg) from 1.3.3 to 1.3.4.
- [Release notes](https://github.com/ged/ruby-pg/releases)
- [Changelog](https://github.com/ged/ruby-pg/blob/master/History.rdoc)
- [Commits](https://github.com/ged/ruby-pg/compare/v1.3.3...v1.3.4)

---
updated-dependencies:
- dependency-name: pg
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2022-03-10 22:32:17 +01:00
Jarek Radosz
b0702337df
DEV: Fix rake qunit logging (#16159) 
It was logging just the first passed object, which resulted printing out empty lines instead of actual messages (e.g. deprecation warnings)
 2022-03-10 20:43:17 +01:00
Penar Musaraj
3a817d2377
FIX: Buggy jump-to-post on Firefox (#16153) 2022-03-10 20:39:39 +01:00
Osama Sayegh
8d96761a4f
FIX: Include engine mount path for API scopes added by plugins (#16154) 
In the API keys page where admins can create API keys with restricted scopes, each scope shows a list of URLs that it allows. But currently, this list of allowed URLs shows incomplete URLs for scopes that are added by plugins. For example, the allowed URL for the "run queries" scope of the data-explorer plugin is shown as `/queries/:id/run` when the correct URL for this scope is `/admin/plugins/explorer/queries/:id/run`. The first 3 segments of the path are the mount path of the plugin's engine and it's missing because the routes set of the engine doesn't include the mount path. To fix this, this commit gets the mount path and prepends it to the URL so the complete URL is shown to the user.

It's not possible to write tests for this change because plugins are not loaded in the test environment by default when core's tests suite is running.
 2022-03-10 22:01:22 +03:00
Discourse Translator Bot
93407005b5
Update translations (#16132) 2022-03-10 16:51:47 +01:00
David Taylor
8a69de7964
DEV: Enable Ember CLI tests in GitHub Actions for official plugins (#16148) 2022-03-10 12:36:58 +00:00
Osama Sayegh
9b5cc1424f
DEV: Don't mutate Excon.defaults[:middlewares] (#16151) 
`Excon.defaults` and its middlewares array are constants that we
shouldn't mutate everytime `FinalDestination#resolve` is called.
 2022-03-10 14:21:45 +03:00
dependabot[bot]
892f7e0506
Build(deps): Bump rubocop from 1.25.1 to 1.26.0 (#16149) 
Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.25.1 to 1.26.0.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop/compare/v1.25.1...v1.26.0)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: indirect
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2022-03-09 23:39:41 +01:00
Jarek Radosz
99b2cfe26e
DEV: Disallow Ember global usage (#16147) 
…and sprinkle `// eslint-disable-next-line no-undef` throughout the code where is unavoidable for now
 2022-03-09 17:54:07 +01:00
Jarek Radosz
2ba602708a
DEV: A manual test waiter might not be needed (#16142) 2022-03-09 15:38:10 +01:00
Jarek Radosz
fbef828ab2
DEV: Remove "empty" template code (#16140) 
Its only use seems to have been removed back in 2016 in a9ed15e11a.
 2022-03-09 13:57:39 +01:00
Sam
43da88db6c
PERF: avoid following links in topic RSS feeds (#16145) 
Topic RSS feeds contain many non canonical links such as:

- https://site.com/t/a-b-c/111/1
- https://site.com/t/a-b-c/111/2
- https://site.com/t/a-b-c/111/3
- https://site.com/t/a-b-c/111/4
- https://site.com/t/a-b-c/111/5
- https://site.com/t/a-b-c/111/6

Previously we were not indexing RSS feeds yet still following these
links.


This change means we totally ignore links in the RSS feeds which
avoids expensive work scanning them just to find we should not
include them.
 2022-03-09 18:25:20 +11:00
Ayke Halder
28bb9e11f4
FEATURE: add nofollow to RSS alternate link in topics and categories (#16013) 
* FEATURE: add nofollow to RSS alternate link in topics and categories

* Rspec tests for category and topic view: add nofollow to RSS alternate link
 2022-03-09 16:34:02 +11:00
Martin Brennan
ca93e5e68b
FIX: Allow admins to change user ignore list (#16129) 
Previously, if an admin user tried to add/remove
users to another user's ignored list, it would
be added to their own ignore list because the
controller used current_user. Now for admins only
a source_user_id parameter can be passed through,
which will be used to ignore the target user for
that source user.
 2022-03-09 14:51:30 +10:00
dependabot[bot]
efd8bb9008
Build(deps): Bump redis-namespace from 1.8.1 to 1.8.2 (#16126) 
Bumps [redis-namespace](https://github.com/resque/redis-namespace) from 1.8.1 to 1.8.2.
- [Release notes](https://github.com/resque/redis-namespace/releases)
- [Changelog](https://github.com/resque/redis-namespace/blob/master/CHANGELOG.md)
- [Commits](https://github.com/resque/redis-namespace/compare/v1.8.1...v1.8.2)

---
updated-dependencies:
- dependency-name: redis-namespace
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2022-03-09 10:11:12 +08:00
Alan Guo Xiang Tan
01c5f9337a
DEV: Upgrade Rails to 6.1.4.7. (#16143) 
There was a security release in 6.1.4.6 to fix: https://github.com/rails/rails/security/advisories/GHSA-wh98-p28r-vrc9

It doesn't affect us as Discourse doesn't use thread local variables
but we should still upgrade as a matter of caution.
 2022-03-09 10:10:51 +08:00
Joshua Rosenfeld
a29b133d33
DEV: Update security policy (#16144) 
Add note regarding low quality reports being received via email.
 2022-03-09 10:02:20 +08:00
Jarek Radosz
9892844507
DEV: Fix a flaky validation message (#16141) 
The order of tags in the validation error message could be random, which we don't really care about, but it made the specs flake out once in a while.

The flaky specs were:

```
spec/lib/discourse_tagging_spec.rb:511
spec/lib/discourse_tagging_spec.rb:519
```
 2022-03-09 09:38:05 +08:00
David Taylor
3ad9c2cdb6
FEATURE: Add mobile support for subcategories-with-featured-topics (#16118) 
Follow-up to eb2e3b510d
 2022-03-08 22:06:27 +00:00
dependabot[bot]
5335b40a87
Build(deps): Bump bootsnap from 1.10.3 to 1.11.1 (#16139) 
Bumps [bootsnap](https://github.com/Shopify/bootsnap) from 1.10.3 to 1.11.1.
- [Release notes](https://github.com/Shopify/bootsnap/releases)
- [Changelog](https://github.com/Shopify/bootsnap/blob/main/CHANGELOG.md)
- [Commits](https://github.com/Shopify/bootsnap/compare/v1.10.3...v1.11.1)

---
updated-dependencies:
- dependency-name: bootsnap
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2022-03-08 22:34:53 +01:00
jbrw
528c3e311a
FIX: Only display the first listed price (#16138) 
Multiple prices may be returned by Amazon (e.g. for new, and also for used). We should only display the first price.
 2022-03-08 15:24:45 -05:00
Jarek Radosz
bf252752e7
FIX: Make reply-ids public by fixing a typo (#16137) 
…and spec the endpoint
 2022-03-08 21:08:15 +01:00
Bianca Nenciu
6d422a8033
FEATURE: Highlight expired bookmark reminders (#15317) 
The user can select what happens with a bookamrk after it expires. New
option allow bookmark's reminder to be kept even after it has expired.
After a bookmark's reminder notification is created, the reminder date
will be highlighted in red until the user resets the reminder date.
User can do that using the new Clear Reminder button from the dropdown.
 2022-03-08 19:44:18 +02:00
Bianca Nenciu
f5422f91aa
FEATURE: Add link to original image in lightbox (#15640) 
Adds a link to the original image next to the download link. It can be
used to view full resolution image in the browser.
 2022-03-08 19:39:46 +02:00
Jarek Radosz
14109ea92c
FIX: Show 404 html on /posts/:id/raw and /p/:id (#16131) 
It returned a blank page before.
 2022-03-08 17:42:07 +01:00
Jarek Radosz
768c80c2a4
DEV: Make find_post_using raise only Discourse::NotFound (#16133) 2022-03-08 17:39:52 +01:00
Jarek Radosz
c212af665c
DEV: Remove unused scss (#16134) 
`.report-container` doesn't seem to be used anywhere
 2022-03-08 17:39:40 +01:00
Joffrey JAFFEUX
690036225f
DEV: using send can be harmful, public_send is less risky (#16135) 
I can't see any harmful use case here, especially because only one param can be used ATM.
 2022-03-08 17:13:26 +01:00
Kris
28842d24d6
UX: print view always shows 0 votes, hide it (#15901) 2022-03-08 15:35:31 +01:00
Bianca Nenciu
4fe99e39c3
FEATURE: Add new site setting list type with name and values (#16045) 
These changes include a bug fix because allow_any attribute of site
settings was completely ignored before.
 2022-03-08 13:18:43 +02:00
dependabot[bot]
fd34ddef8a
Build(deps-dev): Bump rspec-rails from 5.1.0 to 5.1.1 (#16127) 
Bumps [rspec-rails](https://github.com/rspec/rspec-rails) from 5.1.0 to 5.1.1.
- [Release notes](https://github.com/rspec/rspec-rails/releases)
- [Changelog](https://github.com/rspec/rspec-rails/blob/main/Changelog.md)
- [Commits](https://github.com/rspec/rspec-rails/compare/v5.1.0...v5.1.1)

---
updated-dependencies:
- dependency-name: rspec-rails
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2022-03-08 17:11:29 +11:00
dependabot[bot]
9855962834
Build(deps): Bump mini_sql from 1.3.0 to 1.4.0 (#16128) 
Bumps [mini_sql](https://github.com/discourse/mini_sql) from 1.3.0 to 1.4.0.
- [Release notes](https://github.com/discourse/mini_sql/releases)
- [Changelog](https://github.com/discourse/mini_sql/blob/main/CHANGELOG)
- [Commits](https://github.com/discourse/mini_sql/compare/v1.3.0...v1.4.0)

---
updated-dependencies:
- dependency-name: mini_sql
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2022-03-08 17:11:09 +11:00
dependabot[bot]
c1cb635cc0
Build(deps): Bump jmespath from 1.6.0 to 1.6.1 (#16125) 
Bumps [jmespath](https://github.com/trevorrowe/jmespath.rb) from 1.6.0 to 1.6.1.
- [Release notes](https://github.com/trevorrowe/jmespath.rb/releases)
- [Changelog](https://github.com/jmespath/jmespath.rb/blob/main/CHANGELOG.md)
- [Commits](https://github.com/trevorrowe/jmespath.rb/compare/v1.6.0...v1.6.1)

---
updated-dependencies:
- dependency-name: jmespath
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2022-03-07 22:28:29 +01:00
Bianca Nenciu
34b4b53bac
FEATURE: Use Postgres unaccent to ignore accents (#16100) 
The search_ignore_accents site setting can be used to make the search
indexer remove the accents before indexing the content. The unaccent
function from PostgreSQL is better than Ruby's unicode_normalize(:nfkd).
 2022-03-07 23:03:10 +02:00
Jarek Radosz
6e7cdc5bc3
DEV: Use Ember imports in the styleguide code (#16123) 2022-03-07 21:38:09 +01:00
Jarek Radosz
c528de3288
DEV: Make settled() work in the legacy env (#16122) 
(and await for `focusComposer`)
 2022-03-07 20:00:09 +01:00
Jordan Vidrine
af20d435ea
UX: Fix misaligned avatar (#16120) 2022-03-07 11:08:00 -06:00