Commit Graph

283 Commits

Author SHA1 Message Date
Robin Ward
bba0fd0654 REFACTOR: PreloadStore to ES6 2016-07-11 12:57:05 -04:00
Robin Ward
a546395397 REFACTOR: Migrate markdown functionality in ES6 2016-07-11 12:57:05 -04:00
Robin Ward
f854eebc5f
FIX: Entering a topic at the bottom would cause scroll jumps 2016-05-31 10:51:59 -04:00
Robin Ward
9ea32bf7d8
Deprecation: Change {{#each x in y}} to {{#each y as |x|}} 2016-05-04 16:18:09 -04:00
Guo Xiang Tan
256d7a00e9 Update sprockets. (#4167)
* Update sass-rails.

* FIX: Tilt dependency has been removed from Ember::Handlebars::Template.

* Update `DiscourseIIFE` to new Sprockets API.

* `Rails.application.assets` returns `nil` in production.

* Move sprockets-rails out of the assets group.

* Pin ember-rails to 0.18.5 which works with Sprockets 3.x.

* Update sprockets to 3.6.0.

* Make `DiscourseSassCompiler` work with Sprockets 3.

* Use `Sass::Rails::SassImporterGlobbing` instead of haxxing our own.

* Moneky patch so that we don't add dependencies for our custom css.

* FIX: Missing class.

* Upgrade ember-handlebars-template.

* FIX: require path needs to share the same root as the folder's path.

* Bump discourse-qunit-rails.

* Update ember-template-compiler.js to 1.12.2.

* `prepend` is private in Ruby 2.0.0.
2016-04-18 10:47:52 +08:00
Robin Ward
46e4768971 FIX: highlight.js is used, but for highlighting text, not code. 2016-02-18 12:19:00 -05:00
Robin Ward
9b60551d4e Upgrade jQuery 2016-02-11 11:00:41 -05:00
Robin Ward
d1e85bdd8b FEATURE: Use virtual dom framework for faster post rendering 2016-02-11 11:00:40 -05:00
Robin Ward
4bbbdd8dc4 SECURITY: Upgrade Ember to fix CVE-2015-7565. Also upgrade Handlebars 2016-01-15 13:57:45 -05:00
Jeff Atwood
e1f90d12f1 formally remove IE9 support 2016-01-02 23:49:52 -08:00
Sam
43d63367fd PERF: stop loading handlebars and ember compilers in prod
(this removes a nice 50K from our initial payload and saves memory)

Also fixes invalid HTML automatically if added to HEAD or /BODY
2015-11-27 11:59:01 +11:00
Robin Ward
434deb1bd3 SECURITY: Backported XSS fixes from Handlebars 2015-11-24 16:08:08 -05:00
Robin Ward
05849d2afb FIX: Upgrade Select2 widget - fixes focus on mobile 2015-11-09 13:57:47 -05:00
Robin Ward
bb21902954 Add keyboard shortcuts back to d-editor 2015-11-03 14:01:26 -05:00
Sam
0c5189fa2a SECURITY: fix possible XSS expanding quotes 2015-09-08 15:25:00 +10:00
Robin Ward
f5cbaf5609 Have menu panels show up on top of the composer, stop composer at header 2015-09-01 17:34:04 -04:00
Sam
16d532e9c8 FIX: stop disabling default in detect swipe library 2015-08-26 10:26:58 +10:00
Robin Ward
c5460b7d3f FEATURE: Full height hamburger menu
- Rename `site-map` to `hamburger-menu`
- Includes acceptance tests
2015-08-25 16:48:43 -04:00
Régis Hanol
e7e96eb8af fix the run-qunit scripts with backward compatible syntax 2015-08-25 17:37:36 +02:00
Régis Hanol
294669c856 FIX qunit test runner for phantomjs 2.0 2015-08-25 10:42:19 +02:00
Robin Ward
22844b9e46 Ember 1.12 support 2015-08-13 11:14:16 -04:00
Robin Ward
e2e3e7c0e0 Add ES6 support to more files 2015-08-13 10:49:08 -04:00
Sam
e93665b9f7 FEATURE: site setting to allow html tables (which may come from imports)
(allow_html_tables , disabled by default)
2015-07-20 16:56:46 +10:00
Robin Ward
7a58d64f37 Upgrade ember qunit, create new interface for testing components 2015-07-14 13:56:59 -04:00
Robin Ward
01d4085125 Removed bad JS tests, upgrade QUnit + ember-qunit 2015-05-13 14:13:37 -04:00
Robin Ward
0d51c1f0a0 FIX: List views in admin were broken 2015-05-11 13:17:12 -04:00
Robin Ward
d9e5302a16 FIX: HTMLBars compilation was broken in production mode 2015-05-11 11:20:46 -04:00
Robin Ward
39a1444838 Fixes deprecations on various discovery routes 2015-05-11 11:20:45 -04:00
Robin Ward
c6d99bd141 Fixes routing in tests 2015-05-11 11:18:38 -04:00
Robin Ward
ed398e65e0 Fixes issues with composer 2015-05-11 11:18:38 -04:00
Robin Ward
14fa033288 Update cloaking code for HTMLBars 2015-05-11 11:18:37 -04:00
Robin Ward
8294205f7c Ember 1.11 broken WIP 2015-05-11 11:18:37 -04:00
Robin Ward
b3b4fd21ed Broken WIP 2015-05-11 11:18:37 -04:00
Robin Ward
76f7786d0d Support saving posts via Store 2015-04-15 14:54:36 -04:00
Robin Ward
22ffcba8e6 Convert Discourse.Post to ES6 and use Store model
- Includes acceptance tests for composer (post, edit)
- Supports acceptance testing of bootbox
2015-04-15 14:54:36 -04:00
Robin Ward
77f9d1e223 Use pretender's passthrough for dynamically loaded scripts 2015-03-13 12:14:22 -04:00
Robin Ward
de4e4f2b98 Replace $LAB with path aware loadScript that uses jQuery 2015-03-09 14:39:39 -04:00
Sam
3e5420da35 correct comments 2015-03-05 15:09:31 +11:00
Sam
5ba5a9f3d6 UX: fix jerky UI when creating new posts
- do not scroll screen if post is already on screen
- do not hide/show suggested topics each time you post
- be less aggressive about setting scrollTop in LockOn
2015-03-05 15:01:17 +11:00
Robin Ward
cf3582bedb FIX: JSHint wasn't validating ES6 files, this fixes a bunch of errors. 2015-02-10 17:21:16 -05:00
Sam
5ddec2e76d revert lodash upgrade, it is causing severe breakages elsewhere 2015-02-03 11:51:34 +11:00
Régis Hanol
69f95df297 FEATURE: recently used emoji tab
⬆️ update lodash to V.3.0.1
2015-02-02 21:54:15 +01:00
Régis Hanol
cd2c9edb46 FIX: 🐛 upload on IE9 wasn't working :'(
- FIX: make sure we set a default name to a pasted image only on Chrome (the only browser that supports it)
- FIX: use ".json" extension to uploads endpoints since IE9 doesn't pass the correct header
- FIX: pass the CSRF token in a query parameter since IE9 doesn't pass it in the headers
- FIX: display error messages comming from the server when there is one over the default error message
- FIX: HACK around IE9 security issue when clicking a file input via JavaScript (use a label and set `visibility:hidden` on the input)
- FIX: hide the "cancel" upload on IE9 since it's not supported
- FIX: return "text/plain" content-type when uploading a file for IE9 in order to prevent it from displaying the save dialog
- FIX: check the maximum file size on the server 💥
- update jQuery File Upload Plugin to v. 5.42.2
- update JQuery IFram Transport Plugin to v. 1.8.5
- update jQuery UI Widget to v. 1.11.1
2015-01-28 19:43:20 +01:00
Robin Ward
7cc96bdac5 FIX: v8 issue with regexp 2015-01-20 17:29:59 -05:00
Robin Ward
c4ca6b9934 FIX: Activate account page JS error with I18n 2015-01-14 14:00:47 -05:00
Robin Ward
3e7e47e917 Upgrade Select2 2015-01-05 16:02:08 -05:00
Robin Ward
36f53790f4 Added test for markdown bug with linking [ul] and [poll] 2014-12-31 11:45:23 -05:00
Sam
2aec93c13d FEATURE: hasModule global helper to figure out if module exists 2014-12-31 12:29:18 +11:00
Sam
8d8b4ff781 FIX: allow [poll] and [ul] to be used as markdown link name 2014-12-30 14:18:46 +11:00
Robin Ward
1d74e3c663 FIX: Not highlighting posts when entering a topic 2014-12-19 14:44:45 -05:00
Robin Ward
b716682fe5 FIX: Upgrade Ember List View to add 1.9 support 2014-12-18 12:32:53 -05:00
Robin Ward
f3babdb319 Fixes many Ember 1.9.0 deprecations 2014-12-17 09:31:42 -05:00
Robin Ward
331bba4b6d Correct the last few test failures in the 1.9.0 branch 2014-12-17 09:31:42 -05:00
Robin Ward
5659b93c71 Many fixes for Ember 1.9.0 2014-12-17 09:31:40 -05:00
Robin Ward
5f6f85b182 FIX: Disable loading below HTML, we have our own spinner for that and it
broke scrolling on some custom CSS.
2014-12-04 17:12:47 -05:00
Robin Ward
e1f4d781d2 Remove unncessary null check now that the fix is done properly 2014-12-04 16:13:55 -05:00
Robin Ward
a1498925ef FIX: Errors due to _elementCreated called on null 2014-12-04 16:10:10 -05:00
Robin Ward
e035b07e92 Put Ember 1.8.1 + fixes back. 2014-12-04 08:51:35 -05:00
Sam
8977d5917b revert 2014-12-04 09:35:11 +11:00
Sam
6175973fda Revert "Patch Ember to fix https://github.com/emberjs/ember.js/issues/9805"
This reverts commit 393607d25c.
2014-12-04 09:32:02 +11:00
Robin Ward
393607d25c Patch Ember to fix https://github.com/emberjs/ember.js/issues/9805 2014-12-03 16:41:27 -05:00
Robin Ward
ead073bd87 FIX: If we are scheduled after being torn down don't do anything 2014-12-03 15:55:29 -05:00
Robin Ward
39fde5b9fb Upgrade to 1.8.1: So long, metamorphs! 2014-12-03 10:49:18 -05:00
Robin Ward
f73aa444ee FIX: GroupedView bug with latest Ember build 2014-11-17 20:26:21 -05:00
Robin Ward
72cd2f284b FIX: Try a different way of removing use strict from Ember 1.7.1 2014-11-17 15:31:30 -05:00
Robin Ward
7b7567f8e6 FIX: Remove use strict from ember build to get around iOS bugs 2014-11-17 14:42:21 -05:00
Robin Ward
a6b1be81b1 Upgrade to Ember 1.7.1 + group patch 2014-11-10 14:49:02 -05:00
Robin Ward
bab4f48eeb FIX: Trim the profile text in the user card even if it has multiple lines. 2014-11-03 11:59:56 -05:00
Robin Ward
f58c0e1f22 Patch ember-cloaking to work in Ember 1.7 as well as 1.6 2014-10-29 14:21:05 -04:00
Robin Ward
b250696e04 FIX: Deprecation warnings on webkitIndexedDB 2014-10-15 15:46:23 -04:00
Robin Ward
0a5c7b15e2 SECURITY: RegExp engine loopwith improperly formatted URLs. 2014-09-26 13:37:19 -04:00
Robin Ward
0fc0533134 FEATURE: Admin interface for adding custom fields for users 2014-09-25 16:17:51 -04:00
Robin Ward
1e880fd5e1 SECURITY: Malformed URL could crash V8 2014-09-12 13:19:15 -04:00
Jens Maier
9be5c98c8c FIX: Markdown parser: empty links and bbcode parsed as link refs 2014-08-31 02:55:43 +02:00
Jens Maier
b8f5c21df0 Workaround markdown-js links parser bug 2014-08-24 01:56:14 +02:00
Robin Ward
d3cc85c784 TESTS: Use Pretender in test mode for more flexible server responses 2014-07-31 16:49:30 -04:00
Robin Ward
b6684e7168 Upgrade to ember-qunit 2014-07-30 20:09:44 -04:00
Robin Ward
5bee6887cf Sync __oneElement__ with the upstream PR for markdown-js 2014-07-29 12:01:02 -04:00
Robin Ward
f6a15893e4 Small updates from upstream markdown-js 2014-07-28 16:50:32 -04:00
Jens Maier
9124cf0eaf FIX: auto-quote should not trigger when the first " is preceded by bbcode-like garbage. 2014-07-27 16:05:29 +02:00
Robin Ward
0f23456259 FIX: Instead of patching markdown-js, fix the issue in Discourse. 2014-07-21 13:09:57 -04:00
Robin Ward
d6589d4c53 FIX: Cooking issue with paragraphs in a list 2014-07-15 16:42:14 -04:00
Régis Hanol
ef44b6218d FEATURE: better mobile upload experience (upload the picture right away) 2014-07-09 22:40:22 +02:00
Sam
dc9b6b53ad PERF: editor could be crashed if you entered huge inline blocks 2014-07-04 12:49:50 +10:00
Sam
c5bd454ea6 BUGFIX: not binding "this" correctly in horizRule 2014-06-25 10:03:41 +10:00
Robin Ward
3521fb97e4 FIX: More safety for going back while stuff is uncloaking 2014-06-24 13:50:45 -04:00
Robin Ward
b43ea8bcd1 FIX: Upgrade ember-cloaking to avoid setProperties error 2014-06-24 12:13:48 -04:00
Sam
383f0290a4 FEATURE: higher slack ratio out of the box
I upped the slack ratio for a few reasons

1. We render ucloaked anyway on first render,
   so cloaking really is not saving much
2. On mobile you don't get JS events so you need
   a lot more slack to minimize white screens
3. Vast majority of memory is used by object model,
   if we want to tame it we need to remove posts from stream

ember cloaking now supports high slack ratios without going into a tail spin
2014-06-10 15:07:37 +10:00
Régis Hanol
8262279380 update ember-cloaking to support bottom fixed element 2014-06-06 18:59:07 +02:00
Sam
f8c095873c BUGFIX: cloaking code 2014-06-02 10:58:46 +10:00
Sam
a487b49a2d PERF: optimise check 2014-06-02 10:55:54 +10:00
Sam
97eba92a2e BUGFIX: user screen.width cause it will be more correct
BUGFIX: fix deprecation and regression in cloaking
PERF: cache progressWidth super aggresively to avoid reflows
2014-06-02 10:30:16 +10:00
Sam
13f4afe00f BUGFIX: leaving stray views in Ember during navigation 2014-06-02 09:56:06 +10:00
Sam
ab20d0aa10 HACK: work around https://github.com/mishoo/UglifyJS2/issues/328 2014-05-29 11:54:23 +10:00
Robin Ward
2164a25258 Merge pull request #2333 from rhacker/select2
feature: use select2 instead of chosen
2014-05-28 11:42:40 -04:00
Sam
fad868c78f Bump hashes on various files
Upgrade jquery


I made this commit cause my JS debugging CDN support added a header and
wanted we bump cache everywhere
2014-05-15 15:52:09 +10:00
nXqd
0b6ebdac8a feature: use select2 instead of chosen 2014-05-14 08:01:08 +00:00
Robin Ward
773cf60224 FIX: Missing close paren 2014-05-08 16:04:48 -04:00
Robin Ward
a4e30e8f93 Proof of concept: Load controller via ES6 module in Discourse 2014-05-08 11:35:33 -04:00
Robin Ward
fd153623bb Revert "Proof of concept: Load controller via ES6 module in Discourse"
This reverts commit 0327f469c1.
2014-05-05 13:58:57 -04:00
Robin Ward
0327f469c1 Proof of concept: Load controller via ES6 module in Discourse 2014-05-05 13:23:45 -04:00
Robin Ward
91679c61d5 FIX: Markdown formatting error 2014-04-23 16:46:42 -04:00
Robin Ward
73cc722ed5 Update Ember.js, Handlebars and jQuery to latest 2014-04-17 10:45:06 -04:00
Robin Ward
4da76aab96 FIX: Markdown javascript error with certain formatting. 2014-04-09 10:46:24 -04:00
Wojciech Zawistowski
c0a11adbc5 Moves Markdown Editor from vendor to discourse. 2014-03-31 21:56:19 +02:00
Wojciech Zawistowski
297c25ca1f Synced editor scrolling PoC. 2014-03-31 20:57:45 +02:00
Robin Ward
7baa8ea0af FIX: Upwards scrolling. Updates ember-cloaking 2014-03-31 14:32:51 -04:00
Robin Ward
2842952a76 FIX: Update ember-cloaking. Should fix some vanishing posts 2014-03-21 14:30:03 -04:00
Robin Ward
e8ee490778 Extract breaking up a string into a separate file, include it in
embedded view.
2014-03-20 14:34:51 -04:00
Robin Ward
38f2c778fb Update ember-cloaking for latest fixes/tweaks 2014-03-17 12:01:17 -04:00
Robin Ward
1b1c213c61 Remove ember-renderspeed JS file 2014-03-11 16:15:41 -04:00
Sam
d60c7966eb PERF: remove jQuery.UI monkey patch 2014-03-10 09:50:23 +11:00
Régis Hanol
f25bcc5067 couple of bugfixes identified while importing from VB 2014-03-07 10:44:04 +01:00
Régis Hanol
386b1589f2 Bump the JS test suite timeout to 2 minutes
So that it can run properly on my 3-year old MBA
2014-03-05 10:45:57 +01:00
Robin Ward
47357136dc BUGFIX: Fix issues if the DOM element is destroyed while the interval
is ongoing (in particular this was weird for Firefox)
2014-02-28 15:35:45 -05:00
Robin Ward
61ff04d68b Upgrade ember-cloaking to not trigger scroll events when the back button
is hit.
2014-02-28 15:35:45 -05:00
Régis Hanol
68a935c36b FEATURE: upload backups 2014-02-22 01:41:01 +01:00
Robin Ward
7716d940a0 BUGFIX: Allow links to images with absolute URLs as well as parens 2014-02-20 15:24:03 -05:00
Robin Ward
a555dc9f5e FIX: Incorrect post number following a link. Updated ember-cloaking. 2014-02-13 14:08:12 -05:00
Robert Jackson
7acef17a35 Update Ember for CVE-2014-0046. 2014-02-09 11:10:14 -05:00
Neil Lalonde
a72e7324ba Append browser-update div last in the dom to prevent googlebots from seeing it first 2014-02-06 10:48:15 -05:00
Neil Lalonde
f1b4c26e8e Add Mediapartners and AdsBot to list of user agents for Googlebot in browser-update.js.erb 2014-02-04 16:04:51 -05:00
Régis Hanol
632cd44c2f Fixed some JSHint warnings 2014-02-03 11:33:14 +01:00
Régis Hanol
659589e563 BUGFIX: make_list should only look for lists 2014-02-03 11:31:02 +01:00
Chris Hunt
4e9cf2f26e Bump favcount.js to v1.5.0
We've already made the CORS changes in our copy of favcount, but we
should bump the version to match upstream.
2014-01-23 09:29:28 -08:00
Robin Ward
7b20079d85 FIX: Allow Favcount to be used with CORS. I've submitted this upstream
too:

https://github.com/chrishunt/favcount/pull/8
2014-01-23 11:07:10 -05:00
Régis Hanol
7a82b65386 BUGFIX: restore Mousetrap's bindGlobal plugin
cleared deprecated warnings in admin_customize_view
2014-01-22 16:52:09 +01:00
Régis Hanol
9313f27a89 update mousetrap to latest 2014-01-22 10:17:37 +01:00
Robin Ward
d867fb62e4 FIX: Upstream markdown-js fix for quotes inside lists. 2014-01-21 14:34:53 -05:00
Robin Ward
0a8432645d FIX: Updated Markdown-js to include my latest FIX from upstream:
https://github.com/evilstreak/markdown-js/pull/164
2014-01-21 11:05:17 -05:00
Robin Ward
4981525047 REFACTOR: Fixes poor class hierarchy for listing topics
- Upgrades Ember to latest
- Fixes a bunch of bugs with page titles and missing "active" states
2014-01-18 19:26:24 +01:00
Robin Ward
55397361be Update ember-cloaking to remove dependency on I18n 2014-01-17 16:56:24 -05:00
Robin Ward
d16b4487d5 Applied markdown-js fixes from upstream 2014-01-10 13:04:15 -05:00
Chris Hunt
e5c02a8320 Update favcount.js to v1.4.0 2014-01-08 15:14:07 -08:00
Robin Ward
ef2f202c06 Minor update to ember-renderspeed 2014-01-02 16:41:08 -05:00
Robin Ward
8a1593bfd2 Upgrade JSHint to master + my fix for tokens.hasOwnProperty 2013-12-30 14:19:00 -05:00
Robin Ward
7e984e369a Upgrade JSHint. Fixes linting issues. 2013-12-30 12:42:05 -05:00
Robin Ward
62f757da2c FIX: iOS height was incorrect when zoomed for cloaking 2013-12-23 16:18:00 -05:00
Robin Ward
4c93da01c3 Googlebot seems to parse Javascript and inserts our browser update message
into their search results. If our client is googlebot, don't tell them to
update their browser.
2013-12-23 15:13:09 -05:00
Neil Lalonde
1f0a59584b Revert "Re-apply with fixes: Stop using user agent to detect mobile devices. Use a media query and yepnope to load the appropriate css and customizations." 2013-12-18 14:47:22 -05:00
Régis Hanol
06dd7ffe3c better revision history 2013-12-12 03:41:34 +01:00
Neil Lalonde
5171a23a9c Re-apply with fixes: Stop using user agent to detect mobile devices. Use a media query and yepnope to load the appropriate css and customizations. 2013-12-11 11:19:22 -05:00
Neil Lalonde
ed3d3ae1e1 Upgrade font-awesome to version 4 2013-12-11 10:31:09 -05:00
Neil Lalonde
2596f7dec2 Revert "Stop using user agent to detect mobile devices. Use a media query and yepnope to load the appropriate css and customizations." 2013-12-09 16:28:11 -05:00
Neil Lalonde
ca5d4d5e54 Stop using user agent to detect mobile devices. Use a media query and yepnope to load the appropriate css and customizations. 2013-12-09 13:28:42 -05:00
Robin Ward
e20d649dee FIX: Performance issue with [\] characters. 2013-12-09 12:54:10 -05:00
Robin Ward
64a3afe35a Only allow a recursive depth of 3 for markdown links. 2013-12-08 22:22:08 -05:00
Robin Ward
30a9d3676d Some sanity checks with event binding 2013-12-04 13:28:56 -05:00
Robin Ward
3a2ae97668 Vendor the CloakedView stuff 2013-12-04 13:23:20 -05:00
Robin Ward
de78ee302a - Extract Browser capabilities from Discourse namespace into a Singleton.
- Change Scrolling slack based on Android / Touch / Desktop
2013-12-03 13:03:19 -05:00