3 Commits

Author	SHA1	Message	Date
Martin Brennan	7111d5e4bf	DEV: Fix flaky admin confirmation spec (#27784) ... Waiting for the dialog to close was not enough, need to wait for the overridden indicator to show on the site setting.	2024-07-09 12:05:31 +10:00
Martin Brennan	ffc99253fa	DEV: Resolve TODO comments for martin-brennan ... I am changing many of these to notes or resolving them as is, most of these I have not actively worked on in years so someone else can work on them when we get to these areas again.	2024-07-01 15:32:30 +10:00
Martin Brennan	83361b2fc5	FEATURE: Introduce site settings which require confirmation (#27315) ... Many site settings can be distructive or have huge side-effects for a site that the admin may not be aware of when changing it. This commit introduces a `requires_confirmation` attribute that can be added to any site setting. When it is true, a confirmation dialog will open if that setting is changed in the admin UI, optionally with a custom message that is defined in client.en.yml. If the admin does not confirm, we reset the setting to its previous clean value and do not save the new value.	2024-06-19 16:01:24 +10:00