Joffrey JAFFEUX
2938e3f033
FIX: frozen string exception ( #7505 )
...
Initial backtrace:
```
/var/www/discourse/app/mailers/user_notifications.rb:554:in `send_notification_email'
/var/www/discourse/app/mailers/user_notifications.rb:459:in `notification_email'
/var/www/discourse/app/mailers/user_notifications.rb:318:in `user_private_message'
```
* this might fail too
2019-05-08 16:52:38 +02:00
Sam Saffron
1be01f8dd4
DEV: Add support for Rails 6
...
Minor fixes to add Rails 6 support to Discourse, we now will boot
with RAILS_MASTER=1, all specs pass
Only one tiny deprecation left
Largest change was the way ActiveModel:Errors changed interface a
bit but there is a simple backwards compat way of working it
2019-05-02 16:23:25 +10:00
Bianca Nenciu
3d545d66df
FEATURE: Send user activation reminders. ( #7280 )
2019-04-10 16:53:52 +02:00
Guo Xiang Tan
6815f777f9
DEV: Remove unused method.
2019-04-04 14:19:39 +08:00
Gerhard Schlager
197e3fd722
FIX: Keep original subject in emails to staged users
...
Renaming a topic shouldn't be visibile to staged users when the topic was created via email.
2019-01-18 11:07:54 +01:00
Gerhard Schlager
858a456aaf
FEATURE: Use email_site_title in From of digest emails
2019-01-04 17:06:19 +01:00
Gerhard Schlager
c0a8bb9a91
FEATURE: Include "via <site_name>" in email From header
2019-01-04 17:06:19 +01:00
Bianca Nenciu
a06d310855
DEV: Refactor location string builders. ( #6794 )
2018-12-20 10:23:05 +01:00
David Taylor
9248ad1905
DEV: Enable Style/SingleLineMethods and Style/Semicolon in Rubocop ( #6717 )
2018-12-04 11:48:13 +08:00
Bianca Nenciu
6a3767cde7
FEATURE: Warn users via email about suspicious logins. ( #6520 )
...
* FEATURE: Warn users via email about suspicious logins.
* DEV: Move suspicious login check to a job.
2018-10-25 09:45:31 +00:00
Gerhard Schlager
2c5d9269a0
FIX: Notifications shouldn't use user locale unless allow_user_locale is enabled
2018-09-05 11:44:28 +02:00
Gerhard Schlager
9d35240620
Revert "FIX: Notifications shouldn't use user locale unless allow_user_locale is enabled"
...
This reverts commit c788737eed
2018-09-05 01:53:22 +02:00
Gerhard Schlager
c788737eed
FIX: Notifications shouldn't use user locale unless allow_user_locale is enabled
2018-09-05 00:47:39 +02:00
Guo Xiang Tan
87537b679c
Drop reply_key, skipped and skipped_reason from email_logs.
2018-07-30 11:39:28 +08:00
Sam
0c59346478
PERF: reduce querying when creating notifications
...
also style avoid shadowing of vars
2018-07-11 12:38:11 +10:00
Maja Komel
0942e2c795
allow adding tags as a custom subject format for emails ( #5846 )
...
allow adding tags as a custom subject format for emails
2018-07-11 12:24:07 +10:00
Jeff Wong
4599cc8435
FIX: PM participants listed inline
2018-06-11 18:14:25 -07:00
Arpit Jalan
392f184b24
FIX: check for existence of topic before looking for category
2018-05-17 10:49:01 +05:30
Jeff Wong
62a8904729
Feature: Include participants at the bottom of PM emails ( #5797 )
...
* Feature: Include participants at the bottom of PM emails
... as undecorated links.
https://meta.discourse.org/t/email-notification-recipients-unclear-when-pm-is-sent-to-multiple-users/26934/13?u=featheredtoast
Fix: missing translation for PM mentions
* display membership count as `group (count)`
2018-05-03 15:50:06 -07:00
Guo Xiang Tan
74ce2220a7
Make rubocop happy.
2018-03-12 09:48:41 +08:00
Leo McArdle
89f41f8236
FIX: error when group_in_subject enabled but no group in pm
2018-03-11 12:22:11 +00:00
Jeff Wong
f4f8a293e7
FEATURE: Implement 2factor login TOTP
...
implemented review items.
Blocking previous codes - valid 2-factor auth tokens can only be authenticated once/30 seconds.
I played with updating the “last used” any time the token was attempted but that seemed to be overkill, and frustrating as to why a token would fail.
Translatable texts.
Move second factor logic to a helper class.
Move second factor specific controller endpoints to its own controller.
Move serialization logic for 2-factor details in admin user views.
Add a login ember component for de-duplication
Fix up code formatting
Change verbiage of google authenticator
add controller tests:
second factor controller tests
change email tests
change password tests
admin login tests
add qunit tests - password reset, preferences
fix: check for 2factor on change email controller
fix: email controller - only show second factor errors on attempt
fix: check against 'true' to enable second factor.
Add modal for explaining what 2fa with links to Google Authenticator/FreeOTP
add two factor to email signin link
rate limit if second factor token present
add rate limiter test for second factor attempts
2018-02-21 09:04:07 +08:00
Leo McArdle
5d9d0fcb4f
FEATURE: add setting which adds group name to PM email subject ( #5475 )
2018-02-19 10:20:17 +01:00
Erick Guan
03b3e57a44
FEATURE: login by a link from email
...
Co-authored-by: tgxworld <tgx@discourse.org>
2018-02-13 16:14:39 +08:00
Joshua Rosenfeld
f85055d653
FIX: Remove activation link from account approved email ( #5548 )
2018-02-01 14:59:37 +01:00
Arpit Jalan
0e0794dff9
FIX: correct use of invitee vs inviter in email templates
2017-12-04 14:09:48 +05:30
Robin Ward
971e302ff2
FEATURE: Support an end date for user silencing
2017-11-14 13:20:19 -05:00
Neil Lalonde
bf00ab5d4a
FIX: grant admin on subfolder
2017-10-27 16:46:02 -04:00
Neil Lalonde
e47f5cedd2
FEATURE: forgot_password_strict setting also prevents reporting that an email address is taken during signup
2017-10-03 15:28:30 -04:00
Robin Ward
677b016387
Send a suspension message via email to a user
2017-09-25 12:26:41 -04:00
Neil Lalonde
7181fce71e
remove unused file pending_flags_mailer.rb
2017-09-12 18:00:51 -04:00
Neil Lalonde
beea5cac48
FIX: send the queued posts reminder as a message to moderators instead of an email to the contact_email
2017-09-12 18:00:51 -04:00
Neil Lalonde
94d8f6d734
FIX: digest emails should not include posts that are still in the edit grace period
2017-08-14 12:47:33 -04:00
Guo Xiang Tan
5012d46cbd
Add rubocop to our build. ( #5004 )
2017-07-28 10:20:09 +09:00
Guo Xiang Tan
b59dfb86f4
UX: Include group name in email when group is invited to a PM.
...
https://meta.discourse.org/t/xyz-invited-you-to-a-message-but-really-invited-a-group-im-in/65996
2017-07-26 15:51:44 +09:00
Robin Ward
574681dc47
FIX: Show emoji in inline oneboxes
2017-07-21 14:24:48 -04:00
Sam
c79418d334
DEV: Move RTL into lib where it belongs
2017-07-03 15:26:57 -04:00
Arpit Jalan
16d356ab4e
FEATURE: resending invite should include original custom message
...
https://meta.discourse.org/t/will-resent-invite-include-original-custom-message/64699
2017-06-30 18:13:33 +05:30
Neil Lalonde
5be7a2dad4
FIX: invalid html in notification emails when template has been customized
2017-05-10 14:01:26 -04:00
Guo Xiang Tan
71a266b673
Remove daily mailing mode option as it doesn't scale.
...
https://meta.discourse.org/t/daily-updates-option-for-mailing-list-mode/45029/14?u=tgxworld
2017-05-05 12:21:50 +08:00
Guo Xiang Tan
982e3d04f6
PERF: Allow memory to be freed instead of fetching all the objects into memory at once.
...
```
MemoryProfiler.report do
Jobs::UserEmail.new.execute(type: :mailing_list, user_id: user.id)
end.pretty_print
```
Before:
```
Total allocated: 180096119 bytes (1962025 objects)
Total retained: 2194 bytes (16 objects)
allocated memory by gem
-----------------------------------
66979096 activerecord-4.2.8
43507184 nokogiri-1.7.1
43365188 mail-2.6.4
5960201 activesupport-4.2.8
5056267 discourse/lib
4835284 rack-mini-profiler-0.10.1
3825817 arel-6.0.4
2186088 i18n-0.8.1
1719330 discourse/app
```
After:
```
Total allocated: 161935975 bytes (1473940 objects)
Total retained: 2234 bytes (17 objects)
allocated memory by gem
-----------------------------------
45430264 activerecord-4.2.8
43568627 nokogiri-1.7.1
43430754 mail-2.6.4
11233878 rack-mini-profiler-0.10.1
5260825 activesupport-4.2.8
5054491 discourse/lib
2186088 i18n-0.8.1
1822494 arel-6.0.4
```
2017-05-03 17:01:57 +08:00
Neil Lalonde
b193ae2d15
FIX: missing link in unsubscribe text of summary emails
2017-04-28 10:37:52 -04:00
Robin Ward
a545117d2e
FIX: Forgot to clear out a topic excerpt
2017-04-27 11:49:39 -04:00
Robin Ward
2efe0442bf
FIX: Messed up i18n key
2017-04-27 11:45:59 -04:00
Robin Ward
bf9c4a7828
FEATURE: secure_email site setting to prevent data going out in email
2017-04-26 13:05:56 -04:00
Neil Lalonde
2916b45666
multiplier should not have been changed
2017-04-12 14:48:30 -04:00
Neil Lalonde
3957540dd1
FIX: convert emoji to unicode in topic titles in emails
2017-04-10 13:15:25 -04:00
Robin Ward
17f2974d0a
SECURITY: Confirm new administrator accounts via email
2017-04-04 15:59:01 -04:00
Arpit Jalan
1853a4852c
FIX: use email prefix only in subject
2017-03-21 20:29:57 +05:30
Neil Lalonde
402ddb810c
FIX: email customizations now apply to both html and text parts
2017-03-10 14:08:03 -05:00
Neil Lalonde
15adbdcdd5
FEATURE: new template parameters for notification emails that can be used in links: topic_title_url_encoded and site_title_url_encoded
2017-03-10 14:08:03 -05:00
Blake Erickson
80858bae2c
FEATURE: further restrict downloading of backups
...
- send email to logged in admin when they press the "download" button
- show pop-up that email was sent
- create email template
- require a valid token to download backup
2017-03-01 08:28:34 -07:00
Neil Lalonde
581d477ff3
add a comment because I can never find the mailing list summary email
2017-02-08 12:13:29 -05:00
Neil Lalonde
d9146de080
FIX: an image can be shown twice in summary emails
2017-01-09 13:27:43 -05:00
Neil Lalonde
225e6703ba
FIX: summary shows 0 new topics even though it shows some topics
2016-12-30 15:18:13 -05:00
Neil Lalonde
67347432b7
Remove unread counts from last section of summary email, and rename it "New for you"
2016-12-28 14:06:01 -05:00
Neil Lalonde
74956694e5
If summary email finds no topics, show topics more than 1 day old from new users
2016-12-19 14:54:08 -05:00
Neil Lalonde
239d06b218
add Likes Recieved to possible stats in summary email
2016-12-12 14:20:25 -05:00
Neil Lalonde
ad5d16af8e
FIX: summary email popular posts ordering by score, and increase minimum score to qualify as popular
2016-12-07 12:40:44 -05:00
Neil Lalonde
576a424130
FEATURE: number of new topics at the end of summary email can be controlled by a new setting, digest_other_topics
2016-12-01 14:20:24 -05:00
Neil Lalonde
985daf5c72
FIX: summary should not include certain post types
2016-12-01 12:01:32 -05:00
Neil Lalonde
a187932126
Counts at top of summary email are links
2016-11-29 17:10:25 -05:00
Neil Lalonde
96daf5431f
digest: don't show stats with 0. try to show new posts and new users counts.
2016-11-24 16:28:24 -05:00
Neil Lalonde
79dc0518c9
FIX: popular posts in digest need to use same restrictions as topics
2016-11-23 11:24:18 -05:00
Neil Lalonde
86deec3528
FIX: exclude popular posts from deleted topics
2016-11-22 13:23:21 -05:00
Neil Lalonde
1183e582c3
FIX: digest popular posts need minimum datetime
2016-11-18 16:57:23 -05:00
Neil Lalonde
45f368126f
FEATURE: New summary/digest email design
2016-11-18 14:03:42 -05:00
Régis Hanol
829143bf88
FIX: 'List-Unsubscribe' header wasn't added to emails sent when mailing_list_mode was enabled
2016-08-01 20:19:00 +02:00
Régis Hanol
7848a84e0e
FIX: ensure summary emails have the 'List-Unsubscribe' header set
2016-07-15 11:39:29 +02:00
Robin Ward
5f91919663
Email support for watching first post
2016-07-07 12:23:19 -04:00
James Kiesel
7a6bc3f1d7
Apply notification styles to mailing list email manually ( #4283 )
...
* Apply notification styles to mailing list email manually
* Fix failing spec
2016-06-21 20:42:30 +05:30
Sam
852860de66
FEATURE: simpler and friendlier unsubscribe workflow
...
- All unsubscribes go to the exact same page
- You may unsubscribe from watching a category on that page
- You no longer need to be logged in to unsubscribe from a topic
- Simplified footer on emails
2016-06-17 11:28:49 +10:00
James Cook
c0e25b5a9a
Replace certain uses of 'gsub' with 'tr' or 'chomp' for a speed
...
improvement
2016-06-10 22:08:37 -05:00
Arpit Jalan
40e9e1be66
FEATURE: user-friendly custom message
2016-06-08 18:23:22 +05:30
Arpit Jalan
4253141700
FEATURE: custom email message for topic invites
2016-06-07 23:43:15 +05:30
Arpit Jalan
7b205ebba4
FEATURE: customize invite email message
2016-06-06 20:15:30 +05:30
Régis Hanol
99ad251731
different email footer when mailing_list_mode is enabled
2016-06-03 15:48:54 +02:00
James Kiesel
feffe23cc5
FEATURE: More granular mailing list mode ( #4068 )
...
* Rearrange frontend to account for mailing list mode
* Allow update of user preference for mailing list frequency
* Add mailing list frequency estimate
* Simplify frequency estimate; disable activity summary for mailing list mode
* Remove combined updates
* Add specs for enqueue mailing list mode job
* Write mailing list method for mailer
* Fix linting error
* Account for stale topics
* Add translations for default mailing list setting
* One query for mailing list topics
* Fix failing spec
* WIP
* Flesh out html template
* First pass at text-based mailing list summary
* Add user avatar
* Properly format posts for mailing list
* Move make_all_links_absolute into Email::Styles
* Apply first_seen_at to user
* Send mailing list email summary hourly based on first_seen_at
* Branch and test cleanup
* Use existing mailing list mode estimate
* Fix failing specs
2016-05-21 15:17:54 +02:00
Arpit Jalan
51d194cc21
FIX: show invited by username when inviting to topic
2016-04-13 11:38:29 +05:30
Régis Hanol
a359a973e2
remove useless content when sending email to a staged used
2016-04-11 19:06:10 +02:00
Arpit Jalan
17afdc34cc
UX: user invite email style should be consistent with other user notifications
2016-03-25 19:28:55 +05:30
Sam
c095304d6d
FEATURE: limit daily emails per user to 100 per day via site setting
...
- controlled via max_emails_per_day_per_user, 0 to disable
- when limit is reached user is warned
2016-03-23 15:08:48 +11:00
Robin Ward
5771d2aee2
SECURITY: Support for confirm old as well as new email accounts
2016-03-08 14:52:22 -05:00
scossar
2d8b10d139
validate user locale
2016-03-04 13:21:30 -08:00
scossar
a20a52b25f
add user locale
2016-03-03 17:21:50 -08:00
Régis Hanol
21b51090bf
FIX: don't tell staged users they can visit topics in email notifications
2016-02-26 23:56:56 +01:00
Sam Saffron
820a435af8
FEATURE: add "email in-reply-to user option"
...
We no longer include previous replies as "context", instead
we include and excerpt of the post being replied to at the bottom
of notifications, this information was previously missing.
Users may opt in to emailing previous replies if they wish
or opt out of "in-reply-to" which makes sense in some email clients that
are smarter about displaying a tree of replies.
2016-02-26 00:05:59 +11:00
Régis Hanol
8d1da9cedd
FEATURE: keep original title when sending email notifications about a PM
2016-02-23 01:34:16 +01:00
Régis Hanol
780c3ad755
Merge pull request #4008 from joebuhlig/master
...
Add tertiary color to email digests
2016-02-22 14:43:21 +01:00
Joe Buhlig
6763a9923a
Added tertiary color to digest
...
Added hash to color in helper
Added anchor_color to topic and site name links
Styled the unsubscribe link
2016-02-22 07:02:21 -06:00
Sam
ab06f86fbe
FEATURE: allow users to control how many previous replies they get
...
- always means we always send previous replies with every email
- never means we do not
- "unless previously sent" ... is the default, in which we only email you each reply once
The default_email_previous_replies site setting can control this toggle
2016-02-19 13:57:07 +11:00
Sam
3829c78526
PERF: shift most user options out of the user table
...
As it stands we load up user records quite frequently on the topic pages,
this in turn pulls all the columns for the users being selected, just to
discard them after they are loaded
New structure keeps all options in a discrete table, this is better organised
and allows us to easily add more column without worrying about bloating the
user table
2016-02-17 18:08:25 +11:00
Régis Hanol
63b9d1c645
FIX: sends an email notifcation when a user's post is linked
2016-02-16 18:29:23 +01:00
Régis Hanol
c740b42328
FIX: whitelist post_types used in context in email notifications
2016-02-12 12:10:30 +01:00
Régis Hanol
86819f08c3
FIX: use RFC-compliant previous replies separator
2016-02-11 18:48:09 +01:00
Régis Hanol
7d992cb4c5
FIX: sending emails to mailing list subscribers wasn't working
2016-02-03 19:27:58 +01:00
Régis Hanol
378b7f964c
Revert "FEATURE (WIP): add max-width and center email notifications"
2016-01-29 11:13:59 +01:00
Arpit Jalan
26bba1f481
UX: preserve localization in digest email
2016-01-28 23:38:07 +05:30
Arpit Jalan
90d41a994a
universal date format in digest email
2016-01-28 23:15:32 +05:30
scossar
3f09ec2aca
add layout for notifications
2016-01-27 11:27:32 -08:00
