Commit Graph

7360 Commits

Author SHA1 Message Date
Régis Hanol
f5e170c6b5 FIX: catch all server-side error when uploading a file
UX: always show a message to the user whenever an error happens on the server when uploading a file
2017-12-27 16:33:25 +01:00
Maja Komel
2a32536645 grey out disabled badges in admin overview (#5416)
* gray out disabled badges in admin overview

* fix style
2017-12-27 16:57:21 +11:00
Vinoth Kannan
d18c42abd5 FIX: Ignore if the default localization node is not an object (#5439) 2017-12-27 16:53:53 +11:00
David Taylor
f1f2ae594c Remove wrapper <span> from user nav plugin outlet (#5455) 2017-12-27 16:51:39 +11:00
Robin Ward
6cffbb4ea4 FIX: Don't show moderation history option to TL4 2017-12-26 17:13:29 -05:00
Arpit Jalan
89d1107f81 UX: show '{count}+' when not sure about exact search count 2017-12-26 19:50:03 +05:30
Vinoth Kannan
688f39447c Skip tab delimited lists in plain text to table conversion 2017-12-26 15:52:22 +05:30
Joffrey JAFFEUX
f6dc992b0f
FIX: do not apply i18n if already done 2017-12-26 09:51:45 +01:00
Vinoth Kannan
e9cd7af10e FIX: IE not supporting regex negative lookbehind 2017-12-23 23:44:57 +05:30
Vinoth Kannan
035f96d25f Allow linked images inside table cells in HTML to Markdown conversion 2017-12-23 22:48:39 +05:30
Régis Hanol
779efd9235 FIX: don't set properties on destroyed components 2017-12-22 20:33:33 +01:00
Robin Ward
ea9c1e5cf8 Add extensibility endpoints for clicking on topic list item rows 2017-12-22 14:01:17 -05:00
Vinoth Kannan
3ae9d91d86 UX: Use tight list by default in HTML to Markdown conversion 2017-12-22 21:34:55 +05:30
Vinoth Kannan
ac1e93e82a Minor fix to correctly trim spaces in HTML to Markdown conversion 2017-12-22 19:05:40 +05:30
Joffrey JAFFEUX
315b9d796d
select-kit refactoring
* better test helper
* more reliable tests
* more consistent use of data-value/data-name/title/aria-label everywhere: header and rows
2017-12-22 13:08:12 +01:00
Vinoth Kannan
4935ae4338 Remove unwanted spaces between HTML tags and support Word documents 2017-12-22 09:28:24 +05:30
Robin Ward
2908aab0da Allow extensibility on username route format (non-english usernames) 2017-12-21 14:32:51 -05:00
Vinoth Kannan
129d924c0d Dont support single row or column tables in HTML to Markdown conversion 2017-12-21 12:58:57 +05:30
Sam
62a27f9d57 FEATURE: warn if attempting to mention a group with too many members 2017-12-21 16:13:57 +11:00
Sam
081959227d FIX: unicode titles missing when visiting topic from topic list 2017-12-21 15:20:47 +11:00
Sam
252cbd8635 FIX: keyboard shortcut allowed you to open composer on closed topics 2017-12-21 13:09:18 +11:00
Sam
2423b18839 FIX: links inside quotes not opening in new tab 2017-12-21 13:00:20 +11:00
Sam
6bf3bee473 FIX: when leaving PM tab revert to user scoped search 2017-12-21 12:30:41 +11:00
Sam
e756d02088 FIX: create topic keyboard shortcut not checking permissions 2017-12-21 11:23:57 +11:00
Gerhard Schlager
ac7e6dab06 FIX: Refreshing Gravatar didn't work 2017-12-20 20:49:58 +01:00
Régis Hanol
7f69362d9d FIX: external links in whisper ended up in a white page
FIX: clicking a link in a onebox wasn't properly extracting the post_id
2017-12-20 17:55:15 +01:00
Vinoth Kannan
ac1d3a761e Support for table & ol tags for HTML pasting in composer 2017-12-20 19:24:55 +05:30
Guo Xiang Tan
87c334c063 Fix randomly failing JS acceptance tests. 2017-12-20 11:04:47 +08:00
Robin Ward
2735914cf6 FIX: ESlint 2017-12-19 17:55:41 -05:00
Robin Ward
b3fda0ea86 FIX: details tags broke excerpts 2017-12-19 17:28:55 -05:00
Robin Ward
c1716d41c7 Add some plugin outlets to the user card 2017-12-19 15:04:54 -05:00
Vinoth Kannan
6272f35eec blockquote tag support for HTML pasting in composer 2017-12-19 20:59:55 +05:30
Sam
9472821331 Allow plugins to specify custom nav items on mobile 2017-12-19 16:50:25 +11:00
Sam
e63a2487e3 UX: allow for iPhone X in iOS Hacks 2017-12-19 15:20:06 +11:00
Vinoth Kannan
70b6030c74 FIX: IE syntax error in regular expression 2017-12-18 23:03:35 +05:30
Vinoth Kannan
ad41523895 FEATURE: Converting code tags to Markdown while pasting 2017-12-18 22:12:05 +05:30
Vinoth Kannan
b9f553d45d REFACTOR: Small improvement in code for Tag.slice method 2017-12-18 13:38:47 +05:30
Vinoth Kannan
0588edbc96 FEATURE: Keep supported HTML tags in HTML to Markdown conversion 2017-12-18 12:48:17 +05:30
Vinoth Kannan
b963307f30 FIX: IE compatability issue in clipboard files array 2017-12-17 12:04:16 +05:30
Joffrey JAFFEUX
7f89f8aa3f
FIX: reset scroll position when switching tab in edit category modal 2017-12-16 20:46:22 +01:00
Vinoth Kannan
4f2f42d710 PERF: Better handling of headings in HTML inline pasting 2017-12-17 00:45:21 +05:30
Régis Hanol
8175740e87 UX: don't shown the 'staff-counters' div when there's no counter 2017-12-16 13:16:23 +01:00
Régis Hanol
50487d6122 FIX: wasn't able to recover a post 2017-12-16 13:04:20 +01:00
Neil Lalonde
e73556f48f FIX: disable New Topic button if filtered to a tag and a category that you don't have permission to post in 2017-12-15 13:42:29 -05:00
Vinoth Kannan
dc159d7fa6 Grab dimention of the clipboard images 2017-12-15 17:28:38 +05:30
Vinoth Kannan
9cd48207f2 make eslint happy 2017-12-15 17:08:17 +05:30
Vinoth Kannan
236ecec0b0 Skip HTML pasting if image upload available 2017-12-15 16:40:40 +05:30
Vinoth Kannan
5c3ef7875f FIX: Inline head tag html pasting 2017-12-15 12:00:17 +05:30
Vinoth Kannan
bfafca42b7 fix eslint and refactor code 2017-12-15 11:07:50 +05:30
Vinoth Kannan
f0497ee9c4
FEATURE: HTML to Markdown conversion using native JavaScript ES6 classes (#5425) 2017-12-15 10:28:20 +05:30
Régis Hanol
2f792bc59f FIX: a topic should be visited when you've read everything and there's deleted posts at the end 2017-12-15 00:00:48 +01:00
Joffrey JAFFEUX
3090c016d0
FIX: do not display used categories as selectable in categories notifications preferences 2017-12-14 14:40:08 +01:00
Maja Komel
52e38e5527 FIX: save whisper drafts (#5417) 2017-12-14 11:35:08 +11:00
Régis Hanol
53bbf08ea1 FIX: wasn't redirected to group inbox 2017-12-13 23:31:20 +01:00
Régis Hanol
c63ecd87f2 FIX: ensure we're always changing 1 post ownership 2017-12-13 22:45:14 +01:00
Maja Komel
0f4ed2e070 display language name in user locale selector - make it consistent with admin (#5424) 2017-12-14 08:17:36 +11:00
Régis Hanol
1b4483c942 FEATURE: Added 'select +below' and 'select +all replies' options to selecting posts 2017-12-13 22:12:06 +01:00
Joffrey JAFFEUX
c1c31b99ce
Replaces toolbar popup-menu with select-kit 2017-12-13 10:49:32 +01:00
Robin Ward
5fbfe34356 FIX: Moderation History wasn't working from timeline admin button 2017-12-12 12:21:10 -05:00
Kris
55c019f776 UX: Cleaning up staff counters on user profiles 2017-12-12 10:40:16 -05:00
Kris
920571ae07 UX: Making button on advanced search page match input height 2017-12-11 17:15:08 -05:00
Vinoth Kannan
c17a28f875 Using const instead of var while declaring 2017-12-11 14:26:21 +05:30
Vinoth Kannan
fdef4e58f0 Skip markdown table conversion from rich text feature flag setting 2017-12-08 18:30:38 +05:30
Vinoth Kannan
b9c0488687 New site setting to enable or disable rich text pasting 2017-12-08 14:09:39 +05:30
Vinoth Kannan
0a47642003 FIX: Pasted text removing if server unable to parse HTML to Markdown 2017-12-08 13:38:54 +05:30
Robin Ward
74b9828731 FIX: Remove mentions filters from user and groups
Additionally return no data if disabled
2017-12-07 16:29:02 -05:00
Joffrey JAFFEUX
fd99e1ef56 FEATURE: site setting enable_mentions to turn on/off mentions 2017-12-07 16:27:58 -05:00
Robin Ward
3cf4886d3e UX: Add a class name to target the embedded post controls 2017-12-07 15:01:34 -05:00
Vinoth Kannan
be848b8a5c FIX: Image pasted twice when it copied from browser 2017-12-07 21:23:31 +05:30
Vinoth Kannan
5cceb95f92 Improvement in composer HTML pasting 2017-12-07 21:13:09 +05:30
Vinoth Kannan
858cd3a589 Improvement in composer HTML pasting 2017-12-07 21:08:08 +05:30
Maja Komel
cce077de56 move /tags/ topics list out of footer (#5405) 2017-12-07 15:25:04 +01:00
Joffrey JAFFEUX
f0ef307d2d
FIX: topic timer offset applied two times
timezone offset was calculated and sent from browser to server, it would be applied on utc time generated from '2013-11-22 5:00' format for example and then sent back to browser which would display it thinking it's UTC time using `moment(utc time)` when it's in fact an UTC time we have offseted with the initial user timezone.

This is impossible to automatically test in the current app state. Easiest reproduction is in live browser after setting your timezone to `America/New_York`, when setting a topic timer to later_today, after save, the time under the topic should be off to something roughly equal +1/-1  hour to your timezone offset.
2017-12-07 14:42:58 +01:00
Guo Xiang Tan
c64774f4f8 Remove debugging code. 2017-12-07 06:48:12 +08:00
Régis Hanol
c08d53f2dd keyValueStore isn't available in test 2017-12-06 23:28:28 +01:00
Régis Hanol
ae0acfb1df FEATURE: live reply indicators at the bottom of topic 2017-12-06 21:58:59 +01:00
Régis Hanol
ea50f823cb FIX: logging in after an anon ❤️ does not count the ❤️ 2017-12-06 21:58:05 +01:00
Robin Ward
cf3ea4f9bd UX: Use the same 404 page for the unknown route and exception handler 2017-12-06 15:20:24 -05:00
Robin Ward
e8d5d34755 FIX: Don't show trust level if the API didn't return it 2017-12-06 13:13:51 -05:00
ckeboss
7a093ea5d6 Format username for desktop notifications (#5403)
FIX: Desktop notifications weren't formatting the username
2017-12-06 12:52:11 -05:00
Kris
f559275b14 FIX: Adjusted the composer preview to avoid odd scroll issue 2017-12-06 11:31:36 -05:00
Vinoth Kannan
7d88cfde0e Skip paste handling if composer textarea lost focus 2017-12-06 19:36:13 +05:30
Guo Xiang Tan
4531563717 Hide new advanced editor and preview sync behind a hidden site settings. 2017-12-06 12:34:58 +08:00
Robin Ward
410994b7f5 FEATURE: Show a button to Staff for "Moderation History" on posts/topics
When clicked, it pops up a modal showing a history of moderation actions
taken on the post or topic.
2017-12-05 15:20:20 -05:00
Vinoth Kannan
94e9be3b88 Make eslint happy 2017-12-06 01:28:22 +05:30
Vinoth Kannan
8cf7152151 FIX: IE compatability issue in clipboard data types array 2017-12-06 01:02:06 +05:30
Vinoth Kannan
6e054b2572 FEATURE: Convert HTML to Markdown while pasting in composer 2017-12-05 12:23:39 -05:00
Vinoth Kannan
37948838be FIX: Global event variable is not compatible with all browsers 2017-12-05 11:27:08 +05:30
Vinoth Kannan
4654f076f5 FIX: Drive spreadsheet table not converting to Markdown table 2017-12-05 11:03:33 +05:30
Kris
4af4081c39
UX: Updating the edit post title layout 2017-12-04 15:29:02 -05:00
Neil Lalonde
b5a967ab43 lint failure 2017-12-04 14:32:01 -05:00
Neil Lalonde
23ea4b6739 FIX: don't create featured link if title includes more than a url 2017-12-04 14:21:08 -05:00
Neil Lalonde
fb08441802 Revert "FIX: don't create featured link if title includes more than a url" 2017-12-04 12:53:12 -05:00
Vinoth Kannan
e14281bdf6
Merge pull request #5393 from vinothkannans/clip-master
FEATURE: Paste plain text table as Markdown table
2017-12-04 22:45:07 +05:30
Neil Lalonde
cde42c3f69 FIX: don't create featured link if title includes more than a url 2017-12-04 12:03:41 -05:00
Vinoth Kannan
ab4c953d82 FEATURE: Paste plain text table as Markdown table 2017-12-04 20:53:42 +05:30
Arpit Jalan
f466791a15 FIX: resolve from URL when using /new-topic route 2017-12-04 17:34:17 +05:30
Robin Ward
e80caab247 FIX: Reply to tab was not using the username formatter 2017-12-03 15:49:21 -05:00
Robin Ward
a0da098e6b UX: Add new classes to make user creation more targetable 2017-12-03 15:03:06 -05:00
Vinoth Kannan
e2c60ea4b2 FIX: Skip pasting files if plain text available in clipboard 2017-12-02 02:05:11 +05:30
Arpit Jalan
54f5b4d4e0 FEATURE: log clicks on full page search 2017-12-01 23:21:16 +05:30
Joffrey JAFFEUX
966dbb9705
FIX: do not give any element focus when creating topic 2017-12-01 13:16:36 +01:00
Guo Xiang Tan
2e860eddc1 Don't sync scroll when input is not scrollable.
https://meta.discourse.org/t/composer-preview-scroll-not-syncing-with-editor/74975/14?u=tgxworld
2017-12-01 17:08:03 +08:00
Arpit Jalan
496cd3b4df
Merge pull request #5385 from techAPJ/search-logs-improvements
FEATURE: support search click through tracking for user, category and tags
2017-12-01 12:08:38 +05:30
Arpit Jalan
e3925278e2 FEATURE: support search click through tracking for user, category and tags
https://meta.discourse.org/t/search-logs-page/73281/11?u=techapj

This commit adds following features:

- support for tracking click through to user, tag and category
- new filter for search type (header, full page)

This commit also removes "most viewed topic" field from search logs page because we are now tracking multiple click through entities, so topic is not a special entity anymore. This also improves query perf. The query now takes `20.5ms` to runs, as opposed to `655.9ms` previously.
2017-12-01 12:04:55 +05:30
Neil Lalonde
3dd67e9c04 replace 'email' with envelope icon on user card for staged users 2017-11-30 16:55:27 -05:00
Neil Lalonde
bca90381cf FIX: save drafts of new topics with titles but no body 2017-11-30 15:16:12 -05:00
Robin Ward
dfd309c64f FIX: The user summary wasn't using the username formatter 2017-11-30 12:17:03 -05:00
Vinoth Kannan
704dbd7cfc FIX: Unable to remove existing user title (#5386) 2017-11-30 15:54:38 +01:00
Sam
05f5df69b1 UX: Add tooltips for messages and notifications in header 2017-11-30 12:56:54 +11:00
Sam
772301bc65 woops 2017-11-30 12:32:50 +11:00
Sam
bf1f6c7fe4 UX: better help text for composer collapse / discard
also: warn on collapsed close if you are to discard content
2017-11-30 12:28:00 +11:00
Régis Hanol
0d34caff85 UX: show error message when no gravatar is associated 2017-11-29 18:09:44 +01:00
Régis Hanol
1218ead355 UX: preloaded gravatar was appearing on the right instead of the left 2017-11-29 18:07:09 +01:00
Guo Xiang Tan
9fbe1436b6 UX: Replace heuristic solution root domain extraction for topic featured link. 2017-11-29 21:52:41 +08:00
Guo Xiang Tan
8491c5fba5 UX: Replace heuristic solution for extracting root domain. 2017-11-29 16:26:46 +08:00
Guo Xiang Tan
3e9c3f6f13 Fix JS test.
* `new Array` doesn't seem to be available in phantomJS yet.
2017-11-29 16:03:00 +08:00
Guo Xiang Tan
5b965ab5d0 Sync editor and preview when preview is updated. 2017-11-29 11:19:04 +08:00
Guo Xiang Tan
ebc31975e8 Ember.run.schedule -> Ember.run.scheduleOnce. 2017-11-29 10:43:59 +08:00
Guo Xiang Tan
de17a8e856 UX: Sync input and preview when user is typing. 2017-11-29 09:56:15 +08:00
Guo Xiang Tan
4816619ba3 FIX: Editor and preview does not sync when scrolled to the bottom. 2017-11-29 08:38:57 +08:00
Robin Ward
04e8b7dffb UX: Remove another plugin outlet container we don't need 2017-11-28 14:46:17 -05:00
Robin Ward
86df5846c8 Don't use a tag for a couple of topic outlets 2017-11-28 14:42:24 -05:00
Gerhard Schlager
41e70c410c
FEATURE: replace GUID in image name uploaded from iOS (#5370) 2017-11-28 11:05:34 +01:00
Jeff Wong
b094894c94 Feature: Add service worker registration method to plugin API 2017-11-28 14:01:41 +08:00
Sam
ceaadf6246 UX: adjustments for topic title editing 2017-11-28 12:00:18 +11:00
Sam
5a715b7d55 lint it up 2017-11-28 07:39:24 +11:00
Kris
ada1d6b987
Composer restyle
* composer restyle, some input normalization

* style adjustments: spacing, preview background, colors

* small spacing adjustments, removing default iOS input appearance, fixing merge

* small width adjustment

* fixing mobile link modal for small devices

* FIX: more resilient allowInitiatlValueMutation implementation

* Build scrollMap only on scroll.

* FIX: pick date and time was not reseting state

* FIX: removes auto sizing and touchstart support for now

* Revert "FIX: reflects discourse icons naming scheme s/d-icon-*/d-*"

This reverts commit b5ed980235.

* tweak icon-library generation

* FIX: regression preventing to set number of hours before closing

This commit also adds a full test suite for editing topic timer.

* FIX: makes allowInitialValueMutation more restrictive

* FIX: invite-list expects initial value mutation

* fixing tag input spacing

* minor input cleanup

* bump onebox version

* FIX: avoids test failing at some times of the day

* FIX: various issues when editing category permissions

This commit also adds multiple tests
2017-11-27 15:23:18 -05:00
Joffrey JAFFEUX
49b1df40fc
FIX: various issues when editing category permissions
This commit also adds multiple tests
2017-11-27 19:50:04 +01:00
Robin Ward
36d46df8dc New setting to show the reply title on the post menu on mobile 2017-11-27 13:21:53 -05:00
Arpit Jalan
2c16240b60 fix the build 2017-11-27 23:18:08 +05:30
Arpit Jalan
bf415f2d40 FIX: youtube playlist videos were not functioning properly in fullscreen 2017-11-27 22:56:44 +05:30
Sam
eb428ef54d FEATURE: uploads are processed a faster
Also cleans up API to always return 422 on upload error. (previously returned 200)

Uploads are processed using new hijack pattern
2017-11-27 12:43:35 +11:00
Sam
a74ac90bf5 FIX: quote dropped when replying as new topic 2017-11-27 10:08:55 +11:00
Angus McLeod
4b919cd735 Move queuedForTyping assignment (#5366) 2017-11-27 09:43:41 +11:00
Neil Lalonde
39d7745dc5 UX: show staged users' email addresses to staff without requiring a button press 2017-11-24 16:11:34 -05:00
Guo Xiang Tan
f3f051a344 UX: Composer textarea should always start at the top. 2017-11-24 23:24:37 +08:00
Joffrey JAFFEUX
96cdc4e66e
FIX: makes allowInitialValueMutation more restrictive 2017-11-24 13:15:02 +01:00
Guo Xiang Tan
44333c5de3 REFACTORY: Dry up some composer syncing code. 2017-11-24 14:57:36 +08:00
Joffrey JAFFEUX
63307c303a
FIX: regression preventing to set number of hours before closing
This commit also adds a full test suite for editing topic timer.
2017-11-24 02:48:45 +01:00
Neil Lalonde
3f58b18dab FEATURE: user card shows staff if a user is staged and lets them check the email address 2017-11-23 16:38:11 -05:00
Joffrey JAFFEUX
9208909b26 tweak icon-library generation 2017-11-23 18:24:26 +01:00
Joffrey JAFFEUX
dd5562322b Revert "FIX: reflects discourse icons naming scheme s/d-icon-*/d-*"
This reverts commit b5ed980235.
2017-11-23 18:24:26 +01:00
Gerhard Schlager
eaa54a5a64 FIX: don't store state of composer's preview in mobile view 2017-11-23 15:22:00 +01:00
Guo Xiang Tan
c5745feac6 Build scrollMap only on scroll. 2017-11-23 21:44:09 +08:00
Joffrey JAFFEUX
fe94e7c453
FIX: more resilient allowInitiatlValueMutation implementation 2017-11-23 14:39:26 +01:00
Guo Xiang Tan
ab839d134b Fix scrollmap included NaN values. 2017-11-23 18:08:43 +08:00
Guo Xiang Tan
486016acea UX: Improve editor and preview scroll syncing. 2017-11-23 17:02:02 +08:00
Neil Lalonde
6c86e0c94a FEATURE: remove the featured link by editing the topic 2017-11-22 14:53:35 -05:00
Régis Hanol
8a7cbeef00 UX: hide 'dismiss' in notifications dropdown when there are no unread notifications 2017-11-22 15:56:01 +01:00