Commit Graph

10597 Commits

Author SHA1 Message Date
Régis Hanol
62cd6a4122 Merge pull request #3995 from devonestes/reducing-duplication-csv-export
Reducing duplication and string allocation in Jobs::ExportCsvFile
2016-02-06 11:10:21 +01:00
Régis Hanol
8db11aab62 Merge pull request #3996 from gschlager/i18n-datepicker
UX: Use i18n for date picker
2016-02-06 11:07:21 +01:00
Régis Hanol
edfe14b1f1 Merge pull request #3997 from gschlager/datepicker
UX: Date Picker in user preferences was ugly
2016-02-06 11:05:14 +01:00
Gerhard Schlager
8e135e460b UX: Date Picker in user preferences was ugly 2016-02-05 23:28:57 +01:00
Arpit Jalan
8a7868be07 FIX: validate user website 2016-02-06 02:19:48 +05:30
Gerhard Schlager
f7eb7f25bd UX: Use i18n for date picker 2016-02-05 21:49:21 +01:00
Régis Hanol
ea0e63b150 FIX: handle cases where we only pass the notification type rather than the notification id when sending user email 2016-02-05 20:07:30 +01:00
Devon Estes
0aa59956fa Extract method refactoring in Jobs::ExportCsvFile
I was combing through some of the files with worse grades on Code Climate as a guide for places where I could jump in and help, and I saw this as one of the ones in need of some love. I reduced duplication in the #user_list_export method by extracting several methods that were common to both branches of the logic in that method.
2016-02-05 16:47:15 +01:00
Régis Hanol
91ec2c5171 fix eslint 2016-02-05 16:08:31 +01:00
Régis Hanol
56a16a0e89 we still need md5 2016-02-05 15:27:24 +01:00
Sam Saffron
e3747f654b SECURITY: hoist blocks using guids, not md5 hashes 2016-02-06 01:02:48 +11:00
Guo Xiang Tan
726d81f83b FIX: Don't update autocomplete when removing the key. 2016-02-05 16:47:47 +08:00
Guo Xiang Tan
46589a1a0c FEATURE: AR adapter to failover to a replica DB server. 2016-02-05 08:51:10 +08:00
Régis Hanol
2d170712d7 new 'private_email_time_window_seconds' site setting 2016-02-04 17:22:16 +01:00
Régis Hanol
03938afc9b Merge pull request #3992 from techAPJ/report-filter
FEATURE: filter admin reports via user group
2016-02-04 11:21:14 +01:00
Guo Xiang Tan
c99775ebdb FIX: PrettyText should return the valid slug. 2016-02-04 15:05:15 +08:00
Arpit Jalan
eec8436cfe FEATURE: filter admin reports via user group 2016-02-04 11:23:49 +05:30
Régis Hanol
7d992cb4c5 FIX: sending emails to mailing list subscribers wasn't working 2016-02-03 19:27:58 +01:00
Neil Lalonde
ccbbfbc24e FIX: /signup route will show sign up modal for private sites too if they allow registrations 2016-02-03 12:18:33 -05:00
Neil Lalonde
2ff4248c19 FIX: also show Sign Up button on front page of private sites that allow new registrations 2016-02-03 11:36:28 -05:00
Sam Saffron
3f67f91d27 need to allow for now scope 2016-02-04 00:19:08 +11:00
Sam Saffron
60ba9dcc5e PERF: fix N+1 on categories page 2016-02-03 23:59:15 +11:00
Sam Saffron
e9c1f8171c more protection 2016-02-03 19:21:49 +11:00
Sam Saffron
835bedca67 add some protection so it works if currentUser is missing somehow 2016-02-03 19:04:23 +11:00
Sam Saffron
bc75010b20 FEATURE: suggested messages for messages
FEATURE: clicking envelope takes you to inbox

Suggested messages works somewhat like suggested topics.

- New show up first (in either group inbox or inbox)
- Then unread (in either group inbox or inbox)
- Finally "related" which are messages with same participants as the current pm.
2016-02-03 18:50:05 +11:00
Jeff Atwood
133fcef72c remove link for created on topic map 2016-02-02 16:20:14 -08:00
Jeff Atwood
a3cd0ae8ae make PM usernames grey not link-blue 2016-02-02 16:17:14 -08:00
Régis Hanol
cf4c256b17 FEATURE: new 'raw email' modal when listing rejected emails 2016-02-01 21:41:49 +01:00
Régis Hanol
12051f79a8 FIX: don't send empty email notifications for small_actions 2016-02-01 19:12:10 +01:00
Régis Hanol
8608b5cbc1 FIX: don't poll the mailbox in development 2016-02-01 16:56:32 +01:00
Sam Saffron
904e532439 SECURITY: topic titles can show up in user page unescaped when streamed in 2016-02-01 20:53:55 +11:00
Régis Hanol
ce8c2d34d7 FIX: add a 20 seconds grace period before sending a notification about a PM 2016-02-01 10:14:30 +01:00
Jeff Atwood
c3af4abfb5 reduce signup cta thresh, 2 topics, 2 min read time 2016-02-01 00:25:36 -08:00
Sam Saffron
4099823efe FIX: batch badge assigner was not including full info in notification
(missing drilldown link in notification)
2016-02-01 18:27:07 +11:00
Guo Xiang Tan
8772ba2f80 FIX: Redirecting breaks the back button. 2016-02-01 15:11:44 +08:00
Jeff Atwood
f281f6e026 Merge pull request #3989 from cpradio/topic-footer-button-outline
Remove outline: 0 from the topic-footer-buttons, so focus is visible
2016-01-30 15:44:57 -08:00
Sam Saffron
01e0321f44 UX: match mention styling with username styling on top of post 2016-01-31 10:39:05 +11:00
cpradio
f9f5c5e66b Remove outline: 0 from the topic-footer-buttons, so focus is visible 2016-01-30 18:29:36 -05:00
Sam Saffron
6a13cc1c22 UX: tweak mention color to match username color in post header. 2016-01-31 10:02:21 +11:00
Régis Hanol
96380bfd38 FIX: only create 1 email_log when an email is sent 2016-01-29 16:49:49 +01:00
Régis Hanol
378b7f964c Revert "FEATURE (WIP): add max-width and center email notifications" 2016-01-29 11:13:59 +01:00
Guo Xiang Tan
350f1685e5 UX: Hashtag color for dark theme. 2016-01-29 17:28:41 +08:00
Guo Xiang Tan
e8c5127865 Convert to link as long as a valid link is received. 2016-01-29 13:31:11 +08:00
Guo Xiang Tan
90100378b8 Extract category hashtag autocomplete into a resuable function. 2016-01-29 10:55:29 +08:00
Jeff Atwood
6d6d8842d2 make mentions color less black 2016-01-28 11:41:09 -08:00
Arpit Jalan
26bba1f481 UX: preserve localization in digest email 2016-01-28 23:38:07 +05:30
Régis Hanol
d51019ee53 FIX: *always* create an EmailLog whenever we run the UserEmail job
There were actually 2 bugs:

1/ Calling '.try(:key)' on a hash doesn't work. So EmailLogs were never associated to a user.

2/ Turns out that we update the 'user.last_emailed_at' whenever we create an EmailLog (in the 'after_create' callback).
So we need to always create an EmailLog (whenever the email is sent or skipped).
2016-01-28 19:01:35 +01:00
Arpit Jalan
90d41a994a universal date format in digest email 2016-01-28 23:15:32 +05:30
Robin Ward
617dc42cd9 Merge pull request #3975 from techAPJ/category-user
FIX: changing topic from one watched category to another watched category makes topic 'new' again
2016-01-28 10:53:29 -05:00
Régis Hanol
b5bc43023d Merge pull request #3980 from startsat60/master
added plugin outlet under the header content div
2016-01-28 10:40:14 +01:00
Régis Hanol
5c52beeaf2 Merge pull request #3981 from gschlager/uncategorized_description
Replace uncategorized_description setting with translation
2016-01-28 10:36:10 +01:00
Régis Hanol
9832bb4103 Merge pull request #3969 from scossar/email-layout
FEATURE (WIP): add max-width and center email notifications
2016-01-28 10:34:43 +01:00
Emanuele Tonello
6589fe73d8 moved outlet outside of the weap container 2016-01-28 15:27:28 +10:00
scossar
77167f12ad move styles to Styles 2016-01-27 19:07:21 -08:00
Sam Saffron
b25e505fb7 SECURITY: user summary could show topic links you have no permissions to 2016-01-28 11:12:12 +11:00
Gerhard Schlager
f4f87921c2 Replace uncategorized_description setting with translation 2016-01-28 00:26:25 +01:00
scossar
3f09ec2aca add layout for notifications 2016-01-27 11:27:32 -08:00
Sam
5ed21e8767 filter out archived correctly 2016-01-28 00:14:26 +11:00
Sam
b75353c26f correct specs 2016-01-27 23:40:45 +11:00
Sam
50a63a491c don't alert for inbox count of 0 2016-01-27 23:13:37 +11:00
Sam Saffron
bf650de7be FEATURE: change group default tracking level to tracking (database changes) 2016-01-27 21:56:25 +11:00
Sam Saffron
a764cc3a42 FEATURE: by default users track a group (as opposed to watch)
FEATURE: a rollup counting number of messages in the group inbox to tracking users
2016-01-27 21:38:33 +11:00
Arpit Jalan
74f22f95da FEATURE: log admin/moderator grant/revoke action 2016-01-27 15:39:04 +05:30
Emanuele Tonello
938992e9a0 added plugin outlet under the header content div 2016-01-27 16:12:43 +10:00
Sam
1bb485fca5 FIX: when a user got multiple replies to a topic, emails were missing 2016-01-27 12:20:08 +11:00
Jeff Atwood
12b85b9ef9 CSS tweak to top expanded in-reply-to 2016-01-26 17:03:23 -08:00
Gerhard Schlager
1368e2182a UX: Distinguish between noun and verb for "Archive" 2016-01-26 22:41:49 +01:00
Arpit Jalan
5b8817cc70 Merge pull request #3807 from riking/patch-8
Add styling & assets for google docs placeholder oneboxes
2016-01-26 14:37:57 +05:30
Arpit Jalan
3ed703b856 FIX: new user summary page was broken 2016-01-26 03:02:16 +05:30
Arpit Jalan
d0719aed24 FIX: changing topic from one watched category to another watched category makes topic 'new' again 2016-01-26 01:28:01 +05:30
Arpit Jalan
23c1c5ef19 UX: change glyph when inviting existing user to a topic 2016-01-25 13:10:51 +05:30
Sam
403f766546 UX: improve styling of messages and mobile view of messages 2016-01-24 18:11:49 +11:00
Sam
d0ee32f3ce FIX: correct counts on user summary 2016-01-24 16:39:01 +11:00
Sam
4b8e12d138 FIX: link to filtered down list of badges from summary
FEATURE: pick featured badges in summary page
2016-01-24 15:51:30 +11:00
Arpit Jalan
0064927077 FIX: do not allow new email to be duplicate
FIX: return proper error message when email already exists
2016-01-23 13:42:53 +05:30
Neil Lalonde
685ba1eb7f FEATURE: blocked users can send and reply to private messages from staff 2016-01-22 12:54:24 -05:00
Sam
9569235d76 correct path 2016-01-22 07:55:07 +11:00
Guo Xiang Tan
fc83525a2b FIX: Missing tag in CSS. 2016-01-21 20:39:48 +08:00
Sam
7c5a448f63 PERF: remove 10-20ms of work from every page view
<%  s=Time.now;

main_app.categories_path
main_app.guidelines_path
main_app.tos_path
main_app.privacy_path

p (Time.now-s)*1000%>

Returns 10-20ms consistently on i7-4770k, on shared hosts the cost
could easily reach 40ms

This code simply calculates the strings

/categories
/guidelines
/tos
/privacy

It is ludicrous to spend this enormous amount of work just to calculate
4 strings.

I do not know if this is something specific about Discourse or a bug in
Rails (I tried without the main_app prefix and got similar results),
regardless we can got to avoid these _path APIs for now

Discovered this when running a flamegraph on our home page.
2016-01-21 22:43:56 +11:00
Régis Hanol
66f9504632 FIX: remove green background for wiki (this can be re-added via a customization if needed) 2016-01-21 11:46:53 +01:00
Arpit Jalan
590adb5899 Merge pull request #3968 from techAPJ/top-topics
FEATURE: make top criteria formula multipliers controlled by site setting
2016-01-21 14:02:26 +05:30
Arpit Jalan
1cee914565 FEATURE: make top criteria formula multipliers controlled by site
setting
2016-01-21 10:30:06 +05:30
Guo Xiang Tan
a2857d68bb Make eslint happy. 2016-01-21 12:31:50 +08:00
Guo Xiang Tan
bd86e88b05 UX: Remove category hashtag decoration. 2016-01-21 12:27:52 +08:00
Régis Hanol
c79a8e836e FIX: date picker on mobile
UPDATE pickaday.js to latest version
2016-01-20 21:06:41 +01:00
Régis Hanol
74b5d063f9 FIX: enabling suppress_from_homepage should only remove the category from the homepage 2016-01-20 17:55:58 +01:00
Régis Hanol
a601d4b4ba Merge pull request #3954 from rubo77/patch-5
save height on small screens
2016-01-20 16:29:09 +01:00
Régis Hanol
fc3bedaaed Merge pull request #3921 from gschlager/locale-sk
Add Slovak locale
2016-01-20 15:38:48 +01:00
Régis Hanol
c88093eecb Merge pull request #3920 from tgxworld/fix_onebox_emoji
FIX: Emoji in Discourse onebox is wrapped in square brackets.
2016-01-20 15:38:12 +01:00
Régis Hanol
c2c01cdb5d FIX: username suggester to account for the more relaxed username rules (closes #3907) 2016-01-20 15:37:34 +01:00
Régis Hanol
a44fb0cb15 Merge pull request #3799 from riking/patch-6
FEATURE: Make it easy to override the home logo
2016-01-20 14:47:21 +01:00
Régis Hanol
0ba4bcb2ea Merge pull request #3934 from gschlager/badges
UX: Show translated badge names and badge groupings
2016-01-20 14:42:30 +01:00
Régis Hanol
f61537bc16 Merge pull request #3952 from gdpelican/unsubscribe-via-email
Unsubscribe via email
2016-01-20 14:38:14 +01:00
Arpit Jalan
13f5151ced FIX: refresh admin report was broken 2016-01-20 17:41:21 +05:30
James Kiesel
c7283751a3 Unsubscribe via email 2016-01-20 22:25:25 +13:00
Guo Xiang Tan
fa794ef59d FIX: Deleting characters on category hashtag was not triggering autocomplete. 2016-01-20 17:18:04 +08:00
Guo Xiang Tan
55352eeb1b FIX: Make eslint happy. 2016-01-20 12:51:54 +08:00
Guo Xiang Tan
c6697e2c14 Prefix decorate category badges with '#'. 2016-01-20 12:48:00 +08:00
Guo Xiang Tan
9652c3df4f FIX: Don't track category-badges links. 2016-01-20 12:48:00 +08:00
Sam Saffron
7303f8f309 FEATURE: first pass at user summary page 2016-01-20 15:14:25 +11:00
Neil Lalonde
9ad226aaa8 FEATURE: add email query param to login, signup, and password-reset URLs to prefill form 2016-01-19 16:53:46 -05:00
Régis Hanol
11ea16a91a FIX: localize S3 region names 2016-01-19 17:14:45 +01:00
Régis Hanol
5018a8033d FIX: add link to user profile for staged users 2016-01-19 16:41:07 +01:00
Sam
d18085c57d Merge pull request #3962 from scossar/category-dropdown-badge-wrapper-width
FIX: category-dropdown-menu badge-wrapper width
2016-01-19 19:54:43 +11:00
Régis Hanol
522e0dc9ca Merge pull request #3964 from keepcosmos/add-s3-region
Add new s3 region
2016-01-19 09:16:48 +01:00
Sam
665fc44741 FIX: message_archived? not set correctly for groups 2016-01-19 18:35:46 +11:00
Guo Xiang Tan
843f93594f UX: Smaller margins for category badges. 2016-01-19 13:45:18 +08:00
Guo Xiang Tan
4a7f560a35 FEATURE: Decorate category hashtag links. 2016-01-19 10:58:15 +08:00
Guo Xiang Tan
0812807a53 FIX: Use declared constant. 2016-01-19 10:58:15 +08:00
Régis Hanol
61cc776fdd FIX: only send email notifications for regular and whisper type of posts 2016-01-19 01:39:57 +01:00
Régis Hanol
3083657358 FEATURE: better email in support
FEATURE: new incoming_email model
FEATURE: infinite scrolling in emails admin
FEATURE: new 'emails:import' rake task
2016-01-19 00:57:55 +01:00
Régis Hanol
8b0ffd9a88 don't bother iterating over disabled badges 2016-01-18 21:41:12 +01:00
Robin Ward
57c3d65777 Change d-editor to use _ instead of * for italics. 2016-01-18 14:54:54 -05:00
Arpit Jalan
cf1bd35fc6 FIX: while changing site text, old and new values can be nil 2016-01-18 20:56:14 +05:30
keepcosmos
c53b4ae66d add s3 region 2016-01-18 22:50:15 +09:00
Sam
e6c1f1db52 FEATURE: link to filtered badge list from notification
When notified on a badge link to the badge page filtered on username
2016-01-18 18:20:16 +11:00
Sam
ca3e2b4da3 FEATURE: you can not drill down and see why you have badges
Clicking on badges filters down the list to a particular user.
2016-01-18 17:59:20 +11:00
Guo Xiang Tan
a055c37939 Merge pull request #3956 from tgxworld/fix_clashing_slug
FIX: Clashing category slug.
2016-01-18 10:15:13 +08:00
scossar
08801b835c put avatar in nested table 2016-01-17 12:36:15 -08:00
scossar
02c3884661 box-sizing border box 2016-01-17 11:46:37 -08:00
Arpit Jalan
4e269368fc Merge pull request #3960 from techAPJ/ux
UX: set max-width for topic list
2016-01-16 19:16:29 +05:30
Arpit Jalan
380764dc92 FIX: validate email when changing via user preferences page 2016-01-16 10:50:49 +05:30
Neil Lalonde
1fb3c2cee6 make top period chooser styled more like the heading 2016-01-15 17:55:00 -05:00
Neil Lalonde
89be23a5d4 FEATURE: show date ranges in top period chooser 2016-01-15 17:45:00 -05:00
Robin Ward
7b755c3280 FIX: Precompiler should apply get magic too 2016-01-15 14:26:10 -05:00
Robin Ward
4bbbdd8dc4 SECURITY: Upgrade Ember to fix CVE-2015-7565. Also upgrade Handlebars 2016-01-15 13:57:45 -05:00
Régis Hanol
825a01cec3 fix the build 2016-01-15 12:34:28 +01:00
Régis Hanol
c9c6b09f36 FIX: allow staff members to edit staged users preferences 2016-01-15 12:16:00 +01:00
Neil Lalonde
1aa68e085e don't hide all a user's posts when staff manually blocks them 2016-01-14 15:20:26 -05:00
Arpit Jalan
6aa376576f UX: set max-width for topic list 2016-01-15 01:42:09 +05:30
Neil Lalonde
b8299a2710 log when staff blocks/unblocks someone 2016-01-14 15:05:11 -05:00
Neil Lalonde
12790d8dcc FEATURE: staff can block users, which prevents them from creating topics and replies 2016-01-14 14:42:06 -05:00
Arpit Jalan
0dec98f50a FIX: CDN URL should start with protocol 2016-01-14 18:31:23 +05:30
Arpit Jalan
d2c297955a FIX: use CDN URL for audio/video uploads 2016-01-14 17:44:22 +05:30
Robin Ward
166c56ee0d Merge pull request #3958 from halfstrik/master
FIX: Incorrect subfolder authors urls when embedding
2016-01-13 10:20:41 -05:00
Régis Hanol
50408bc7a1 Merge pull request #3957 from tgxworld/allow_opts_to_datepicker
Allow date-picker component to be extended with custom options.
2016-01-13 15:51:34 +01:00
Guo Xiang Tan
a362ad9407 FIX: Emoji in Discourse onebox is wrapped in square brackets. 2016-01-13 19:00:11 +08:00
Guo Xiang Tan
4f9eb0fc67 Allow date-picker component to be extended with custom options. 2016-01-13 17:33:37 +08:00
strikki
cbd2fbf9a8 FIX: Incorrect subfolder authors urls when embedding 2016-01-13 12:24:03 +03:00
Régis Hanol
737c606710 FIX: 'cancel_scheduled_job' wasn't working due to sidekiq upgrade 2016-01-13 09:08:26 +01:00
Guo Xiang Tan
c60e360c90 FIX: Clashing category slug. 2016-01-13 15:32:29 +08:00
Arpit Jalan
68a69c213c UX: handle long words in topic title 2016-01-13 12:11:02 +05:30
Arpit Jalan
e676974f16 Merge pull request #3953 from techAPJ/wiki
FEATURE: allow users to wikify their own posts based on trust level
2016-01-13 09:53:33 +05:30
Sam Saffron
f5c2ce8141 FIX: download my post button was broken 2016-01-13 14:37:58 +11:00
Robin Ward
1f8586168b FIX: Incorrect subfolder urls when embedding 2016-01-12 12:38:49 -05:00
Régis Hanol
e2744fc19f FIX: adding the 'contains_messages' column back 2016-01-12 12:06:51 +01:00
Régis Hanol
8049dfdfda CLEANUP: remove 'contains_messages' leftover 💩 2016-01-12 11:29:26 +01:00
Régis Hanol
96aa5b865f FIX: mentions regex server-side (ie. don't count email addresses) 2016-01-12 09:53:09 +01:00
Sam
65e808b26d FEATURE: go to inbox after archiving a message 2016-01-12 15:49:05 +11:00
Sam
06b5798fb9 fix activity pending route, hidden for now 2016-01-12 15:48:44 +11:00