224 Commits

Author SHA1 Message Date
Jarek Radosz
365f558bda
DEV: Update ember-resolver () 2022-07-11 22:52:01 +02:00
Jarek Radosz
006de01943
DEV: Update ember-cli-handlebars () 2022-07-11 22:25:40 +02:00
Jarek Radosz
c3fd91670e
DEV: Update linting setup and fix issues ()
Re-lands  and 

* Update eslint-config-discourse
* Update linting workflow
* Prettier-ignore stuff
* Update template-lint config
* Auto-fix template issues
* Fix various template issues
  Mostly incorrect attributes and unused templates
* Prettier js files
* Fix template auto-fix regressions
* Small css tweak

Co-authored-by: Peter Wagenet <peter.wagenet@gmail.com>
2022-07-06 10:37:54 +02:00
Peter Wagenet
371bbadb92
No implicit this codemod ()
* Run no-implicit-this codemod for app templates
* Run tagless-ember-components-codemod for plugins
* Turn on no-implicit-this lint
2022-07-05 19:41:31 +02:00
Peter Wagenet
7caaee27cc
DEV: Generate template backing classes for app ()
```sh
npx ember-holy-futuristic-template-namespacing-batman-codemod ensure-template-only-has-backing-class
```

We would like to colocate templates but, when no backing class exists, colocated templates extend `templateOnly` instead of `Ember.Component`. Generating the backing class helps avoid any behavioral changes.

We can also run the `tagless-ember-components-codemod` to put the tags into the templates at which point we could convert these back to template-only components.
2022-07-04 01:27:29 +02:00
Jarek Radosz
16ea7ab248
DEV: Run angle-brackets codemod ()
Co-authored-by: Peter Wagenet <peter.wagenet@gmail.com>
2022-06-30 12:30:50 +02:00
Jarek Radosz
39a025c7af
DEV: Allow newer versions of node ()
It should now properly work with 18.x, so we should start moving into direction of it being the default.
2022-06-28 20:52:31 +02:00
Jarek Radosz
4821d44c3c
DEV: Update webpack () 2022-06-28 14:39:09 +02:00
Jarek Radosz
f505221a9c
DEV: Update ember-cli-terser () 2022-06-27 18:13:46 +02:00
Jarek Radosz
d1d6868325
DEV: Update xss.js ()
* DEV: Update xss.js

* Fix our hack
2022-06-24 10:28:05 +08:00
Jarek Radosz
f27dddd405
DEV: Make addons buildable on their own () 2022-06-23 22:19:54 +02:00
Jarek Radosz
16550537d0
DEV: Drop ember-maybe-import-regenerator ()
I believe it's no longer needed on the browsers we support
2022-06-23 15:20:10 +02:00
Jarek Radosz
3cb67fcb6c
DEV: Update ember-cli-htmlbars () 2022-06-23 14:36:50 +02:00
Jarek Radosz
56d3bd5bdd
DEV: Update @glimmer/component () 2022-06-23 13:35:42 +02:00
Jarek Radosz
b09cce6897
DEV: Update ember-source-channel-url () 2022-06-22 00:12:43 +02:00
Jarek Radosz
06feeed187
DEV: Update @ember/optional-features () 2022-06-22 00:12:33 +02:00
Jarek Radosz
216663effa
DEV: Update ember-cli-dependency-checker () 2022-06-22 00:12:24 +02:00
Jarek Radosz
b50056a9f3
DEV: Update ember-cli-inject-live-reload () 2022-06-22 00:12:15 +02:00
Jarek Radosz
9cb9d1105e
DEV: Update ember-auto-import () 2022-06-21 22:06:41 +02:00
Jarek Radosz
fcb4e5a1a1
DEV: Make wizard an ember addon ()
Co-authored-by: David Taylor <david@taylorhq.com>
2022-06-17 14:50:21 +02:00
Jarek Radosz
79f5a7750c
DEV: Remove unused wizard code ()
`theme-preview` component and `colorsId`/`fontId` usage.
2022-06-06 21:01:47 +02:00
Jarek Radosz
54e42b124a
FIX: Restore automatic style preview in wizard ()
Updating the homepage/style preview regressed in .
2022-06-06 21:01:34 +02:00
Jarek Radosz
8a58ce6578
DEV: Use @action decorator in wizard () 2022-06-04 19:19:49 +02:00
Jarek Radosz
f4b9d4e285
FIX: Don't throw errors on wizard dropdowns () 2022-06-04 18:04:00 +02:00
Alan Guo Xiang Tan
072faa08bb DEV: Reenable wizard test after fixing auto start for wizard qunit tests
`run-qunit.js` does not expect QUnit tests to start automatically but
our wizard QUnit setup did not respect the `qunit_disable_auto_start`
URL param. Hence, tests would start running automatically and when a
subsequent `QUnit.start()` function call is made, we ended up getting a
`QUnit.start cannot be called inside a test context.` error.

This error can be consistently reproduced in the `discourse:discourse_test` container but not in
the local development environment. I do not know why and did not feel
like it is important at this point in time to know why.
2022-05-25 15:12:27 +08:00
CommanderRoot
86a783b3ad
DEV: Replace deprecated String.prototype.substr() ()
String.prototype.substr() is deprecated so we replace it with String.prototype.slice() which works similarily but isn't deprecated.

Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
Co-authored-by: Jarek Radosz <jradosz@gmail.com>
2022-04-01 17:35:17 +02:00
Jarek Radosz
99b2cfe26e
DEV: Disallow Ember global usage ()
…and sprinkle `// eslint-disable-next-line no-undef` throughout the code where is unavoidable for now
2022-03-09 17:54:07 +01:00
Jarek Radosz
d5be02dac5
DEV: Bump eslint-config-discourse () 2022-03-06 18:15:15 +01:00
Penar Musaraj
d9c511f734
DEV: Refactor animation for invalid inputs in wizard () 2021-12-16 17:17:36 -05:00
Martin Brennan
18a209bd0d
DEV: Use Uppy in wizard-field-image uploads ()
We cannot use any of the uppy mixins or core code, because
the code there is not shared with the wizard, and to move
it all to discourse-common would be a task almost equal
difficulty to taking the ring to Mordor.

Therefore, we can just use the uppy vendor libraries in the
wizard, and do a quick-n-dirty version of the uppy upload
code for the wizard-field-image uploader.
2021-12-13 15:23:44 +10:00
Jarek Radosz
bdd2c888b0
DEV: Avoid using globals () 2021-11-13 13:10:13 +01:00
Jarek Radosz
9ca93f57cc
DEV: Remove jQuery global usage where possible () 2021-11-12 19:23:20 +01:00
Jarek Radosz
d162229758
DEV: Replace equal() with strictEqual() () 2021-11-08 10:26:28 +01:00
Joffrey JAFFEUX
cc68eb825b
DEV: drops jquery usage from ajax wizards lib () 2021-10-25 10:24:53 +02:00
Joffrey JAFFEUX
c2d4638ee1
DEV: drops jquery usage from wizard-canvas () 2021-10-20 14:42:06 +02:00
Penar Musaraj
85b8fea262
UX: Add Styling step to wizard ()
Refactors three wizard steps (colors, fonts, homepage style) into one new step called Styling.
2021-08-25 17:10:12 -04:00
Jarek Radosz
e68c1d5ba5
DEV: Use key over the deprecated keyCode ()
Makes the code a bit more readable. Inspired by https://github.com/emberjs/ember.js/pull/19185
2021-08-09 11:41:36 +02:00
Joffrey JAFFEUX
32d0467881
DEV: avoids using document.write ()
It doesn’t provide much than just avoiding some logs in tests. I didn't change test_starter as it's going to be removed at some point.
2021-07-27 14:42:21 +02:00
Joffrey JAFFEUX
519528daa2
FIX: allows to use icon-picker in wizard ()
- inlines dasherize helper in sk
- uses an ajax helper to load wizard's ajax lib when in wizard
- amends wizard's ajax lib to work with string as first arg
- disabled loading spinner in wizard as it's not available
2021-07-21 13:49:21 +02:00
Penar Musaraj
7b5f31ff04
FIX: Wizard locale change wasn't applying to some elements () 2021-04-30 12:14:16 -04:00
Osama Sayegh
4f88f2eb15
FEATURE: Allow theme tests to be run in production (take 2) ()
This commit allows site admins to run theme tests in production via a new `/theme-qunit` route. When you visit `/theme-qunit`, you'll see a list of the themes/components installed on your site that have tests, and from there you can select a theme or component that you run its tests.

We also have a new rake task `themes:install_and_test` that can be used to install a list of themes/components on a temporary database and run the tests of the themes/components that are installed. This rake task can be useful when upgrading/deploying a Discourse instance to make sure that the installed themes/components are compatible with the new Discourse version being deployed, and if the tests fail you can abort the build/deploy process so you don't end up with a broken site.
2021-04-28 23:12:08 +03:00
Osama Sayegh
a169dc6832
Revert "FEATURE: Allow theme tests to be run in production ()" ()
This reverts commit 7217dcb67a59f9c47d655455b60b4e1d8dc30f28.

https://meta.discourse.org/t/failed-to-bootstrap-due-to-out-of-memory-killer/188141/18?u=osama

Precompiling test_helper.js is so expensive that it can make bootstrap
fail on servers with limited resources (2GB RAM). We will find another
way that doesn't require much resources.
2021-04-26 23:05:58 +03:00
Osama Sayegh
7217dcb67a
FEATURE: Allow theme tests to be run in production ()
This commit allows site admins to run theme tests in production via a new `/theme-qunit` route. When you visit `/theme-qunit`, you'll see a list of the themes/components installed on your site that have tests, and from there you can select a theme or component that you run its tests.

We also have a new rake task `themes:install_and_test` that can be used to install a list of themes/components on a temporary database and run the tests of the themes/components that are installed. This rake task can be useful when upgrading/deploying a Discourse instance to make sure that the installed themes/components are compatible with the new Discourse version being deployed, and if the tests fail you can abort the build/deploy process so you don't end up with a broken site.
2021-04-26 12:56:45 +03:00
Joffrey JAFFEUX
c6a1042950
DEV: prettier 2.2.1 () 2021-01-27 12:39:20 +01:00
Gerhard Schlager
3b2f6e129a
FEATURE: Add English (UK) as locale ()
* "English" gets renamed into "English (US)"
* "English (UK)" replaces "English"

@discourse-translator-bot keep_translations_and_approvals
2021-01-20 21:32:22 +01:00
Roman Rizzi
bbe5d8d5cf
DEV: Sort imports alphabetically () 2020-12-01 15:31:26 -03:00
Roman Rizzi
1c2358ba16
DEV: Tidy up imports. ()
Only allow one import definition per file and add a new eslint rule to enforce it.
2020-11-27 11:30:16 -03:00
Robin Ward
3394d994e9 FIX: Tests were using jQuery selectors
For the most part `querySelectorAll` will work with jQuery selectors,
but the big exception is `:eq(0)` and similar. Those needed to be
replaced.
2020-11-23 11:36:07 -05:00
Robin Ward
0d0ae5e67f REFACTOR: Add support for currentRouteName in test helpers
This replaces the global `currentPath`
2020-11-13 09:31:09 -05:00
Penar Musaraj
0b7f43fba8
REFACTOR: Remove SweetAlert dependency () 2020-11-10 11:31:54 -05:00