discourse

github-mirror/discourse

Fork 0

mirror of https://github.com/discourse/discourse.git synced 2024-11-30 07:33:43 +08:00

Commit Graph

Author SHA1 Message Date

Author	SHA1	Message	Date
Alan Guo Xiang Tan	68a3f7783e	DEV: Remove the use of `Capybara::Session#quit` (#24978 ) Why this change? This is what `Capybara::Session#quit` does: ``` def quit @driver.quit if @driver.respond_to? :quit @document = @driver = nil @touched = false @server&.reset_error! end ``` One notable thing is that it resets server errors which means that any server errors encountered by a session is cleared. That is not what we want since it hides errors even though `Capybara.raise_server_errors` has been set to `true`.	2023-12-20 13:20:14 +08:00
Joffrey JAFFEUX	08df8fc1d1	UX: enhances chat copy features (#23770 ) - Allows to copy quotes from mobile - Allows to copy text of a message from mobile - Allows to select messages by clicking on it when selection has started Note this commit is also now using toasts to show a confirmation of copy, and refactors system specs helpers concerning secondary actions. <!-- NOTE: All pull requests should have tests (rspec in Ruby, qunit in JavaScript). If your code does not include test coverage, please include an explanation of why it was omitted. -->	2023-10-04 16:14:37 +02:00
Joffrey JAFFEUX	32e32f43b5	FIX: prevents user to restore message deleted by staff (#22571 ) It could only occur on message created by the user itself and deleted while the user was looking at the channel. It more generally fix the trash service which was not correctly setting the author of the delete.	2023-07-13 10:16:15 +02:00

Alan Guo Xiang Tan

68a3f7783e

DEV: Remove the use of Capybara::Session#quit (#24978 )

Why this change?

This is what `Capybara::Session#quit` does:

```
    def quit
      @driver.quit if @driver.respond_to? :quit
      @document = @driver = nil
      @touched = false
      @server&.reset_error!
    end
```

One notable thing is that it resets server errors which means that any
server errors encountered by a session is cleared. That is not what we
want since it hides errors even though `Capybara.raise_server_errors`
has been set to `true`.

2023-12-20 13:20:14 +08:00

Joffrey JAFFEUX

08df8fc1d1

UX: enhances chat copy features (#23770 )

- Allows to copy quotes from mobile
- Allows to copy text of a message from mobile
- Allows to select messages by clicking on it when selection has started

Note this commit is also now using toasts to show a confirmation of copy, and refactors system specs helpers concerning secondary actions.

<!-- NOTE: All pull requests should have tests (rspec in Ruby, qunit in JavaScript). If your code does not include test coverage, please include an explanation of why it was omitted. -->

2023-10-04 16:14:37 +02:00

Joffrey JAFFEUX

32e32f43b5

FIX: prevents user to restore message deleted by staff (#22571 )

It could only occur on message created by the user itself and deleted while the user was looking at the channel.

It more generally fix the trash service which was not correctly setting the author of the delete.

2023-07-13 10:16:15 +02:00

3 Commits