Osama Sayegh
118f7869bb
FEATURE: Add bulk destroy to admin users list ( #29744 )
...
This commit introduces a new feature that allows staff to bulk select and delete users directly from the users list at `/admin/users/list`. The main use-case for this feature is make deleting spammers easier when a site is under a large spam attack.
Internal topic: t/140321.
2024-11-25 11:13:35 +03:00
Osama Sayegh
eaa3f813c1
FIX: Don't secure the about banner image ( #29889 )
...
Uploads that are linked to site settings shouldn't be flagged as secure in login-required sites that enable secure uploads. However, in order for site setting uploads to not be marked secured, the frontend uploader has to include 2 params in the upload request: `for_site_setting: true` and `type: "site_setting"`.
Since these 2 params are semantically identical, we want the `type: "site_setting"` param alone to make the upload correctly treated as a site setting upload. To achieve that, we need to include the `site_setting` type in the public types list because the `for_site_setting` param has the same effect — it marks the upload as a public type.
b138eaf9e5/lib/upload_security.rb (L128-L131)
2024-11-25 11:12:00 +03:00
Joffrey JAFFEUX
0c68b14534
FIX: correctly link to settings in full page ( #29913 )
...
There's already a test for this behavior and the CI is currently broken because of it.
2024-11-25 08:21:41 +01:00
Ted Johansson
fd39753e58
DEV: Ignore normalize_emails when using SSO ( #29890 )
...
We recently tried to default the normalize_emails site setting to true to avoid spam. What this does is it considers e-mails the same regardless of plus addressing, e.g. bob+1@mail.com == bob+2@mail.com . This caused some problems for SSO users.
This PR makes it so that DiscourseConnect never normalizes e-mails.
2024-11-25 11:55:27 +08:00
Ted Johansson
88af23e1ca
DEV: Modernize admin user fields ( #29843 )
...
This PR modernizes the user fields area of the admin UI. It is largely based on the work on the emoji section.
2024-11-25 11:54:43 +08:00
Joffrey JAFFEUX
66409fa8b4
UX: improved collapsed drawer state/interactions ( #29850 )
...
- Clicking the channel title of a collapsed drawer will only open the drawer, and not open settings
- Remove the back button when the drawer is collapsed
- Uses same icon for toggling on chat that composer
- add max-width to minimised drawer + add hover effect
---------
Co-authored-by: chapoi <101828855+chapoi@users.noreply.github.com>
2024-11-25 03:39:03 +01:00
dependabot[bot]
b607f2d4a5
Build(deps-dev): Bump typescript from 5.6.3 to 5.7.2 ( #29906 )
Linting / run (push) Has been cancelled
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (annotations, core) (push) Has been cancelled
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (backend, core) (push) Has been cancelled
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (backend, plugins) (push) Has been cancelled
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (frontend, plugins) (push) Has been cancelled
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (frontend, themes) (push) Has been cancelled
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, chat) (push) Has been cancelled
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, core) (push) Has been cancelled
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, plugins) (push) Has been cancelled
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, themes) (push) Has been cancelled
Tests / core frontend (${{ matrix.browser }}) (Chrome) (push) Has been cancelled
Tests / core frontend (${{ matrix.browser }}) (Firefox ESR) (push) Has been cancelled
Tests / core frontend (${{ matrix.browser }}) (Firefox Evergreen) (push) Has been cancelled
Licenses / run (push) Has been cancelled
Migration Tests / Tests with Ruby ${{ matrix.ruby }} (3.3) (push) Has been cancelled
Tests / merge (push) Has been cancelled
2024-11-25 00:36:34 +01:00
dependabot[bot]
502b2a6ef2
Build(deps): Bump puma from 6.4.3 to 6.5.0 ( #29908 )
2024-11-25 00:36:10 +01:00
dependabot[bot]
62768d11d0
Build(deps-dev): Bump mocha from 2.5.0 to 2.6.0 ( #29907 )
2024-11-25 00:35:36 +01:00
dependabot[bot]
1396dfabba
Build(deps-dev): Bump @swc/core from 1.9.2 to 1.9.3 ( #29905 )
...
Bumps [@swc/core](https://github.com/swc-project/swc ) from 1.9.2 to 1.9.3.
- [Release notes](https://github.com/swc-project/swc/releases )
- [Changelog](https://github.com/swc-project/swc/blob/main/CHANGELOG.md )
- [Commits](https://github.com/swc-project/swc/compare/v1.9.2...v1.9.3 )
---
updated-dependencies:
- dependency-name: "@swc/core"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-24 22:45:28 +01:00
dependabot[bot]
8b24a0128a
Build(deps-dev): Bump lint-to-the-future from 2.4.0 to 2.4.1 ( #29903 )
...
Bumps [lint-to-the-future](https://github.com/mansona/lint-to-the-future ) from 2.4.0 to 2.4.1.
- [Release notes](https://github.com/mansona/lint-to-the-future/releases )
- [Changelog](https://github.com/mansona/lint-to-the-future/blob/main/CHANGELOG.md )
- [Commits](https://github.com/mansona/lint-to-the-future/commits )
---
updated-dependencies:
- dependency-name: lint-to-the-future
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-24 22:45:12 +01:00
Mark VanLandingham
d880db3b7b
DEV: Apply modifier for topic_view link_counts ( #29883 )
2024-11-22 14:49:39 -06:00
Juan David Martínez Cubillos
08440b0035
DEV: Add tl3_custom_promotions plugin modifier to tl3_promotions.rb ( #29834 )
...
* DEV: Add tl3_custom_promotions plugin modifier to tl3_promotions.rb
* added tests
* added tests for demotions
* changed argument order in test
2024-11-22 15:28:43 -05:00
Gerhard Schlager
0295b4165c
FIX: Permalink.create didn't work as expected anymore ( #29895 )
...
This moves the logic of setting the correct permalink values back into the controller. And it replaces the validation with a simpler one, that always works, even when the model is loaded from the DB.
Follow-up to #29634 which broke import scripts and lots of documentation on Meta.
2024-11-22 21:11:26 +01:00
Jordan Vidrine
44fbf1048c
UX: Multiple codeblocks fixes ( #29898 )
2024-11-22 13:52:23 -06:00
Penar Musaraj
4b23e6d248
DEV: Enable experimental_topics_filter by default ( #29897 )
2024-11-22 12:40:17 -05:00
Penar Musaraj
a97ac905d1
Revert "UX: Codeblocks edits ( #29893 )" ( #29896 )
...
This reverts commit 667a09b159
2024-11-22 12:09:40 -05:00
Joffrey JAFFEUX
f24d2b926f
FIX: makes tags reactive with docked header ( #29894 )
...
No test as it's complicated to have a very simple test for this and I don't want to write a system spec for such a very specific thing.
2024-11-22 18:00:11 +01:00
Jordan Vidrine
667a09b159
UX: Codeblocks edits ( #29893 )
2024-11-22 09:05:48 -06:00
Loïc Guitaut
f87333c4e0
DEV: Refactor DiscourseAutomation::DestroyAutomation a bit
...
Small followup to 932bd6b
2024-11-22 16:05:31 +01:00
Jarek Radosz
0641d3e4b3
DEV: Improve hbr topic list detection ( #29892 )
...
1. `addRawTemplate` is called too early for deprecation handlers to process its deprecation call, so toggle the hbr flag directly
2. move the deprecation handler to an initializer so that other (non-template) calls are always handled
3. move the debug logging to the handler
2024-11-22 14:28:01 +01:00
Jarek Radosz
b9838d6066
DEV: Fix theme name in this deprecation notices ( #29888 )
...
A followup to 019ba099c8
2024-11-22 10:24:02 +00:00
Régis Hanol
d71016522e
FIX: hide chat button in user card ( #29887 )
...
when the user isn't able to receive DMs (either because they've disabled it or because they're suspended for example).
Internal ref - t/142198
2024-11-22 09:05:58 +01:00
Tobias Eigen
5bf5d13356
UX: Corrected text for notification titles ( #29860 )
...
Improves notification title text from:
Chat quoted -> Quoted in chat
Chat watched thread -> Watched chat thread
2024-11-22 09:37:41 +04:00
Akshay Birajdar
b138eaf9e5
FEATURE: Add Bulk actions to /filter page ( #29420 )
...
- Add bulk actions component on /filter page for both desktop & mobile view.
- Add system specs to assert bulk actions to be available on /filter page.
2024-11-22 11:51:06 +11:00
dependabot[bot]
f162df9ac1
Build(deps): Bump minitest from 5.25.1 to 5.25.2 ( #29886 )
...
Bumps [minitest](https://github.com/minitest/minitest ) from 5.25.1 to 5.25.2.
- [Changelog](https://github.com/minitest/minitest/blob/master/History.rdoc )
- [Commits](https://github.com/minitest/minitest/compare/v5.25.1...v5.25.2 )
---
updated-dependencies:
- dependency-name: minitest
dependency-type: indirect
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-21 23:50:17 +01:00
dependabot[bot]
dd55b5493d
Build(deps-dev): Bump puppeteer-core from 23.8.0 to 23.9.0 ( #29885 )
...
Bumps [puppeteer-core](https://github.com/puppeteer/puppeteer ) from 23.8.0 to 23.9.0.
- [Release notes](https://github.com/puppeteer/puppeteer/releases )
- [Changelog](https://github.com/puppeteer/puppeteer/blob/main/release-please-config.json )
- [Commits](https://github.com/puppeteer/puppeteer/compare/puppeteer-core-v23.8.0...puppeteer-core-v23.9.0 )
---
updated-dependencies:
- dependency-name: puppeteer-core
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-21 23:46:39 +01:00
David Taylor
fe88e2239d
DEV: Improve pnpmfile workspace workaround ( #29881 )
...
Some setups have pnpm installed as `pnpm.cjs`, so the `endsWith` check wasn't working
2024-11-21 22:36:55 +00:00
Bianca Nenciu
250a145361
DEV: Fix undefined variable ( #29876 )
...
Follow up to commit 429cf656e7
2024-11-21 20:23:20 +02:00
Amanda Alves Branquinho
02ad1f9cd5
Dev/add outlet for participant ( #29864 )
...
* DEV: add outlet for topic participant
* format topic participant file
* Update app/assets/javascripts/discourse/app/components/topic-map/topic-participant.gjs
Co-authored-by: Jarek Radosz <jradosz@gmail.com>
---------
Co-authored-by: Jarek Radosz <jradosz@gmail.com>
2024-11-21 14:41:03 -03:00
David Taylor
019ba099c8
DEV: Unsilence this-property-fallback deprecation ( #29855 )
...
This one has the potential to be very noisy, so a special dedupliation handler is introduced.
https://meta.discourse.org/t/337276
2024-11-21 16:35:05 +00:00
Renato Atilio
6e5d4ee492
DEV: refactor composer references on composer-container/-editor ( #29629 )
...
Most of it is removing the ComposerContainer > ComposerEditor indirect references to the composer service, so ComposerEditor now deals with the service directly.
Form template was moved from DEditor to ComposerEditor.
2024-11-21 13:29:12 -03:00
Tobias Eigen
8fd2980685
Update client.en.yml to change "locale" to "language" in a setting description ( #29857 )
...
the only_show_selected_locale setting refers to "selected locale" when the rest of the UI on the page refers to "language", so I changed it to "Only show results in selected language".
2024-11-21 07:47:53 -08:00
Jarek Radosz
2589545623
DEV: Detect hbr topic list customizations ( #29793 )
2024-11-21 16:00:49 +01:00
Gabriel Grubba
db15e11cb9
FEATURE: Add modifier to delete after merge ( #29872 )
...
while it is ok to have the check for if the person can delete a topic, for this feature some times you might want some more flexibility.
Instead of relying on patching this class and method, it would be better to have a modifier that can be decide if the topic should be deleted after the merge.
2024-11-21 11:12:06 -03:00
Joffrey JAFFEUX
0b210e0fc3
FIX: correctly closes search menu on escape ( #29848 )
...
Prior to this fix the menu would not close if a child was in focus, and the search suggestions had a special implementation to handle this. The fix now relies on trapping the keydown escape event on the top dip of the search menu.
2024-11-21 07:39:47 +01:00
Bianca Nenciu
429cf656e7
FIX: Use FinalDestination::HTTP to push notifications ( #29858 )
...
Sometimes `Jobs::PushNotification` gets stuck, probably because of the
network call. This commit replaces `Excon` with `FinalDestination::HTTP`
which is safer.
2024-11-21 14:11:51 +11:00
Ella E.
a0cf8f64f9
UX: Update sidebar invite button to use correct title attribute text ( #29875 )
...
This PR updates the sidebar's Invite button to use the intended text for its title attribute.
2024-11-21 12:22:01 +10:00
chapoi
58edabc2b5
DEV: Dmenu add modifier ( #29846 )
2024-11-21 03:14:46 +01:00
Gary Pendergast
f1bf63f89c
FIX: Tweak the unread channel shortcut key behaviour ( #29874 )
2024-11-21 11:41:02 +11:00
Blake Erickson
acc87202b9
DEV: Fix flaky test with bulk select closing topics ( #29871 )
...
This commit is going to try using the `have_read_post` page object from
`topic_view` instead of the page object for `topic` because it's
implementation has a longer wait time as it uses the ENV variable for
wait time: `Capybara.default_max_wait_time * 2`.
If this works out we should probably remove the duplicated
`have_read_post` page object so that we have a single implementation.
2024-11-20 16:34:44 -07:00
Jordan Vidrine
34e6c8f3dd
UX: Codeblocks experiment merge ( #29870 )
2024-11-20 17:24:41 -06:00
dependabot[bot]
0b96ec26ab
Build(deps-dev): Bump lefthook from 1.8.2 to 1.8.4 ( #29811 )
...
Bumps [lefthook](https://github.com/evilmartians/lefthook ) from 1.8.2 to 1.8.4.
- [Release notes](https://github.com/evilmartians/lefthook/releases )
- [Changelog](https://github.com/evilmartians/lefthook/blob/master/CHANGELOG.md )
- [Commits](https://github.com/evilmartians/lefthook/compare/v1.8.2...v1.8.4 )
---
updated-dependencies:
- dependency-name: lefthook
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-21 00:11:52 +01:00
dependabot[bot]
4f4b4e74c7
Build(deps): Bump ember-resolver from 13.0.2 to 13.1.0 ( #29868 )
...
Bumps [ember-resolver](https://github.com/ember-cli/ember-resolver ) from 13.0.2 to 13.1.0.
- [Release notes](https://github.com/ember-cli/ember-resolver/releases )
- [Changelog](https://github.com/ember-cli/ember-resolver/blob/main/CHANGELOG.md )
- [Commits](https://github.com/ember-cli/ember-resolver/compare/v13.0.2...v13.1.0 )
---
updated-dependencies:
- dependency-name: ember-resolver
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-20 23:39:31 +01:00
Amanda Alves Branquinho
71a8d48d21
DEV: add outlet wrapper for small user list ( #29763 )
...
* DEV: add outlet wrapper for small user list
* DEV: use value transformer to extend small user attrs function
* Update app/assets/javascripts/discourse/app/components/small-user-list.gjs
Co-authored-by: Jarek Radosz <jradosz@gmail.com>
---------
Co-authored-by: Jarek Radosz <jradosz@gmail.com>
2024-11-20 19:22:02 -03:00
dependabot[bot]
b98af3bc53
Build(deps-dev): Bump @discourse/lint-configs from 2.2.0 to 2.2.1 ( #29869 )
...
Bumps [@discourse/lint-configs](https://github.com/discourse/lint-configs ) from 2.2.0 to 2.2.1.
- [Commits](https://github.com/discourse/lint-configs/commits )
---
updated-dependencies:
- dependency-name: "@discourse/lint-configs"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-20 23:19:06 +01:00
Kris
fdfc9284fa
DEV: add order to posters column so it gets a classname ( #29866 )
2024-11-20 17:09:21 -05:00
dependabot[bot]
a8426d9ea7
Build(deps-dev): Bump sqlite3 from 2.2.0 to 2.3.0 ( #29862 )
...
Bumps [sqlite3](https://github.com/sparklemotion/sqlite3-ruby ) from 2.2.0 to 2.3.0.
- [Release notes](https://github.com/sparklemotion/sqlite3-ruby/releases )
- [Changelog](https://github.com/sparklemotion/sqlite3-ruby/blob/main/CHANGELOG.md )
- [Commits](https://github.com/sparklemotion/sqlite3-ruby/compare/v2.2.0...v2.3.0 )
---
updated-dependencies:
- dependency-name: sqlite3
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-20 23:05:08 +01:00
dependabot[bot]
4a00b74e76
Build(deps): Bump mutex_m from 0.2.0 to 0.3.0 ( #29865 )
...
Bumps [mutex_m](https://github.com/ruby/mutex_m ) from 0.2.0 to 0.3.0.
- [Release notes](https://github.com/ruby/mutex_m/releases )
- [Commits](https://github.com/ruby/mutex_m/compare/v0.2.0...v0.3.0 )
---
updated-dependencies:
- dependency-name: mutex_m
dependency-type: indirect
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-20 23:04:47 +01:00
Blake Erickson
1841e72571
DEV: Make sure chat migration is in plugin directory ( #29867 )
...
This migration is for chat so it needs to live in the chat plugin
directory.
Follow up to: 23a7f00524
2024-11-20 14:50:15 -07:00
