github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-30 07:13:44 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
38,152 Commits 214 Branches 500 Tags 960 MiB
6bab2acc9f
Commit Graph

7340 Commits

Author SHA1 Message Date
Guo Xiang Tan
6bab2acc9f
Fix typo. 
Follow up to af52df2d
 2020-07-02 14:23:10 +08:00
Guo Xiang Tan
af52df2d96
DEV: Add hidden site setting for PG search ranking normalization. 2020-07-02 14:11:18 +08:00
Gerhard Schlager
fc8e842773 FIX: Sometimes not all output of psql was logged during restores 
There was a race condition which could prevent Discourse from logging the last couple of lines of output from psql.
 2020-06-30 16:52:50 +02:00
Dan Ungureanu
fe284ffd06
Revert "DEV: Remove useless code (#10130)" 
Some oneboxes still generate empty P tags (video oneboxes).

This reverts commit c299d02287.
 2020-06-29 13:56:28 +03:00
Régis Hanol
860deeb072 FIX: identify slug-less topic urls everywhere 
In 91c89df6, I fixed the onebox to support local topics with a slug-less URL.
This commit fixes all the other spots (search, topic links and user badges) where we look up for a local topic.

Follow-up-to: 91c89df6
 2020-06-29 12:31:20 +02:00
David Taylor
0edffcc47d
FIX: Correct version comparison logic when comparing stable to beta (#10135) 
* FIX: Correct version comparison logic when comparing stable to beta

For example, version 1.3.0 should be considered higher than 1.3.0.beta3. So `Discourse.has_needed_version?('1.3.0', '1.3.0.beta3')` should return true

* Switch to use Gem::Version to compare versions
 2020-06-29 17:52:33 +10:00
Dan Ungureanu
c299d02287
DEV: Remove useless code (#10130) 
protection is not needed and can easily be bypassed with empty divs anyway.
 2020-06-29 17:49:30 +10:00
Blake Erickson
69803599a9 DEV: Refactor seed data filter 
Added a small helper class to for seed data because we need to add the
same filter to multisite:migrate as we have in db:migrate. Having this
filter in both places means we can get rid of the SKIP_SEED flag.
 2020-06-26 14:36:50 -06:00
Guo Xiang Tan
c16ad39f8e
DEV: Run seeds irregardless of post deploy migration flag. 
Follow up to 01937b2d
 2020-06-26 11:04:34 +08:00
Guo Xiang Tan
01937b2de2
Revert "FIX: Seed needs to run before optimizing site icons." 
This reverts commit 715ddf3861.
 2020-06-26 11:03:47 +08:00
Guo Xiang Tan
715ddf3861
FIX: Seed needs to run before optimizing site icons. 2020-06-26 08:58:53 +08:00
Justin DiRose
768bb406ee
DEV: Add knowledge-explorer to official plugin list (#10127) 2020-06-25 14:52:14 -05:00
Blake Erickson
01b6349a67
DEV: Add skip seed flag (#10116) 
* add a flag to skip seed

* only seed when running post deployment migrations
 2020-06-25 10:14:58 -06:00
Sam Saffron
689568c216
FIX: invalid urls should not break store.has_been_uploaded? 
Breaking this method has wide ramification including breaking
search indexing.
 2020-06-25 15:00:15 +10:00
Sam Saffron
3cb41d5429
PERF: stop adding more topics to search when not needed 
The logic of adding additional search results does not seem to be
needed anymore.

It appears to be a relic of an old implementation.

This saves an entire search query for every search made.
 2020-06-25 12:31:12 +10:00
Neil Lalonde
b9174c8e8a
Version bump to v2.6.0.beta1 2020-06-24 14:00:19 -04:00
Régis Hanol
7109d94ee7 FIX: properly invalidate inline oneboxes when rebaking 
When rebaking a post we were invalidating _regular_ oneboxes but not inline oneboxes.

DEV: also renamed 'InlineOneboxer.purge' to 'InlineOneboxer.invalidate' to keep
the API consistent with 'Oneboxer.invalidate'
 2020-06-24 11:54:54 +02:00
Guo Xiang Tan
b28d97b64a
FIX: Bump onebox for twitch video and clips embedding fix. 2020-06-24 11:00:30 +08:00
Régis Hanol
91c89df68a FIX: onebox local topic when using slug-less URL 
When linking to a topic in the same Discourse, we try to onebox the link to show the title
and other various information depending on whether it's a "standard" or "inline" onebox.

However, we were not properly detecting links to topics that had no slugs (eg. https://meta.discourse.org/t/1234).
 2020-06-23 17:18:38 +02:00
Daniel Waterworth
368af327fa DEV: Reduce size of begin-rescue region 
Follow-up-to: e3e7905d9e
 2020-06-23 10:14:09 +01:00
Guo Xiang Tan
84c12d8f3d
DEV: Allow multisite apps to boot with readonly db. 2020-06-23 16:34:25 +08:00
Martin Brennan
e92909aa77
FIX: Use ActionDispatch::Http::ContentDisposition for uploads content-disposition (#10108) 
See https://meta.discourse.org/t/broken-pipe-error-when-uploading-to-a-s3-clone-a-pdf-with-a-name-containing-e-i-etc/155414

When setting content-disposition for attachment, use the ContentDisposition class to format it. This handles filenames with weird characters and localization (accented characters) correctly.
 2020-06-23 17:10:56 +10:00
Guo Xiang Tan
1157d2a0ff
DEV: Print proper summary when errors have been reporter in turbo_rspec 2020-06-23 13:34:58 +08:00
Guo Xiang Tan
e3e7905d9e
FIX: TurboTests::Runner not failing on errors. 2020-06-23 11:45:18 +08:00
Guo Xiang Tan
0384b6d910
FIX: multisite:migrate failing to properly seed data. 2020-06-23 09:10:02 +08:00
Robin Ward
ac9577bcc7 FIX: Don't raise an exception if we can't update the user on demotion 
This is causing issues when purging old users, if they are set up in the
exact condition where they will be demoted into another group, but also
do not have a primary email.
 2020-06-22 15:43:59 -04:00
Dan Ungureanu
2e1efbde52
FIX: Pass local scope variable to inner function 2020-06-22 19:23:59 +03:00
Bianca Nenciu
68f767a557
FEATURE: Check if selectable avatars exist before enabling them (#10032) 2020-06-22 16:58:26 +03:00
Guo Xiang Tan
3370ef188e
FEATURE: Remove deprecated uploads url site settings. 
The site settings have been replaced with direct image upload since
Discourse 2.3.
 2020-06-22 14:32:29 +08:00
Aman Gupta Karmani
8a86705e51
FIX: handle heroku style HTTP_X_REQUEST_START (#10087) 2020-06-19 10:17:24 -04:00
Daniel Waterworth
9cf77372a2 FIX: Guardian#can_remove_allowed_users? shouldn't break for ownerless topics 
A topic can outlive its original author. TopicGuardian should still work
in this situation.
 2020-06-19 10:35:52 +01:00
Gerhard Schlager
2da6faf281 FEATURE: Add before_email_send event 
Plugins can use it to customize the message (e.g. add header) before the email is sent.
 2020-06-18 18:58:51 +02:00
Bernhard Suttner
e31471585a
DEV: allow to have duplicate topic titles if categegory is different (#10034) 
Co-authored-by: Robin Ward <robin.ward@gmail.com>

Co-authored-by: Robin Ward <robin.ward@gmail.com>
 2020-06-18 11:19:47 -04:00
Bianca Nenciu
db1bebddce
FIX: Hide the post history for TL4 (#10065) 2020-06-18 13:27:51 +03:00
Dan Ungureanu
d21a08c284
DEV: Deprecate Category#url_with_id in favor of Category#url (#9972) 2020-06-18 11:32:14 +03:00
Robin Ward
e8756e1a95 FIX: Muted/Ignore should prevent PMs regardless of case sensitivity 2020-06-17 14:26:14 -04:00
David Taylor
e29afa200a
FIX: Cleanup migrations with timestamps in the future 
A future-dated migration was accidently introduced by me in 45c399f0. This was removed in b9762afc, but other migrations had already been generated based on its incorrect date. This commit removes the offending data in the schema_migrations table, and corrects the version in the published_pages migration.

This commit also adds a check to db:migrate which raises an error when invalid migration timestamps are used.
 2020-06-17 15:58:22 +01:00
Guo Xiang Tan
45eb97c202
FIX: Thread safety issues with multisite:migrate and SeedFu. 2020-06-17 16:15:43 +08:00
Guo Xiang Tan
828ceab64b
DEV: Make rubocop happy. 2020-06-17 15:47:05 +08:00
Martin Brennan
e5da2d24e5
FIX: Add attachment content-disposition for all non-image files (#10058) 
This will make it so the original filename is used when downloading all non-image files, bringing S3Store into line with the to_s3 migration and local storage. Video and audio files will still stream correctly in HTML players as well.

See https://meta.discourse.org/t/cannot-download-non-image-media-files-original-filenames-lost-when-uploaded-to-s3/152797 for a lot of extra context.
 2020-06-17 11:16:37 +10:00
Krzysztof Kotlarek
dcb816b548
FIX: add table name to topic view query (#10052) 
When plugin is hooking into TopicView joining other tables, it may fail because `created_at` is potentially available on 2 tables. Therefore we should explicitly define which `created_at` we want.
 2020-06-17 10:40:01 +10:00
Robin Ward
7f8c5cf70b FIX: Allow plugins to provide test directories with transpiled .js 2020-06-16 14:31:01 -04:00
Jarek Radosz
669c940ec3 Revert "DEV: Remove the remaining ENV["TRAVIS"] usage (#10041)" 
This reverts commit 78aff841e3.

See https://review.discourse.org/t/dev-remove-the-remaining-env-travis-usage-10041/12737/4?u=cvx
 2020-06-16 19:42:00 +02:00
Jarek Radosz
78aff841e3
DEV: Remove the remaining ENV["TRAVIS"] usage (#10041) 2020-06-16 17:41:15 +02:00
Gerhard Schlager
859d9b75a7 FIX: Restoring backup from PG12 could fail on PG10 
The `EXECUTE FUNCTION` syntax for `CREATE TRIGGER` statements was introduced in PostgreSQL 11. We need to replace `EXECUTE FUNCTION` with `EXECUTE PROCEDURE` in order to be able to restore backups created with PG12 on PG10.
 2020-06-16 16:04:14 +02:00
Gerhard Schlager
4cff4892e8 Locale checks were disabled by mistake 2020-06-16 16:04:14 +02:00
Dan Ungureanu
84dfaad137
FIX: Fill acting_user field instead of target_user in history 2020-06-16 13:30:58 +03:00
Blake Erickson
a2713578dd DEV: Allow plugins to exclude seed data 
This allows plugins to specify if they would like to filter out any seed
data files from running during migrations.
 2020-06-15 15:30:25 -06:00
Guo Xiang Tan
58e52c0e4f
DEV: Use rails_failover gem for ActiveRecord and Redis failover handling 2020-06-15 15:47:07 +08:00
Guo Xiang Tan
d8cd912769
DEV: Switch to db config to disable advisory locks. 2020-06-15 14:33:41 +08:00