Commit Graph

261 Commits

Author SHA1 Message Date
Jarek Radosz
87f8bafa7e
DEV: Remove obsolete CSS prefixes () 2022-09-15 16:54:08 +02:00
Jarek Radosz
658eedeaa7
UX: Avoid showing text cursor on unselectables () 2022-09-15 15:56:45 +02:00
Jarek Radosz
1284d746b0
DEV: Remove progid:DXImageTransform () 2022-08-21 09:17:58 +02:00
Kris
a24bcceb19
UX: option to account for the sidebar in the breakpoint mixin ()
* UX: account for sidebar in breakpoint mixin

* default to false
2022-07-20 10:56:41 +08:00
Kris
f0005401b7
UX: core adjustments and styles for the experimental sidebar () 2022-06-29 10:49:01 +08:00
Chapoi
a6abf8d07a
UX: update hljs-builtin-name colour () 2022-05-18 16:11:59 -04:00
Chapoi
96d656f450
UX: update hljs-builtin-name highlight ()
* update hljs-builtin-name highlight

* Move dark-light function to better file
2022-05-18 15:55:40 +02:00
Jordan Vidrine
8cb344ddde
UX: Change color functions to match original primary, tertiary functions ()
* UX: Change the way new primary colors are calculated
2022-02-23 15:41:50 -06:00
Penar Musaraj
715ec0d72f
DEV: Normalize ol and ul styling () 2022-02-22 22:17:41 +01:00
Jordan Vidrine
c92e62a271
UX: Styleguide changes & color variable additions () 2022-02-17 14:39:29 -06:00
Kris
34e2ed6d76
Revert "A11Y: Use dynamic type scaling on iOS devices ()"
This reverts commit 9be2717e3b.
2022-02-16 10:01:58 -05:00
Kris
9be2717e3b
A11Y: Use dynamic type scaling on iOS devices () 2022-02-16 09:06:08 -05:00
janzenisaac
ee050e5063
DEV: Make user card non-clickable for anon users: ()
Make name / avatar non-clickable for anon users
2022-02-14 11:25:41 -06:00
Penar Musaraj
3b75120b3d
UX: Support type=search inputs in inline forms () 2022-02-03 13:50:24 +01:00
Jordan Vidrine
0e371d4c6d
SYNTAX: Use classes instead of html element targeting ()
* SYNTAX: Use classes instead of html element targeting
2021-11-15 14:49:45 -06:00
Penar Musaraj
dfeca42bf8
FEATURE: user/category/tag results in full page search ()
See PR for details, this commit also changes the layout of the full page search.
2021-09-20 10:01:11 -04:00
Penar Musaraj
24e71acf3f
UX: Normalize sizing for inputs, buttons, dropdowns ()
See PR for details
2021-09-09 11:01:56 -04:00
Kris
aa6daeaa3e
FEATURE: New style for personal messages () 2021-07-21 10:41:04 -04:00
Jarek Radosz
494fe7f2f6
UX: Adjust list and onebox margins ()
Lists – made the indent smaller (helps on mobile), added vertical margin
Onebox – added top margin
2021-05-25 23:52:33 -04:00
Jarek Radosz
9b9b601e2f
DEV: Remove unused offscreen-content ()
Looks like a vestige of Ember 1.x?
2021-05-25 18:39:06 +02:00
Josh Soref
59097b207f
DEV: Correct typos and spelling mistakes ()
Over the years we accrued many spelling mistakes in the code base. 

This PR attempts to fix spelling mistakes and typos in all areas of the code that are extremely safe to change 

- comments
- test descriptions
- other low risk areas
2021-05-21 11:43:47 +10:00
Penar Musaraj
9bc126949e
DEV: Support referencing public images in plugins in SCSS () 2021-05-03 14:40:02 -04:00
Jeff Wong
849b786378
DEV: refactor font sizing into css custom variables ()
* DEV: refactor font sizing into css custom variables

Add font variables as css variables. Allows plugins/themes to update/overwrite the variables and have core pick up changes. This allows for a theme or plugin to overhaul core's font ratios if desired.
2021-04-28 17:21:59 -07:00
Jeff Wong
75abe8d295
DEV: make font sizing and ratios default ()
Make it easier for themes/plugins to use Discourse's built in font sizing
and override font ratios
2021-04-16 12:58:16 -07:00
Penar Musaraj
abb0a4bae2
DEV: Add SCSS helper to replace asset-uri and image-uri () 2021-04-12 13:57:39 +10:00
Penar Musaraj
e4f3a04d53
DEV: Move color definition functions to mixins () 2021-03-24 18:35:52 -04:00
Kris
e9a05ce161
UX: login; smaller titles, more consistent spacing, other fixes ()
* Fixes an issue where long translations cause layout issues

* Fixes an issue where the alignment shifts when switching between signup/login

* Makes some of the margin/padding more consistent

* Removes duplicate .login-modal and .create-account classes and replaces them with .login-modal-body and .create-account-body

* Adds another color transformation so we could remove prefers-color-scheme... the problem with that was that my OS' UI might be set to something different than my Discourse preferences (prefers-color-scheme only responds to OS UI settings)
2021-03-09 17:00:46 -05:00
Kris
362dd798ae
UX: add link for email login below username, remove button () 2021-02-24 16:30:08 -05:00
Penar Musaraj
c0fd4ab9d6
DEV: Remove deprecated plugins variables importer () 2021-02-23 16:20:59 -05:00
Penar Musaraj
5604ce70d4
DEV: More refactoring of SCSS importers () 2021-02-19 11:22:24 -05:00
Jordan Vidrine
4580595bd8
Login signup zazz ()
This PR re-styles the login and create account modals.
2021-02-10 14:53:18 -06:00
Penar Musaraj
2bc739eaa5
UX: Use bright color for primary button hover on dark schemes () 2021-02-04 13:31:09 -05:00
Penar Musaraj
2dc48fd6c1
UX: Uniformize styles for focus states () 2021-02-03 11:45:54 -05:00
Penar Musaraj
5f846531a5
DEV: Cleanup variables/mixins SCSS imports ()
Prepends variables.scss and mixins.scss globally for all assets. With
one notable exception, theme fields, which will be addressed in a
separate PR.
2021-01-05 14:05:34 -05:00
Penar Musaraj
d1058f4e4c
UX: Blend header colors () 2020-12-16 09:38:51 -05:00
Kris
da5841de0b
REFACTOR: Remove position fixed from the header and use sticky instead ()
This removes fixed positioning from d-header and the topic timeline.

Plugins, themes and components that use the above/below header plugin outlet will likely need some margin/padding adjustments.
2020-10-19 17:26:38 -04:00
Penar Musaraj
a4356b99af
FEATURE: Separate base and heading font site_settings ()
Allows site administrators to pick different fonts for headings in the wizard and in their site settings. Also correctly displays the header logos in wizard previews.
2020-10-05 13:40:41 -04:00
Jarek Radosz
b2adbead59 DEV: Apply unselectable style consistently 2020-09-21 13:32:46 +02:00
Penar Musaraj
94ed54a616
DEV: Small refactor of topic progress wrapper positioning ()
This moves the logic for horizontally placing the topic progress wrapper from the JS component to SCSS. Doing so means it is more easily overridable by themes and plugins.

This also changes the left/right spacing from 1em to 2em for non-mobile screens (it fits better on iPad portrait especially).
2020-09-10 13:29:14 -04:00
Jordan Vidrine
5a34c7cc9e FIX: Adds important declaration to .hidden utility/helper class
This commit adds the `!important` declaration to `.hidden` utility/helper class. Without the `!important` declaration, it is not applied correctly across the site.
2020-09-10 11:06:50 -04:00
Joffrey JAFFEUX
52672b9eab
DEV: apply new coding standards () 2020-09-04 13:42:47 +02:00
Bianca Nenciu
f2e14a3946
FEATURE: Add site setting and wizard step to set base font ()
Co-authored-by: Neil Lalonde <neillalonde@gmail.com>
2020-08-31 13:14:09 +03:00
Penar Musaraj
c937afc75e
FEATURE: automatic dark mode ()
A first step to adding automatic dark mode color scheme switching. Adds a new SCSS file at `color_definitions.scss` that serves to output all SCSS color variables as CSS custom properties. And replaces all SCSS color variables with the new CSS custom properties throughout the stylesheets. 

This is an alpha feature at this point, can only be enabled via console using the `default_dark_mode_color_scheme_id` site setting.
2020-08-03 22:57:10 -04:00
Penar Musaraj
25dcc577ae
DEV: More color transformation refactoring 2020-07-29 12:01:12 -04:00
Penar Musaraj
3116591dc6
DEV: Refactor dark-light-choose() usage in SCSS
Covers most, but not all, cases.
2020-07-29 09:09:37 -04:00
Penar Musaraj
c2d31f5336
DEV: Remove effectively unused disable-no-hover class 2020-07-28 21:44:16 -04:00
Jordan Vidrine
7cf45dab01
Remove darken & lighten functions from scss () 2020-07-28 18:21:53 -04:00
Penar Musaraj
81ab62c72a
DEV: Refactor blend-primary-secondary() usage in SCSS 2020-07-28 13:33:31 -04:00
Penar Musaraj
69efbd213b
DEV: Refactor dark-light-diff usage in stylesheets
- Adds new `$danger-low-mid` SCSS variable
- Removes `dark-light-diff` outside variables and color transformations
2020-07-28 11:06:06 -04:00
Jordan Vidrine
9eedc83e00
UI: Markdown Code Wrapping () 2020-07-08 20:50:42 -04:00
Kris
66257ca8b6 FEATURE: Add "smallest" option to user text size preferences 2020-07-07 13:08:19 -04:00
Joe
6e341f1839 UX: restore table borders
Newer versions of Normalize remove the `border-collapse: collapse;` property and fallback to browser defaults. This commit restores that property because we're using it in quite a few places.
2020-07-06 21:25:41 +08:00
Régis Hanol
525a2174b3
Restore 'pointer' cursor on buttons
Normalize removed their opinionated cursor styling of buttons in [4.0.1](170455d6f6).

Follow-up-to: 1fd3a30a59
2020-07-06 13:15:31 +02:00
Jordan Vidrine
5f61deff80
FIX: updates variables for HTML to use em instead of px in font-size () 2020-05-26 17:48:35 -05:00
Kris
4e1c2fbd18 UX: Add prefixed property so Firefox also gets 4-space tabs in code 2020-05-05 21:00:40 -04:00
Kris
67429335d5 Remove SASS spacing function 2020-04-24 19:32:02 -04:00
Kris
cd5b7109d0 UX: Cap height of user fields on mobile user-cards, add line-clamp mixin 2020-02-14 16:19:11 -05:00
Joffrey JAFFEUX
8ea114007f
UX: adds hover effect on lightboxed images ()
* UX: adds hover effect on lightboxed images

This commits also adds two scss functions:

- is-light-color-scheme()
- is-dark-color-scheme()

This hover effect won't be added on dark color schemes, as images already standout nicely on dark backgrounds.

Co-Authored-By: David Taylor <david@taylorhq.com>
2019-11-26 15:06:30 +01:00
Kris
b066a4128d Adding a text-overflow: ellipsis; mixin and related cleanup 2019-11-06 14:00:29 -05:00
Kris
bacc114462 UX: Convert alert & modal close to buttons for improved accessibility 2019-10-28 16:04:29 -04:00
David Taylor
be96c4478e
FEATURE: Login with Discord ()
This migrates the functionality of discourse-plugin-discord-auth into core. 

The plugin will automatically disable itself when core is updated: fd0867844d

For setup instructions, visit https://meta.discourse.org/t/configuring-discord-login-for-discourse/127129
2019-08-30 10:54:19 +01:00
David Taylor
d348368ab6
FEATURE: Allow themes to override color transformation variables ()
Theme developers can now add any of the transformed color variables to their color scheme in about.json. For example

```
  "color_schemes": {
    "Light": {
      "primary": "333333",
      "secondary": "ffffff",
      "primary-low": "ff0000"
    }
  },
```

would override the primary-low variable when compiling SCSS for the color scheme. The primary-low variable will also be visible in administrator color palette UI.
2019-08-12 11:02:38 +01:00
Joe
fd4557a9ef UX: Mobile editor style fixes () 2019-07-11 09:57:53 -04:00
Penar Musaraj
446ec1b44a
Set input and textarea font size to 16px on iOS () 2019-05-07 10:44:43 -04:00
Penar Musaraj
de10bd7fb4 UI: Footer nav fixes
- moves footer nav to the header on iPads
- disables scrolling events for iPads
- removes footer nav entirely on Chrome PWAs
- toggles DiscourseHub iOS app status bar styling (dark/light) when opening/closing lightboxes and modals
2019-04-15 15:25:40 -04:00
Penar Musaraj
a37181ab30 Move footer nav z-index below header menus 2019-04-15 12:03:42 -04:00
Penar Musaraj
51630b5187 Footer nav tweaks 2019-04-12 12:29:54 -04:00
Penar Musaraj
f060c9b3ff UI: improvements to footer nav for app and PWAs
Adds support for iPad and Chrome PWAs

Better scroll direction logic when reaching bottom of the page
2019-04-11 14:11:26 -04:00
Penar Musaraj
eae22548de
Footer navigation for iOS PWAs and DiscourseHub app () 2019-04-10 12:23:18 -04:00
Kris
8e9d0ceb67 UX: Mobile - fix editor button space, divider, extra upload icon 2019-04-09 13:15:31 -04:00
David Taylor
f524f8f811
Remove Yahoo login support from core and deprecate OpenID2.0 ()
- Plugin developers using OpenID2.0 should migrate to OAuth2 or OIDC. OpenID2.0 APIs will be removed in v2.4.0

- For sites requiring Yahoo login, it can be implemented using the OpenID Connect plugin: https://meta.discourse.org/t/103632

For more information, see https://meta.discourse.org/t/113249
2019-04-08 10:38:25 +01:00
Kris
d9eed924f5 minor box-shadow adjustment 2019-03-28 15:13:53 -04:00
Kris
88a3b89990 UX: Improve user profile header layout on mobile 2019-03-20 14:56:34 -04:00
Kris
95e8c935c5 UX: Update brand color, some login adjustments 2019-03-15 17:20:52 -04:00
Joffrey JAFFEUX
04a63cfaaa
[WIP] FEATURE: merge share and invite actions together ()
This commit also:
- removes [+ New Topic] behaviour from share, this feature has been duplicated in composer actions, months ago
- introduces our new experimental spacing standard for css: eg: `s(2)`
- introduces a new panel UI for modals
2019-02-20 15:42:44 +01:00
David Taylor
7878e5007a
FIX: Refactor to prevent themes affecting core stylesheets ()
If a theme setting contained invalid SCSS, it would cause an error 500 on the site, with no way to recover. This commit stops loading theme settings in the core stylesheets, and instead only loads the color scheme variables. This change also makes `common/foundation/variables.scss` available to themes without an explicit import.
2019-02-19 15:55:59 +00:00
Robin Ward
ca03b2ff30 Move SCSS variables for topic post width
This allows them to be re-used by other components, for example the
upcoming review queue.
2019-02-06 11:37:59 -05:00
Kris
37c28cf0b7 UX: Header icon color fix 2019-02-01 09:51:12 -05:00
Kris
94f16ba931 UX: Make button icons use lighter color instead of opacity 2019-01-31 13:59:49 -05:00
Kris
868528f862 Slight shadow adjustment to hide overflow 2019-01-24 14:49:39 -05:00
Kris
b664674d2b make smaller text size bigger 2019-01-17 12:11:31 -05:00
Kris
675bf94133 UX: Bump up base font size 1px, add smaller text size option 2019-01-17 10:30:34 -05:00
David Taylor
1ebd3dbbd0
FEATURE: Allow the base font size to be changed on a per-user basis () 2019-01-14 13:21:46 +00:00
Kris
4af7471ead Better contrast ratio match between dark and light themes 2019-01-02 17:54:22 -05:00
Kris
816acc6984 Improving color contrast of $danger-low for dark themes 2018-12-20 14:46:13 -05:00
Kris
8c227715ae $primary-high contrast reduction for dark themes 2018-12-11 10:08:00 -05:00
Kris
050c02228e UX: Globally dim categories slightly 2018-12-07 20:01:38 -05:00
Penar Musaraj
03deda2147
Upgrade to FontAwesome 5 (take two) ()
* Add missing icons to set

* Revert FA5 revert

 This reverts commit 42572ff

* use new SVG syntax in locales

* Noscript page changes (remove login button, center "powered by" footer text)

* Cast wider net for SVG icons in settings

- include any _icon setting for SVG registry (offers better support for plugin settings)

- let themes store multiple pipe-delimited icons in a setting

- also replaces broken onebox image icon with SVG reference in cooked post processor

* interpolate icons in locales

* Fix composer whisper icon alignment

* Add support for stacked icons

* SECURITY: enforce hostname to match discourse hostname

This ensures that the hostname rails uses for various helpers always matches
the Discourse hostname

* load SVG sprite with pre-initializers

* FIX: enable caching on SVG sprites

* PERF: use JSONP for SVG sprites so they are served from CDN

This avoids needing to deal with CORS for loading of the SVG

Note, added the svg- prefix to the filename so we can quickly tell in
dev tools what the file is

* Add missing SVG sprite JSONP script to CSP

* Upgrade to FA 5.5.0

* Add support for all FA4.7 icons

- adds complete frontend and backend for renamed FA4.7 icons

- improves performance of SvgSprite.bundle and SvgSprite.all_icons

* Fix group avatar flair preview

- adds an endpoint at /svg-sprites/search/:keyword

- adds frontend ajax call that pulls icon in avatar flair preview even when it is not in subset

* Remove FA 4.7 font files
2018-11-26 16:49:57 -05:00
Sam
42572ff138 Revert font awesome 5 changes
We are still pushing ahead on this 100% just need a bit longer to prepare
all plugins
2018-11-08 16:12:18 +11:00
Penar Musaraj
a5871b6dd1 Rename conflicting SCSS mixin 2018-11-07 14:18:55 -05:00
Penar Musaraj
005e1ecb9b
FEATURE: Update Font Awesome to v5.4.1 and SVGs ()
* First take on subsetting svg icons

* FontAwesome 5 svg subset WIP

* Include icons from plugins/badges into svg sprite subset

* add svg icon support to themes

* Add spec for SvgSprite

* Misc. SVG icon fixes

* Use FA5 svgs in local-dates plugin

* CSS adjustments, fix SVG icons in group flair

* Use SVG icons in poll plugin

* Add SVG icons to /wizard
2018-11-07 13:05:43 -05:00
Kris
1d7720ef99 UX: Adding Google-compliant logo 2018-10-24 22:11:19 -04:00
Kris
94b115f7d9 increase contrast for $danger-medium on dark themes 2018-10-10 09:51:50 -04:00
Kris
948c556cc6 decrease contrast on danger-low color 2018-10-04 17:30:10 -04:00
Kris
072f5ce825 Increase ruby character size 2018-08-03 13:37:08 -04:00
Kris
01fe42d5e2 prettier fix 2018-07-12 16:41:44 -04:00
Kris
b79fedd540 Streamlining some breakpoint mixins 2018-07-12 16:39:16 -04:00
Kris
a201103127 removing some old styles 2018-07-12 00:53:24 -04:00
Robin Ward
fbc194c330 Don't use !important for wiki color. Allow themes to override it. 2018-06-20 10:47:27 -04:00
Jeff Wong
160898acf3 Feature: add jump to post modal on mobile 2018-06-13 22:01:35 -07:00