Jarek Radosz
c3fd91670e
DEV: Update linting setup and fix issues ( #17345 )
...
Re-lands #16119 and #17298
* Update eslint-config-discourse
* Update linting workflow
* Prettier-ignore stuff
* Update template-lint config
* Auto-fix template issues
* Fix various template issues
Mostly incorrect attributes and unused templates
* Prettier js files
* Fix template auto-fix regressions
* Small css tweak
Co-authored-by: Peter Wagenet <peter.wagenet@gmail.com>
2022-07-06 10:37:54 +02:00
Peter Wagenet
371bbadb92
No implicit this codemod ( #17235 )
...
* Run no-implicit-this codemod for app templates
* Run tagless-ember-components-codemod for plugins
* Turn on no-implicit-this lint
2022-07-05 19:41:31 +02:00
David Taylor
24413e5a11
DEV: Enable no-curly-component-invocation lint rule
...
This will ensure we invoke components consistently across our codebase
2022-07-04 17:25:42 +01:00
Faizaan Gagan
c45dbe4159
enable eol-last for eslint and ember-template-lint ( #12678 )
...
enable eol-last for eslint and ember-template-lint
Fixed a handlful of .hbs files where newlines weren't present
2021-04-12 17:22:00 -07:00
Joffrey JAFFEUX
110f6ec6dd
DEV: fixes eslint/prettier on github actions ( #10601 )
2020-09-04 20:01:14 +02:00
Joffrey JAFFEUX
3debb576d4
REFACTOR: require-valid-alt-text was duplicated ( #9663 )
2020-05-07 16:24:15 +02:00
Joffrey JAFFEUX
98039e6cc5
FIX: template-lint uses strict rel-noopener rule which requires noreferrer ( #9449 )
2020-04-16 22:38:10 +02:00
Kane York
c670a34013
DEV: Fix and enable the 'require-button-type' lint
2020-04-14 18:32:16 -07:00
Joffrey JAFFEUX
c4644c61d9
DEV: enforces double quotes ember-template-lint ( #9416 )
2020-04-14 08:18:49 +02:00
Joffrey JAFFEUX
7d1c90e5eb
DEV: upgrades ember-template-lint 2.5.2 ( #9411 )
2020-04-14 00:43:55 +02:00
Joffrey JAFFEUX
b66b277dc4
DEV: enforces block-indentation of ember-template-lint rules ( #9408 )
2020-04-13 17:17:20 +02:00
Joffrey JAFFEUX
3cac60f07c
DEV: enforce no-quoteless-attributes ember-template-lint ( #9400 )
2020-04-09 22:00:44 +02:00
Kane York
2afb95fe3e
DEV: Enable and fix the 'no-multiple-empty-lines' lint
2020-03-30 14:13:33 -07:00
Kane York
1703270055
DEV: Enable and fix no-trailing-spaces lint
2020-03-30 14:13:33 -07:00
David Taylor
e6e6d20912
Revert "DEV: Enable and fix link-href-attributes lint"
...
Introducing an href attribute on the upload button caused the page to reload when clicked
This reverts commit a17fa222af
2020-03-27 11:43:00 +00:00
Kane York
17211b940f
DEV: Enable and fix the 'no-duplicate-attributes' lint
2020-03-26 12:31:34 -07:00
Kane York
7c14d9ae9f
DEV: Add and disable all failing 'stylistic' lints
2020-03-26 12:31:34 -07:00
Kane York
e98e83a1ff
DEV: Disable all failing 'recommended' lints and extend 'recommended'
2020-03-26 12:31:34 -07:00
Kane York
eff4974829
sorting fix
2020-03-26 12:31:34 -07:00
Kane York
07dc8d20c4
DEV: Enable and fix the 'require-iframe-title' lint
2020-03-26 12:31:34 -07:00
Kane York
a17fa222af
DEV: Enable and fix link-href-attributes lint
2020-03-26 12:31:34 -07:00
Kane York
af41c37d42
DEV: Enable all 'recommended' passing ember template linting rules
...
Also sort the ember template linting rules
2020-03-26 12:31:34 -07:00
Joffrey JAFFEUX
11921c4868
DEV: enforces ember-template-lint: no-html-comments ( #9183 )
...
https://github.com/ember-template-lint/ember-template-lint/blob/master/docs/rule/no-html-comments.md
2020-03-12 07:51:05 +01:00
Joffrey JAFFEUX
61a2c3650d
DEV: enforces ember-template-lint: no-partial ( #9173 )
...
selected-posts parial is kept and calling the new component to prevent errors with users who would have rewritten topic.hbs
dashboard-problems and version-checks seem less risky and have only been converted to components
2020-03-11 15:30:14 +01:00
Joffrey JAFFEUX
683cb28099
DEV: enforces ember-template-lint: no-triple-curlies ( #9165 )
...
This pr replaces `{{{ }}}` usage by a {{html-safe}} helper. While it doesn't solve the underlying issue, it gives us a path forward without risking breaking too much existing behavior.
Also introduces an htmlSafe computed macro:
```
import { htmlSafe } from "discourse/lib/computed";
htmlDescription: htmlSafe("description")
```
Overtime {{html-safe}} usage should be removed and moved to components properties or specialized components/helpers.
2020-03-11 09:23:10 +01:00
romanrizzi
f795c1b8e8
Revert "DEV: enforces ember-template-lint: no-triple-curlies ( #9150 )"
...
This reverts commit d436b600fb
2020-03-10 15:00:12 -03:00
Joffrey JAFFEUX
d436b600fb
DEV: enforces ember-template-lint: no-triple-curlies ( #9150 )
...
This pr replaces `{{{ }}}` usage by a {{html-safe}} helper. While it doesn't solve the underlying issue, it gives us a path forward without risking breaking too much existing behavior.
Also introduces an htmlSafe computed macro:
```
import { htmlSafe } from "discourse/lib/computed";
htmlDescription: htmlSafe("description")
```
Overtime {{html-safe}} usage should be removed and moved to components properties or specialized components/helpers.
2020-03-10 16:46:57 +01:00
Joffrey JAFFEUX
f1bb1db354
DEV: enforces ember-template-lint: no-unbound ( #9147 )
...
From ember-template-lint documentation (https://github.com/ember-template-lint/ember-template-lint/blob/master/docs/rule/no-unbound.md ):
```
{{unbound}} is a legacy hold over from the days in which Ember's template engine was less performant. Its use today is vestigial, and it no longer offers performance benefits.
It is also a poor practice to use it for rendering only the initial value of a property that may later change.
```
Co-Authored-By: Jarek Radosz <jradosz@gmail.com>
2020-03-09 15:28:31 +01:00
Joffrey JAFFEUX
4f37233208
DEV: enforces ember-template-lint: simple-unless ( #9146 )
2020-03-09 13:44:34 +01:00
Joffrey JAFFEUX
8612bfb152
DEV: enforces ember-template-lint: no-unused-block-params ( #9138 )
2020-03-09 10:03:46 +01:00
Joffrey JAFFEUX
e9b6b0194c
DEV: enforce ember-template-lint: no-unnecessary-concat ( #9133 )
2020-03-07 12:58:48 +01:00
Joffrey JAFFEUX
a24f51278a
DEV: enforces link-rel-noopener linting rule ( #8936 )
...
* DEV: enforces link-rel-noopener linting rule
* oops
* better syntax
2020-03-06 11:35:18 -05:00
Joffrey JAFFEUX
902d0e1e3a
DEV: enforces no-invalid-interactive linting rule ( #8907 )
2020-02-11 15:55:16 +01:00
Joffrey JAFFEUX
0d9b99582d
DEV: enforces table-groups linting rule ( #8903 )
2020-02-10 08:14:26 +01:00
Joffrey JAFFEUX
99ad2e408a
DEV: enforces style-concatenation linting rule ( #8888 )
2020-02-10 08:13:50 +01:00
Joffrey JAFFEUX
dafd3c3b47
DEV: enforces no self-closing-void-elements ( #8879 )
2020-02-06 17:26:06 +01:00
Robin Ward
f7c0cd1982
Support for Ember Template linting
2020-02-05 11:33:15 -05:00
