Sam Saffron
89c4332ac1
DEV: correct spec making bad assumptions
...
bio_cooked is not meant to be touched directly, on save we "cook" the raw
bio.
2019-06-12 16:31:50 +10:00
Maja Komel
0a1b16bb16
FIX: clean up cooked group bio when bio is removed ( #7745 )
2019-06-12 16:18:38 +10:00
Guo Xiang Tan
73bf880f74
FIX: Correct more edge cases with InlineUploads.
2019-06-12 10:44:25 +08:00
Guo Xiang Tan
ff48fbdfda
FIX: InlineUploads raises an error when img tag is invalid.
2019-06-12 10:31:00 +08:00
Guo Xiang Tan
d49c193289
FIX: posts:inline_uploads rake task needs to bypass bump.
2019-06-12 09:13:31 +08:00
David Taylor
f60451a89d
DEV: Fix linting error
2019-06-12 00:19:52 +01:00
David Taylor
0ebe5ec1f8
FIX: Check postStream.gaps exists before trying postSteam.gaps.after
2019-06-11 23:48:21 +01:00
Joffrey JAFFEUX
23f457b87d
DEV: disables d-editor emoji test to attempt to fix timeouts ( #7755 )
2019-06-12 00:30:11 +02:00
Joffrey JAFFEUX
5da91fa8f8
DEV: disable emoji-picker test to attempt to fix timeouts ( #7754 )
2019-06-12 00:11:21 +02:00
Joffrey JAFFEUX
1feaacaecb
DEV: skip emoji picker opening test to attempt to fix timeouts ( #7753 )
2019-06-11 23:54:20 +02:00
Joffrey JAFFEUX
58057484fe
DEV: skip ace-editor to attempt to avoid timeouts ( #7752 )
2019-06-11 23:38:43 +02:00
Robin Ward
f6e0c79742
FIX: Trigger change event when inserting text
...
This would normally not fire and result in odd behavior in the review
queue when inserting links.
2019-06-11 17:27:34 -04:00
Joffrey JAFFEUX
cb08d3cc26
DEV: adds module debugging to js tests ( #7751 )
2019-06-11 23:14:42 +02:00
Robin Ward
3d7c26c15e
FIX: Memory Leaks w/ Container ( #7750 )
...
Gives instance initializers the ability to add a `teardown` method that
will be called between tests to clean up after themselves.
2019-06-11 18:41:27 +02:00
Robin Ward
47095a7fa1
FIX: Memory leak when adding ajax prefilter repeatedly.
2019-06-11 11:50:35 -04:00
Robin Ward
c322cccd53
FIX: Memory Leaks when decorating posts ( #7749 )
...
* Remove long-deprecated method
* FIX: Memory Leaks when decorating posts
Previously we'd keep creating mixins dynamically when decorating the
same class.
This code changes the API to recommend an `id` parameter for each
decorator which will avoid leaks. All plugins should be updated to
include this parameter, although if they don't in the meantime it'll
just mean a warning in the console (and a continued leak.)
2019-06-11 17:21:23 +02:00
Bianca Nenciu
934adb14d2
FIX: On tag change notify only users watching the tag. ( #7707 )
2019-06-11 18:06:54 +03:00
Vinoth Kannan
1881e895dc
SPEC: correctly skips invalid upload urls
...
788f995f30
2019-06-11 20:15:40 +05:30
Vinoth Kannan
788f995f30
FIX: skip external urls which has upload url in query string.
...
Add spec tests for post.each_upload_url method. e8fafbc123
2019-06-11 19:55:02 +05:30
Arpit Jalan
e2636f0ec7
FIX: handle array in redirect param
2019-06-11 17:49:09 +05:30
David Taylor
f4fd75aea4
DEV: Rename variable to avoid conflict
2019-06-11 13:02:40 +01:00
David Taylor
f1d5b992bf
DEV: Correct linting error
2019-06-11 12:51:18 +01:00
Joffrey JAFFEUX
dc15486f0a
Revert "DEV: resets csrf ajax prefilter only if present ( #7747 )"
...
This reverts commit 6612218a4e
2019-06-11 13:34:25 +02:00
David Taylor
61b587f66e
FIX: Mark ignored posts as 'read', if last visible post is read ( #7739 )
2019-06-11 12:16:28 +01:00
David Taylor
000a35b219
FIX: Do not live-load posts from ignored users
2019-06-11 12:07:14 +01:00
Joffrey JAFFEUX
6612218a4e
DEV: resets csrf ajax prefilter only if present ( #7747 )
2019-06-11 12:50:20 +02:00
Joffrey JAFFEUX
ebf77f74b7
Revert "DEV: prevents csrf token to leak state between tests ( #7746 )"
...
This reverts commit b29d63a52d
2019-06-11 12:19:49 +02:00
Joffrey JAFFEUX
b29d63a52d
DEV: prevents csrf token to leak state between tests ( #7746 )
2019-06-11 11:54:23 +02:00
Joffrey JAFFEUX
e6714d3531
Revert "DEV: attempts to prevent session object to be retain in csrf init ( #7743 )"
...
This reverts commit 62c56b6e59
2019-06-11 10:58:32 +02:00
Guo Xiang Tan
864222372f
Remove incorrectly committed byebug.
...
Follow up to 49b921147a
2019-06-11 16:33:49 +08:00
Guo Xiang Tan
49b921147a
FIX: Undefined method in posts:inline_uploads.
2019-06-11 16:28:41 +08:00
Guo Xiang Tan
40e67971f9
DEV: Add spec for Email::Sender for upload links in plain text emails.
2019-06-11 16:02:24 +08:00
Joffrey JAFFEUX
4deb0f6d59
DEV: prevents post-cooked decorators to leak between tests ( #7744 )
2019-06-11 10:02:10 +02:00
Joffrey JAFFEUX
62c56b6e59
DEV: attempts to prevent session object to be retain in csrf init ( #7743 )
2019-06-11 09:59:14 +02:00
Joffrey JAFFEUX
c407e32368
DEV: should check on object and not length ( #7742 )
2019-06-11 09:45:45 +02:00
Guo Xiang Tan
e5cace9185
FIX: File size text should not be part of link.
2019-06-11 15:21:06 +08:00
Guo Xiang Tan
fb0a655e8a
FEATURE: Update pull hotlinked images to use Upload#short_url.
2019-06-11 15:17:29 +08:00
Guo Xiang Tan
42ab016856
FIX: Use markdown for images and attachments in Email::Receiver.
2019-06-11 14:49:46 +08:00
Guo Xiang Tan
36c0cfa890
FIX: Use new attachment markdown format in ImportScripts::Uploader.
2019-06-11 14:49:28 +08:00
Guo Xiang Tan
9d0fba64c0
FIX: Use attachment format in user export system post take 2.
2019-06-11 12:15:11 +08:00
Guo Xiang Tan
a112259c66
DEV: Missed a spot in 658c6e0caf.
2019-06-11 11:41:28 +08:00
Guo Xiang Tan
658c6e0caf
FIX: Use attachment format in user export system post.
2019-06-11 11:33:01 +08:00
Guo Xiang Tan
d20ea38f02
Fix the build.
...
Follow up to bd538f7437
2019-06-11 10:05:57 +08:00
Dan Ungureanu
a046f6ced5
FEATURE: Trigger Discourse events from authenticators. ( #7724 )
2019-06-11 11:28:42 +10:00
Daniel Waterworth
d073a7d5a8
DEV: Added commit approved notification type for discourse-code-review
...
We need to reserve ids in core so plugins do not clash.
2019-06-11 11:17:23 +10:00
Guo Xiang Tan
06d974d55c
FEATURE: Add base62 sha1 to cooked data attribute
...
* FEATURE: Add base62 sha1 to data attribute in `Post#cooked`.
* FIX: Use `Upload#short_url` when quoting an image.
2019-06-11 11:15:45 +10:00
Guo Xiang Tan
bd538f7437
FIX: Composer preview not caching inline onebox.
2019-06-11 09:14:53 +08:00
Bianca Nenciu
9168ffc201
PERF: Use already loaded post when quoting or opening draft.
2019-06-11 08:21:38 +08:00
Sam Saffron
7b17eb06da
FEATURE: ban any SSO attempts with invalid external id
...
We now treat any external_id of blank string (" " or " " or "", etc) or a
invalid word (none, nil, blank, null) - case insensitive - as invalid.
In this case the client will see "please contact admin" the logs will explain
the reason clearly.
2019-06-11 10:04:26 +10:00
Robin Ward
ecebff5060
Only show deprecation warning if the webhook is active
2019-06-10 16:23:12 -04:00
