Robin Ward
ba6d4b2a8d
FIX: Better handling for toggling must_approve_users
...
If you turn it on now, default all users to approved since they were
previously. Also support approving a user that doesn't have a reviewable
record (it will be created first.)
This also includes a refactor to move class method calls to
`DiscourseEvent` into an initializer. Otherwise the load order of
classes makes a difference in the test environment and some settings
might be triggered and others not, randomly.
2019-04-16 15:56:35 -04:00
Penar Musaraj
cec0b580e6
UX: detect DiscourseHub user agent in recently used devices
2019-04-16 13:50:47 -04:00
Roman Rizzi
d2ea602bdd
DEV: Mark flaky tests as pending until we fix them. ( #7386 )
2019-04-16 13:35:54 -03:00
Gerhard Schlager
72a7f9af87
FIX: Add the last missing translation for push notifications
...
and sync the message for "custom" with the message of regular notifications
2019-04-16 18:04:46 +02:00
Gerhard Schlager
7e8579b8aa
UX: Add translations for lightbox
2019-04-16 17:03:01 +02:00
Joffrey JAFFEUX
5ec19987b4
FIX: attempts to fix a regression making touchs on emojis less reliable ( #7383 )
2019-04-16 12:31:33 +02:00
Gerhard Schlager
3aca070311
FIX: Restoring backup shouldn't change disable_emails from "yes" to "non-staff"
2019-04-16 11:48:07 +02:00
Gerhard Schlager
ac27bdce14
DEV: Prevent warnings in specs
2019-04-16 11:41:27 +02:00
Dan Ungureanu
35a866fe22
FIX: Do not strip email lines having lists.
2019-04-16 11:39:35 +03:00
Sam Saffron
0c35b8b420
FEATURE: add suggested_topics_unread_max_days_old
...
This new site setting determines the maximum age of unread topics in
suggested. By default if you have any unread topics older than 90 days
they will be omitted from suggested.
This change was added for 2 reasons:
1. A performance safeguard, some users tend to collect a huge amount of
read state so it becomes super expensive to find unread
2. People who collect a large amount of unread are much more interested in
recent unread topics vs ancient unread topics, this makes suggested more
relevant
Also, this is a minor speed up for tests cause 3 expensive tests became 1.
2019-04-16 17:52:10 +10:00
Guo Xiang Tan
784940bea0
Fix the build.
2019-04-16 15:47:16 +08:00
Guo Xiang Tan
1056dd16d3
FIX: Publish web hooks when topic archetype is converted.
2019-04-16 15:18:39 +08:00
Guo Xiang Tan
347663e852
UX: Switch ellipsis direction when expanding web hook event details.
2019-04-16 14:28:23 +08:00
Guo Xiang Tan
8cb1890245
FIX: Missing topic edited web hook when publishing a topic.
2019-04-16 14:28:23 +08:00
Guo Xiang Tan
d6e45864ce
Fix failing spec.
2019-04-16 09:59:35 +08:00
Guo Xiang Tan
ce4c8e957b
PERF: Avoid looking up the same group multiple times during bulk invite.
...
Also cache the guardian check because it does a query to check if the
user is an owner of the group.
2019-04-16 09:42:25 +08:00
Guo Xiang Tan
25514550f0
FIX: Bulk invite should skip invite and add existing users to groups.
2019-04-16 09:42:25 +08:00
Guo Xiang Tan
6e6cdfaf80
FIX: Bulk invite should not add users to automatic groups.
...
* Also checks that the user creating the bulk invite has permission.
2019-04-16 09:42:25 +08:00
Penar Musaraj
74c4ef6b50
Fix draft position in iOS webview
2019-04-15 19:10:18 -04:00
Dan Ungureanu
e23c87c442
FIX: Prevent exception in rescue block.
...
> Job exception: undefined method `id' for nil:NilClass
> clean_up_inactive_users.rb:25:in `rescue in block in execute'
2019-04-16 01:27:39 +03:00
Robin Ward
3ceff0a92a
FEATURE: Send the user a notification when their post is approved
2019-04-15 16:20:16 -04:00
Penar Musaraj
de10bd7fb4
UI: Footer nav fixes
...
- moves footer nav to the header on iPads
- disables scrolling events for iPads
- removes footer nav entirely on Chrome PWAs
- toggles DiscourseHub iOS app status bar styling (dark/light) when opening/closing lightboxes and modals
2019-04-15 15:25:40 -04:00
Robin Ward
fca3044b10
UX: When editing a reviewable, show created_by
2019-04-15 15:11:34 -04:00
Robin Ward
d859e1594e
UX: Add a description for scores
2019-04-15 14:21:25 -04:00
Kris
4b74525446
FIX: Group requests page missing wrapper
2019-04-15 14:16:02 -04:00
Penar Musaraj
14eb8eea01
FIX: Prevent input zooming in iOS
...
Since enabling pinch-to-zoom in iOS (eae22548de
), there was an issue with inputs: Safari auto-zooms inputs with font-size under 16px. Now zooming will be disabled while focus is on an input.
This commit also removes a) a lightbox zoom-enabling event (no longer needed) and b) a comment about iOS zoom issues.
2019-04-15 13:05:43 -04:00
David Taylor
af86cf46dc
FEATURE: Allow API requests to specify the DISCOURSE_VISIBLE
header
...
This allows API consumers to automatically update the user's last_seen time. The default behaviour is unchanged.
2019-04-15 17:34:34 +01:00
Penar Musaraj
a37181ab30
Move footer nav z-index below header menus
2019-04-15 12:03:42 -04:00
Penar Musaraj
c5fecdd5bd
FIX: Set text title for desktop push notifications
...
Fixes a broken translation on some browser push notifications, same as 4c23083c57
but for client-side translations.
2019-04-15 10:55:16 -04:00
David Taylor
428536788c
FIX: Do not error when importing a theme with empty files
2019-04-15 15:46:47 +01:00
Penar Musaraj
6bbdf5b56e
DEV: add "pre_notification_alert" event
...
Allows plugins to modify payload before sending a notification alert
2019-04-15 10:17:15 -04:00
Penar Musaraj
24fd710f04
Revert "FIX: strip spoilers in notification excerpts"
...
This reverts commit 55942224ed
.
2019-04-15 10:15:17 -04:00
Arpit Jalan
989325ea7c
FIX: show available details when rescuing error
2019-04-15 14:09:52 +05:30
Arpit Jalan
07b961ab13
DEV: rescue avatar rake tasks with error backtrace
2019-04-15 14:06:29 +05:30
Arpit Jalan
594674703c
FIX: properly log webhook errors in UI on rescue ( #7376 )
2019-04-15 12:19:48 +05:30
Dan Ungureanu
e92cd5318b
FEATURE: Add setting to strip whitespaces from incoming emails. ( #7375 )
...
Some email clients add leading whitespaces which get are transformed in
code blocks when processed.
2019-04-15 16:26:00 +10:00
David Taylor
fd0de64e0d
UX: Render wizard previews for high-DPI displays ( #7371 )
...
* UX: Render wizard previews for high-DPI displays
Sets up a canvas element of twice the required dimensions, scales all coordinates by 2x, then shrinks the display in css.
* Use window.devicePixelRatio to determine scale factor
2019-04-15 16:16:05 +10:00
Guo Xiang Tan
e50494bcde
Revert "DEV: Upgradae to Bundler 2."
...
This reverts commit f65c8a7ba1
.
I can't deal with this now.
2019-04-15 11:05:51 +08:00
Guo Xiang Tan
afbf852e0e
DEV: Add specs for cleaning up uploads in non pending reviable posts.
...
Follow up to f7ebfb1acc
2019-04-15 09:20:34 +08:00
Guo Xiang Tan
f65c8a7ba1
DEV: Upgradae to Bundler 2.
2019-04-15 09:02:02 +08:00
Tim Lange
00ee68f799
FIX: Fixed category reordering using arrow icons ( #7374 )
2019-04-15 10:56:21 +10:00
Vinoth Kannan
8e40c35eb8
FIX: 'have_uploads' scope should include all uploads without multisite 'upload_path' prefix
2019-04-15 01:54:55 +05:30
Vinoth Kannan
70fef8e0c3
FIX: change to correct bundled version
2019-04-14 14:46:56 +05:30
Vinoth Kannan
87b53e170b
FIX: skip <br> inside <p> if next character is \n
2019-04-14 14:44:54 +05:30
Arpit Jalan
a423e9b14a
FIX: rescue avatars:refresh
rake task
2019-04-14 14:26:15 +05:30
Jeff Wong
2863abefdd
FIX: detect local assets for subfolder installs
2019-04-13 10:35:23 -07:00
Arpit Jalan
95ada3f190
FIX: save registration IP address for invited users
2019-04-13 13:04:25 +05:30
Kris
b71f19d394
UX: Responsive reviewables down to tablet width
2019-04-12 22:26:24 -04:00
Robin Ward
ef1af53e05
FIX: If creating an active user via the API, create reviewables
2019-04-12 15:25:02 -04:00
Robin Ward
f7ebfb1acc
FIX: Only consider pending queued posts for cleaning up uploads
2019-04-12 14:39:32 -04:00