Régis Hanol
cfa281a697
FIX: remove muted topics/tags/categories from top and hot topics lists ( #30892 )
...
So it matches the behavior of latest and new.
2025-01-29 11:51:10 +01:00
David Taylor
a480c40f81
Revert "DEV: Upload assets to S3 in parallel ( #30210 )" ( #31050 )
...
This reverts commit b9f8a77d9ba5222bbf55172092f0b235b92d1c85.
Reverting while we work on adding error handling. At the moment,
failures are logged, but the process still exits with status=0.
2025-01-29 10:03:56 +00:00
David Battersby
c64b5d6d7a
FEATURE: Multiple Draft Topics ( #30790 )
...
Allows users to save multiple topic and personal message drafts,
allowing more flexibility around content creation.
The "New Topic" button will now always start a fresh topic. Drafts can
be resumed from the drafts dropdown menu or using the "My Drafts" link
in the sidebar.
Since drafts require a unique `draft_key` and `user_id` combination, we
have updated the format of the draft key for both topics and personal
messages. They will now have a prefix like "new_topic_" or
"new_message_" with the timestamp of when the composer was first opened
appended.
2025-01-29 10:23:26 +04:00
Sam
29e48a6478
DEV: remove experimental lightbox ( #30973 )
...
Experimental lightbox did not pan out, we are rolling it back so we can
start again from base principles.
2025-01-29 16:08:21 +11:00
Jarek Radosz
d455bf4365
UX: Fix mobile chat DM row layout ( #31043 )
2025-01-29 03:24:35 +01:00
Martin Brennan
15838aa756
DEV: Convert AdminReport component to gjs ( #31011 )
...
This commit converts the `AdminReport` component, which is quite
high complexity, to gjs. After this initial round, ideally this
component would be broken up into smaller components because it is
getting quite big now.
Also in this commit:
* Add an option to display the report description in a tooltip, which
was
the main way the description was shown until recently. We want to use
this on the dashboard view mostly.
* Move admin report "mode" definitions to the server-side Report model,
inside a `Report::MODES` constant, collecting the modes defined in
various
places in the UI into one place
* Refactor report code to refer to mode definitions
* Add a `REPORT_MODES` constant in JS via javascript.rake and refactor
JS to refer to the modes
* Delete old admin report components that are no longer used
(trust-level-counts, counts, per-day-counts) which were replaced
by admin-report-counters a while ago
* Add a new `registerReportModeComponent` plugin API, some plugins
introduce their own modes (like AI's `emotion`) and components and
we need a way to render them
2025-01-29 10:33:43 +10:00
David Taylor
5a64d0e932
DEV: Add release-notes link to readme ( #31046 )
2025-01-29 00:28:18 +00:00
Martin Brennan
d8102cb532
FIX: Update AdminNotice details when problem check tracker changes ( #31031 )
...
We have many problem check trackers, and some of them
like `OutOfDateThemes` can have a message which has variable
data in it shown to admins. In this case, a list of themes
that need updating. Currently if you resolve one of these
out of date themes and refresh the list of problems, you
do not see any change.
This is happening because we are only updating the `details`
of the `ProblemCheckTracker` record, not the corresponding
`AdminNotice` record which is what is displayed to the admins
on their dashboard. This commit fixes the issue by updating the
details of the notice at the same time as the problem check
tracker details.
2025-01-29 09:44:20 +10:00
David Taylor
3196918f4d
DEV: Update 'development' section of readme, and drop outdated docs ( #31044 )
...
These docs have not been updated for many years. Up-to-date content can
be found at
https://meta.discourse.org/c/documentation/developer-guides/56
2025-01-28 23:25:25 +00:00
Saif Murtaza
09b62f9a76
Update README.md ( #31042 )
...
I took off the old sentence - "Discourse is built for the next 10 years
of the Internet, so our requirements are high.”
as per our decision here:
https://dev.discourse.org/t/update-github-readmes-after-v3-4-release/134402/6
2025-01-29 07:56:05 +09:00
dependabot[bot]
5cad80b2d5
Build(deps-dev): Bump @glint/environment-ember-template-imports from 1.5.1 to 1.5.2 ( #31040 )
...
Bumps
[@glint/environment-ember-template-imports](https://github.com/typed-ember/glint )
from 1.5.1 to 1.5.2.
- [Release notes](https://github.com/typed-ember/glint/releases )
-
[Changelog](https://github.com/typed-ember/glint/blob/main/.release-it.yml )
- [Commits](https://github.com/typed-ember/glint/compare/1.5.1...1.5.2 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-28 22:32:49 +01:00
Kris
f6c5eca485
DEV: add btn-default classes to buttons using default styling ( #31039 )
...
All of these buttons use our default grey background styling, but aren't
carrying the `btn-default` class, which makes them easier to target in
themes. This PR adds the class.
2025-01-28 15:40:34 -05:00
Penar Musaraj
dcac09ed32
DEV: Add proper error response when searching with an invalid page param ( #31026 )
...
Previously, for a search query with `page=11` or higher, we were quietly
returning the page 10 results. The frontend app isn't affected because
it sets its own limit to 10 pages, but still, this response from the
search endpoint does not make sense.
This change switches to returning a 400 error when the `page` parameter
is above the allowed limit (a max of 10).
2025-01-28 15:12:52 -05:00
Kris
7334cfb191
UX: add missing class to group bulk select button ( #31038 )
...
This bulk-select button on group pages is styled like a default button,
but lacks the `btn-default` class, making it inconsistent to style in
themes
2025-01-28 14:39:07 -05:00
Jarek Radosz
9e3993dd64
DEV: Lock @glimmer/syntax to 0.93.1 ( #31037 )
...
Cross-ref:
https://github.com/discourse/discourse/pull/31003 ,
https://github.com/discourse/discourse/pull/31025 ,
https://github.com/discourse/discourse/pull/31033
2025-01-28 17:52:03 +01:00
Kris
f84a419ab6
DEV: add missing class to top replies button ( #31024 )
...
This button in the topic map has our default button styling, but misses
the btn-default class, making it inconsistent in themes
2025-01-28 08:50:39 -05:00
Manuel Kostka
8d9b3467f3
DEV: Use CSS custom properties ( #31034 )
2025-01-28 08:50:13 -05:00
Jarek Radosz
7dcae416ad
DEV: Run pnpm dedupe on Dependabot PRs ( #30950 )
2025-01-28 13:16:33 +01:00
Alan Guo Xiang Tan
c0fdb2f33d
PERF: Optimize uploads:disable_secure_uploads to load in batches ( #31030 )
...
This commit updates the `uploads:disable_secure_uploads` to be more
memory efficient by loading records in batches instead.
2025-01-28 15:31:00 +08:00
Martin Brennan
ed316b40a4
FIX: Hijack controller for topic move posts ( #31029 )
...
We have had reports of the topic post move endpoint
sometimes timing out, not necessarily with a large
number of posts, but between two topics that have a
large number of posts.
This buys us some time by `hijack`ing the controller,
which gives us 90 seconds instead of the Unicorn 30
seconds to do the work. At some point we may want to
do this in a background job.
c.f.
https://meta.discourse.org/t/moving-posts-to-a-long-topic-fails/347984
2025-01-28 16:27:30 +10:00
Kelv
a2db9f959a
DEV: add IDs of old deprecations to admin warning banner ( #31027 )
...
We are adding some old deprecations (deprecated since 2022 at least) to
the admin warning banner.
2025-01-28 12:56:38 +08:00
Michael Brown
6bf5883fd7
FIX: always search email logs including the cc: addresses
...
It seems from the original commit notes that this was only included as a query
optimisation, but doing so leads to confusion: https://meta.discourse.org/t/348688
Searching for outbound mail to an address should find that address regardless
of whether or not the mail type to search for is explicitly `group_smtp`.
2025-01-27 21:57:24 -05:00
Jarek Radosz
06d135872c
Revert "Build(deps): Bump @glimmer/syntax from 0.93.1 to 0.94.1… ( #31025 )
...
…(#31003 )"
This reverts commit fa6b35b11594c2f68aaacc619c620a8f281897ee.
2025-01-28 12:45:22 +10:00
Ted Johansson
907db4d5fd
DEV: Remove plugin sidebar rendering fallback ( #31012 )
...
We used this flag for experimenting with admin plugin sidebars. We have now settled on a tabbed layout, and this is no longer needed.
This PR simply ignores the flag in a backwards-compatible way, so we can discontinue usage in plugins and then remove the backwards-compatibility in core.
2025-01-28 09:42:24 +08:00
dependabot[bot]
90e4c3e2f7
Build(deps-dev): Bump @swc/core from 1.10.9 to 1.10.11 ( #31019 )
...
Bumps [@swc/core](https://github.com/swc-project/swc ) from 1.10.9 to
1.10.11.
- [Release notes](https://github.com/swc-project/swc/releases )
- [Changelog](https://github.com/swc-project/swc/blob/main/CHANGELOG.md )
-
[Commits](https://github.com/swc-project/swc/compare/v1.10.9...v1.10.11 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-28 00:19:43 +01:00
dependabot[bot]
e4e6cba355
Build(deps-dev): Bump @glint/environment-ember-loose from 1.5.1 to 1.5.2 ( #31020 )
...
Bumps
[@glint/environment-ember-loose](https://github.com/typed-ember/glint )
from 1.5.1 to 1.5.2.
- [Release notes](https://github.com/typed-ember/glint/releases )
-
[Changelog](https://github.com/typed-ember/glint/blob/main/.release-it.yml )
- [Commits](https://github.com/typed-ember/glint/compare/1.5.1...1.5.2 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-28 00:18:52 +01:00
Krzysztof Kotlarek
cfcc60f847
FEATURE: new fast_typing_threshold site setting ( #30865 )
...
Rename `min_first_post_typing_time` to `fast_typing_threshold` and
provide admin 4 options:
- disabled
- low - 1 second
- standard - 3 seconds
- high - 5 seconds
Related PRs:
- https://github.com/discourse/discourse-zoom/pull/112
2025-01-28 09:53:03 +11:00
dependabot[bot]
b4130a76ad
Build(deps-dev): Bump rubocop-ast from 1.37.0 to 1.38.0 ( #31021 )
...
Bumps [rubocop-ast](https://github.com/rubocop/rubocop-ast ) from 1.37.0
to 1.38.0.
- [Release notes](https://github.com/rubocop/rubocop-ast/releases )
-
[Changelog](https://github.com/rubocop/rubocop-ast/blob/master/CHANGELOG.md )
-
[Commits](https://github.com/rubocop/rubocop-ast/compare/v1.37.0...v1.38.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-27 23:34:39 +01:00
dependabot[bot]
ae1fd0fcf3
Build(deps-dev): Bump language_server-protocol from 3.17.0.3 to 3.17.0.4 ( #31022 )
...
Bumps
[language_server-protocol](https://github.com/mtsmfm/language_server-protocol-ruby )
from 3.17.0.3 to 3.17.0.4.
-
[Changelog](https://github.com/mtsmfm/language_server-protocol-ruby/blob/main/CHANGELOG.md )
-
[Commits](https://github.com/mtsmfm/language_server-protocol-ruby/compare/v3.17.0.3...v3.17.0.4 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-27 23:34:26 +01:00
Kris
edb4be7c0f
A11Y: fix color issue with delete topic button in WCAG palette ( #31023 )
...
Reported here:
https://meta.discourse.org/t/wcag-high-contrast-color-palettes-for-low-vision/168795/30
Before:
After:
2025-01-27 17:33:14 -05:00
dependabot[bot]
f0a8f95204
Build(deps-dev): Bump stylelint from 16.14.0 to 16.14.1 ( #31018 )
...
Bumps [stylelint](https://github.com/stylelint/stylelint ) from 16.14.0
to 16.14.1.
- [Release notes](https://github.com/stylelint/stylelint/releases )
-
[Changelog](https://github.com/stylelint/stylelint/blob/main/CHANGELOG.md )
-
[Commits](https://github.com/stylelint/stylelint/compare/16.14.0...16.14.1 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-27 23:01:27 +01:00
Renato Atilio
7206a7182b
UX: re-check triggerRule to avoid autocomplete in code ( #30961 )
...
Re-checks triggerRule when navigating around with arrow keys and after
continued typing.
ref /t/-/23884
2025-01-27 18:55:24 -03:00
dependabot[bot]
a5f533667d
Build(deps): Bump the babel group with 2 updates ( #31001 )
...
Bumps the babel group with 2 updates:
[@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core )
and
[@babel/standalone](https://github.com/babel/babel/tree/HEAD/packages/babel-standalone ).
Updates `@babel/core` from 7.26.0 to 7.26.7
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
-
[Commits](https://github.com/babel/babel/commits/v7.26.7/packages/babel-core )
Updates `@babel/standalone` from 7.26.6 to 7.26.7
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
-
[Commits](https://github.com/babel/babel/commits/v7.26.7/packages/babel-standalone )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-27 22:54:03 +01:00
Penar Musaraj
590c250239
A11Y: Show focus when tabbing to user menu items (bottom bar) ( #31015 )
2025-01-27 15:38:54 -05:00
dependabot[bot]
fa6b35b115
Build(deps): Bump @glimmer/syntax from 0.93.1 to 0.94.1 ( #31003 )
...
Bumps
[@glimmer/syntax](https://github.com/glimmerjs/glimmer-vm/tree/HEAD/packages/@glimmer/syntax )
from 0.93.1 to 0.94.1.
- [Release notes](https://github.com/glimmerjs/glimmer-vm/releases )
-
[Changelog](https://github.com/glimmerjs/glimmer-vm/blob/main/CHANGELOG.md )
-
[Commits](https://github.com/glimmerjs/glimmer-vm/commits/HEAD/packages/@glimmer/syntax )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-27 20:48:34 +01:00
dependabot[bot]
bc051b4d0a
Build(deps-dev): Bump qunit from 2.24.0 to 2.24.1 ( #31008 )
...
Bumps [qunit](https://github.com/qunitjs/qunit ) from 2.24.0 to 2.24.1.
- [Release notes](https://github.com/qunitjs/qunit/releases )
- [Changelog](https://github.com/qunitjs/qunit/blob/main/History.md )
- [Commits](https://github.com/qunitjs/qunit/compare/2.24.0...2.24.1 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-27 20:44:12 +01:00
Penar Musaraj
7303aded24
A11Y: Allow tabbing to members link in chat channel card ( #31016 )
2025-01-27 14:42:23 -05:00
Kris
85344b4b07
UX: sidebar "more" icon color fix ( #31017 )
...
Currently the vertical ellipsis is slightly darker than other sidebar
icons
Before:
After:
2025-01-27 13:47:45 -05:00
Kris
19aed18d4f
UX: hide user card focus until keyboard navigation begins ( #31014 )
...
When the usercard is opened, we manually assign focus to the first link
to capture focus, but this creates an undesirable focus ring for
visitors not relying on focus indicators for navigation.
With this update, the focus is assigned to the container rather than the
first link. This fulfills the goal of capturing focus within the user
card, but hides the focus ring until navigation within the card begins.
`tabindex="-1"` is necessary because this allows us to manually focus
the container (normally unfocusable) while removing it from the tab
order for subsequent navigation.
Before:
After:
then on tab:
---------
Co-authored-by: Penar Musaraj <pmusaraj@gmail.com>
2025-01-27 12:34:04 -05:00
dependabot[bot]
89d358d811
Build(deps-dev): Bump jsuites from 5.8.5 to 5.9.0 ( #31004 )
...
Bumps [jsuites](https://github.com/jsuites/jsuites ) from 5.8.5 to 5.9.0.
- [Release notes](https://github.com/jsuites/jsuites/releases )
-
[Changelog](https://github.com/jsuites/jsuites/blob/master/changelog.md )
- [Commits](https://github.com/jsuites/jsuites/commits )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-27 16:38:50 +01:00
dependabot[bot]
fc77464751
Build(deps-dev): Bump rubocop-rails from 2.29.0 to 2.29.1 ( #31009 )
...
Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails ) from
2.29.0 to 2.29.1.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases )
-
[Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md )
-
[Commits](https://github.com/rubocop/rubocop-rails/compare/v2.29.0...v2.29.1 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-27 16:38:07 +01:00
dependabot[bot]
fc95144728
Build(deps-dev): Bump @glint/template from 1.5.1 to 1.5.2 ( #31007 )
...
Bumps [@glint/template](https://github.com/typed-ember/glint ) from 1.5.1
to 1.5.2.
- [Release notes](https://github.com/typed-ember/glint/releases )
-
[Changelog](https://github.com/typed-ember/glint/blob/main/.release-it.yml )
- [Commits](https://github.com/typed-ember/glint/compare/1.5.1...1.5.2 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-27 16:36:35 +01:00
dependabot[bot]
a4dbdfd90a
Build(deps-dev): Bump puppeteer-core from 24.1.0 to 24.1.1 ( #30966 )
...
Bumps [puppeteer-core](https://github.com/puppeteer/puppeteer ) from
24.1.0 to 24.1.1.
- [Release notes](https://github.com/puppeteer/puppeteer/releases )
-
[Changelog](https://github.com/puppeteer/puppeteer/blob/main/CHANGELOG.md )
-
[Commits](https://github.com/puppeteer/puppeteer/compare/puppeteer-core-v24.1.0...puppeteer-core-v24.1.1 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-27 16:36:15 +01:00
Joffrey JAFFEUX
a52a8f4663
FIX: correctly closes panels in threads ( #31013 )
...
The following case was bugged:
- visit a thread in full page chat
- click channel title
- click back button in channel navbar
- 💥 you would have a channel with limited width as if there was
still the thread showing next to it, but it was empty
2025-01-27 16:34:56 +01:00
dependabot[bot]
c20aa5f671
Build(deps-dev): Bump @glint/core from 1.5.1 to 1.5.2 ( #31006 )
...
Bumps [@glint/core](https://github.com/typed-ember/glint ) from 1.5.1 to
1.5.2.
- [Release notes](https://github.com/typed-ember/glint/releases )
-
[Changelog](https://github.com/typed-ember/glint/blob/main/.release-it.yml )
- [Commits](https://github.com/typed-ember/glint/compare/1.5.1...1.5.2 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-27 15:26:07 +01:00
dependabot[bot]
0345ae64c2
Build(deps-dev): Bump eslint from 9.18.0 to 9.19.0 ( #31005 )
...
Bumps [eslint](https://github.com/eslint/eslint ) from 9.18.0 to 9.19.0.
- [Release notes](https://github.com/eslint/eslint/releases )
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md )
- [Commits](https://github.com/eslint/eslint/compare/v9.18.0...v9.19.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-27 15:25:32 +01:00
dependabot[bot]
29c0ca9459
Build(deps-dev): Bump stylelint from 16.13.2 to 16.14.0 ( #31002 )
...
Bumps [stylelint](https://github.com/stylelint/stylelint ) from 16.13.2
to 16.14.0.
- [Release notes](https://github.com/stylelint/stylelint/releases )
-
[Changelog](https://github.com/stylelint/stylelint/blob/main/CHANGELOG.md )
-
[Commits](https://github.com/stylelint/stylelint/compare/16.13.2...16.14.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-27 15:24:26 +01:00
Renato Atilio
0d240308c8
FIX: reset bool site setting not updating checkbox ( #30999 )
2025-01-27 10:53:27 -03:00
Renato Atilio
5d1c696240
UX: respect user locale when sending chat notices ( #30996 )
2025-01-27 10:53:13 -03:00
Joffrey JAFFEUX
83a47c36a5
DEV: implements model/afterModel/deactivate in drawer router ( #29879 )
...
These changes allow to load model when loading a screen of the drawer,
the underlying idea is to avoid having to rely on the global
`activeChannel`, this essentially makes each screen responsible for it's
data.
This change is also fixing a bug where clicking on a link routing to the
same screen of the drawer you are already on, would display a blank
drawer.
2025-01-27 11:03:15 +01:00
