Guo Xiang Tan
b6a139b581
Fix broken spec.
2018-09-06 12:41:43 +08:00
Guo Xiang Tan
434035f167
FIX: Link post to uploads in PostCreator
.
...
* This ensures that uploads are linked to their post on creation
instead of a background job which may be delayed if Sidekiq
is facing difficulties.
2018-09-06 11:18:11 +08:00
Jeff Atwood
5baecffb0d
improved opengraph site setting copy
2018-09-05 19:54:45 -07:00
Sam
5bdc00c3be
FIX: do not automatically route all actions to hovered posts
...
This feature (hitting d when a post is hovered with mouse deletes) causes a lot of confusion and is very risky.
2018-09-06 10:34:58 +10:00
Kris
8cff3c9bbc
UX: Prevent long names from overflowing post
2018-09-05 17:48:31 -04:00
Joffrey JAFFEUX
e59622f2ba
FIX: deactivate chart trends for now ( #6364 )
2018-09-05 23:33:29 +02:00
Gerhard Schlager
26082688d1
FIX: Zero is a valid value for the page parameter
2018-09-05 20:43:05 +02:00
Kris
1c65969bb4
post read-state icon alignment
2018-09-05 13:19:36 -04:00
Joffrey JAFFEUX
17087eff2a
FIX: Reset tags on category change ( #6363 )
2018-09-05 17:18:52 +02:00
Guo Xiang Tan
f3aef2cc83
FIX: Incorrect/missing extension in short_url fails to map to upload.
...
`Hash#invert` causes us to lose keys if the hash contains similar
values.
2018-09-05 21:48:58 +08:00
Gerhard Schlager
3134dd4763
FIX: Wizard didn't change locale when Enter key was used in drop-down
2018-09-05 15:14:09 +02:00
Gerhard Schlager
2801376df5
FIX: Wizard didn't load translations correctly
...
* Translations from the js.* namespace were not found, because the i18n-patches were not loaded.
* The extra-locales didn't use a hash in the URL.
2018-09-05 15:14:09 +02:00
Gerhard Schlager
2c5d9269a0
FIX: Notifications shouldn't use user locale unless allow_user_locale is enabled
2018-09-05 11:44:28 +02:00
Guo Xiang Tan
72834f19ff
DEV: Add rake tasks to list posts with broken images.
2018-09-05 16:54:15 +08:00
Sam
d9c0dc8687
correct prev commit
...
s3. did not exists it is s3-
2018-09-05 16:11:44 +10:00
Sam
83e1315e42
FIX: correct urls in uploads table to point at dualstack
...
Last week we added support for dual stack urls but did not remap the
the old records in the uploads and optimized images table
This caused a few minor edge cases worst was that if you rebaked old
images S3 CDN was not repopulated.
2018-09-05 15:58:04 +10:00
Gerhard Schlager
9d35240620
Revert "FIX: Notifications shouldn't use user locale unless allow_user_locale is enabled"
...
This reverts commit c788737eed
.
2018-09-05 01:53:22 +02:00
Gerhard Schlager
f4956f79a5
Make Rubocop happy
2018-09-05 01:04:43 +02:00
Gerhard Schlager
e22bf8ff28
Update German translations
2018-09-05 00:47:39 +02:00
Gerhard Schlager
44922b0c25
zh_TW isn't broken anymore
2018-09-05 00:47:39 +02:00
Gerhard Schlager
6658a6601c
Remove unused rake task
2018-09-05 00:47:39 +02:00
Gerhard Schlager
0d8c72d8c4
DEV: Add rake task to check locale files for errors
2018-09-05 00:47:39 +02:00
Gerhard Schlager
b8fc699164
FIX: Detect {{foo}} as interpolation key
2018-09-05 00:47:39 +02:00
Gerhard Schlager
c788737eed
FIX: Notifications shouldn't use user locale unless allow_user_locale is enabled
2018-09-05 00:47:39 +02:00
Vinoth Kannan
d9be4f47e8
SPEC: redirect to original URL after social signup
2018-09-05 03:24:50 +05:30
Vinoth Kannan
8a952a2cc2
Make prettier happy
2018-09-05 02:00:13 +05:30
Kris
5cf1a9a23a
UX: primary & danger buttons should lighten on hover in dark themes
2018-09-04 16:18:10 -04:00
Vinoth Kannan
d8b543bb67
FIX: redirect to original URL after social signup
2018-09-05 01:44:23 +05:30
David Taylor
4382fb5fac
DEV: Allow plugins to whitelist specific user custom_fields for editing ( #6358 )
2018-09-04 20:45:36 +10:00
Guo Xiang Tan
d1af89e3b3
DEV: Extract global admin api rate limiting into a dedicated method.
...
* We have a use case for overriding the rate limiting logic in a
plugin.
2018-09-04 16:37:54 +08:00
Sam
6e3f249aea
Disable auth token logging
...
We have a work in progress feature that required the logging,
This feature is not going to be shipped for a while so disabling this
for now.
2018-09-04 17:05:17 +10:00
Guo Xiang Tan
3b337bfc6b
Revert "FIX: Don't rate limit admin and staff constraints when matching routes."
...
This reverts commit 651b50b1a1
.
2018-09-04 14:27:21 +08:00
Sam
e4498d2a8a
FIX: keep db and job correctly in multisite logs
...
This ensures we report job and db correctly, previously we were
only reporting this on default
2018-09-04 16:05:44 +10:00
Guo Xiang Tan
19182c0c8f
DEV: Skip fragile tests for now.
2018-09-04 13:58:09 +08:00
Guo Xiang Tan
651b50b1a1
FIX: Don't rate limit admin and staff constraints when matching routes.
...
* When an error is raised when checking route constraints, we
can only return true/false which either lets the request
through or return a 404 error. Therefore, we just skip
rate limiting here and let the controller handle the
rate limiting.
2018-09-04 13:52:58 +08:00
Guo Xiang Tan
edbcc992d4
Allow unicorn timeout to be configurable via ENV.
2018-09-04 13:21:41 +08:00
Vinoth Kannan
f896d6b021
FIX: Skip keypress event if alt key is down
2018-09-04 10:45:35 +05:30
Guo Xiang Tan
08b268c5bc
Be more forceful in disconnecting connections during failover.
2018-09-04 10:32:43 +08:00
Sam
ad70502ab8
FIX: ignore invalid usernames in incoming link tracker
...
If an incoming link username has NULL in it simply ignore it
2018-09-04 12:28:32 +10:00
Guo Xiang Tan
8dc1463ab3
Enable Lint/ShadowingOuterLocalVariable
for Rubocop.
2018-09-04 10:16:42 +08:00
Sam
2f5c21e28c
FIX: return a 400 error instead of 500 for null injections
...
Many security scanners like to inject NULL in inputs causing application
to exception out and return a 500
We now handle this exception and render a 400 status back
2018-09-04 12:11:52 +10:00
Guo Xiang Tan
0a14e0a256
Ensure params[:files]
responds to map
in Lograge.
2018-09-04 09:22:54 +08:00
Sam
fcae21c4fc
remove test that is no longer relevant
2018-09-04 10:52:12 +10:00
Sam
3748d3e281
UX: hide associate accounts if second factor is enabled
...
Once second factor is enabled all login via associated accounts is banned
showing this section just leads to confusion
2018-09-04 10:42:39 +10:00
Sam
155eb02c7e
UX: remove auth token log from user page
...
This feature is not quite ready so we are deferring on it for a few more weeks
2018-09-04 10:28:33 +10:00
Gerhard Schlager
eeedc3901e
FIX: Replying to deleted post via email should create new reply to topic
2018-09-03 23:06:40 +02:00
Vinoth Kannan
fe6c3b7d2e
Make prettier happy
2018-09-04 00:31:41 +05:30
Vinoth Kannan
24a14af15a
FIX: Respect invalidate_oneboxes option for inline oneboxes
2018-09-03 22:33:43 +05:30
Guo Xiang Tan
ecf60c0c33
DEV: More attempts at stablizing specs in Travis.
...
Re-enable skipped test because it doesn't fail locally
for me to debug it.
2018-09-03 14:52:15 +08:00
Gerhard Schlager
f33433bf9e
Validation of params should restrict to max int ( #6331 )
...
* FIX: Validation of params should restrict to max int
* FIX: Send status 400 when "page" param isn't between 1 and max int
2018-09-03 14:45:32 +10:00