Martin Brennan
7afb5fc481
DEV: Use Discourse::SYSTEM_USER_ID in fixtures/009_users ( #24743 )
...
I couldn't find where we created the system user and
this is why -- everywhere else in the app we reference
SYSTEM_USER_ID but here.
2023-12-07 09:04:45 +10:00
Kris
c197f8c6ee
UX: make github onebox styles more responsive ( #24761 )
2023-12-06 17:45:56 -05:00
Jarek Radosz
694b5f108b
DEV: Fix various rubocop lints ( #24749 )
...
These (21 + 3 from previous PRs) are soon to be enabled in rubocop-discourse:
Capybara/VisibilityMatcher
Lint/DeprecatedOpenSSLConstant
Lint/DisjunctiveAssignmentInConstructor
Lint/EmptyConditionalBody
Lint/EmptyEnsure
Lint/LiteralInInterpolation
Lint/NonLocalExitFromIterator
Lint/ParenthesesAsGroupedExpression
Lint/RedundantCopDisableDirective
Lint/RedundantRequireStatement
Lint/RedundantSafeNavigation
Lint/RedundantStringCoercion
Lint/RedundantWithIndex
Lint/RedundantWithObject
Lint/SafeNavigationChain
Lint/SafeNavigationConsistency
Lint/SelfAssignment
Lint/UnreachableCode
Lint/UselessMethodDefinition
Lint/Void
Previous PRs:
Lint/ShadowedArgument
Lint/DuplicateMethods
Lint/BooleanSymbol
RSpec/SpecFilePathSuffix
2023-12-06 23:25:00 +01:00
Kris
42a75e3df9
FIX: saving tag changes without description ( #24753 )
2023-12-06 14:17:56 -05:00
chapoi
42e5bbaf38
UX: fix double-scrollbar in keyboard-shortcuts-modal ( #24751 )
2023-12-06 17:12:14 +01:00
Mark VanLandingham
efcb5bb3df
DEV: Plugin outlet around user menu empty state ( #24730 )
2023-12-06 08:06:50 -06:00
Jarek Radosz
6a66dc1cfb
DEV: Fix Lint/BooleanSymbol ( #24747 )
2023-12-06 13:19:09 +01:00
Jarek Radosz
138bf486d3
DEV: Fix Lint/DuplicateMethods ( #24746 )
2023-12-06 13:18:34 +01:00
Jarek Radosz
4280c01153
DEV: Fix Lint/ShadowedArgument ( #24733 )
2023-12-06 13:16:10 +01:00
David Taylor
1e471f7ec2
FIX: Handle 404 correctly when transition has no path ( #24748 )
2023-12-06 12:12:19 +00:00
David Taylor
b3d1707b65
DEV: Refactor Wizard routes, controllers and templates ( #24725 )
...
Extracted from https://github.com/discourse/discourse/pull/23678
Co-authored-by: Godfrey Chan <godfreykfc@gmail.com>
2023-12-06 12:07:07 +00:00
David Battersby
8b46dc8bb5
FEATURE: Add thumbnails for chat image uploads ( #24328 )
...
Introduces the concept of image thumbnails in chat, prior to this we uploaded and used full size chat images within channels and direct messages.
The following changes are covered:
- Post processing of image uploads to create the thumbnail within Chat::MessageProcessor
- Extract responsive image ratios into CookedProcessorMixin (used for creating upload variations)
- Add thumbnail to upload serializer from plugin.rb
- Convert chat upload template to glimmer component using .gjs format
- Use thumbnail image within chat upload component (stores full size img in orig-src data attribute)
- Old uploads which don't have thumbnails will fallback to full size images in channels/DMs
- Update Magnific lightbox to use full size image when clicked
- Update Glimmer lightbox to use full size image (enables zooming for chat images)
2023-12-06 14:59:18 +08:00
Martin Brennan
30d5e752d7
DEV: Revert guardian changes ( #24742 )
...
I took the wrong approach here, need to rethink.
* Revert "FIX: Use Guardian.basic_user instead of new (anon) (#24705 )"
This reverts commit 9057272ee2#24735 )"
This reverts commit a5d4bf6dd2#24706 )"
This reverts commit 77b6a038ba#24681 )"
This reverts commit de983796e1
2023-12-06 16:37:32 +10:00
Martin Brennan
9057272ee2
FIX: Use Guardian.basic_user instead of new (anon) ( #24705 )
...
c.f. de983796e1
2023-12-06 11:56:21 +10:00
Martin Brennan
3141994e38
FIX: Add checkbox-label to notification bulk actions ( #24734 )
...
Followup to c80b5b718c
2023-12-06 11:22:48 +10:00
Ella E
47629db3db
UX: Add a link from admin reports page to meta a topic ( #24707 )
...
* UX: Add a link from admin reports page to meta a topic
* DEV: apply prettier
2023-12-05 16:37:44 -07:00
Kris
3a98474983
A11Y: allow tab titles to use default translation ( #24727 )
2023-12-05 17:16:56 -05:00
Kris
b65f281842
FIX: escape category description text ( #24724 )
2023-12-05 15:48:13 -05:00
Mark VanLandingham
d4c02d738b
DEV: Add topicNotificationLevel fn to post model ( #24723 )
2023-12-05 12:08:29 -06:00
David Taylor
a5fc8f3253
FIX: Account activation under ember-5 build ( #24722 )
...
We were previously relying on Ember's 'vendor' bundle to make the jquery global available on the activate_account route. That no longer happens under our Ember 5 build.
This commit updates our activate-account script to remove the need for jquery, so that it works under both Ember 3 and Ember 5 builds.
2023-12-05 17:49:40 +00:00
Isaac Janzen
6aeddad333
DEV: Add search-menu-before-advanced-search plugin outlet ( #24720 )
2023-12-05 10:08:27 -07:00
David Taylor
863c0cdecc
FIX: Ensure slugless topic URLs are correctly redirected ( #24719 )
...
Using `DiscourseURL.routeTo` with `replaceURL: true` wouldn't cause a true Ember redirect. That meant that the transition source would be be replaced in the browser's history stack, and the 'back' button wouldn't work as expected. Instead, we can use the router service to perform a proper redirect.
2023-12-05 15:37:01 +00:00
chapoi
ad77a6876c
UX: fix alignment ( #24718 )
2023-12-05 14:19:21 +01:00
dependabot[bot]
9a10f9d240
Build(deps): Bump terser from 5.24.0 to 5.25.0 in /app/assets/javascripts ( #24703 )
...
* Build(deps): Bump terser in /app/assets/javascripts
Bumps [terser](https://github.com/terser/terser ) from 5.24.0 to 5.25.0.
- [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md )
- [Commits](https://github.com/terser/terser/compare/v5.24.0...v5.25.0 )
---
updated-dependencies:
- dependency-name: terser
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* Update lockfiles for ember version flag
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: discoursebuild <build@discourse.org>
2023-12-05 11:50:29 +01:00
Isaac Janzen
b9110c5a71
FIX: Don't refresh on topic search result click ( #24697 )
...
Fixes an issue where when selecting a topic search result we were refreshing the page rather than letting `DiscourseURL` redirect us to the given topic. This was because we were leaning on a `a` tag and it's href to handle the redirect
3aeff56faf/app/assets/javascripts/discourse/app/components/search-menu/results/types.hbs (L15-L16)
2023-12-04 11:27:38 -07:00
David Taylor
87d850948f
PERF: Only apply terser to production assets ( #24699 )
...
We funnel vendored javascript through ember-cli, but that's only used for the testem environment. Therefore, there's no need to minify it in production builds. In my tests, this reduces peak RSS of a production build from 3.53GB to 3.15GB.
2023-12-04 18:05:55 +00:00
Kris
c4381e0265
FIX: don't apply extraClassName to all popup menus ( #24695 )
2023-12-04 11:40:57 -06:00
David Taylor
9479b30ada
FIX: Ensure 'untagged' document title is set correctly ( #24689 )
...
https://meta.discourse.org/t/286130/4
2023-12-04 13:43:02 +00:00
David Taylor
cdb904a1b0
DEV: Remove unused htmlbars-inline-precompile shim ( #24687 )
...
Since 4425e99bf9
2023-12-04 12:34:45 +00:00
Jarek Radosz
e0c876696a
DEV: Fix some qunit linting issues ( #24686 )
...
`qunit/literal-compare-order`
`qunit/no-compare-relation-boolean`
`qunit/assert-args`
2023-12-04 13:32:16 +01:00
Jarek Radosz
2029777b86
DEV: Replace AdminWrapper with body-class/html-class ( #24683 )
...
AdminWrapper isn't used (directly) in all-the*
Co-authored-by: David Taylor <david@taylorhq.com>
2023-12-04 12:53:07 +01:00
chapoi
1df1a9490d
UX: fix sidebar modal ( #24646 )
...
* UX: fix modal width
2023-12-04 08:10:17 +01:00
Krzysztof Kotlarek
d9ac0c33ff
FIX: update tag description field placeholder ( #24644 )
...
Improvements after https://github.com/discourse/discourse/pull/24561
1. Make placeholder more descriptive
2. Respect new line breaks in description
2023-12-04 09:38:20 +11:00
Kris
56795f5c07
UX: improve btn-transparent styling ( #24666 )
2023-12-02 14:21:22 +11:00
David Taylor
aba3acf4cc
DEV: Correct deprecation id for discovery-controller-shims ( #24671 )
2023-12-01 19:11:48 +00:00
Mark VanLandingham
fb06cd6712
DEV: Add JS API to adjust desktop topic timeline min/max height ( #24669 )
2023-12-01 10:29:12 -06:00
David Taylor
9f9c82ea97
DEV: Only add ember-global deprecation for Ember 3 ( #24667 )
...
(otherwise, we're accidentally extending support into Ember 5!)
Followup to 106c1c317f
2023-12-01 14:50:15 +00:00
chapoi
f8bf4bda00
UX: fix info text color on custom field for login ( #24665 )
2023-12-01 14:41:44 +01:00
David Taylor
106c1c317f
DEV: Restore ember-global deprecation in production ( #24664 )
...
Even with our patch to the deprecate() macro, this is optimized out of the production build because it's wrapped in an `if(DEBUG)` statement. (https://github.com/davidtaylorhq/ember.js/blob/14c02f53b8/packages/%40ember/-internals/bootstrap/index.ts#L19-L19 )
2023-12-01 13:07:57 +00:00
David Taylor
b72a177fb3
DEV: Exclude deprecation-collector plugin from source identifier ( #24662 )
2023-12-01 12:21:19 +00:00
dependabot[bot]
4df672a541
Build(deps-dev): Bump jsdom from 23.0.0 to 23.0.1 in /app/assets/javascripts ( #24657 )
...
* Build(deps-dev): Bump jsdom in /app/assets/javascripts
Bumps [jsdom](https://github.com/jsdom/jsdom ) from 23.0.0 to 23.0.1.
- [Release notes](https://github.com/jsdom/jsdom/releases )
- [Changelog](https://github.com/jsdom/jsdom/blob/main/Changelog.md )
- [Commits](https://github.com/jsdom/jsdom/compare/23.0.0...23.0.1 )
---
updated-dependencies:
- dependency-name: jsdom
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
* Update lockfiles for ember version flag
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: discoursebuild <build@discourse.org>
2023-12-01 11:11:16 +01:00
Isaac Janzen
aadc104817
FIX: Flashing when loading glimer search results ( #24658 )
2023-11-30 20:54:32 -07:00
Isaac Janzen
7539b457b2
DEV: Add forceDropdownForMenuPanels to plugin api ( #24655 )
2023-11-30 15:26:13 -07:00
Keegan George
d2b53ccac2
DEV: Port discourse-table-builder theme component to core ( #24441 )
2023-11-30 10:54:29 -08:00
chapoi
9fb4175008
UX: make summary 100% height ( #24649 )
2023-11-30 12:29:26 +01:00
Meghna
91ab2766e9
UX: properly align close button icon on composer messages ( #24632 )
2023-11-30 13:21:50 +05:30
Krzysztof Kotlarek
7e013b2120
DEV: add recurrence rule parameter to downloadCalendar API ( #24404 )
...
Add option to create recurrent calendar events. Recurrence rule parameter follows rfc5545 specification: https://datatracker.ietf.org/doc/html/rfc5545#section-3.3.10
2023-11-30 13:56:22 +11:00
Martin Brennan
c58cd697d2
FIX: Further improvements for plugin list ( #24622 )
...
Followup e37fb3042d
2023-11-30 10:53:17 +10:00
dependabot[bot]
f90fab3628
Build(deps): Bump the babel group in /app/assets/javascripts with 2 updates ( #24637 )
...
* Build(deps): Bump the babel group
Bumps the babel group in /app/assets/javascripts with 2 updates: [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core ) and [@babel/standalone](https://github.com/babel/babel/tree/HEAD/packages/babel-standalone ).
Updates `@babel/core` from 7.23.3 to 7.23.5
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.23.5/packages/babel-core )
Updates `@babel/standalone` from 7.23.4 to 7.23.5
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.23.5/packages/babel-standalone )
---
updated-dependencies:
- dependency-name: "@babel/core"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: babel
- dependency-name: "@babel/standalone"
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: babel
...
Signed-off-by: dependabot[bot] <support@github.com>
* Update lockfiles for ember version flag
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: discoursebuild <build@discourse.org>
2023-11-29 22:29:41 +01:00
Daniel Waterworth
434ae5bbe7
FIX: Allow setting an array custom field to a singleton value ( #24636 )
...
Also, validation happens per item in an array field.
2023-11-29 14:18:47 -06:00
