5 Commits

Author	SHA1	Message	Date
Robin Ward	8311374a5a	DEV: Replace version.js.erb with pre generated file	2020-05-11 15:43:09 -04:00
Robin Ward	d2b16a7618	DEV: Generate emoji/data on demand (#9744) ... These emoji rarely change and can be re-generated when we make changes to them.	2020-05-11 15:29:46 -04:00
Joffrey JAFFEUX	00a038d646	REFACTOR: removes various assignments and superfluous params (#9699)	2020-05-08 09:19:48 +02:00
Robin Ward	f9608c0af5	DEV: Remove INLINE_ONEBOX_* constants ... There were two constants here, `INLINE_ONEBOX_LOADING_CSS_CLASS` and `INLINE_ONEBOX_CSS_CLASS` that were both longer than the strings they were DRYing up: `inline-onebox-loading` and `inline-onebox` I normally appreciate constants, but in this case it meant that we had a lot of JS imports resulting in many more lines of code (and CPU cycles spent figuring them out.) It also meant we had an `.erb` file and had to invoke Ruby to create the JS file, which meant the app was harder to port to Ember CLI. I removed the constants. It's less DRY but faster and simpler, and arguably the loss of DRYness is not significant as you can still search for the `inline-onebox-loading` and `inline-onebox` strings easily if you are refactoring.	2020-05-07 16:14:38 -04:00
Robin Ward	79c64eaeff	DEV: Move pretty-text into an ember-addon format (#9689)	2020-05-07 12:37:47 -04:00