github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-30 22:54:57 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
22,313 Commits 214 Branches 500 Tags 960 MiB
823e50b099
Commit Graph

13397 Commits

Author SHA1 Message Date
Guo Xiang Tan
566f367fc3 FIX: Don't migrate custom emojis that are no longer valid. 
* Warn about failed migration in logs.
 2017-03-17 08:28:24 +08:00
Victor van Poppelen
9e60f9f093 JSON API parsing error on CSRF exception: single quotes in ['BAD CSRF'] is invalid JSON: 
https://meta.discourse.org/t/json-api-parsing-error-single-quotes-used-for-errors-like-bad-csrf/58869
 2017-03-16 16:47:18 -07:00
Neil Lalonde
ad8a579c79 UX: banner enabled/disabled posts should be small posts, not full-size posts 2017-03-16 17:31:37 -04:00
Robin Ward
1957d12670 SECURITY: Don't use backticks for exporting your archive 2017-03-16 16:24:59 -04:00
Neil Lalonde
22f197c153 FEATURE: subcategory list style: boxes with featured topics 2017-03-16 11:54:45 -04:00
Sam
2c952e1981 Merge pull request #4760 from nbianca/fix_topic_title 
Fixes duplicated title in header after edit
 2017-03-16 11:49:45 -04:00
Bianca Nenciu
f8a31d927f Fixes duplicated topic title in header after edit. 2017-03-16 17:34:39 +02:00
Robin Ward
fd591257a8 Merge pull request #4759 from kennym/support-ports-for-ip-addresses-in-embedding 
FIX: Allow ports for embed host IPs
 2017-03-16 11:23:42 -04:00
Guo Xiang Tan
9f299b6842 Use after_commit since after_save runs within the transaction as well. 2017-03-16 16:02:34 +08:00
Guo Xiang Tan
299b92b4d7 Fix broken user created event trigger. 2017-03-16 15:36:27 +08:00
Guo Xiang Tan
5169ef8814 Fix broken specs. 2017-03-16 15:05:28 +08:00
Guo Xiang Tan
bf78c228f4 FIX: User created web hook being enqueued before record has been saved. 
* Improve web hook tests as well.
 2017-03-16 14:44:09 +08:00
Guo Xiang Tan
bb85795934 FIX: Leave group membership button not updating. 
https://meta.discourse.org/t/leave-group-button-on-groups-page-doesnt-give-any-feedback/57359/4
 2017-03-16 11:33:55 +08:00
Guo Xiang Tan
65c000ad74 FEATURE: Track views on user profile card as profile views. 2017-03-16 10:59:08 +08:00
Guo Xiang Tan
0a87547cbc Fix broken tests. 2017-03-16 10:22:15 +08:00
Erick Guan
cfbfea0596 FEATURE: Allow easier customization to the web hook event serialization. 2017-03-16 10:09:05 +08:00
Guo Xiang Tan
bbc85e1e29 Merge pull request #4750 from discourse/group_login_registration_flow 
FEATURE: Redirect to groups page and apply group actions upon login/s…
 2017-03-16 09:50:56 +08:00
Guo Xiang Tan
ca965bb455 FEATURE: Redirect to groups page after login/registration flow. 2017-03-16 09:48:51 +08:00
giorgia
576982484d FEATURE: Make admin user list sortable. 
https://meta.discourse.org/t/make-admin-users-list-sortable-suggestion/47649
 2017-03-16 09:24:15 +08:00
Vinoth Kannan
d3f07122c4 UX: 'Join Group' button position moved to group header 2017-03-16 08:40:27 +08:00
Kenny Meyer
ae957bca25 Allow ports for embed host IPs 2017-03-15 18:16:34 -03:00
Sam
61a7162c01 Merge pull request #4747 from gsambrotta/show-disable-delete-btn-cat 
Show disable delete btn cat
 2017-03-15 15:45:05 -04:00
Neil Lalonde
5c4f37a24e cdn-img will render nothing if src is null 2017-03-15 13:30:29 -04:00
Anaketa
d7dedc4649 add show/hide to tooltip 2017-03-15 17:23:52 +01:00
Anaketa
63febf391b create btn, tooltip and style it 2017-03-15 17:16:21 +01:00
Guo Xiang Tan
911d6abfad Merge pull request #4757 from nbianca/change_timestamp_bug 
Change timestamp only for admin.
 2017-03-15 10:44:19 +08:00
Neil Lalonde
bc31d25132 some cleanup thanks to eviltrout 2017-03-14 17:23:19 -04:00
Neil Lalonde
5c923fef58 FIX: category logo preview in settings shouldn't render it like a background image 2017-03-14 17:12:09 -04:00
Sam
7378077036 Merge pull request #4749 from cpradio/add-subcategory-class-hamburger-menu 
UX: Add subcategory class to hamburger menu items that are subcategories
 2017-03-14 17:08:35 -04:00
Bianca Nenciu
8354768d7c Change timestamp only for admin. 2017-03-14 23:07:36 +02:00
Neil Lalonde
889902256b FIX: encoded characters shown in category boxes 2017-03-14 14:51:11 -04:00
Sam
8ac7e6a605 Merge pull request #4753 from cpradio/plugin-outlet-user-preferences 
DEV: Add plugin-outlet to allow SSO sites to put a message on the User Preferences page
 2017-03-14 10:32:09 -04:00
Guo Xiang Tan
58de40154d Bump EMOJI_VERSION to clear cache. 2017-03-14 15:31:01 +08:00
Guo Xiang Tan
6a6113fcea Merge pull request #4682 from tgxworld/store_custom_emoji_as_uploads 
FIX: Store custom emojis as uploads.
 2017-03-14 14:14:18 +08:00
Guo Xiang Tan
324b346bb1 FIX: Restore was not redirecting to logs route. 2017-03-14 14:00:18 +08:00
Guo Xiang Tan
1a7e954e09 FIX: Store custom emojis as uploads. 
* Depending on a hardcoded directory was a flawed design
  which made it impossible to debug when custom emojis go
  missing.
 2017-03-14 13:07:18 +08:00
Guo Xiang Tan
99943ec769 Make eslint happy. 2017-03-14 11:52:15 +08:00
Guo Xiang Tan
83d2e63771 Make eslint happy. 2017-03-14 11:47:35 +08:00
Guo Xiang Tan
8e45322b09 FIX: Only group admins can see group edit page. 2017-03-14 11:45:58 +08:00
cpradio
a5af9a834f DEV: Add plugin-outlet to allow SSO sites to put a message on the User Preferences page 2017-03-13 18:26:00 -04:00
Neil Lalonde
318f7bab4b fix padding so entire box is clickable 2017-03-13 16:49:03 -04:00
Neil Lalonde
3dab932b96 fix trying to render cdn image of undefined 2017-03-13 16:22:37 -04:00
Neil Lalonde
6d7e968e30 FEATURE: box-style rendering of sub-categories 2017-03-13 15:25:52 -04:00
Régis Hanol
30d5d61158 use 'toLocaleDateString()' 2017-03-13 16:11:49 +01:00
cpradio
15f7fff561 UX: Add subcategory class to hamburger menu items that are subcategories 
UX: Add data-category-url to make targetting a category li element in the hamburger menu easier
 2017-03-13 10:51:41 -04:00
Sam
64680286f4 correct logic, so revalidation is reset 
correct test so it can run at any point
 2017-03-13 10:47:43 -04:00
Sam
a690121805 SECURITY: always allow staff to resend activation mails 2017-03-13 10:32:24 -04:00
Sam
1a745ca16a else @user makes no sense :) 2017-03-13 10:22:23 -04:00
Sam
ef24fd54ba FEATUE: automatically validate token is stored in redis 
This ensures we have some handling for redis flushall

We attempt to recover our in-memory session token once every 30 seconds

Code is careful to only set the token if it is nil, to allow for manual
cycling to remain safe if needed
 2017-03-13 10:19:02 -04:00
Guo Xiang Tan
9364d8ce71 FIX: Store user's id instead for sending activation email. 
* Email and username are both allowed to be used for logging in.
  Therefore, it is easier to just store the user's id rather than
  to store the username and email in the session.
 2017-03-13 20:24:55 +08:00
Guo Xiang Tan
7ebfa3c901 SECURITY: Only allow users to resend activation email with a valid session. 
* Improve error when an active user tries to request for an activation email.
 2017-03-13 19:35:29 +08:00
Régis Hanol
dd60cb82c3 UX: add client-side rate limit on click counters 2017-03-13 11:31:37 +01:00
Arpit Jalan
848120c098 FEATURE: RSS feed for top page period filters 2017-03-13 15:23:46 +05:30
Guo Xiang Tan
4d4a1a1552 Add scope for human users. 2017-03-11 14:25:09 +08:00
Sam
16593ae8bf FEATURE: log reason staff auto blocks a user 2017-03-10 15:45:48 -05:00
Sam
f13367cecd FIX: latest + category not respecting homepage category suppression 2017-03-10 15:17:51 -05:00
Sam
19ad1e2c2e less opacity for quote button 2017-03-10 14:57:58 -05:00
Neil Lalonde
402ddb810c FIX: email customizations now apply to both html and text parts 2017-03-10 14:08:03 -05:00
Neil Lalonde
15adbdcdd5 FEATURE: new template parameters for notification emails that can be used in links: topic_title_url_encoded and site_title_url_encoded 2017-03-10 14:08:03 -05:00
Sam
bc1a6ccb90 Merge pull request #4741 from tgxworld/allow_bookmark_removal 
FIX: Allow user to remove bookmark from posts as long as bookmark is …
 2017-03-10 12:49:20 -05:00
Arpit Jalan
f7e7ca3937 FEATURE: anonymized site statistics 2017-03-10 18:50:26 +05:30
Guo Xiang Tan
0e41b1181a UX: Display button to add a group when no group has been selected. 
https://meta.discourse.org/t/new-button-on-groups/44546
 2017-03-10 17:15:49 +08:00
Guo Xiang Tan
eb6ef0311e Hide special users from about pages. 2017-03-10 15:33:31 +08:00
Guo Xiang Tan
a43ec88f46 Merge pull request #4743 from tgxworld/fix_autocomplete_being_rerendered 
FIX: Category autocomplete breaks when search menu widget rerenders.
 2017-03-10 09:42:18 +08:00
Sam
3032aa7db9 PERF: avoid looking globals from providers after first call 2017-03-09 18:00:55 -05:00
Guo Xiang Tan
b419a5765e FEATURE: Add seen/unseen filters to advanced search UI. 
https://meta.discourse.org/t/advanced-search-posts-that-i-have-seen/57966
 2017-03-09 10:46:06 +08:00
Régis Hanol
00380d84c5 UX: display text & html parts alongside raw email in incoming email modal 2017-03-08 23:15:42 +01:00
Arpit Jalan
dfd5b06c82 FIX: custom CSS/HTML files were not getting downloaded on Chrome 2017-03-09 01:09:26 +05:30
Régis Hanol
23b06d2895 FIX: should not try to send digest to users who reached the bounce threshold 2017-03-08 19:19:11 +01:00
Guo Xiang Tan
6a7773b681 FIX: Category autocomplete breaks when search menu widget rerenders. 
https://github.com/discourse/discourse/pull/4717#issuecomment-284914585
 2017-03-08 20:13:48 +08:00
Guo Xiang Tan
3c41cb6b7d FIX: Reply to topic keyboard shortcut raises an error on non-topic routes. 2017-03-08 19:55:35 +08:00
Arpit Jalan
801b5838e1 FIX: do not show faq/guidelines page to anonymous users for private forums 2017-03-08 16:00:49 +05:30
Régis Hanol
cf8bc4483f FIX: always send critical emails even when bounce score threshold has been reached 2017-03-08 10:06:16 +01:00
Arpit Jalan
090236b15b FIX: do not show about page to anonymous users for private forums 2017-03-08 13:15:44 +05:30
Guo Xiang Tan
689dd16be0 FIX: Allow user to remove bookmark from posts as long as bookmark is present. 
https://meta.discourse.org/t/bookmark-issue-when-access-to-topic-is-lost-pms/51993
 2017-03-08 13:53:49 +08:00
Sam
0c03ccb01e FEATURE: allow plugins to transform, the transformed post 
This allows plugins to amend posts prior to rendering.
 2017-03-07 17:12:31 -05:00
Sam
99f4d5082b FIX: Improve token rotation and increase logging 
- avoid access denied on bad cookie, instead just nuke it
- avoid marking a token unseen for first minute post rotation
- log path in user auth token logs
 2017-03-07 13:27:43 -05:00
Sam
9f8cfee450 remove dupe code, correct logging logic 2017-03-07 13:27:43 -05:00
Robin Ward
42fd4f987e When viewing yourself, default to activity, not summary. 2017-03-07 12:03:05 -05:00
Neil Lalonde
d95e4102c1 FIX: tags created in secured categories should not be forbidden outside those categories 2017-03-07 11:46:46 -05:00
Robin Ward
dad57fa033 FIX: More errors with non-ascii URLs 2017-03-07 11:21:41 -05:00
Guo Xiang Tan
d1e587c10a Merge pull request #4737 from oblakeerickson/approve_invited_user 
FIX: approve invited user
 2017-03-07 21:14:34 +08:00
Guo Xiang Tan
60b7453f3f FIX: Do not trigger fullpage search when selecting autocomplete term with enter. 2017-03-07 11:56:40 +08:00
Guo Xiang Tan
f3a7e398ca Merge pull request #4717 from cpradio/autocomplete-search 
FEATURE: Autocomplete support on search
 2017-03-07 06:40:45 +08:00
Sam
443bce6466 add a descriptive comment 2017-03-06 15:15:07 -05:00
Sam
3227d79430 FIX: extra-nav-item outlet no longer adds a DIV to UL 
This amends the extensibility on navigation bar so extra nav items are not
added to a DIV nested into the UL, instead the LIs are rendered as usual
 2017-03-06 15:00:13 -05:00
Robin Ward
3905778fc0 FIX: Put back the back button fix again. 2017-03-06 12:24:27 -05:00
Rafael dos Santos Silva
c3477cd40d Merge pull request #4716 from discourse/bounced_emails_details 
FEATURE: Allow checking the raw response of a bounced email
 2017-03-06 13:30:19 -03:00
Régis Hanol
0abe433495 Merge pull request #4736 from techAPJ/group-bulk-add 
FIX: grant trust level when bulk adding users to group
 2017-03-06 12:43:26 +01:00
Guo Xiang Tan
1e8573ac75 Merge pull request #4738 from rimian/patch-4 
less restrictive to allow plugin outlets
 2017-03-06 17:25:18 +08:00
Guo Xiang Tan
7d82a53dfe FIX: Group#name is case insensitive. 2017-03-06 17:24:03 +08:00
Arpit Jalan
d5bcc70e9c FIX: grant trust level when bulk adding users to group 2017-03-06 14:39:53 +05:30
Guo Xiang Tan
66b5f97743 Merge pull request #4739 from tgxworld/fix_cant_recover_a_topic_that_belongs_to_a_deleted_user 
Fix cant recover a topic that belongs to a deleted user
 2017-03-06 15:12:54 +08:00
Guo Xiang Tan
8aea3caf00 FIX: Ensure that we only move posts that belong to the original topic. 2017-03-06 15:04:10 +08:00
Guo Xiang Tan
477eb0591e FIX: Posts in a deleted topic couldn't be moved. 
https://meta.discourse.org/t/moving-posts-to-new-topic/58436/4
 2017-03-06 14:56:20 +08:00
Rimian Perkins
95f7b60212 less restrictive to allow plugin outlets 
for extra-nav-items
 2017-03-06 14:38:57 +11:00
Blake Erickson
dbb3ddc7a6 FIX: approve invited user 
This commit fixes the case where invited users who typed in a password
would not be approved by default. Because we moved the user create logic
for an invited user there was a clash with the `save` in the user model
and the `save` in the invite_redeemer class.

- added approve logic into invite_redeemer class.
- added tests to verify that the user is approved
- added a check to see if must_approve_users is on
- added a check to see if the inviter is staff
- go ahead and approve the user if must_approve_users is off
- keep existing User.approve workflow if user exists
- improve if/else logic to remove duplicate code
- use `Time.zone.now`
 2017-03-05 06:58:23 -07:00
Guo Xiang Tan
08ffbf6c61 Use Time.zone.now instead. 2017-03-05 11:10:40 +08:00
Neil Lalonde
9c7a02192a FIX: flag action buttons are missing when visiting flags from the hamburger menu 2017-03-04 11:36:58 -05:00
cpradio
3eb51f0d77 FIX: Make it a tad bit harder to accidentally redirect to full page search while autocomplete is open 2017-03-03 22:48:28 -05:00