9 Commits

Author	SHA1	Message	Date
Guo Xiang Tan	5012d46cbd	Add rubocop to our build. (#5004)	2017-07-28 10:20:09 +09:00
Andy Waite	3e50313fdc	Prepare for separation of RSpec helper files ... Since rspec-rails 3, the default installation creates two helper files: * `spec_helper.rb` * `rails_helper.rb` `spec_helper.rb` is intended as a way of running specs that do not require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's current `spec_helper.rb` does). For more information: https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files In this commit, I've simply replaced all instances of `spec_helper` with `rails_helper`, and renamed the original `spec_helper.rb`. This brings the Discourse project closer to the standard usage of RSpec in a Rails app. At present, every spec relies on loading Rails, but there are likely many that don't need to. In a future pull request, I hope to introduce a separate, minimal `spec_helper.rb` which can be used in tests which don't rely on Rails.	2015-12-01 20:39:42 +00:00
Luciano Sousa	0fd98b56d8	few components with rspec3 syntax	2015-01-09 13:34:37 -03:00
Neil Lalonde	27cbc06563	Add fixed_category_positions site setting to handle whether categories are ordered by specified positions or by activity.	2014-05-16 11:33:52 -04:00
Erick Guan	6d45f71254	move concerns to the model/concerns	2014-04-19 12:00:40 +08:00
Neil Lalonde	341adc93a4	Allow categories with null position, which means sort them based on activity. Mix absolutely positioned (position is not null) categories with null position categories.	2013-12-16 15:13:57 -05:00
Sam	31b73171dc	correct ordering algorithm	2013-10-21 16:14:09 +11:00
Sam	25723de9c8	no need for the undefine	2013-10-21 09:52:28 +11:00
Sam	5f74cb6bf9	category is not "positionable"	2013-10-18 18:09:30 +11:00