Jarek Radosz
9028df0fda
DEV: Use includes()
instead of indexOf() >= 0
( #17553 )
...
Missed those cases in #17541
2022-07-19 10:27:40 +08:00
Jarek Radosz
0db6ae1e1f
DEV: Fix typos and other spell-checker warnings ( #17554 )
2022-07-19 10:27:10 +08:00
Jarek Radosz
057d6b406d
DEV: Extensively use includes()
( #17541 )
...
Also, the change in insert-hyperlink (from `this.linkUrl.indexOf("http") === -1` to `!this.linkUrl.startsWith("http")`) was intentional fix: we don't want to prevent users from looking up topics with http in their titles.
2022-07-17 20:48:36 +02:00
Osama Sayegh
5176c689e9
UX: Change wording for 'regular' categories to 'normal' ( #17134 )
...
At some point in the past we decided to rename the 'regular' notification state of topics/categories to 'normal'. However, some UI copy was missed when the initial renaming was done so this commit changes the spots that were missed to the new name.
2022-06-20 06:49:33 +03:00
Bianca Nenciu
4fe99e39c3
FEATURE: Add new site setting list type with name and values ( #16045 )
...
These changes include a bug fix because allow_any attribute of site
settings was completely ignored before.
2022-03-08 13:18:43 +02:00
Joffrey JAFFEUX
1abe807528
REFACTOR: setting component mixin ( #14437 )
...
* REFACTOR: setting component mixing
- drops jquery usage
- extract spit function
- uses @action
- removes get usage where possible
- uses helpers
- minor changes
Co-authored-by: Jarek Radosz <jradosz@gmail.com>
2021-09-27 10:43:26 +02:00
Jarek Radosz
e68c1d5ba5
DEV: Use key
over the deprecated keyCode
( #13795 )
...
Makes the code a bit more readable. Inspired by https://github.com/emberjs/ember.js/pull/19185
2021-08-09 11:41:36 +02:00
Joffrey JAFFEUX
c9bd4b4c64
FIX: ensures validValues is an array ( #13435 )
...
Before this fix the setting object would have exceptions on 3 fields: computedNameProperty, computedValueProperty and validValues
```
TypeError: Cannot read property 'forEach' of undefined
at Class.validValues (http://localhost:4200/assets/admin.js:10468:19 )
at Class.<anonymous> (http://localhost:4200/assets/vendor.js:82492:19 )
at http://localhost:4200/assets/vendor.js:28633:34
at untrack (http://localhost:4200/assets/vendor.js:26641:7 )
at ComputedProperty.get (http://localhost:4200/assets/vendor.js:28632:13 )
at Class.CPGETTER_FUNCTION [as validValues] (http://localhost:4200/assets/vendor.js:26259:25 )
at Class.r (<anonymous>:1:83)
```
2021-06-18 14:02:21 +02:00
Ahmed Gagan
2308a58113
DEV: Added support for custom site setting 'emoji_list' ( #12414 )
...
Example usage:
```
best_emojis:
type: emoji_list
default: laughing|open_mouth|cry|angry|hugs
client: true
```
2021-04-07 15:32:05 +02:00
Roman Rizzi
bbe5d8d5cf
DEV: Sort imports alphabetically ( #11382 )
2020-12-01 15:31:26 -03:00
Bianca Nenciu
d2116f0029
FIX: Show error message if user is already silenced or suspended ( #10988 )
...
Users could be silenced or suspended by two staff members at the same time and
would not be aware of it. This commit shows an error message if another penalty
has been applied.
2020-11-03 17:38:56 +02:00
Joffrey JAFFEUX
702f7a5a67
FIX: makes dashboard periods use current day and weekly 7 days ( #10817 )
...
Prior to this fix, weekly could be 8 days and we could have differences between period chooser text and actual results in the chart.
A good followup to this PR would be to add custom date ranges in period-chooser component.
2020-10-05 10:32:12 +02:00
Robin Ward
ce3fe2f4c4
REFACTOR: Support bundling our admin
section as an ember addon
2020-09-22 15:14:29 -04:00