github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-24 21:16:08 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
22,979 Commits 190 Branches 500 Tags 938 MiB
83d3938df9
Commit Graph

13787 Commits

Author SHA1 Message Date
Robin Ward
57a2042ef6 FIX: Quiet server side errors for requesting json for account-created 2017-05-04 12:30:13 -04:00
Robin Ward
b3165f8435 FIX: If badges are disabled don't show "Top Badges" on summary view 2017-05-04 12:14:32 -04:00
Neil Lalonde
c98601129b Move name, avatar, and title fields from profile tab to account tab 2017-05-04 12:04:07 -04:00
Robin Ward
de0d13e4ef FIX: Badge filtering was always to the currentUser 2017-05-04 11:58:56 -04:00
Neil Lalonde
f4c09e9e90 fix select input widths regression in user preferences 2017-05-04 11:25:22 -04:00
Arpit Jalan
0bdced165a UX: change timestamp button on mobile was hidden behind date selector 2017-05-04 18:47:25 +05:30
Guo Xiang Tan
58edd203a9 SECURITY: XSS issue in share popup if invalid link is passed in. 2017-05-04 10:33:59 +08:00
Guo Xiang Tan
94c8410521 FIX: Show share popup only for valid buttons. 2017-05-04 10:31:09 +08:00
Robin Ward
b3908a1d7f FIX: The user might be anonymous 2017-05-03 18:39:02 -04:00
Robin Ward
60693240e1 FIX: Filter badges to user on their badges page too 2017-05-03 17:58:59 -04:00
Guo Xiang Tan
3eb920e2b0 Merge pull request #4841 from fantasticfears/webhook-ping 
add event name for ping webhooks in the header
 2017-05-04 04:54:40 +08:00
Neil Lalonde
7f09bc9a09 Merge pull request #4849 from discourse/prefs 
User preferences in tabs
 2017-05-03 16:53:26 -04:00
Neil Lalonde
389a0e1a1c FIX: emails should use default theme colors 2017-05-03 14:35:13 -04:00
Robin Ward
b705634ee1 FIX: If you have a badge, filter to you when clicking on it 2017-05-03 13:35:20 -04:00
Robin Ward
09cb61b533 FIX: Jumping to a post that doesn't exist should jump to closest 2017-05-03 13:24:30 -04:00
Neil Lalonde
8bcfea3b0d new outlets for plugins 2017-05-03 11:41:01 -04:00
Sam
342ef5f81a FEATURE: out-of-the-box dark/light user selectable themes 2017-05-03 11:31:33 -04:00
Robin Ward
81190f5d66 FIX: Redirect away from account-created if you're logged in 2017-05-03 11:18:01 -04:00
Robin Ward
12fb20fe1b FEATURE: Allow users to resend/update email from confirmation page 2017-05-03 11:18:01 -04:00
Robin Ward
b381372184 Use Ember.js for the /u/account-created path so we can add controls 2017-05-03 11:18:01 -04:00
Arpit Jalan
86f1cc8c92 FIX: don't apply max_emails_per_day_per_user on critical emails 2017-05-03 17:07:39 +05:30
Guo Xiang Tan
982e3d04f6 PERF: Allow memory to be freed instead of fetching all the objects into memory at once. 
```
MemoryProfiler.report do
  Jobs::UserEmail.new.execute(type: :mailing_list, user_id: user.id)
end.pretty_print
```

Before:
```
Total allocated: 180096119 bytes (1962025 objects)
Total retained:  2194 bytes (16 objects)

allocated memory by gem
-----------------------------------
  66979096  activerecord-4.2.8
  43507184  nokogiri-1.7.1
  43365188  mail-2.6.4
   5960201  activesupport-4.2.8
   5056267  discourse/lib
   4835284  rack-mini-profiler-0.10.1
   3825817  arel-6.0.4
   2186088  i18n-0.8.1
   1719330  discourse/app
```

After:
```
Total allocated: 161935975 bytes (1473940 objects)
Total retained:  2234 bytes (17 objects)

allocated memory by gem
-----------------------------------
  45430264  activerecord-4.2.8
  43568627  nokogiri-1.7.1
  43430754  mail-2.6.4
  11233878  rack-mini-profiler-0.10.1
   5260825  activesupport-4.2.8
   5054491  discourse/lib
   2186088  i18n-0.8.1
   1822494  arel-6.0.4
```
 2017-05-03 17:01:57 +08:00
Arpit Jalan
cdce060a38 FIX: don't apply max emails per day per user to forgot password 2017-05-03 14:02:37 +05:30
Neil Lalonde
2503241ce5 FEATURE: rebuild user preferences page to use tabs 2017-05-02 16:52:18 -04:00
Sam
946f25098f Refactor theme fields so they support custom theme defined vars 
This paves the way to allowing themes to specify uploads and so on.
 2017-05-02 16:02:14 -04:00
Arpit Jalan
77a8cae094 FIX: rescue specific errors on invite failure 2017-05-02 15:13:33 +05:30
Erick Guan
9f8a917d65 add event name for ping webhooks in the header 2017-05-02 08:13:23 +02:00
Guo Xiang Tan
f5b11cb429 PERF: Don't allocate extra array. 2017-05-02 11:54:23 +08:00
Robin Ward
3736b440cb FIX: Quoting an expanded first post would force it to reload the cooked 2017-05-01 15:01:35 -04:00
Neil Lalonde
0722ffadf1 Remove site settings enforce_global_nicknames and discourse_org_access_key 2017-05-01 14:53:16 -04:00
Neil Lalonde
ca224ed8e9 FIX: pending flags message should go to moderators group, not staff 2017-05-01 14:53:16 -04:00
Sam
556ef4cfbd FIX: case sensitive unconditional add of exact match in user search 2017-05-01 14:37:16 -04:00
Robin Ward
dfe1174137 FIX: The dates for retroactive anniversary badges were wrong 2017-05-01 12:06:18 -04:00
Arpit Jalan
9e9ead0954 FIX: incorrect label for top topics dropdown on mobile when filtering 2017-05-01 16:43:23 +05:30
Jeff Atwood
a4815047c0 purge scheduler_stats every 1 month instead of 3 2017-04-28 15:05:15 -07:00
Robin Ward
f05f1a24d3 Change Anniversary badge to be multiple grant, once per year 2017-04-28 14:22:54 -04:00
Neil Lalonde
bb82e0a041 FIX: theme preview from preferences wasn't working 2017-04-28 14:01:57 -04:00
Neil Lalonde
b193ae2d15 FIX: missing link in unsubscribe text of summary emails 2017-04-28 10:37:52 -04:00
Robin Ward
cb8f91ca21 FIX: Scrolling offset was broken when entering some topics 2017-04-27 16:22:25 -04:00
Robin Ward
5774a9a2c8 Revert offset calculation, was working poorly. 2017-04-27 12:20:32 -04:00
Robin Ward
a545117d2e FIX: Forgot to clear out a topic excerpt 2017-04-27 11:49:39 -04:00
Robin Ward
2efe0442bf FIX: Messed up i18n key 2017-04-27 11:45:59 -04:00
Guo Xiang Tan
304ace926e FIX: Raise right response when post_action does not exist. 2017-04-27 17:29:53 +08:00
Guo Xiang Tan
e4b9f72f9e FIX: Force the right encoding when handling email. 2017-04-27 16:51:54 +08:00
Guo Xiang Tan
7873a2efb7 Merge pull request #4843 from tgxworld/disable_post_min_length_for_pm 
FEATURE: Disable minimum post length check when in PM with non human …
 2017-04-27 16:35:19 +08:00
Guo Xiang Tan
59b906ab0d FEATURE: Disable minimum post length check when in PM with non human users. 
https://meta.discourse.org/t/discourse-narrative-bot-beta-feedback/58621/65?u=tgxworld
 2017-04-27 16:00:22 +08:00
Guo Xiang Tan
85d9342ff0 Merge pull request #4836 from tgxworld/fix_clean_up_staged_users_job 
FIX: Clean up unused staged users job not completing.
 2017-04-27 15:41:46 +08:00
Arpit Jalan
b755279cf0 remove unneeded code 2017-04-27 08:47:47 +05:30
Arpit Jalan
e3f82140d8 more readable code for filtering username/email when bulk adding to group 2017-04-27 08:43:28 +05:30
Arpit Jalan
b41d96fac1 FIX: properly initialize hashes 2017-04-27 02:56:14 +05:30
Arpit Jalan
9b0ecdaf7e Merge pull request #4839 from techAPJ/bulk-add-group 
FEATURE: provide more details when performing a bulk add to group
 2017-04-27 02:39:57 +05:30
Arpit Jalan
285c167fae FEATURE: provide more details when performing a bulk add to group 2017-04-27 01:37:51 +05:30
Robin Ward
30ebaf6b6a Update FontAwesome to 4.7.0 2017-04-26 15:16:30 -04:00
Robin Ward
cd4f0393a8 Add a title tag to the search results page 2017-04-26 15:02:07 -04:00
Robin Ward
bf9c4a7828 FEATURE: secure_email site setting to prevent data going out in email 2017-04-26 13:05:56 -04:00
Guo Xiang Tan
fe0a7d97ca Fix incorrect class name. 2017-04-26 18:12:51 +08:00
Guo Xiang Tan
b00886f5c1 Remove sidekiq-statistic gem. 
* We don't really use it and there is an on-going issue
  with the gem not expiring keys in a Redis list which
  hasn't been fully resolved.

  https://github.com/davydovanton/sidekiq-statistic/issues/73
 2017-04-26 14:54:47 +08:00
Guo Xiang Tan
daa97c40ce FIX: Clean up unused staged users job not completing. 2017-04-26 10:51:36 +08:00
Guo Xiang Tan
1f6418f907 Track error message in SchedulerStats. 2017-04-26 01:34:25 +08:00
Arpit Jalan
aeead60036 FIX: make TopicEmbed trashable 2017-04-25 18:40:39 +05:30
Régis Hanol
64787e7fa4 Merge pull request #4831 from gdpelican/image-gallery 
FEATURE: Use image gallery functionality in magnific
 2017-04-25 09:39:10 +02:00
James Kiesel
48c0f3faf3 Use image gallery feature of magnific 
commit cc7061e9458d04dd02aad9c02ba3a89306e0fae7
Author: James Kiesel <james.kiesel@gmail.com>
Date:   Tue Apr 25 11:21:08 2017 +0900

    ;

commit 9233be7e432daff605812e6b49042f69d348b6e7
Author: James Kiesel <james.kiesel@gmail.com>
Date:   Tue Apr 25 10:01:26 2017 +0900

    Don't break if $elem is undefined

commit 598a694c070c86df8d9f5ffa1ed84e2f8756e65f
Author: James Kiesel <james.kiesel@gmail.com>
Date:   Tue Apr 25 04:51:14 2017 +0900

    .

commit 1711685a33ccd236011f54d3e652991728530b3a
Author: James Kiesel <james.kiesel@gmail.com>
Date:   Tue Apr 25 04:34:11 2017 +0900

    ;

commit 81703f36c0593250aeac3418fde86660fd307092
Author: James Kiesel <james.kiesel@gmail.com>
Date:   Tue Apr 25 04:12:37 2017 +0900

    Use image gallery functionality in magnific
 2017-04-25 11:23:15 +09:00
Guo Xiang Tan
6f7c6b0fd0 FIX: Incorrect error raised. 2017-04-25 09:59:01 +08:00
cpradio
d69122c385 UX: Change banner close button to be floated to the right 2017-04-24 20:51:02 -04:00
Régis Hanol
0d66529d2b PostReply doesn't have a primary key, so no luck here 2017-04-24 23:14:01 +02:00
Régis Hanol
1787c45b38 PERF: don't load all replies in memory when moving posts 2017-04-24 23:00:32 +02:00
Régis Hanol
8fe0bbb238 REFACTOR: improve Notification.ensure_consistency SQL query readability 2017-04-24 23:00:27 +02:00
Régis Hanol
301dd139ae PERF: faster Group.refresh_automatic_group & Group.ensure_consistency 2017-04-24 23:00:21 +02:00
Régis Hanol
3d406b047c PERF: much faster Badge.ensure_consistency 2017-04-24 22:59:49 +02:00
Robin Ward
f41ab98e86 FIX: Scrolling to the bottom was still a bit weird with no suggested 2017-04-24 16:36:43 -04:00
Robin Ward
62966b1023 FIX: Remove duplicate route warning, it's just a noop now 2017-04-24 13:36:05 -04:00
Robin Ward
4e1f8ec72b FIX: Without suggested topics jumping to a post had the wrong offset 2017-04-24 13:21:50 -04:00
Guo Xiang Tan
423f2ab228 FIX: Processing incoming email should be done in a background job. 2017-04-24 13:57:28 +08:00
Arpit Jalan
1f5089e474 FIX: handle invite error in wizard 2017-04-21 20:07:04 +05:30
cpradio
20c2c66dd4 FEATURE: Add normal as a preference for topic subscription state when replying to a topic 2017-04-20 22:33:10 -04:00
Rafael dos Santos Silva
e922623da8 FIX: User Admin screen on mobile style was off 2017-04-20 23:18:01 -03:00
Guo Xiang Tan
8b2e3bf5f1 FIX: Topic title should be included in post webhook payload. 2017-04-21 10:04:21 +08:00
Sam
aec73d4003 correct the spec again 2017-04-20 17:41:35 -04:00
Sam
a9b953ac5a FIX: on create you could not add a theme component 2017-04-20 17:37:13 -04:00
Sam
dcf9459b7c staff should track 2017-04-20 17:32:05 -04:00
Sam
5365973c0a FIX: detection of error changed, so you can clear errors 2017-04-20 16:55:18 -04:00
Neil Lalonde
703e6faf54 Revert "remove important from extra-info-wrapper color" 2017-04-20 16:27:10 -04:00
jomaxro
b3eef0513f Remove console logging 2017-04-20 16:08:16 -04:00
Sam
7a9eee1b71 FEATURE: default notification level for group messages 
also fixes it so staff can amend other user's group notification level
 2017-04-20 15:47:35 -04:00
Neil Lalonde
05efa7ce68 simplify last_notified_id 2017-04-20 15:26:28 -04:00
Arpit Jalan
5d9d2cf287 FIX: do not explicitly show email of flagger / flagged user 2017-04-20 22:09:30 +05:30
Sam
dfe3c162cc move stylesheet after js 2017-04-20 12:34:50 -04:00
Neil Lalonde
3d32158893 remove important from extra-info-wrapper color 2017-04-20 11:53:41 -04:00
Sam
81c08fe451 missing badge count in dark theme 2017-04-20 11:52:06 -04:00
Sam
bbed29ba57 correct font preloading 2017-04-20 11:18:37 -04:00
Sam
8628a57f4e FIX: colors picker not working with CDN 2017-04-20 11:04:23 -04:00
Guo Xiang Tan
94c7be3ca6 Merge pull request #4824 from tgxworld/fix_optimize_image_timeout 
Fix optimize image timeout
 2017-04-20 15:53:43 +08:00
Arpit Jalan
ea26c56631 FIX: redirect to login page for anonymous user when profiles are hidden 2017-04-20 13:00:45 +05:30
Guo Xiang Tan
2af1b9e93c Add time out when optimizing images. 2017-04-20 15:21:43 +08:00
Guo Xiang Tan
5c39c8f24b UX: Improve the way users set timers for TopicStatusUpdate. 2017-04-20 14:25:45 +08:00
Sam
7eabb90b71 FEATURE: added error messages for bad theme CSS / JS 2017-04-19 16:46:46 -04:00
Neil Lalonde
3835e16cf7 FIX: New implementation of the "notify about flag after" setting. Only notify about new flags since the last notification. Send a private message to staff. Mention the 3 most active moderators in the message so they get notification emails. 2017-04-19 16:17:45 -04:00
Sam
0930db221f FIX: destroying color scheme could remove wrong item from UI 2017-04-19 15:31:21 -04:00
Sam
c5ee448713 FEATURE: Only show overridden option for theme css 
also fixes bad styling of mobile glyph
 2017-04-19 15:24:00 -04:00
Sam
c76d780675 FEATURE: show a paintbrush for color schemes 2017-04-19 11:06:21 -04:00
clapmyhands
5d28a1ac0d UX: Make abondon post confirmation button red. 2017-04-19 21:54:58 +08:00
Arpit Jalan
5fa5c18a48 use notification_levels methods for specifying normal notification level 2017-04-19 16:17:24 +05:30
cpradio
2dccaff25d FIX: Correct behavior of auto-notification state updating to exclude when the topic already has a state of normal/muted 2017-04-19 06:29:35 -04:00
Rafael dos Santos Silva
d9ba168420 FIX: Show solved status on category with featured topics view too 2017-04-19 00:54:13 -03:00
Rafael dos Santos Silva
8d3ebfd2ac FIX: Show topic status on category view 2017-04-19 00:41:07 -03:00
Neil Lalonde
e7b0ce1334 FIX: add white space in discourse-tags so tags can wrap 2017-04-18 17:09:46 -04:00
Sam
0a67d859d5 correct watcher so it handles color scheme changes correctly 2017-04-18 16:48:15 -04:00
Sam
bbeb69ddc9 FIX: sort theme by lower case theme name 2017-04-18 15:43:38 -04:00
Sam
8ffb918824 FIX: add more consistent gutter to ace editor 
old css hack had issues when line number was higher than 10
 2017-04-18 15:43:22 -04:00
Sam
8ee2a500bc FEATURE: add hamburger extensibility 2017-04-18 15:18:03 -04:00
Robin Ward
8b8ee2ad61 Pass a context in when using a HTML builder 2017-04-18 12:35:35 -04:00
Sam Saffron
a19c02f0d3 FEATURE: allow copying of color schemes to clipboard 2017-04-18 09:37:55 -04:00
Arpit Jalan
1c23aedccf FIX: always send password reset email when accepting invite if password is not set 2017-04-18 14:37:06 +05:30
Guo Xiang Tan
60f1169077 REFACTOR: Reduce repetition in code. 2017-04-18 17:03:49 +08:00
Guo Xiang Tan
03762e2828 Merge pull request #4818 from OsamaSayegh/ui/groups-heading-admin-page 
The "Groups" section's heading on user admin page was visible to mods
 2017-04-18 16:12:33 +08:00
Arpit Jalan
8dea70d354 Revert "FIX: User website allows new TLDs" 2017-04-18 13:18:51 +05:30
Rafael dos Santos Silva
4289dbe3e5 FIX: User website allows new TLDs 2017-04-18 00:30:37 -03:00
Robin Ward
1363988cd7 Support for an HTML builder that can create dynamic HTML 2017-04-17 17:32:55 -04:00
Sam
3ccd5eacb4 prefer multiline \A \z 2017-04-17 16:57:37 -04:00
Sam
86904e9cd6 FIX: better error handling for theme import 2017-04-17 16:55:53 -04:00
Sam
5e3a0846f7 FEATURE: allow themes to share color schemes 2017-04-17 15:56:24 -04:00
osamasayegh
3e048d686e The "Groups" section's heading on user admin page was visible to mods 
Since moderators can't manage a user groups, they shouldn't see the Groups heading on the user admin page.

## Before:

![before](https://cloud.githubusercontent.com/assets/17474474/25099135/c0e1d5a4-23b3-11e7-95d1-8036bff057d4.png)


## After:

![after](https://cloud.githubusercontent.com/assets/17474474/25099130/c060a538-23b3-11e7-8428-602fc523e9e8.png)
 2017-04-17 21:53:30 +03:00
jomaxro
7b708e5cf2 Disable browser auto-complete for messages 2017-04-17 14:24:09 -04:00
Sam
b43d2e42f4 missing spots 2017-04-17 12:30:20 -04:00
Sam
81ebe853d1 missed a few spots 2017-04-17 12:05:23 -04:00
Sam
5dd752877e FEATURE: try adding some preload hints for chrome 2017-04-17 11:52:43 -04:00
jloh
5f47603b07
FIX: increase host_must_be_valid regex for .technology TLD 
.technology is 11 chars long and wasn't being matched previously
 2017-04-15 21:06:51 +10:00
Arpit Jalan
0954367bf4 FIX: send activation email when accepting invite if password is set 2017-04-15 14:59:50 +05:30
Guo Xiang Tan
04016f0dec Support Ruby 2.4. 2017-04-15 12:29:00 +08:00
cpradio
4dc4c5bebc FIX: Update auto_notification to also update the subscription state when replying if the current state is less than the state being requested 2017-04-14 15:44:42 -04:00
Sam
ed2e62f845 correct environment handling for test mode 2017-04-14 14:00:46 -04:00
Sam
873a07a625 trigger a stylesheed update 2017-04-14 13:36:49 -04:00
Sam
def7348777 FIX: display custom sections with default theme 
also cleans up mechanism for previewing themes, cleans up naming,
gets rid of old janky "preview_style", secures local theme key
 2017-04-14 13:35:12 -04:00
Arpit Jalan
fe29fe71c5 FIX: embedding comments was broken 2017-04-14 08:14:22 +05:30
Sam
809fbb25ce FIX: blanking theme field was not properly removing it 2017-04-13 17:24:15 -04:00
Sam
9927489f4e FEATURE: auto focus text editor when editing themes 2017-04-13 16:21:46 -04:00
Sam
43e4fc03ef FIX: clicking on themes while editing left a blank screen 2017-04-13 15:49:46 -04:00
Sam
3f4f0b32a9 FIX: path wizard showing with no style 2017-04-13 15:22:39 -04:00
Sam
37d4dd4a4b use scss mode instead of css mode 2017-04-13 12:05:27 -04:00
Sam
ee950b419f correct transitioning to theme CSS editing 2017-04-13 11:09:31 -04:00
Sam
679b6548e6 FIX: order child themes by name 2017-04-13 10:51:44 -04:00
Sam
e61be7af13 FIX: improve dark theme styling in header for tags 2017-04-13 10:39:36 -04:00
Arpit Jalan
ef093b1610 Merge pull request #4807 from techAPJ/email-token-social 
FIX: confirm email token for user created via social login
 2017-04-13 16:18:15 +05:30
Guo Xiang Tan
3d76fb9c2c FIX: Don't show category options for reports that can't be scoped to a category. 2017-04-13 17:10:55 +08:00
Arpit Jalan
7fb17b83c4 FIX: confirm email token for user created via social login 2017-04-13 14:15:32 +05:30
Guo Xiang Tan
bda20cc44a FIX: Don't enqueue topic status update job if topic is deleted. 2017-04-13 12:02:35 +08:00
Guo Xiang Tan
ee449b0dd5 Improve SSO verbose log when user record is invalid. 2017-04-13 11:39:26 +08:00
Guo Xiang Tan
72c16967e6 FIX: Check for reserved usernames before hitting DB. 2017-04-13 11:32:20 +08:00
Guo Xiang Tan
57788200ec REFACTOR: Add User.reserved_username?. 2017-04-13 10:44:26 +08:00
Neil Lalonde
07d596ea05 FIX: handle expanding quotes from deleted posts by rendering a trash icon 2017-04-12 16:48:47 -04:00