github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-24 10:02:33 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
32,929 Commits 190 Branches 500 Tags 938 MiB
8c07c272f2
Commit Graph

19568 Commits

Author SHA1 Message Date
Vinoth Kannan
8c07c272f2 make rubocop happy. 2019-05-09 05:25:44 +05:30
Vinoth Kannan
87cd4701b8 FEATURE: option to skip posts with ignored missing uploads 2019-05-09 05:11:15 +05:30
Joffrey JAFFEUX
e6cfc584d0 Revert "FIX: frozen string exception (#7506)" 
This reverts commit c4b7fb2754.
 2019-05-08 17:27:09 +02:00
Joffrey JAFFEUX
497c0ba418 Revert "FIX: frozen string exception (#7505)" 
This reverts commit 2938e3f033.
 2019-05-08 17:27:03 +02:00
Maja Komel
24ca074f3f FIX: short description title on client side when empty description 
follow-up 77af097c
 2019-05-08 17:07:12 +02:00
David Taylor
e84531a6a6 FIX: Correctly clear theme stylesheet cache when changing color scheme 2019-05-08 16:02:55 +01:00
Joffrey JAFFEUX
54c2f24ee9
REFACTOR: composer model (#7499) 2019-05-08 16:53:12 +02:00
Joffrey JAFFEUX
2938e3f033
FIX: frozen string exception (#7505) 
Initial backtrace:

```
/var/www/discourse/app/mailers/user_notifications.rb:554:in `send_notification_email'
/var/www/discourse/app/mailers/user_notifications.rb:459:in `notification_email'
/var/www/discourse/app/mailers/user_notifications.rb:318:in `user_private_message'
```

* this might fail too
 2019-05-08 16:52:38 +02:00
Joffrey JAFFEUX
4aaee7ee35
REFACTOR: change-timestamp controller (#7498) 2019-05-08 16:26:51 +02:00
Joffrey JAFFEUX
c4b7fb2754
FIX: frozen string exception (#7506) 
Initial backtrace:

```
/var/www/discourse/app/models/incoming_domain.rb:29:in `to_url'
/var/www/discourse/app/models/incoming_link.rb:83:in `referer'
/var/www/discourse/app/models/incoming_link.rb:106:in `referer_valid'
```
 2019-05-08 16:25:54 +02:00
Robin Ward
b409dab77f Rename flags_default_topics to reviewable_default_topics 
This functionality regressed with the reviewable update. I took the
opporunity to rename it when fixing it for clarity.
 2019-05-08 10:07:10 -04:00
Maja Komel
77af097ce0 FIX: add short description to title on client side 2019-05-08 15:03:33 +02:00
David Taylor
b717e23ceb FIX: Dynamically adjust scale when rendering wizard canvases 
This was a typo in fd0de64
 2019-05-08 13:14:28 +01:00
Bianca Nenciu
861023f0d6 FIX: Skip attachments in click track. 2019-05-08 11:55:31 +03:00
Guo Xiang Tan
f04518fdf9 DEV: Reduce number of jobs enqueued. 
Apply code review suggestion from
405ba00c08.
 2019-05-08 15:58:08 +08:00
Guo Xiang Tan
405ba00c08 FEATURE: Create notifications on wiki edits for watching users. 
* Moves creation of notification into background job.
 2019-05-08 15:31:10 +08:00
Guo Xiang Tan
46ea69a73c UX: Initialize client side category model with right search_priority. 
This is strictly a UX change since the default value of the column is 0.
 2019-05-08 14:16:20 +08:00
Robin Ward
5af7c90bab FEATURE: Hide Reviewable scores, change score filter to Priority 
We found score hard to understand. It is still there behind the scenes
for sorting purposes, but it is no longer shown.

You can now filter by minimum priority (low, med, high) instead of
score.
 2019-05-07 14:05:23 -04:00
Blake Erickson
5b5b5a5931 FIX: return an error if a user tries to whisper 
This commit fixes a bug where a user creates a whisper post via the api
but is posted as a regular message because they don't have access to
whisper. Now a 403 unauthorized will be returned instead of the whisper
param just being ignored for regular users. Staff users should not be
affected by this change.

https://meta.discourse.org/t/a-whisper-is-posted-as-a-message-if-the-user-is-not-staff-moderator-admin-when-using-the-api/116601
 2019-05-07 11:42:26 -06:00
Joffrey JAFFEUX
626534ad94
FIX: lighten instead of adding transparency to consolidated pageviews (#7495) 2019-05-07 18:14:13 +02:00
Roman Rizzi
0a66065774
FIX: Move default options that were in the bufferedRender function. This will fix shortcut navigation for discourse-assign (#7497) 2019-05-07 12:25:10 -03:00
Saurabh Patel
e20f13ebb7 fix css of prev and next page links, move them to bottom of page (#7465) 
Thanks 👍
 2019-05-07 17:04:27 +02:00
Penar Musaraj
446ec1b44a
Set input and textarea font size to 16px on iOS (#7480) 2019-05-07 10:44:43 -04:00
Bianca Nenciu
98a75906c8
FIX: Close topics deleted by users and ensure topic stubs are destroyed. (#7430) 2019-05-07 16:25:52 +03:00
Arpit Jalan
ed70595314 UX: add information about the use of permalinks 2019-05-07 17:13:26 +05:30
Bianca Nenciu
71fb8a4195 DEV: Fix failing click-track tests. 2019-05-07 13:54:12 +03:00
Joffrey JAFFEUX
4bbb34f7cb
REFACTOR: admin-user (#7475) 2019-05-07 10:53:21 +02:00
Joffrey JAFFEUX
f73ed45429
REFACTOR: color-scheme model (#7477) 2019-05-07 10:51:52 +02:00
Joffrey JAFFEUX
9507eff927
REFACTOR: resumable-upload (#7474) 2019-05-07 10:51:11 +02:00
Bianca Nenciu
4ff1195537 FEATURE: Use Beacon API for tracking clicks. (#7483) 2019-05-07 16:37:43 +10:00
Joe
cf99431c18 Fix like and flag button count alignment (#7487) 2019-05-07 16:34:29 +10:00
Guo Xiang Tan
abbc639e0d FIX: Only unregister service workers that belongs to Discourse. 2019-05-07 13:08:06 +08:00
Arpit Jalan
03169401ff UX: correct order of site statistics on /about page 2019-05-07 09:50:41 +05:30
Guo Xiang Tan
451f7842ff DEV: More send -> public_send. 2019-05-07 10:05:58 +08:00
Sam Saffron
cac80cdc3b DEV: more send -> public_send changes 
This is a work in progress commit for more send to public_send conversions

Also adds some comments for cases where we need to keep send
 2019-05-07 11:58:06 +10:00
Guo Xiang Tan
61cc0f8c5f Follow up to 152238b4cf. 2019-05-07 09:57:27 +08:00
Guo Xiang Tan
152238b4cf DEV: Prefer public_send over send. 2019-05-07 09:33:21 +08:00
Sam Saffron
9be70a22cd DEV: introduce new API to look up dynamic site setting 
This removes all uses of both `send` and `public_send` from consumers of
SiteSetting and instead introduces a `get` helper for dynamic lookup

This leads to much cleaner and safer code long term as we are always explicit
to test that a site setting is really there before sending an arbitrary
string to the class

It also removes a couple of risky stubs from the auth provider test
 2019-05-07 11:00:30 +10:00
Robin Ward
47995d2d89 FIX: Your own likes were missing on posts 2019-05-06 20:03:50 -04:00
Robin Ward
31e100530f FEATURE: Flag count in post menu 
This change shows a notification number besides the flag icon in the
post menu if there is reviewable content associated with the post.
Additionally, if there is pending stuff to review, the icon has a red
background.

We have also removed the list of links below a post with the flag
status. A reviewer is meant to click the number beside the flag icon to
view the flags. As a consequence of losing those links, we've removed
the ability to undo or ignore flags below a post.
 2019-05-06 16:13:31 -04:00
Penar Musaraj
5e546ba7d1 Standardize viewport rules for mobile and desktop 
Also removes`maximum-scale` on non-mobile devices, better for accessibility.
 2019-05-06 10:28:29 -04:00
Régis Hanol
e2e72f4e8e DEV: rename ReadOnly module to ReadOnlyHeader 2019-05-06 16:07:49 +02:00
Dan Ungureanu
33e06dd796
FIX: Make select all and below skip small actions. (#7425) 2019-05-06 16:22:11 +03:00
Dan Ungureanu
a40dcbde9b
FIX: Do not move hidden post actions. (#7424) 
Hidden (staff-only) post actions are whisper posts with no content, that
are later transformed by the client into post actions (discourse-assign
uses this).
 2019-05-06 16:21:42 +03:00
Guo Xiang Tan
8217d5be78 UX: Switch mobile header back for 5s when notification comes in. 2019-05-06 16:58:25 +08:00
Sam Saffron
f8eddd40ad PERF: remove avg_time calculations and regular jobs from posts and topics 
After careful analysis of large data-sets it became apparent that avg_time
had no impact whatsoever on "best of" topic scoring. Calculating avg_time
was a very costly operation especially on large databases.

We have some longer term plans of introducing other weighting that is read
time based into our scoring for "best of" and "top" topics, but in the
interim to stop a large amount of work that is not achieving any value we
are removing the jobs.

Column removal will follow once we decide on a new replacement metric.
 2019-05-06 15:59:01 +10:00
Guo Xiang Tan
ba3cf7109c DEV: Remove unused lines of code. 2019-05-06 13:48:51 +08:00
Sam Saffron
267d129f38 FEATURE: only scroll to bottom for discobot 
Non discobot replies on PMs triggering scroll cause confusion.
 2019-05-06 10:55:58 +10:00
Robin Ward
99a2a769d4 FIX: Conflict error (version was already used) 2019-05-03 16:36:37 -04:00
Vinoth Kannan
e8fafbc123 List and restore missing post uploads from S3 inventory. 2019-05-04 01:16:20 +05:30