github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-25 01:32:23 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
26,876 Commits 190 Branches 500 Tags 938 MiB
8c1d145f0e
Commit Graph

10966 Commits

Author SHA1 Message Date
Guo Xiang Tan
9f5bc7a5ee
Merge pull request #5605 from nbianca/favorites 
Added the required hooks for discourse-favorites plugin.
 2018-02-23 07:12:09 +08:00
Guo Xiang Tan
18c1d1565c UX: Fix missing css styles on invite modal. 2018-02-23 07:08:19 +08:00
Guo Xiang Tan
dd26bbe868
Merge pull request #5610 from discourse/pm-tags 
FEATURE: Allow staffs to tag PMs
 2018-02-23 07:07:41 +08:00
Bianca Nenciu
184d521fc9 Added the required hooks for discourse-favorites plugin. 2018-02-22 23:58:53 +02:00
Bianca Nenciu
0e3e5f25a6 Try extracting time period only when the filter is 'top'. 2018-02-22 23:56:37 +02:00
Régis Hanol
0210a7f2bf FIX: social login buttons were not working 2018-02-22 18:06:28 +01:00
Guo Xiang Tan
862e83287e
Merge pull request #5575 from featheredtoast/tab-index-composer-actions 
tab index composer actions
 2018-02-22 15:16:41 +08:00
Guo Xiang Tan
7bcc0c1da9 FIX: Login buttons not working on sign up modal. 2018-02-22 14:01:07 +08:00
Guo Xiang Tan
ae2d7ba857 Partially revert d170c8fccc to bring back 3df0626aa5. 2018-02-22 13:42:04 +08:00
Arpit Jalan
d170c8fccc Revert 'Accessibility: focus management in topics' 
reverts:

- 3df0626aa5
- 3212cdda78
- 59b7760e2e
- bfc1301823
 2018-02-22 10:32:37 +05:30
Kane York
bfc1301823 UX: Remove default focus styling from posts & topic list items 
The styling is superseded by the .selected management
 2018-02-22 12:21:23 +08:00
Kane York
59b7760e2e UX: Make the .selected class follow focus 2018-02-22 12:20:47 +08:00
Kane York
3212cdda78 UX: Use focus as the first selector for J/K navigation 2018-02-22 11:55:36 +08:00
Kane York
3df0626aa5 UX: Apply hover styling to post actions on focus 2018-02-22 11:55:36 +08:00
Sam
f4418ae884 PERF: fast docking of timeline so it does not overlap 
In the past we debounced all dock check this causes situations where
sometimes timeline would not dock in time especially on slow computers

This works around it by performing the dock by hand.

Also there was missing integer casting causing over aggressive re-rendering
 2018-02-22 12:52:43 +11:00
Guo Xiang Tan
412b298f55 UX: Smaller input field for preferences 2FA form. 2018-02-22 09:07:43 +08:00
Guo Xiang Tan
1b04d881c5 UX: Display lock icon in admin user lists when user has 2FA enabled. 2018-02-22 09:00:09 +08:00
Joffrey JAFFEUX
6f5acfe783 Login with email/forget password UI refactoring 
* move button into login modal with social buttons
* adds email link next to login field when filling it
* adds proper validation messages
* improves forgot password flash clearing
* more tests
 2018-02-22 08:06:15 +08:00
Sam
720e1965e3 FEATURE: add category suppress from latest 
In the past we used suppress_from_homepage, it had mixed semantics
it would remove from category list if category list was on home and
unconditionally remove from latest.

New setting explicitly only removes from latest list but leaves the
category list alond
 2018-02-22 09:56:35 +11:00
Jeff Wong
d2b518c61c QR code display fix on dark backgrounds (#5613) 
https://meta.discourse.org/t/2fa-qr-code-not-visible-on-dark-theme/81152?u=awole20
 2018-02-21 23:23:47 +01:00
Vinoth Kannan
2b509eaa91
Merge branch 'master' into pm-tags 2018-02-21 23:55:59 +05:30
Régis Hanol
4e7244d8d9 FIX: never open internal links in a new tab when user prefers opening external links in a new tab 2018-02-21 17:51:53 +01:00
Vinoth Kannan
d4b2e840cb remove unwanted code 2018-02-21 20:19:19 +05:30
Vinoth Kannan
84ce1acfef FEATURE: Allow staffs to tag PMs 2018-02-21 20:11:46 +05:30
Guo Xiang Tan
14f3594f9f Review Changes for f4f8a293e7. 2018-02-21 14:55:49 +08:00
Jeff Wong
f4f8a293e7 FEATURE: Implement 2factor login TOTP 
implemented review items.

Blocking previous codes - valid 2-factor auth tokens can only be authenticated once/30 seconds.
I played with updating the “last used” any time the token was attempted but that seemed to be overkill, and frustrating as to why a token would fail.
Translatable texts.
Move second factor logic to a helper class.
Move second factor specific controller endpoints to its own controller.
Move serialization logic for 2-factor details in admin user views.
Add a login ember component for de-duplication
Fix up code formatting
Change verbiage of google authenticator

add controller tests:
second factor controller tests
change email tests
change password tests
admin login tests

add qunit tests - password reset, preferences

fix: check for 2factor on change email controller
fix: email controller - only show second factor errors on attempt
fix: check against 'true' to enable second factor.

Add modal for explaining what 2fa with links to Google Authenticator/FreeOTP

add two factor to email signin link

rate limit if second factor token present

add rate limiter test for second factor attempts
 2018-02-21 09:04:07 +08:00
Kris
ce97bdb472 Flag badge too wide in header panels 2018-02-20 17:31:02 -05:00
Kris
677e126fbf UX: Implementing a box-shadow system, cleaning up existing shadows 2018-02-20 12:18:20 -05:00
Régis Hanol
60ec483caa FIX: include title in local onebox when linking to a different topic 2018-02-19 22:40:14 +01:00
Arpit Jalan
614b1c8e68 FIX: admin was not able to unblock screened IP address 2018-02-20 00:36:13 +05:30
OsamaSayegh
f3815cd785 FEATURE: New site setting for additional allowed filetypes for staff (#5364) 
* FEATURE: New site setting for additional allowed filetypes for staff

* Problematic variable name

* feedback

* small issues

* fix indentation

* failing tests

* Remove message bus and fix minor issues

* Missed this message bus
 2018-02-19 10:44:24 +01:00
Zach Whitehead
afa2b36842 Add class to category link for easy styling (#5606) 2018-02-19 10:22:27 +01:00
Joffrey JAFFEUX
b3b6373f77
FIX: do not show mail-forward icon if not needed 2018-02-19 09:52:35 +01:00
Kris
a2327b4897 login button alignment fix 2018-02-16 17:13:10 -05:00
Kris
35a49a240a UX: Improving header scalability for large font themes 2018-02-16 15:58:10 -05:00
Kris
67526907cd Tags should wrap on mobile topic-list 2018-02-15 15:15:42 -05:00
Kris
5de78a719b Fixing emoji admin page column 2018-02-15 15:07:26 -05:00
Robin Ward
32e8cef0ad
Merge pull request #5596 from discourse/mobile-landscape-timeline 
UX: Make mobile timeline extra short in landscape
 2018-02-15 11:34:03 -08:00
Robin Ward
3faeb4f093 Calculate the heights when we need them 2018-02-15 14:33:20 -05:00
Joffrey JAFFEUX
2cf40096d1
FIX: makes mini-tag-chooser search more efficient 2018-02-15 15:01:19 +01:00
Arpit Jalan
585fc26f8e FIX: allow discourse app to link directly to upgrade page 2018-02-15 18:20:25 +05:30
Joffrey JAFFEUX
e1883ba828
minor select-kit css improvements 2018-02-15 12:56:20 +01:00
Arpit Jalan
b43ac801d1 FIX: show create new topic link in advanced search mode 2018-02-15 17:23:34 +05:30
hnb-ku
afdc559f4f FEATURE: Whitelist div[data-theme-*] (#5598) 
* Whitelist div[data-theme-*]

Whitelisting data attributes on <div> elements that match [data-theme-*] allows theme authors to target elements in posts and not have those attributes sanitized. 

https://meta.discourse.org/t/79520/16

* Update white-lister.js.es6
 2018-02-15 04:32:41 -05:00
Kris
5ab44833ab UX: Make mobile timeline extra short in landscape 2018-02-14 23:27:06 -05:00
Guo Xiang Tan
9c7d609575 UX: Restore width of composer user selector. 
* This fixes the build as well as a short width
  resulted in the user selector collapsing into
  the compressed display.
 2018-02-15 11:49:10 +08:00
Guo Xiang Tan
28365f8ae5 PERF: Have nginx cache and serve the service worker file. 2018-02-15 10:50:39 +08:00
Robin Ward
a03e7cee63 FIX: Group posts had the wrong paths in subfolders 2018-02-14 20:33:31 -05:00
Rafael dos Santos Silva
218c8e8623
Merge pull request #5595 from discourse/new-gfycat-onebox 
New gfycat onebox
 2018-02-14 19:03:28 -02:00
Kris
dffdff91a6 Fix avatar flair alignment on mobile user profiles 2018-02-14 13:39:30 -05:00
Kris
e85458e1b9 Removing old bootstrap columns 2018-02-14 12:27:34 -05:00
Joffrey JAFFEUX
3ad0266dd8
FIX: better handling of category badge when displaying sub and parent cat 2018-02-14 16:42:20 +01:00
Joffrey JAFFEUX
8ae2c4555a
FIX: do not translate the same string two times when rendering icon label 2018-02-14 12:41:24 +01:00
Joffrey JAFFEUX
23ef5f10e9
FIX: check can_create_tag on create and not on select 2018-02-14 12:20:07 +01:00
Joffrey JAFFEUX
e3774c7bed
FEATURE: displays category badge in {{category-chooser}} header 2018-02-14 11:49:23 +01:00
Joffrey JAFFEUX
e7761db60f
FIX: improves contrast on period-chooser when using dark-theme 2018-02-14 11:16:57 +01:00
Joffrey JAFFEUX
5d00a97ae9
FIX: regression preventing uncategorized badge to be shown 2018-02-14 11:03:33 +01:00
Joffrey JAFFEUX
b0eed424f7
FIX: continue discussion when creating new topic from composer-actions 2018-02-14 10:32:46 +01:00
Joffrey JAFFEUX
480c94d298
minor visual improvements to mini-tag-chooser 2018-02-14 10:26:43 +01:00
Sam
f028ffaf29 SECURITY: correct local onebox category checks 
Also removes ugly "source_topic_id" from cooked posts

Patch was authored by @zogstrip

Signed-off-by: Sam <sam.saffron@gmail.com>
 2018-02-14 10:40:46 +11:00
Joffrey JAFFEUX
548db91c76
FIX: displays an error when reaching tags limit 2018-02-14 00:30:09 +01:00
Neil Lalonde
22f0b0096d FEATURE: show avatar flair on user profile page 2018-02-13 17:13:38 -05:00
Robin Ward
556ab8480e FIX: ESlint 2018-02-13 16:06:40 -05:00
Robin Ward
713993d150 UX: Link post ids in staff action logs to the post 2018-02-13 15:59:10 -05:00
Joffrey JAFFEUX
ed114177e7
Mini tag chooser tweaks 2018-02-13 19:41:03 +01:00
Joffrey JAFFEUX
d525a644d2
fix linting 2018-02-13 18:12:30 +01:00
Joffrey JAFFEUX
20123271d2
FIX: override backspaceFromFilter only if defined 2018-02-13 17:48:00 +01:00
Neil Lalonde
20e44b3c14 Revert "FIX: 404 page when clicking a badge notification from before changing username" 2018-02-13 11:39:33 -05:00
Joffrey JAFFEUX
6bfc25d895
FEATURE: new {{mini-tag-chooser}} replaces {{tag-chooser}} in composer 2018-02-13 17:23:12 +01:00
Vinoth Kannan
0a95d2a21f FIX: Upload fails silently if it is bigger than max allowed size 2018-02-13 14:39:25 +05:30
Erick Guan
03b3e57a44 FEATURE: login by a link from email 
Co-authored-by: tgxworld <tgx@discourse.org>
 2018-02-13 16:14:39 +08:00
Sam
14d0450bef FEATURE: Only load service worker for Android 
TBD an interface for plugin to enable service workers on desktop if they need them
 2018-02-13 16:23:36 +11:00
Sam
074d590abd FIX: stop counting offline page as a page view 2018-02-13 16:19:43 +11:00
Sam
b34b1b6fe3 FIX: invite to message was not allowing groups 
Previously we were incorrectly checking mentionable instead of messageable

Also fix edge case where multiple groups sharing a name mean that exact match override is not working

Also cleans up params sent to user selector
 2018-02-13 13:28:46 +11:00
Kris
5f8f691e2b FIX: Border issue with group inputs on high resolution displays 2018-02-12 21:09:40 -05:00
Robin Ward
ae15faeb34 FIX: Allow links from one relative uri to another 2018-02-12 18:27:08 -05:00
Kris
32116654ec removing duplicate topic-map desktop/mobile styles 2018-02-12 15:20:14 -05:00
Robin Ward
d962d6072e FIX: Don't auto select ALL topics, only keyboard chosen ones 2018-02-12 13:54:37 -05:00
Robin Ward
7b7f94d7df FIX: Using cmd-f to search in a topic wasn't restricting to that topic 2018-02-12 13:09:56 -05:00
Kris
44f39ddc86 prevent post-link clicks from being squished by long strings 2018-02-12 11:52:42 -05:00
Rafael dos Santos Silva
4644757785 FEATURE: Style new gfycat onebox 2018-02-12 13:39:52 -02:00
Joffrey JAFFEUX
3d5c4580bd
FIX: makes sure we add ellipsis to action-title 2018-02-12 16:27:24 +01:00
Kris
d30c43e8cc usercard overflow fix 2018-02-10 21:27:25 -05:00
Kris
3d22ba35bc usercard website fix 2018-02-09 21:45:38 -05:00
Robin Ward
b31e6e64fb FIX: After deleting a post, staff can recover it 2018-02-09 19:42:16 -05:00
Robin Ward
2faa4c2f5f FIX: Don't show personal messages if disabled as a composer action 2018-02-09 16:58:35 -05:00
Kris
56352137ca UX: Preventing usercard and profile URLs from overflowing 2018-02-09 16:55:43 -05:00
Kris
88a992014b Default modals were too wide 2018-02-09 15:45:34 -05:00
Kris
597f17bf70 button padding nitpick 2018-02-09 15:41:59 -05:00
Vinoth Kannan
91beedd0ca FEATURE: Composer HTML pasting ul tag support for MS Word 2018-02-10 01:18:56 +05:30
Kris
1e51be923c UX: Improving post-link alignment 2018-02-09 12:43:15 -05:00
Kris
6f094ee27e extra-info-wrapper titles were too short 2018-02-08 20:43:34 -05:00
Kris
69bccb9e32 UX: Better alignment of small topic statuses 2018-02-08 17:04:29 -05:00
Jeff Wong
8e49033ed1 tab index composer actions 
add styling for :focus
 2018-02-08 12:16:13 -08:00
Kris
e17e6d2880 Removing unneeded width 2018-02-08 14:10:04 -05:00
Robin Ward
dedeb2deb8 FIX: Don't show the link button in the composer if linking is disabled 2018-02-08 12:56:10 -05:00
Joffrey JAFFEUX
8c89f5704d
FIX: makes sure we display whisper if we don’t have a post 2018-02-08 14:18:53 +01:00
Joffrey JAFFEUX
190d208631
FEATURE: improves composer-actions toggle menu 
* only toggles
* fix a bug with presence
* more tests
* do not duplicate `continuing discussion...` text
* persist state to allow switching between toggles
 2018-02-08 11:46:55 +01:00
Robin Ward
209a6cae2c FIX: Don't show messages setting if messages are disabled 2018-02-07 11:43:22 -05:00
Robin Ward
c0ef6ca01c UX: Show the footer on the user summary and preferences pages 2018-02-07 11:35:36 -05:00
Neil Lalonde
ce26f48f97 FIX: only send up to 100 selected tags in the tag search request to avoid sending a query string that's too long 2018-02-06 17:54:57 -05:00
Joffrey JAFFEUX
cdded801c5
FIX: correctly shows link to post number when editing 2018-02-06 22:17:27 +01:00
Kris
900f37e5a9 UX: Allow history modal to scale down on smaller screens 2018-02-06 15:02:51 -05:00
Joffrey JAFFEUX
b1593c0184
FIX: prevents exception when opening new topic on mobile 
Repro:

- Visit https://meta.discourse.org/categories, refresh the page
- Navigate to Latest
- Click New Topic
- Error occurs
 2018-02-06 14:48:04 +01:00
Kris
e7b732ad95 FIX: Desktop/mobile heatmap colors should be the same 2018-02-05 21:36:35 -05:00
Neil Lalonde
648a11a6a1 FIX: size of tags input field of tag group 2018-02-05 15:05:43 -05:00
Simon Cossar
e3de396091 Set text to empty string when null is passed as argument (#5560) 2018-02-06 07:05:32 +11:00
Joffrey JAFFEUX
c48761c628
s/select-box-kit/select-kit 
Definitely remove legacy naming.
 2018-02-05 18:25:39 +01:00
Kris
ad8c2c08a4 fixing link alignment in titles 2018-02-05 10:42:37 -05:00
Joffrey JAFFEUX
bd0a8ae792
FIX: makes scrollbar always on for small dropdowns 2018-02-05 10:51:06 +01:00
Joffrey JAFFEUX
5cd5d5aca5
FIX: prevents a regression where enter wasn't working in inputs 2018-02-05 09:55:58 +01:00
Kris
86bf6babf8 FIX: Prevent long composer overlapping controls 2018-02-02 22:31:55 -05:00
Kris
cf623e65e0 tag alignment fix 2018-02-02 21:29:51 -05:00
Kris
cd798e49d8 header text wrap fix 2018-02-02 19:33:00 -05:00
Kris
8bac9c7a09 header-extra wrap fix 2018-02-02 19:28:45 -05:00
Kris
9e690bf238
UX: Cleaning up category badge alignment (#5561) 2018-02-02 19:03:25 -05:00
Robin Ward
2f19588311 FIX: If personal messages are disabled, don't show messages for groups 2018-02-02 16:35:54 -05:00
Robin Ward
68d0d39ab7 FIX: Order the homepage box in the same order as the top menu 
This is required because "no interface" is the same as showing
the first entry. But when the top menu has changed the first
entry is no longer the same, so it shows the wrong default.
 2018-02-02 16:11:28 -05:00
Joffrey JAFFEUX
b4aad15267
FIX: simplify styling of category-name when using category-drop/link 2018-02-02 10:31:20 +01:00
Joffrey JAFFEUX
cf592fa35d
remove debugging code 2018-02-02 09:31:47 +01:00
Joshua Rosenfeld
e5655f0b6b
UX: Add specific classes to ip address rows on user admin 2018-02-02 00:40:10 -05:00
Joffrey JAFFEUX
85db6cd2d7
FIX: makes sure we have a content to filter 2018-02-02 02:13:06 +01:00
Joffrey JAFFEUX
a4445b0c1e
FIX: improve dropdown-select-box on mobile 2018-02-02 00:47:12 +01:00
Robin Ward
d31417d3af FIX: Remove unused import 2018-02-01 18:03:22 -05:00
Joffrey JAFFEUX
ce507b7957
FEATURE: display search on large category-drop and tag-drop 2018-02-01 23:51:29 +01:00
Robin Ward
8ff4104555 Many enhancements to the flagging / suspending interface. 2018-02-01 17:13:02 -05:00
Joffrey JAFFEUX
f7df68c9a3
FIX: makes composer-actions toggling whisper instead of replying 2018-02-01 23:07:37 +01:00
Robin Ward
0156ae486d Apply extra classes to header avatar 2018-02-01 16:59:10 -05:00
Robin Ward
9f96d59a17 FIX: Unused import 2018-02-01 16:31:21 -05:00
Robin Ward
08db10491e Adds a new plugin API for adding classes to be shown on user avatars 2018-02-01 15:24:26 -05:00
Joffrey JAFFEUX
42399261ba
adds margin to avatar in composer-action-title 2018-02-01 18:41:11 +01:00
Joffrey JAFFEUX
e3301c4869
FIX: max-height auto is not valid 2018-02-01 18:08:55 +01:00
Robin Ward
64ba876ff4 FIX: Don't show "Grant Badge" if badges are disabled 2018-02-01 11:33:48 -05:00
Joffrey JAFFEUX
97ddaeeae8
FIX: use css instead of js to fix select-kit-collection max-height 2018-02-01 16:56:07 +01:00
Joffrey JAFFEUX
9923829402
FEATURE: Menu toggle for different reply modes 
Allow users to access different reply modes from the composer.

Actions introduced:

- reply_as_new_topic
- reply_as_private_message
- reply_to_topic
- reply_as_whisper/not
 2018-02-01 16:42:56 +01:00
Robin Ward
96710754d9
Merge pull request #5540 from discourse/mixed-text-direction-support 
FEATURE: Mixed text direction support
 2018-02-01 07:29:15 -08:00
Arpit Jalan
49424fd798 rename private to personal 2018-02-01 13:25:29 +05:30
Arpit Jalan
ff0376a80b rename 'enable_private_messages' to 'enable_personal_messages' 2018-02-01 13:25:29 +05:30
Arpit Jalan
25ec077eca rename 'min_private_message_{post/title}_length' to 'min_personal_message_{post/title}_length' 2018-02-01 13:25:29 +05:30
Sam
60ee9a4ccf make tests a bit happier 2018-02-01 15:56:22 +11:00
Sam
ee0d3f15c1 FEATURE: allow better fidelity for auto linkify, disable most tlds based linkify 
New site settings:

enable_markdown_linkify: which is default on, auto links https:// and http:// and mail://

markdown_linkify_tlds: which allows control of what tlds get autolinked for cases such as www.site.com, default is com|net|gov
 2018-02-01 13:22:38 +11:00
Régis Hanol
826584b9c1 UX: prevent anons from clearing pins in topic view 2018-01-31 20:34:53 +01:00
Régis Hanol
8c91d418dd UX: improve semantic of login button for better password managers compatibility 2018-01-31 20:09:59 +01:00
Kris
add641cbbc
UX: Input and search cleanup (#5546) 
* Cleaning up input sizes

* alignment

* more alignment adjustments
 2018-01-31 11:44:51 -05:00
Régis Hanol
48f8d9f8a4 UX: prevent anons from clearing pins 📌 2018-01-31 17:13:52 +01:00
Régis Hanol
d233ecbe34 push updates to backups list to client 2018-01-31 12:05:06 +01:00
Neil Lalonde
aab2d102ff FIX: 404 page when clicking a badge notification from before changing username 2018-01-30 15:56:44 -05:00
Vinoth Kannan
10ed4c0078 FEATURE: Composer HTML pasting support for complex table formats 2018-01-31 01:39:11 +05:30
Kris
56987e2290 Profile textarea too short in iOS10 2018-01-30 09:31:18 -05:00
Vinoth Kannan
88c05d7050 Limit the maxLength of the name and description text inputs for custom user fields 2018-01-30 17:04:18 +05:30